From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04713C48BDF for ; Fri, 18 Jun 2021 09:18:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D2B98613B4 for ; Fri, 18 Jun 2021 09:18:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230225AbhFRJUj (ORCPT ); Fri, 18 Jun 2021 05:20:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59784 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229819AbhFRJUi (ORCPT ); Fri, 18 Jun 2021 05:20:38 -0400 Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com [IPv6:2a00:1450:4864:20::52f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B54E5C061574 for ; Fri, 18 Jun 2021 02:18:29 -0700 (PDT) Received: by mail-ed1-x52f.google.com with SMTP id df12so5205305edb.2 for ; Fri, 18 Jun 2021 02:18:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=HRCq4fgN0aqqkE/8MiANC+rXlD39PnksNydgp1NHMj8=; b=aAUvntb9wvjm5kq0+mzAEZrxmcfn0Uq6awR26z3mwJ9WN1M1UjStHyT0vq8IcMR2EZ YxniL1472HHUuFHpCT4Db/CdB4znRz4U6otxHDqPVYY4PhZGWvbraoQiLsJuCHDa97IJ pAZAUDbKDzrRBTvSVZKktiKPq5qvcGKyS+O0va+boqerEOciWdv2r2f7C4hzYA84v6gY uSKEQ2lvdbsyFwYQAKuNzyCzIdc5SLkVvSfX/qfi2PpTE5ZwgTkkzNmyGR4CY5qpoAhU eza97I+5UquHK1GJTNy5RKMkp5vlkITwHBoqUozjghYNSwNUVDNig2XyJndsi03pl73M 9Plg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=HRCq4fgN0aqqkE/8MiANC+rXlD39PnksNydgp1NHMj8=; b=SE2cmJu//KXVki1IaTYC6bR8dZS4sCukeoRUae3Vk8LY6Q90pIJBg6q/1HkCf6KQPh pUGEN4gNX5zjywhasfv1BV28baapfLeF9f4f93POMjqXwC6cUblUZA2UhD07CepUdU4I ObI6LLS0Mxwq4D2574SHq0YpF2Dbh/SddLPav1SK/BYjtGeQMFfa/H3x6OV+xwka0IaY DxQXSRB8S6jx6HnTU4U00CFAtgmCbNfvZnJ0QuXg00yW3ls+XWvNfyh6xCnLF06jWE1C huY/LcC/C9fO6WJMGkI7WAOY6NlKFY3+gSuLcGL0lBNHS+A0Oc32EOp7bFqEbTlDc/AH Ohng== X-Gm-Message-State: AOAM5339bePJI7laQFasZNx0qAkU8am3cvLCP1AbY32ihxFvgev9XvoR Nc5ghkCjG3MinvDoDaAGnLxfzw== X-Google-Smtp-Source: ABdhPJwkM7MFKtctHz8EhEAN6FWomn+q375ZFzmKixM6u9jPqqm7bxiCxZcxkEywq+sBmzBudXNXiw== X-Received: by 2002:a05:6402:2714:: with SMTP id y20mr3735609edd.41.1624007908152; Fri, 18 Jun 2021 02:18:28 -0700 (PDT) Received: from myrica (adsl-84-226-111-173.adslplus.ch. [84.226.111.173]) by smtp.gmail.com with ESMTPSA id u12sm788646eje.40.2021.06.18.02.18.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Jun 2021 02:18:27 -0700 (PDT) Date: Fri, 18 Jun 2021 11:18:08 +0200 From: Jean-Philippe Brucker To: Eric Auger Cc: rjw@rjwysocki.net, lenb@kernel.org, joro@8bytes.org, mst@redhat.com, will@kernel.org, catalin.marinas@arm.com, baolu.lu@linux.intel.com, dwmw2@infradead.org, linux-acpi@vger.kernel.org, iommu@lists.linux-foundation.org, virtualization@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org, sebastien.boeuf@intel.com, robin.murphy@arm.com, kevin.tian@intel.com, lorenzo.pieralisi@arm.com, guohanjun@huawei.com, sudeep.holla@arm.com Subject: Re: [PATCH v4 4/6] iommu/dma: Pass address limit rather than size to iommu_setup_dma_ops() Message-ID: References: <20210610075130.67517-1-jean-philippe@linaro.org> <20210610075130.67517-5-jean-philippe@linaro.org> <6d139529-9539-fbe4-8f85-da39461047ba@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <6d139529-9539-fbe4-8f85-da39461047ba@redhat.com> Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Wed, Jun 16, 2021 at 05:28:59PM +0200, Eric Auger wrote: > Hi Jean, > > On 6/10/21 9:51 AM, Jean-Philippe Brucker wrote: > > diff --git a/arch/arm64/mm/dma-mapping.c b/arch/arm64/mm/dma-mapping.c > > index 4bf1dd3eb041..7bd1d2199141 100644 > > --- a/arch/arm64/mm/dma-mapping.c > > +++ b/arch/arm64/mm/dma-mapping.c > > @@ -50,7 +50,7 @@ void arch_setup_dma_ops(struct device *dev, u64 dma_base, u64 size, > > > > dev->dma_coherent = coherent; > > if (iommu) > > - iommu_setup_dma_ops(dev, dma_base, size); > > + iommu_setup_dma_ops(dev, dma_base, size - dma_base - 1); > I don't get  size - dma_base - 1? Because it's wrong, should be dma_base + size - 1. Thanks for catching it! Thanks, Jean From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8343C48BDF for ; Fri, 18 Jun 2021 09:18:33 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9D728613CB for ; Fri, 18 Jun 2021 09:18:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9D728613CB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 723E882A29; Fri, 18 Jun 2021 09:18:33 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id rJ5UJJvoxVlE; Fri, 18 Jun 2021 09:18:32 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp1.osuosl.org (Postfix) with ESMTPS id 7563C828D1; Fri, 18 Jun 2021 09:18:32 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 4CBD1C000D; Fri, 18 Jun 2021 09:18:32 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136]) by lists.linuxfoundation.org (Postfix) with ESMTP id EEEF0C000B for ; Fri, 18 Jun 2021 09:18:30 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id DD21C60595 for ; Fri, 18 Jun 2021 09:18:30 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp3.osuosl.org (amavisd-new); dkim=pass (2048-bit key) header.d=linaro.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id iy1Ikk1DbANA for ; Fri, 18 Jun 2021 09:18:30 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 Received: from mail-ed1-x529.google.com (mail-ed1-x529.google.com [IPv6:2a00:1450:4864:20::529]) by smtp3.osuosl.org (Postfix) with ESMTPS id 0CBB0600CB for ; Fri, 18 Jun 2021 09:18:29 +0000 (UTC) Received: by mail-ed1-x529.google.com with SMTP id d7so7775077edx.0 for ; Fri, 18 Jun 2021 02:18:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=HRCq4fgN0aqqkE/8MiANC+rXlD39PnksNydgp1NHMj8=; b=aAUvntb9wvjm5kq0+mzAEZrxmcfn0Uq6awR26z3mwJ9WN1M1UjStHyT0vq8IcMR2EZ YxniL1472HHUuFHpCT4Db/CdB4znRz4U6otxHDqPVYY4PhZGWvbraoQiLsJuCHDa97IJ pAZAUDbKDzrRBTvSVZKktiKPq5qvcGKyS+O0va+boqerEOciWdv2r2f7C4hzYA84v6gY uSKEQ2lvdbsyFwYQAKuNzyCzIdc5SLkVvSfX/qfi2PpTE5ZwgTkkzNmyGR4CY5qpoAhU eza97I+5UquHK1GJTNy5RKMkp5vlkITwHBoqUozjghYNSwNUVDNig2XyJndsi03pl73M 9Plg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=HRCq4fgN0aqqkE/8MiANC+rXlD39PnksNydgp1NHMj8=; b=jN66RrM+ww6irWEzxeF55P1tqodAvxSTtpD4Lb520GzA8YRGbslytdvDW6/CfPVu5j e/yq2w3aM7i2J3Eea4Xtep9BuEftT5kg1QMPkHM9ibjdk9ynOKxXqJDcbBgDHQOvPHfZ v38DBXTUAYN6oQmR1r/hAhCoTwtOu5sqqwXURu6zbZl0HqI+Njq3sHe7gjAwk1+JuL4f RTxlpVa7FhcrcaTXMSBlybtep+zRlEXKJfi3cXuZkbvT7EmGajFFcfMAZwcW3pUhcf8T EsseYjV5SgWZJEx9FJH/YlxbVLe+wEyNiFcKieRQEeSB8lFr9PI4cATk9mxjz5TPk6pV xLgA== X-Gm-Message-State: AOAM533Wuhq4+QdpYn7SIB3NH3e1ZzKDa1TTlfNZUgBNrlbSPZMP1vTU YM5fW6yz5ORH8xIb6U1kE0XVmw== X-Google-Smtp-Source: ABdhPJwkM7MFKtctHz8EhEAN6FWomn+q375ZFzmKixM6u9jPqqm7bxiCxZcxkEywq+sBmzBudXNXiw== X-Received: by 2002:a05:6402:2714:: with SMTP id y20mr3735609edd.41.1624007908152; Fri, 18 Jun 2021 02:18:28 -0700 (PDT) Received: from myrica (adsl-84-226-111-173.adslplus.ch. [84.226.111.173]) by smtp.gmail.com with ESMTPSA id u12sm788646eje.40.2021.06.18.02.18.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Jun 2021 02:18:27 -0700 (PDT) Date: Fri, 18 Jun 2021 11:18:08 +0200 From: Jean-Philippe Brucker To: Eric Auger Subject: Re: [PATCH v4 4/6] iommu/dma: Pass address limit rather than size to iommu_setup_dma_ops() Message-ID: References: <20210610075130.67517-1-jean-philippe@linaro.org> <20210610075130.67517-5-jean-philippe@linaro.org> <6d139529-9539-fbe4-8f85-da39461047ba@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <6d139529-9539-fbe4-8f85-da39461047ba@redhat.com> Cc: kevin.tian@intel.com, mst@redhat.com, catalin.marinas@arm.com, sudeep.holla@arm.com, rjw@rjwysocki.net, robin.murphy@arm.com, virtualization@lists.linux-foundation.org, linux-acpi@vger.kernel.org, iommu@lists.linux-foundation.org, sebastien.boeuf@intel.com, guohanjun@huawei.com, will@kernel.org, dwmw2@infradead.org, linux-arm-kernel@lists.infradead.org, lenb@kernel.org X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" T24gV2VkLCBKdW4gMTYsIDIwMjEgYXQgMDU6Mjg6NTlQTSArMDIwMCwgRXJpYyBBdWdlciB3cm90 ZToKPiBIaSBKZWFuLAo+IAo+IE9uIDYvMTAvMjEgOTo1MSBBTSwgSmVhbi1QaGlsaXBwZSBCcnVj a2VyIHdyb3RlOgo+ID4gZGlmZiAtLWdpdCBhL2FyY2gvYXJtNjQvbW0vZG1hLW1hcHBpbmcuYyBi L2FyY2gvYXJtNjQvbW0vZG1hLW1hcHBpbmcuYwo+ID4gaW5kZXggNGJmMWRkM2ViMDQxLi43YmQx ZDIxOTkxNDEgMTAwNjQ0Cj4gPiAtLS0gYS9hcmNoL2FybTY0L21tL2RtYS1tYXBwaW5nLmMKPiA+ ICsrKyBiL2FyY2gvYXJtNjQvbW0vZG1hLW1hcHBpbmcuYwo+ID4gQEAgLTUwLDcgKzUwLDcgQEAg dm9pZCBhcmNoX3NldHVwX2RtYV9vcHMoc3RydWN0IGRldmljZSAqZGV2LCB1NjQgZG1hX2Jhc2Us IHU2NCBzaXplLAo+ID4gIAo+ID4gIAlkZXYtPmRtYV9jb2hlcmVudCA9IGNvaGVyZW50Owo+ID4g IAlpZiAoaW9tbXUpCj4gPiAtCQlpb21tdV9zZXR1cF9kbWFfb3BzKGRldiwgZG1hX2Jhc2UsIHNp emUpOwo+ID4gKwkJaW9tbXVfc2V0dXBfZG1hX29wcyhkZXYsIGRtYV9iYXNlLCBzaXplIC0gZG1h X2Jhc2UgLSAxKTsKPiBJIGRvbid0IGdldMKgIHNpemUgLSBkbWFfYmFzZSAtIDE/CgpCZWNhdXNl IGl0J3Mgd3JvbmcsIHNob3VsZCBiZSBkbWFfYmFzZSArIHNpemUgLSAxLiBUaGFua3MgZm9yIGNh dGNoaW5nIGl0IQoKVGhhbmtzLApKZWFuCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwppb21tdSBtYWlsaW5nIGxpc3QKaW9tbXVAbGlzdHMubGludXgtZm91 bmRhdGlvbi5vcmcKaHR0cHM6Ly9saXN0cy5saW51eGZvdW5kYXRpb24ub3JnL21haWxtYW4vbGlz dGluZm8vaW9tbXU= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7FB83C49361 for ; Fri, 18 Jun 2021 09:18:35 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 406D6613CB for ; Fri, 18 Jun 2021 09:18:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 406D6613CB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=virtualization-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 0C52240140; Fri, 18 Jun 2021 09:18:35 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Qqw-NQrPVd-M; Fri, 18 Jun 2021 09:18:34 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp2.osuosl.org (Postfix) with ESMTPS id B821D4010A; Fri, 18 Jun 2021 09:18:33 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 8C576C000D; Fri, 18 Jun 2021 09:18:33 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137]) by lists.linuxfoundation.org (Postfix) with ESMTP id C8AE0C000B for ; Fri, 18 Jun 2021 09:18:31 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id B765940204 for ; Fri, 18 Jun 2021 09:18:31 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp4.osuosl.org (amavisd-new); dkim=pass (2048-bit key) header.d=linaro.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id y6gQn7BVvdIn for ; Fri, 18 Jun 2021 09:18:30 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 Received: from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com [IPv6:2a00:1450:4864:20::52a]) by smtp4.osuosl.org (Postfix) with ESMTPS id 46AFA401E9 for ; Fri, 18 Jun 2021 09:18:30 +0000 (UTC) Received: by mail-ed1-x52a.google.com with SMTP id i13so7672689edb.9 for ; Fri, 18 Jun 2021 02:18:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=HRCq4fgN0aqqkE/8MiANC+rXlD39PnksNydgp1NHMj8=; b=aAUvntb9wvjm5kq0+mzAEZrxmcfn0Uq6awR26z3mwJ9WN1M1UjStHyT0vq8IcMR2EZ YxniL1472HHUuFHpCT4Db/CdB4znRz4U6otxHDqPVYY4PhZGWvbraoQiLsJuCHDa97IJ pAZAUDbKDzrRBTvSVZKktiKPq5qvcGKyS+O0va+boqerEOciWdv2r2f7C4hzYA84v6gY uSKEQ2lvdbsyFwYQAKuNzyCzIdc5SLkVvSfX/qfi2PpTE5ZwgTkkzNmyGR4CY5qpoAhU eza97I+5UquHK1GJTNy5RKMkp5vlkITwHBoqUozjghYNSwNUVDNig2XyJndsi03pl73M 9Plg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=HRCq4fgN0aqqkE/8MiANC+rXlD39PnksNydgp1NHMj8=; b=FsYb/UiEVXO6OKsEaSVfA4tfADK0SBCJnqXMeH6HGoUJGPEBLNEqeeZPq+to6GV391 LK0ytRxdJStlnPYvVXzly6X9dxwNG2CBphTJ8fT8jpEOA5H1blvh8c0/kfjs6tC9QGoF RnuBWzFfoCd6sY4GZHkEMLwxS5waISMKwr3OeIn8zbb6hYq6ZlW5VahMi1MV5J1Tvzn9 qO+f8TBo72jZVgTLpNMpnR5HK7pxqKJ+Khi9Ni3JBeLc7NwhTWZYWVJWWCFmvPeMLXX7 BJs6JJVnIMzPo1Rh7Ua/hzstkwGhSMGbLu9L7RxP+Ol27Bl7MNbyCLxgFS/hIWfZzrjH H+lg== X-Gm-Message-State: AOAM533Gnncr46L9mPh+UDVyKeUa6mkfbw9iJvaUl+VupRUCSysY6BhB z6m1uL5Cx97MshcJlhQSzY7piA== X-Google-Smtp-Source: ABdhPJwkM7MFKtctHz8EhEAN6FWomn+q375ZFzmKixM6u9jPqqm7bxiCxZcxkEywq+sBmzBudXNXiw== X-Received: by 2002:a05:6402:2714:: with SMTP id y20mr3735609edd.41.1624007908152; Fri, 18 Jun 2021 02:18:28 -0700 (PDT) Received: from myrica (adsl-84-226-111-173.adslplus.ch. [84.226.111.173]) by smtp.gmail.com with ESMTPSA id u12sm788646eje.40.2021.06.18.02.18.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Jun 2021 02:18:27 -0700 (PDT) Date: Fri, 18 Jun 2021 11:18:08 +0200 From: Jean-Philippe Brucker To: Eric Auger Subject: Re: [PATCH v4 4/6] iommu/dma: Pass address limit rather than size to iommu_setup_dma_ops() Message-ID: References: <20210610075130.67517-1-jean-philippe@linaro.org> <20210610075130.67517-5-jean-philippe@linaro.org> <6d139529-9539-fbe4-8f85-da39461047ba@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <6d139529-9539-fbe4-8f85-da39461047ba@redhat.com> Cc: lorenzo.pieralisi@arm.com, mst@redhat.com, catalin.marinas@arm.com, joro@8bytes.org, sudeep.holla@arm.com, rjw@rjwysocki.net, robin.murphy@arm.com, virtualization@lists.linux-foundation.org, linux-acpi@vger.kernel.org, iommu@lists.linux-foundation.org, sebastien.boeuf@intel.com, guohanjun@huawei.com, baolu.lu@linux.intel.com, will@kernel.org, dwmw2@infradead.org, linux-arm-kernel@lists.infradead.org, lenb@kernel.org X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" T24gV2VkLCBKdW4gMTYsIDIwMjEgYXQgMDU6Mjg6NTlQTSArMDIwMCwgRXJpYyBBdWdlciB3cm90 ZToKPiBIaSBKZWFuLAo+IAo+IE9uIDYvMTAvMjEgOTo1MSBBTSwgSmVhbi1QaGlsaXBwZSBCcnVj a2VyIHdyb3RlOgo+ID4gZGlmZiAtLWdpdCBhL2FyY2gvYXJtNjQvbW0vZG1hLW1hcHBpbmcuYyBi L2FyY2gvYXJtNjQvbW0vZG1hLW1hcHBpbmcuYwo+ID4gaW5kZXggNGJmMWRkM2ViMDQxLi43YmQx ZDIxOTkxNDEgMTAwNjQ0Cj4gPiAtLS0gYS9hcmNoL2FybTY0L21tL2RtYS1tYXBwaW5nLmMKPiA+ ICsrKyBiL2FyY2gvYXJtNjQvbW0vZG1hLW1hcHBpbmcuYwo+ID4gQEAgLTUwLDcgKzUwLDcgQEAg dm9pZCBhcmNoX3NldHVwX2RtYV9vcHMoc3RydWN0IGRldmljZSAqZGV2LCB1NjQgZG1hX2Jhc2Us IHU2NCBzaXplLAo+ID4gIAo+ID4gIAlkZXYtPmRtYV9jb2hlcmVudCA9IGNvaGVyZW50Owo+ID4g IAlpZiAoaW9tbXUpCj4gPiAtCQlpb21tdV9zZXR1cF9kbWFfb3BzKGRldiwgZG1hX2Jhc2UsIHNp emUpOwo+ID4gKwkJaW9tbXVfc2V0dXBfZG1hX29wcyhkZXYsIGRtYV9iYXNlLCBzaXplIC0gZG1h X2Jhc2UgLSAxKTsKPiBJIGRvbid0IGdldMKgIHNpemUgLSBkbWFfYmFzZSAtIDE/CgpCZWNhdXNl IGl0J3Mgd3JvbmcsIHNob3VsZCBiZSBkbWFfYmFzZSArIHNpemUgLSAxLiBUaGFua3MgZm9yIGNh dGNoaW5nIGl0IQoKVGhhbmtzLApKZWFuCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpWaXJ0dWFsaXphdGlvbiBtYWlsaW5nIGxpc3QKVmlydHVhbGl6YXRp b25AbGlzdHMubGludXgtZm91bmRhdGlvbi5vcmcKaHR0cHM6Ly9saXN0cy5saW51eGZvdW5kYXRp b24ub3JnL21haWxtYW4vbGlzdGluZm8vdmlydHVhbGl6YXRpb24= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FD53C48BDF for ; Fri, 18 Jun 2021 09:20:23 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3670C613BA for ; Fri, 18 Jun 2021 09:20:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3670C613BA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JfL2InoSQVuMvBj6PstSUoTTd8X/rpiLYowxA0Rpb2o=; b=S1wTc98zgpax00 URyVTB127NClHpreTbSTjjS+uudTVHr8Jja0xl0Su9vOxKre/bMyC45SpA+Wl41QKBL4rWn4vSWxb Yp6LRpuctGRzx4W5wSiUukyIdkRUIjq7fpnpmakpp+TnKRjET7XRh8umgF8o6TOKjpldDrAAIfmI9 0QjB5+UMi8Q4iFRyl+FRe8y1wg5oYJb0FQT3A6ThiiWdHtLSc2Gworzy3M6i1/Om06SQkSP3u29j3 OOX0DQ01tMWHhE5gOK/mx4qXrUtGaK5uPy6MY+JfZRLq94z6vr/cv/UG2GdXYucLbrCSlKQ0GxNAE I4SgrTJZRQw2QBvheAZg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1luAe1-00DR7s-TA; Fri, 18 Jun 2021 09:18:34 +0000 Received: from mail-ed1-x52b.google.com ([2a00:1450:4864:20::52b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1luAdy-00DR72-33 for linux-arm-kernel@lists.infradead.org; Fri, 18 Jun 2021 09:18:31 +0000 Received: by mail-ed1-x52b.google.com with SMTP id n20so7690218edv.8 for ; Fri, 18 Jun 2021 02:18:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=HRCq4fgN0aqqkE/8MiANC+rXlD39PnksNydgp1NHMj8=; b=aAUvntb9wvjm5kq0+mzAEZrxmcfn0Uq6awR26z3mwJ9WN1M1UjStHyT0vq8IcMR2EZ YxniL1472HHUuFHpCT4Db/CdB4znRz4U6otxHDqPVYY4PhZGWvbraoQiLsJuCHDa97IJ pAZAUDbKDzrRBTvSVZKktiKPq5qvcGKyS+O0va+boqerEOciWdv2r2f7C4hzYA84v6gY uSKEQ2lvdbsyFwYQAKuNzyCzIdc5SLkVvSfX/qfi2PpTE5ZwgTkkzNmyGR4CY5qpoAhU eza97I+5UquHK1GJTNy5RKMkp5vlkITwHBoqUozjghYNSwNUVDNig2XyJndsi03pl73M 9Plg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=HRCq4fgN0aqqkE/8MiANC+rXlD39PnksNydgp1NHMj8=; b=Ma7gsJL2I0g4nVzfAgfEvvTtZD4DiaawxKb+NF9QfkrIJmskmAqJyJ3ekBgJnf34r6 enzWBDgXujc0JfAGBYBw7CYoLFhrMnqJLFImeH52BdcxHLOY73kFWHRXsmT/O06rVJZd vAj+zbdsYZyVRNhvl8KOCXhA+03AWbPHyS62QfiLKfkhub9EqR9QKd0vryf7luWiAYHY FSilrV8sDEBC34iY0i0c0fNJ5VM5VZZ8x+kgVWzz1l9is7sowMfG7/FtJhWNK8LJSwI7 gvCfh6gAOnGf48IGJj5+gQRk0XIVG2QAzufla9xf6N1aqYAIpz41HoTJfOYJyKssuJj4 FtKw== X-Gm-Message-State: AOAM5318SQbiDpKB3CUeLxxQ+SmODnJwAnQKmzbOrlvK4wzbhezKisz0 hUtvzFUtowH6X5P4A/g94E9ELA== X-Google-Smtp-Source: ABdhPJwkM7MFKtctHz8EhEAN6FWomn+q375ZFzmKixM6u9jPqqm7bxiCxZcxkEywq+sBmzBudXNXiw== X-Received: by 2002:a05:6402:2714:: with SMTP id y20mr3735609edd.41.1624007908152; Fri, 18 Jun 2021 02:18:28 -0700 (PDT) Received: from myrica (adsl-84-226-111-173.adslplus.ch. [84.226.111.173]) by smtp.gmail.com with ESMTPSA id u12sm788646eje.40.2021.06.18.02.18.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Jun 2021 02:18:27 -0700 (PDT) Date: Fri, 18 Jun 2021 11:18:08 +0200 From: Jean-Philippe Brucker To: Eric Auger Cc: rjw@rjwysocki.net, lenb@kernel.org, joro@8bytes.org, mst@redhat.com, will@kernel.org, catalin.marinas@arm.com, baolu.lu@linux.intel.com, dwmw2@infradead.org, linux-acpi@vger.kernel.org, iommu@lists.linux-foundation.org, virtualization@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org, sebastien.boeuf@intel.com, robin.murphy@arm.com, kevin.tian@intel.com, lorenzo.pieralisi@arm.com, guohanjun@huawei.com, sudeep.holla@arm.com Subject: Re: [PATCH v4 4/6] iommu/dma: Pass address limit rather than size to iommu_setup_dma_ops() Message-ID: References: <20210610075130.67517-1-jean-philippe@linaro.org> <20210610075130.67517-5-jean-philippe@linaro.org> <6d139529-9539-fbe4-8f85-da39461047ba@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <6d139529-9539-fbe4-8f85-da39461047ba@redhat.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210618_021830_199428_0ECE5701 X-CRM114-Status: GOOD ( 12.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gV2VkLCBKdW4gMTYsIDIwMjEgYXQgMDU6Mjg6NTlQTSArMDIwMCwgRXJpYyBBdWdlciB3cm90 ZToKPiBIaSBKZWFuLAo+IAo+IE9uIDYvMTAvMjEgOTo1MSBBTSwgSmVhbi1QaGlsaXBwZSBCcnVj a2VyIHdyb3RlOgo+ID4gZGlmZiAtLWdpdCBhL2FyY2gvYXJtNjQvbW0vZG1hLW1hcHBpbmcuYyBi L2FyY2gvYXJtNjQvbW0vZG1hLW1hcHBpbmcuYwo+ID4gaW5kZXggNGJmMWRkM2ViMDQxLi43YmQx ZDIxOTkxNDEgMTAwNjQ0Cj4gPiAtLS0gYS9hcmNoL2FybTY0L21tL2RtYS1tYXBwaW5nLmMKPiA+ ICsrKyBiL2FyY2gvYXJtNjQvbW0vZG1hLW1hcHBpbmcuYwo+ID4gQEAgLTUwLDcgKzUwLDcgQEAg dm9pZCBhcmNoX3NldHVwX2RtYV9vcHMoc3RydWN0IGRldmljZSAqZGV2LCB1NjQgZG1hX2Jhc2Us IHU2NCBzaXplLAo+ID4gIAo+ID4gIAlkZXYtPmRtYV9jb2hlcmVudCA9IGNvaGVyZW50Owo+ID4g IAlpZiAoaW9tbXUpCj4gPiAtCQlpb21tdV9zZXR1cF9kbWFfb3BzKGRldiwgZG1hX2Jhc2UsIHNp emUpOwo+ID4gKwkJaW9tbXVfc2V0dXBfZG1hX29wcyhkZXYsIGRtYV9iYXNlLCBzaXplIC0gZG1h X2Jhc2UgLSAxKTsKPiBJIGRvbid0IGdldMKgIHNpemUgLSBkbWFfYmFzZSAtIDE/CgpCZWNhdXNl IGl0J3Mgd3JvbmcsIHNob3VsZCBiZSBkbWFfYmFzZSArIHNpemUgLSAxLiBUaGFua3MgZm9yIGNh dGNoaW5nIGl0IQoKVGhhbmtzLApKZWFuCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJt LWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21h aWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=