All of
 help / color / mirror / Atom feed
From: Dan Carpenter <>
To: James Smart <>
Cc: Ram Vegesna <>,
	"James E.J. Bottomley" <>,
	"Martin K. Petersen" <>,
	Daniel Wagner <>, Hannes Reinecke <>,,,
Subject: [PATCH] scsi: elx: libefc: signedness bug in efc_d_send_prli_rsp()
Date: Fri, 18 Jun 2021 16:42:56 +0300	[thread overview]
Message-ID: <YMyi4LNaVmD7kQEN@mwanda> (raw)

The "rc" variable needs to be signed for the error handling to work.
It holds either a negative error code, EFC_SCSI_CALL_COMPLETE (0),

Fixes: 202bfdffae27 ("scsi: elx: libefc: FC node ELS and state handling")
Signed-off-by: Dan Carpenter <>
 drivers/scsi/elx/libefc/efc_device.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/elx/libefc/efc_device.c b/drivers/scsi/elx/libefc/efc_device.c
index 31a688bce6e9..725ca2a23fb2 100644
--- a/drivers/scsi/elx/libefc/efc_device.c
+++ b/drivers/scsi/elx/libefc/efc_device.c
@@ -15,7 +15,7 @@
 efc_d_send_prli_rsp(struct efc_node *node, u16 ox_id)
 	struct efc *efc = node->efc;
 	node->ls_acc_oxid = ox_id;

             reply	other threads:[~2021-06-18 13:43 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-18 13:42 Dan Carpenter [this message]
2021-06-19 15:44 ` [PATCH] scsi: elx: libefc: signedness bug in efc_d_send_prli_rsp() James Smart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YMyi4LNaVmD7kQEN@mwanda \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.