From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFCB2C48BDF for ; Fri, 18 Jun 2021 14:02:02 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B91C06120A for ; Fri, 18 Jun 2021 14:02:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B91C06120A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 1C59E82BB3; Fri, 18 Jun 2021 16:01:59 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="zg7uTboq"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id AC07782BBC; Fri, 18 Jun 2021 16:01:56 +0200 (CEST) Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id AB85F82B74 for ; Fri, 18 Jun 2021 16:01:53 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=ilias.apalodimas@linaro.org Received: by mail-wr1-x433.google.com with SMTP id f2so10874167wri.11 for ; Fri, 18 Jun 2021 07:01:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=r37hyKZIMqdz/b9aPPHPhG6iygDOHRAH9rovTAx+uLc=; b=zg7uTboqB7ZzV/Fui3NBysl4kOLCBws/1/rD2WExPDKDKukakWHdDSgTyyh2vdHvUk Cydgmd+swUApe5KxjermcltHOe7Nlg7LLE8MmV4C0Y7VOMypME3PGHjYmt3ZxP+ZSVWp rfuhTe8/52N3PBwTOrz80KOh1UXCHatvUKgI5wpwI5U9m5yegmgr3kP3cIeLsqbqcoGq T87wRjh+gk04PEKmvlHW4cgDI7hscGXfif7IYZcpv+VaOPFsk2cjr09t00Ptt88U/JbY fCN4Cec9/atBsf9cFQ2nZlyYDeKC+QJ3xVz0k8amCbSepG2pdcIYgPpTRNriJuIWJguC eBuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=r37hyKZIMqdz/b9aPPHPhG6iygDOHRAH9rovTAx+uLc=; b=ZcLabzet5THFgVF4WJ1e9Wm5UpA/qTj4xvsnyPZqb0zKxFzPf6doLDnQvu19sqbqRb 5npEJ1Kv29IzQMHtxUaydNBsdzWmzDMmpfCdbzSXETuvoW5yOTkvSh3+ecHx6+u2hlYa d9s2Gn2YbfK5AmfoDQvo9ZWczCQl4/feMcrEi9TJXTY7qmLzwV3+MTd0O3exth8mXTy+ lcS4nQ/JMeX6dxlkfn2YAKCIW6FkLkbux74tMCC6oJgTiVoajLP+UC6ry6E90oMJ9A2k i4W5o1px/hqODR/HE0nY+EnGhHGuSVxKHkmeMUeAoEjVt980v2P8BICxx/o30+Cxd02e SWWw== X-Gm-Message-State: AOAM531bURfbrp4GGF/3lYPhmQzNnsJPPhWwlnaZNQC0J4ONOZL54vIT pbtz1QgIb4g7+qeSST96sLSZtw== X-Google-Smtp-Source: ABdhPJzSTQWm8BJTJ42+IFVoPwIXSXR0sY6I8LnFbqgVBJpbX3iv/qcd0tM+r+uB19IhgY8oZKL8OA== X-Received: by 2002:a5d:5082:: with SMTP id a2mr12722895wrt.199.1624024913251; Fri, 18 Jun 2021 07:01:53 -0700 (PDT) Received: from enceladus (athedsl-269684.home.otenet.gr. [85.73.101.18]) by smtp.gmail.com with ESMTPSA id z19sm10930547wmf.31.2021.06.18.07.01.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Jun 2021 07:01:52 -0700 (PDT) Date: Fri, 18 Jun 2021 17:01:47 +0300 From: Ilias Apalodimas To: Masami Hiramatsu Cc: Heinrich Schuchardt , Takahiro Akashi , Michal Simek , Alexander Graf , U-Boot Mailing List Subject: Re: [PATCH 2/3 v2] efi_loader: Force a sinlge FMP instance per hardware store Message-ID: References: <20210618105115.257938-1-ilias.apalodimas@linaro.org> <20210618105115.257938-2-ilias.apalodimas@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Fri, Jun 18, 2021 at 10:52:51PM +0900, Masami Hiramatsu wrote: > Hi Ilias, > > 2021???6???18???(???) 19:51 Ilias Apalodimas : > > > > Chapter 23 of the EFI spec (rev 2.9) says: > > "A specific updatable hardware firmware store must be represented by > > exactly one FMP instance". > > This is not the case for us, since both of our FMP protocols can be > > installed at the same time because they are controlled by a single > > 'dfu_alt_info' env variable. > > So make the config options depend on each other and allow the user to > > install one of them at any given time. If we fix the meta-data provided > > by the 'dfu_alt_info' in the future, to hint about the capsule type > > (fit or raw) we can revise this and enable both FMPs to be installed, as > > long as they target different firmware hardware stores > > > > Note that we are not using a Kconfig 'choice' on purpose, since we > > want to allow both of those to be installed and tested in sandbox > > This sounds like changing the Kconfig, thus... > It does > [...] > > > > - /* Load capsule drivers */ > > - ret = arch_efi_load_capsule_drivers(); > > - if (ret != EFI_SUCCESS) > > - return ret; > > I think this part of the change should be included in the next patch. > > Thank you, Yep, I completely missed this during the rebasing. I'll send a v3. Thanks! /Ilias