* [PATCH 1/2] tests/migration: parse the thread-id key of CpuInfoFast
@ 2021-06-03 14:19 huangy81
2021-06-03 14:20 ` [PATCH 2/2] tests/migration: fix "downtime_limit" type when "migrate-set-parameters" huangy81
` (3 more replies)
0 siblings, 4 replies; 8+ messages in thread
From: huangy81 @ 2021-06-03 14:19 UTC (permalink / raw)
To: qemu-devel
Cc: Hyman Huang(黄勇), Dr. David Alan Gilbert, Juan Quintela
From: Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
thread_id in CpuInfoFast is deprecated, parse thread-id instead
after execute qmp query-cpus-fast. fix this so that test can
go smoothly.
Signed-off-by: Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
---
tests/migration/guestperf/engine.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/migration/guestperf/engine.py b/tests/migration/guestperf/engine.py
index 208e095794..9e16fa92d2 100644
--- a/tests/migration/guestperf/engine.py
+++ b/tests/migration/guestperf/engine.py
@@ -113,7 +113,7 @@ def _migrate(self, hardware, scenario, src, dst, connect_uri):
vcpus = src.command("query-cpus-fast")
src_threads = []
for vcpu in vcpus:
- src_threads.append(vcpu["thread_id"])
+ src_threads.append(vcpu["thread-id"])
# XXX how to get dst timings on remote host ?
--
2.24.3
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 2/2] tests/migration: fix "downtime_limit" type when "migrate-set-parameters"
2021-06-03 14:19 [PATCH 1/2] tests/migration: parse the thread-id key of CpuInfoFast huangy81
@ 2021-06-03 14:20 ` huangy81
2021-06-16 6:33 ` Hyman Huang
2021-06-21 8:20 ` Daniel P. Berrangé
2021-06-16 6:26 ` [PATCH 1/2] tests/migration: parse the thread-id key of CpuInfoFast Hyman Huang
` (2 subsequent siblings)
3 siblings, 2 replies; 8+ messages in thread
From: huangy81 @ 2021-06-03 14:20 UTC (permalink / raw)
To: qemu-devel
Cc: Hyman Huang(黄勇), Dr. David Alan Gilbert, Juan Quintela
From: Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
migrate-set-parameters parse "downtime_limit" as integer type when
execute "migrate-set-parameters" before migration, and, the unit
dowtime_limit is milliseconds, fix this two so that test can go
smoothly.
Signed-off-by: Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
---
tests/migration/guestperf/engine.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/migration/guestperf/engine.py b/tests/migration/guestperf/engine.py
index 9e16fa92d2..7c991c4407 100644
--- a/tests/migration/guestperf/engine.py
+++ b/tests/migration/guestperf/engine.py
@@ -153,7 +153,7 @@ def _migrate(self, hardware, scenario, src, dst, connect_uri):
max_bandwidth=scenario._bandwidth * 1024 * 1024)
resp = src.command("migrate-set-parameters",
- downtime_limit=scenario._downtime / 1024.0)
+ downtime_limit=scenario._downtime)
if scenario._compression_mt:
resp = src.command("migrate-set-capabilities",
--
2.24.3
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] tests/migration: parse the thread-id key of CpuInfoFast
2021-06-03 14:19 [PATCH 1/2] tests/migration: parse the thread-id key of CpuInfoFast huangy81
2021-06-03 14:20 ` [PATCH 2/2] tests/migration: fix "downtime_limit" type when "migrate-set-parameters" huangy81
@ 2021-06-16 6:26 ` Hyman Huang
2021-06-21 6:29 ` Hyman Huang
2021-06-21 8:20 ` Daniel P. Berrangé
2021-07-01 9:15 ` Dr. David Alan Gilbert
3 siblings, 1 reply; 8+ messages in thread
From: Hyman Huang @ 2021-06-16 6:26 UTC (permalink / raw)
To: qemu-devel; +Cc: Dr. David Alan Gilbert, Juan Quintela
在 2021/6/3 22:19, huangy81@chinatelecom.cn 写道:
> From: Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
>
> thread_id in CpuInfoFast is deprecated, parse thread-id instead
> after execute qmp query-cpus-fast. fix this so that test can
> go smoothly.
>
> Signed-off-by: Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
> ---
> tests/migration/guestperf/engine.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/migration/guestperf/engine.py b/tests/migration/guestperf/engine.py
> index 208e095794..9e16fa92d2 100644
> --- a/tests/migration/guestperf/engine.py
> +++ b/tests/migration/guestperf/engine.py
> @@ -113,7 +113,7 @@ def _migrate(self, hardware, scenario, src, dst, connect_uri):
> vcpus = src.command("query-cpus-fast")
> src_threads = []
> for vcpu in vcpus:
> - src_threads.append(vcpu["thread_id"])
> + src_threads.append(vcpu["thread-id"])
>
> # XXX how to get dst timings on remote host ?
>
>
- ping
this patch fix thread_id so that guestperf can run successfully
please review, thanks : ) !
--
Best regard
Hyman Huang(黄勇)
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] tests/migration: fix "downtime_limit" type when "migrate-set-parameters"
2021-06-03 14:20 ` [PATCH 2/2] tests/migration: fix "downtime_limit" type when "migrate-set-parameters" huangy81
@ 2021-06-16 6:33 ` Hyman Huang
2021-06-21 8:20 ` Daniel P. Berrangé
1 sibling, 0 replies; 8+ messages in thread
From: Hyman Huang @ 2021-06-16 6:33 UTC (permalink / raw)
To: qemu-devel; +Cc: Dr. David Alan Gilbert, Juan Quintela
在 2021/6/3 22:20, huangy81@chinatelecom.cn 写道:
> From: Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
>
> migrate-set-parameters parse "downtime_limit" as integer type when
> execute "migrate-set-parameters" before migration, and, the unit
> dowtime_limit is milliseconds, fix this two so that test can go
> smoothly.
>
> Signed-off-by: Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
> ---
> tests/migration/guestperf/engine.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/migration/guestperf/engine.py b/tests/migration/guestperf/engine.py
> index 9e16fa92d2..7c991c4407 100644
> --- a/tests/migration/guestperf/engine.py
> +++ b/tests/migration/guestperf/engine.py
> @@ -153,7 +153,7 @@ def _migrate(self, hardware, scenario, src, dst, connect_uri):
> max_bandwidth=scenario._bandwidth * 1024 * 1024)
>
> resp = src.command("migrate-set-parameters",
> - downtime_limit=scenario._downtime / 1024.0)
> + downtime_limit=scenario._downtime)
>
> if scenario._compression_mt:
> resp = src.command("migrate-set-capabilities",
>
- ping
this patch fix the downtime_limit setting when guestperf start
migration, qemu can not accept down_time parameter with float type. when
running guestperf to test migration, it'll report error.
i think it's resonable for apply this patch
please review,thanks, :) !
--
Best regard
Hyman Huang(黄勇)
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] tests/migration: parse the thread-id key of CpuInfoFast
2021-06-16 6:26 ` [PATCH 1/2] tests/migration: parse the thread-id key of CpuInfoFast Hyman Huang
@ 2021-06-21 6:29 ` Hyman Huang
0 siblings, 0 replies; 8+ messages in thread
From: Hyman Huang @ 2021-06-21 6:29 UTC (permalink / raw)
To: qemu-devel; +Cc: Daniel P. Berrangé, Dr. David Alan Gilbert, Juan Quintela
cc original author Daniel P. Berrangé <berrange@redhat.com> :)
may be this two fixes can be squashed into a single patch.
在 2021/6/16 14:26, Hyman Huang 写道:
>
>
> 在 2021/6/3 22:19, huangy81@chinatelecom.cn 写道:
>> From: Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
>>
>> thread_id in CpuInfoFast is deprecated, parse thread-id instead
>> after execute qmp query-cpus-fast. fix this so that test can
>> go smoothly.
>>
>> Signed-off-by: Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
>> ---
>> tests/migration/guestperf/engine.py | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tests/migration/guestperf/engine.py
>> b/tests/migration/guestperf/engine.py
>> index 208e095794..9e16fa92d2 100644
>> --- a/tests/migration/guestperf/engine.py
>> +++ b/tests/migration/guestperf/engine.py
>> @@ -113,7 +113,7 @@ def _migrate(self, hardware, scenario, src, dst,
>> connect_uri):
>> vcpus = src.command("query-cpus-fast")
>> src_threads = []
>> for vcpu in vcpus:
>> - src_threads.append(vcpu["thread_id"])
>> + src_threads.append(vcpu["thread-id"])
>> # XXX how to get dst timings on remote host ?
>>
>
> - ping
>
> this patch fix thread_id so that guestperf can run successfully
>
> please review, thanks : ) !
>
--
Best regard
Hyman Huang(黄勇)
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] tests/migration: fix "downtime_limit" type when "migrate-set-parameters"
2021-06-03 14:20 ` [PATCH 2/2] tests/migration: fix "downtime_limit" type when "migrate-set-parameters" huangy81
2021-06-16 6:33 ` Hyman Huang
@ 2021-06-21 8:20 ` Daniel P. Berrangé
1 sibling, 0 replies; 8+ messages in thread
From: Daniel P. Berrangé @ 2021-06-21 8:20 UTC (permalink / raw)
To: huangy81; +Cc: Juan Quintela, qemu-devel, Dr. David Alan Gilbert
On Thu, Jun 03, 2021 at 10:20:37PM +0800, huangy81@chinatelecom.cn wrote:
> From: Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
>
> migrate-set-parameters parse "downtime_limit" as integer type when
> execute "migrate-set-parameters" before migration, and, the unit
> dowtime_limit is milliseconds, fix this two so that test can go
> smoothly.
>
> Signed-off-by: Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
> ---
> tests/migration/guestperf/engine.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] tests/migration: parse the thread-id key of CpuInfoFast
2021-06-03 14:19 [PATCH 1/2] tests/migration: parse the thread-id key of CpuInfoFast huangy81
2021-06-03 14:20 ` [PATCH 2/2] tests/migration: fix "downtime_limit" type when "migrate-set-parameters" huangy81
2021-06-16 6:26 ` [PATCH 1/2] tests/migration: parse the thread-id key of CpuInfoFast Hyman Huang
@ 2021-06-21 8:20 ` Daniel P. Berrangé
2021-07-01 9:15 ` Dr. David Alan Gilbert
3 siblings, 0 replies; 8+ messages in thread
From: Daniel P. Berrangé @ 2021-06-21 8:20 UTC (permalink / raw)
To: huangy81; +Cc: Juan Quintela, qemu-devel, Dr. David Alan Gilbert
On Thu, Jun 03, 2021 at 10:19:53PM +0800, huangy81@chinatelecom.cn wrote:
> From: Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
>
> thread_id in CpuInfoFast is deprecated, parse thread-id instead
> after execute qmp query-cpus-fast. fix this so that test can
> go smoothly.
>
> Signed-off-by: Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
> ---
> tests/migration/guestperf/engine.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] tests/migration: parse the thread-id key of CpuInfoFast
2021-06-03 14:19 [PATCH 1/2] tests/migration: parse the thread-id key of CpuInfoFast huangy81
` (2 preceding siblings ...)
2021-06-21 8:20 ` Daniel P. Berrangé
@ 2021-07-01 9:15 ` Dr. David Alan Gilbert
3 siblings, 0 replies; 8+ messages in thread
From: Dr. David Alan Gilbert @ 2021-07-01 9:15 UTC (permalink / raw)
To: huangy81; +Cc: qemu-devel, Juan Quintela
* huangy81@chinatelecom.cn (huangy81@chinatelecom.cn) wrote:
> From: Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
>
> thread_id in CpuInfoFast is deprecated, parse thread-id instead
> after execute qmp query-cpus-fast. fix this so that test can
> go smoothly.
>
> Signed-off-by: Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
Queued (both 1 and 2)
> ---
> tests/migration/guestperf/engine.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/migration/guestperf/engine.py b/tests/migration/guestperf/engine.py
> index 208e095794..9e16fa92d2 100644
> --- a/tests/migration/guestperf/engine.py
> +++ b/tests/migration/guestperf/engine.py
> @@ -113,7 +113,7 @@ def _migrate(self, hardware, scenario, src, dst, connect_uri):
> vcpus = src.command("query-cpus-fast")
> src_threads = []
> for vcpu in vcpus:
> - src_threads.append(vcpu["thread_id"])
> + src_threads.append(vcpu["thread-id"])
>
> # XXX how to get dst timings on remote host ?
>
> --
> 2.24.3
>
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2021-07-01 9:16 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-03 14:19 [PATCH 1/2] tests/migration: parse the thread-id key of CpuInfoFast huangy81
2021-06-03 14:20 ` [PATCH 2/2] tests/migration: fix "downtime_limit" type when "migrate-set-parameters" huangy81
2021-06-16 6:33 ` Hyman Huang
2021-06-21 8:20 ` Daniel P. Berrangé
2021-06-16 6:26 ` [PATCH 1/2] tests/migration: parse the thread-id key of CpuInfoFast Hyman Huang
2021-06-21 6:29 ` Hyman Huang
2021-06-21 8:20 ` Daniel P. Berrangé
2021-07-01 9:15 ` Dr. David Alan Gilbert
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.