From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10759C4743C for ; Mon, 21 Jun 2021 14:10:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E63266120D for ; Mon, 21 Jun 2021 14:10:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229804AbhFUOMR (ORCPT ); Mon, 21 Jun 2021 10:12:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54130 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229736AbhFUOMQ (ORCPT ); Mon, 21 Jun 2021 10:12:16 -0400 Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [IPv6:2a00:1450:4864:20::32e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 72156C061574 for ; Mon, 21 Jun 2021 07:10:01 -0700 (PDT) Received: by mail-wm1-x32e.google.com with SMTP id v20-20020a05600c2154b02901dcefb16af0so62388wml.5 for ; Mon, 21 Jun 2021 07:10:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=8kepLA1skYYXxAo8YW3JZV6sp2HsHnw4TxhCp+yjjQg=; b=h/9/G+BKEWjlDy3cdYEoizmczLXp8k8O9toVOq6Dnc48Iqq0r+nELVmFqttkJenHOo n2j5Idv6Z0CDRsIwKaZhm4xQ/vkIY8xI9Ipvy0R9csY0JiwEjJcmX6MiDjr9TF6ruBof I9wBaMgjrWWYA9SFHzCFACRrc29LsSqkVX1rKmzlcM25gkGuCekxVfBhh61S0a2Hcv9M 4xFlKBEsWluVYnFh0Dw9O/LHIjp8tmv4X7HVeLLBu+AzSuvZI6pxsc4kMHiOBrWusfyg TEnOtOujadbTWVKDERUWzTQ8N27HsF4iqqlU2G9GpKhV7aGYYJzKGfofUtsAyC0NPZQD nItA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=8kepLA1skYYXxAo8YW3JZV6sp2HsHnw4TxhCp+yjjQg=; b=TxCNyg202fE4A8SEZDud6xjsB3ahlZXNPnupdsXoTNVll8bpmETRmALoOUzLxtazN+ m0sFJAc6GAnOQnfrhJHTkwEbph7sF4XQfMPJ1gM6e04xPFyh+Z0PkuKGiEO/1dJAVDaU eQJd7RjfnI5ddYXi+UHTR6koIMM+dQMXqvsoX4oeefxzzQ3f7p1j7Hxic4jbe1WcL9fX CHn61lhaGh9CE5S9Gh6Q/Va/o1DVvgazX1k6KlvRYxWfr1GgrkJ0UUF7VKbdKb4fxr0J h5NTCanQYilDTn0w/fRa9gVRmASEoFZfTJDWBErrxoIMX8TyonKG6zNspBwCVcshLZ8G 80kA== X-Gm-Message-State: AOAM533YjVRJmgsFzKzPk8JBogtbssI8rhCjDmgVex/a3FMsUeFZ81Vp RazP58OeeHZyNcJODsolFrg= X-Google-Smtp-Source: ABdhPJwHv49pYFJDn8vquRM0+2cpK1F0btscoOHXlGyMmv4gAoMpiY01o32Uy1jcbBoDA1Qm2vTxQQ== X-Received: by 2002:a1c:a3c4:: with SMTP id m187mr15738405wme.41.1624284600021; Mon, 21 Jun 2021 07:10:00 -0700 (PDT) Received: from localhost ([62.96.65.119]) by smtp.gmail.com with ESMTPSA id m37sm15730023wms.46.2021.06.21.07.09.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Jun 2021 07:09:58 -0700 (PDT) Date: Mon, 21 Jun 2021 16:11:55 +0200 From: Thierry Reding To: Krzysztof Kozlowski Cc: Rob Herring , Will Deacon , Joerg Roedel , Linux IOMMU , Jon Hunter , Nicolin Chen , linux-tegra , Robin Murphy , linux-arm-kernel Subject: Re: [PATCH v3 2/9] dt-bindings: arm-smmu: Add Tegra186 compatible string Message-ID: References: <20210603164632.1000458-1-thierry.reding@gmail.com> <20210603164632.1000458-3-thierry.reding@gmail.com> <14551e79-853d-471f-bb5e-0d2d6581a9b6@canonical.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Ug2yoxoaj18CzXNu" Content-Disposition: inline In-Reply-To: <14551e79-853d-471f-bb5e-0d2d6581a9b6@canonical.com> User-Agent: Mutt/2.0.7 (481f3800) (2021-05-04) Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org --Ug2yoxoaj18CzXNu Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jun 21, 2021 at 08:46:54AM +0200, Krzysztof Kozlowski wrote: > On 18/06/2021 21:47, Rob Herring wrote: > > On Thu, Jun 3, 2021 at 10:49 AM Thierry Reding wrote: > >> > >> From: Thierry Reding > >> > >> The ARM SMMU instantiations found on Tegra186 and later need inter- > >> operation with the memory controller in order to correctly program > >> stream ID overrides. > >> > >> Furthermore, on Tegra194 multiple instances of the SMMU can gang up > >> to achieve higher throughput. In order to do this, they have to be > >> programmed identically so that the memory controller can interleave > >> memory accesses between them. > >> > >> Add the Tegra186 compatible string to make sure the interoperation > >> with the memory controller can be enabled on that SoC generation. > >> > >> Signed-off-by: Thierry Reding > >> --- > >> Documentation/devicetree/bindings/iommu/arm,smmu.yaml | 11 +++++++++-- > >> 1 file changed, 9 insertions(+), 2 deletions(-) > >> > >> diff --git a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml b/D= ocumentation/devicetree/bindings/iommu/arm,smmu.yaml > >> index 9d27aa5111d4..1181b590db71 100644 > >> --- a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml > >> +++ b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml > >> @@ -54,8 +54,14 @@ properties: > >> - const: arm,mmu-500 > >> - description: NVIDIA SoCs that program two ARM MMU-500s identi= cally > >> items: > >> + - description: NVIDIA SoCs that require memory controller inter= action > >=20 > > This is not valid jsonschema: > >=20 > > /builds/robherring/linux-dt/Documentation/devicetree/bindings/iommu/arm= ,smmu.yaml: > > properties:compatible:oneOf:4:items: 'anyOf' conditional failed, one > > must be fixed: > > None is not of type 'object', 'boolean' > > None is not of type 'array' > > from schema $id: http://json-schema.org/draft-07/schema# > > /builds/robherring/linux-dt/Documentation/devicetree/bindings/iommu/arm= ,smmu.yaml: > > properties:compatible:oneOf:4:items: 'oneOf' conditional failed, one > > must be fixed: > > None is not of type 'object' > > None is not of type 'array' > > from schema $id: http://devicetree.org/meta-schemas/keywords.yaml# > > /builds/robherring/linux-dt/Documentation/devicetree/bindings/iommu/arm= ,smmu.yaml: > > properties:compatible:oneOf:4:items: 'oneOf' conditional failed, one > > must be fixed: > > None is not of type 'object' > > None is not of type 'array' > > from schema $id: http://devicetree.org/meta-schemas/string-array.yaml# > > /builds/robherring/linux-dt/Documentation/devicetree/bindings/iommu/arm= ,smmu.yaml: > > properties:compatible:oneOf:5:items: 'oneOf' conditional failed, one > > must be fixed: > > [{'enum': [{'const': 'nvidia,tegra194-smmu'}, {'const': > > 'nvidia,tegra186-smmu'}]}, {'const': 'nvidia,smmu-500'}] is not of > > type 'object' > > {'const': 'nvidia,tegra194-smmu'} is not of type 'string' > > {'const': 'nvidia,tegra186-smmu'} is not of type 'string' > > from schema $id: http://devicetree.org/meta-schemas/string-array.yaml# > >=20 > >=20 > > This was not reviewed nor tested since the DT list was not Cc'ed. >=20 > Ugh, I see now weird empty item on a list... and not only DT list was > skipped - Thierry did not Cc you either. This seemed like a too trivial addition to waste Rob's time on, so I didn't add him (or the DT list for that matter) on Cc. The ARM SMMU maintainers had reviewed this, which seemed like it was enough for what the DT bindings change was doing. In any case, I clearly should've checked the DT binding check output more carefully. It's rather messy for Tegra because there's quite a few that we haven't converted yet. I'll have to resume my effort to convert the remaining ones and fixup the device trees so that we can actually run the DT binding and DTB validation checks more usefully. > My bad, I did not check that patch thoroughly before applying. >=20 > Thierry, please Cc folks mentioned by get_maintainer.pl. Either sent a > fix or a revert, if fix needs more time. I've sent out a follow-up fix that removes the two bogus lines. It looks like that was the result of a bad conflict resolution on my part. > Additionally, why the patch changes reg to "minItems: 1" for > nvidia,tegra194-smmu? This is because originally the Tegra194 SMMU nodes were supposed to only represent a "dual" instance. However, on Tegra194 there are three SMMU instances in total, with the third instance (dedicated for isochronous traffic) being completely separate and having only a single range of registers. That third instance was previously supposed to be covered by the normal "arm,mmu-500" compatible string, but given that we really need that interoperation between SMMU and memory controller for SID override programming, we need the Tegra-specific compatible for the ISO instance of the SMMU as well. And since that uses only one set of registers, minItems had to become 1. Thierry --Ug2yoxoaj18CzXNu Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmDQnikACgkQ3SOs138+ s6F2uBAAhnU+wroFvGjGTsdCo19Lye7ZwlgYVldxZuzdoI44tNFapF9qTlWT/yE+ MVCOVn2Z85TkKmMWqZh2qFrbBaX4m0tU2QkoIbs5W7Poc6CECTUUsKRSHFWTojgh 1bak/TQdCSFrpwte1XOZ414EFvXRNIEmB2oD8I714MBAlpzSYLFew+1DkLTtBjqa 2Aa80pzR3OEmGhs4h643KHDdDT3RCFLu/h/Xh2h6FCv900D42bLybO0dUyatGbcX XilHecs9gsLSysXAyVyDOZ0EDBVPeeQi1CKo6coC5nXg355cEvNWtYjyW9Bi/J7b m+a3TnU9ryd+fZJFiNTzeu2ElYb8JDotBPf9CeDNeSEL7IHy9o8uOsfM4LJQuCfv 1SCDHiMdSEd7rxk3us3G/yHPaTBSLHIouud7cNy0WCD5JPL/fNgCBSLvOOXFr2LZ kKx3v++QwiLSn+lJrbb5QKyDLIWhUUrV8L2ssf2WdQGGNNKkMzjXgb99NaHHGpZU 8+q90lfktYxoWX6mehBu1luIJ2CPpvlEdX2Nb6zkHcsCwmzSiKDcTLzeBQLSquH+ 5z/FCo/510vTm2rD/9YbjGWbOZ+k8/bs+jTV2rGk/gAxeOuXEbScCyAG7UrFHAvt F6WCjfa4448VFtk0ww2Gm6DMYyrc5VKyn66oCd/xWl/iOQonB4Q= =3Q5A -----END PGP SIGNATURE----- --Ug2yoxoaj18CzXNu-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.0 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_RED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 918C1C4743C for ; Mon, 21 Jun 2021 14:10:06 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3634961261 for ; Mon, 21 Jun 2021 14:10:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3634961261 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id EAA26607A5; Mon, 21 Jun 2021 14:10:05 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id PSaxCVE9hfm7; Mon, 21 Jun 2021 14:10:05 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp3.osuosl.org (Postfix) with ESMTPS id BAA0D60601; Mon, 21 Jun 2021 14:10:04 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 951E0C0010; Mon, 21 Jun 2021 14:10:04 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136]) by lists.linuxfoundation.org (Postfix) with ESMTP id B483EC000C for ; Mon, 21 Jun 2021 14:10:03 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id A26E460601 for ; Mon, 21 Jun 2021 14:10:03 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id WdSKVmeQlN11 for ; Mon, 21 Jun 2021 14:10:02 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by smtp3.osuosl.org (Postfix) with ESMTPS id 557CD60017 for ; Mon, 21 Jun 2021 14:10:01 +0000 (UTC) Received: by mail-wm1-x333.google.com with SMTP id j21-20020a05600c1c15b02901dde2accccbso64932wms.4 for ; Mon, 21 Jun 2021 07:10:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=8kepLA1skYYXxAo8YW3JZV6sp2HsHnw4TxhCp+yjjQg=; b=h/9/G+BKEWjlDy3cdYEoizmczLXp8k8O9toVOq6Dnc48Iqq0r+nELVmFqttkJenHOo n2j5Idv6Z0CDRsIwKaZhm4xQ/vkIY8xI9Ipvy0R9csY0JiwEjJcmX6MiDjr9TF6ruBof I9wBaMgjrWWYA9SFHzCFACRrc29LsSqkVX1rKmzlcM25gkGuCekxVfBhh61S0a2Hcv9M 4xFlKBEsWluVYnFh0Dw9O/LHIjp8tmv4X7HVeLLBu+AzSuvZI6pxsc4kMHiOBrWusfyg TEnOtOujadbTWVKDERUWzTQ8N27HsF4iqqlU2G9GpKhV7aGYYJzKGfofUtsAyC0NPZQD nItA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=8kepLA1skYYXxAo8YW3JZV6sp2HsHnw4TxhCp+yjjQg=; b=sxOEcP73TqR47UZUb1Smq6c4lyg7vZXoR6uUA/YSCZij/sq2wXNNe62D9krCB/w8uf Q7eUdcqOXu5bXbInUSJ7ZDQANSy2PDYK+mYkmzRDLp6vSpnlqXnKq18rZfsHxONfI/03 A2gO5OfStbva+fshDxqy8f3Jo8fDB+ErG8s0KFGzL73c7sqnhVx+6vIeGcphTezPFZ+Z gAnpm0spSbRxSfgHMq5/APGju9/bNE39h7Yv58E+rYP5En5Go3Xgii/iYrFdqTNVjJsb zo0noGvtqFlyO4UoOaFl7W27I/Yc0IElwA3zaAGCqn7jrbb1F6d+5ktY0dTPV87cXOWR K6pQ== X-Gm-Message-State: AOAM530g6W+fkflx5+dag8ibUB3GSoV6XwCNMX17yrc19bNhPBpd4XqV P6nuK5OuqeClP1poNFtKEqk= X-Google-Smtp-Source: ABdhPJwHv49pYFJDn8vquRM0+2cpK1F0btscoOHXlGyMmv4gAoMpiY01o32Uy1jcbBoDA1Qm2vTxQQ== X-Received: by 2002:a1c:a3c4:: with SMTP id m187mr15738405wme.41.1624284600021; Mon, 21 Jun 2021 07:10:00 -0700 (PDT) Received: from localhost ([62.96.65.119]) by smtp.gmail.com with ESMTPSA id m37sm15730023wms.46.2021.06.21.07.09.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Jun 2021 07:09:58 -0700 (PDT) Date: Mon, 21 Jun 2021 16:11:55 +0200 From: Thierry Reding To: Krzysztof Kozlowski Subject: Re: [PATCH v3 2/9] dt-bindings: arm-smmu: Add Tegra186 compatible string Message-ID: References: <20210603164632.1000458-1-thierry.reding@gmail.com> <20210603164632.1000458-3-thierry.reding@gmail.com> <14551e79-853d-471f-bb5e-0d2d6581a9b6@canonical.com> MIME-Version: 1.0 In-Reply-To: <14551e79-853d-471f-bb5e-0d2d6581a9b6@canonical.com> User-Agent: Mutt/2.0.7 (481f3800) (2021-05-04) Cc: Rob Herring , Robin Murphy , Jon Hunter , Linux IOMMU , Nicolin Chen , linux-tegra , Will Deacon , linux-arm-kernel X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============0124851076426206582==" Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" --===============0124851076426206582== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Ug2yoxoaj18CzXNu" Content-Disposition: inline --Ug2yoxoaj18CzXNu Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jun 21, 2021 at 08:46:54AM +0200, Krzysztof Kozlowski wrote: > On 18/06/2021 21:47, Rob Herring wrote: > > On Thu, Jun 3, 2021 at 10:49 AM Thierry Reding wrote: > >> > >> From: Thierry Reding > >> > >> The ARM SMMU instantiations found on Tegra186 and later need inter- > >> operation with the memory controller in order to correctly program > >> stream ID overrides. > >> > >> Furthermore, on Tegra194 multiple instances of the SMMU can gang up > >> to achieve higher throughput. In order to do this, they have to be > >> programmed identically so that the memory controller can interleave > >> memory accesses between them. > >> > >> Add the Tegra186 compatible string to make sure the interoperation > >> with the memory controller can be enabled on that SoC generation. > >> > >> Signed-off-by: Thierry Reding > >> --- > >> Documentation/devicetree/bindings/iommu/arm,smmu.yaml | 11 +++++++++-- > >> 1 file changed, 9 insertions(+), 2 deletions(-) > >> > >> diff --git a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml b/D= ocumentation/devicetree/bindings/iommu/arm,smmu.yaml > >> index 9d27aa5111d4..1181b590db71 100644 > >> --- a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml > >> +++ b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml > >> @@ -54,8 +54,14 @@ properties: > >> - const: arm,mmu-500 > >> - description: NVIDIA SoCs that program two ARM MMU-500s identi= cally > >> items: > >> + - description: NVIDIA SoCs that require memory controller inter= action > >=20 > > This is not valid jsonschema: > >=20 > > /builds/robherring/linux-dt/Documentation/devicetree/bindings/iommu/arm= ,smmu.yaml: > > properties:compatible:oneOf:4:items: 'anyOf' conditional failed, one > > must be fixed: > > None is not of type 'object', 'boolean' > > None is not of type 'array' > > from schema $id: http://json-schema.org/draft-07/schema# > > /builds/robherring/linux-dt/Documentation/devicetree/bindings/iommu/arm= ,smmu.yaml: > > properties:compatible:oneOf:4:items: 'oneOf' conditional failed, one > > must be fixed: > > None is not of type 'object' > > None is not of type 'array' > > from schema $id: http://devicetree.org/meta-schemas/keywords.yaml# > > /builds/robherring/linux-dt/Documentation/devicetree/bindings/iommu/arm= ,smmu.yaml: > > properties:compatible:oneOf:4:items: 'oneOf' conditional failed, one > > must be fixed: > > None is not of type 'object' > > None is not of type 'array' > > from schema $id: http://devicetree.org/meta-schemas/string-array.yaml# > > /builds/robherring/linux-dt/Documentation/devicetree/bindings/iommu/arm= ,smmu.yaml: > > properties:compatible:oneOf:5:items: 'oneOf' conditional failed, one > > must be fixed: > > [{'enum': [{'const': 'nvidia,tegra194-smmu'}, {'const': > > 'nvidia,tegra186-smmu'}]}, {'const': 'nvidia,smmu-500'}] is not of > > type 'object' > > {'const': 'nvidia,tegra194-smmu'} is not of type 'string' > > {'const': 'nvidia,tegra186-smmu'} is not of type 'string' > > from schema $id: http://devicetree.org/meta-schemas/string-array.yaml# > >=20 > >=20 > > This was not reviewed nor tested since the DT list was not Cc'ed. >=20 > Ugh, I see now weird empty item on a list... and not only DT list was > skipped - Thierry did not Cc you either. This seemed like a too trivial addition to waste Rob's time on, so I didn't add him (or the DT list for that matter) on Cc. The ARM SMMU maintainers had reviewed this, which seemed like it was enough for what the DT bindings change was doing. In any case, I clearly should've checked the DT binding check output more carefully. It's rather messy for Tegra because there's quite a few that we haven't converted yet. I'll have to resume my effort to convert the remaining ones and fixup the device trees so that we can actually run the DT binding and DTB validation checks more usefully. > My bad, I did not check that patch thoroughly before applying. >=20 > Thierry, please Cc folks mentioned by get_maintainer.pl. Either sent a > fix or a revert, if fix needs more time. I've sent out a follow-up fix that removes the two bogus lines. It looks like that was the result of a bad conflict resolution on my part. > Additionally, why the patch changes reg to "minItems: 1" for > nvidia,tegra194-smmu? This is because originally the Tegra194 SMMU nodes were supposed to only represent a "dual" instance. However, on Tegra194 there are three SMMU instances in total, with the third instance (dedicated for isochronous traffic) being completely separate and having only a single range of registers. That third instance was previously supposed to be covered by the normal "arm,mmu-500" compatible string, but given that we really need that interoperation between SMMU and memory controller for SID override programming, we need the Tegra-specific compatible for the ISO instance of the SMMU as well. And since that uses only one set of registers, minItems had to become 1. Thierry --Ug2yoxoaj18CzXNu Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmDQnikACgkQ3SOs138+ s6F2uBAAhnU+wroFvGjGTsdCo19Lye7ZwlgYVldxZuzdoI44tNFapF9qTlWT/yE+ MVCOVn2Z85TkKmMWqZh2qFrbBaX4m0tU2QkoIbs5W7Poc6CECTUUsKRSHFWTojgh 1bak/TQdCSFrpwte1XOZ414EFvXRNIEmB2oD8I714MBAlpzSYLFew+1DkLTtBjqa 2Aa80pzR3OEmGhs4h643KHDdDT3RCFLu/h/Xh2h6FCv900D42bLybO0dUyatGbcX XilHecs9gsLSysXAyVyDOZ0EDBVPeeQi1CKo6coC5nXg355cEvNWtYjyW9Bi/J7b m+a3TnU9ryd+fZJFiNTzeu2ElYb8JDotBPf9CeDNeSEL7IHy9o8uOsfM4LJQuCfv 1SCDHiMdSEd7rxk3us3G/yHPaTBSLHIouud7cNy0WCD5JPL/fNgCBSLvOOXFr2LZ kKx3v++QwiLSn+lJrbb5QKyDLIWhUUrV8L2ssf2WdQGGNNKkMzjXgb99NaHHGpZU 8+q90lfktYxoWX6mehBu1luIJ2CPpvlEdX2Nb6zkHcsCwmzSiKDcTLzeBQLSquH+ 5z/FCo/510vTm2rD/9YbjGWbOZ+k8/bs+jTV2rGk/gAxeOuXEbScCyAG7UrFHAvt F6WCjfa4448VFtk0ww2Gm6DMYyrc5VKyn66oCd/xWl/iOQonB4Q= =3Q5A -----END PGP SIGNATURE----- --Ug2yoxoaj18CzXNu-- --===============0124851076426206582== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu --===============0124851076426206582==-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 242CBC4743C for ; Mon, 21 Jun 2021 14:12:03 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E3C6A6120D for ; Mon, 21 Jun 2021 14:12:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E3C6A6120D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=cAiTANPWi3NyIcSLw4848yWlptadjG38dXsm3jbBE/g=; b=Rm8oLokw+kx3QpL/NVdtmDY82A mMKSRGqQsFEiv/SO/Y6mYRrlfWdIk9akz8RK7rqYUQEy+Z55K5VHFCrvgmbx4tHSYGMYk7sOAZBHi a4w/PVQpOo2jpkEweuktjo2meOiFx1fkjkaxfWb8dEm8SRhYXaS9xAtVBVcyW/myyWh3mg2+PfYf0 7vdAoykaBd4EVrNQRQmSR99RT6SLU2bDQ71HfGTDAqSOTpmR1HtGz2cn5yuMIPlajIPwfJFIVERtH em1CmEB5agK6dN5DNBGbz5r77AKverG1d2pMOTUBjVkqMULLBKtrlnXTguDr+sH+zTS2zOgaZW9xO dqvzQmjQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lvKcq-003gQN-FR; Mon, 21 Jun 2021 14:10:08 +0000 Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lvKcm-003gPI-W3 for linux-arm-kernel@lists.infradead.org; Mon, 21 Jun 2021 14:10:06 +0000 Received: by mail-wm1-x32e.google.com with SMTP id h21-20020a1ccc150000b02901d4d33c5ca0so68335wmb.3 for ; Mon, 21 Jun 2021 07:10:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=8kepLA1skYYXxAo8YW3JZV6sp2HsHnw4TxhCp+yjjQg=; b=h/9/G+BKEWjlDy3cdYEoizmczLXp8k8O9toVOq6Dnc48Iqq0r+nELVmFqttkJenHOo n2j5Idv6Z0CDRsIwKaZhm4xQ/vkIY8xI9Ipvy0R9csY0JiwEjJcmX6MiDjr9TF6ruBof I9wBaMgjrWWYA9SFHzCFACRrc29LsSqkVX1rKmzlcM25gkGuCekxVfBhh61S0a2Hcv9M 4xFlKBEsWluVYnFh0Dw9O/LHIjp8tmv4X7HVeLLBu+AzSuvZI6pxsc4kMHiOBrWusfyg TEnOtOujadbTWVKDERUWzTQ8N27HsF4iqqlU2G9GpKhV7aGYYJzKGfofUtsAyC0NPZQD nItA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=8kepLA1skYYXxAo8YW3JZV6sp2HsHnw4TxhCp+yjjQg=; b=kxdAxwW2fhHFB6QOxB9xBerrQBwQqumwOsJnjwNlwSyFjNuNezuwWXjomhcjSdy1pJ DTiN61/aRUPBiO2Qsqviq76k8/ml76ld3Uqu0b/Yk5zMq9iFadSoeUXUlTdCYPsxOFI+ E9tJlC2Zb42uNZgePlD9SZxSJwhkVmJ3F74nhCmNACBrAKKZPhAYlR0vzsnTNqKl0ZsX Re3MbCpnq0DVytDBLovprgjDdX4xy9UUKRaZGlSEZkGdsLCTAoy+1VGS2+HjUI170okE Be8u4MYTnFTUXN5xJ9PmGJ07rxSv5Tkqi4q8gNkvtv5rYNY8YrhXMowNS+yCdacOGoBF Dp+Q== X-Gm-Message-State: AOAM531l1KlROHC6yXt7FrPVFgrW67Nc7fRbFXJRpb6/Wew/bGKdoT/T r4tcXzYEk/aaLp4FVa8b+ts= X-Google-Smtp-Source: ABdhPJwHv49pYFJDn8vquRM0+2cpK1F0btscoOHXlGyMmv4gAoMpiY01o32Uy1jcbBoDA1Qm2vTxQQ== X-Received: by 2002:a1c:a3c4:: with SMTP id m187mr15738405wme.41.1624284600021; Mon, 21 Jun 2021 07:10:00 -0700 (PDT) Received: from localhost ([62.96.65.119]) by smtp.gmail.com with ESMTPSA id m37sm15730023wms.46.2021.06.21.07.09.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Jun 2021 07:09:58 -0700 (PDT) Date: Mon, 21 Jun 2021 16:11:55 +0200 From: Thierry Reding To: Krzysztof Kozlowski Cc: Rob Herring , Will Deacon , Joerg Roedel , Linux IOMMU , Jon Hunter , Nicolin Chen , linux-tegra , Robin Murphy , linux-arm-kernel Subject: Re: [PATCH v3 2/9] dt-bindings: arm-smmu: Add Tegra186 compatible string Message-ID: References: <20210603164632.1000458-1-thierry.reding@gmail.com> <20210603164632.1000458-3-thierry.reding@gmail.com> <14551e79-853d-471f-bb5e-0d2d6581a9b6@canonical.com> MIME-Version: 1.0 In-Reply-To: <14551e79-853d-471f-bb5e-0d2d6581a9b6@canonical.com> User-Agent: Mutt/2.0.7 (481f3800) (2021-05-04) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210621_071005_104314_EADC7622 X-CRM114-Status: GOOD ( 35.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============3315820317836612192==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============3315820317836612192== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Ug2yoxoaj18CzXNu" Content-Disposition: inline --Ug2yoxoaj18CzXNu Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jun 21, 2021 at 08:46:54AM +0200, Krzysztof Kozlowski wrote: > On 18/06/2021 21:47, Rob Herring wrote: > > On Thu, Jun 3, 2021 at 10:49 AM Thierry Reding wrote: > >> > >> From: Thierry Reding > >> > >> The ARM SMMU instantiations found on Tegra186 and later need inter- > >> operation with the memory controller in order to correctly program > >> stream ID overrides. > >> > >> Furthermore, on Tegra194 multiple instances of the SMMU can gang up > >> to achieve higher throughput. In order to do this, they have to be > >> programmed identically so that the memory controller can interleave > >> memory accesses between them. > >> > >> Add the Tegra186 compatible string to make sure the interoperation > >> with the memory controller can be enabled on that SoC generation. > >> > >> Signed-off-by: Thierry Reding > >> --- > >> Documentation/devicetree/bindings/iommu/arm,smmu.yaml | 11 +++++++++-- > >> 1 file changed, 9 insertions(+), 2 deletions(-) > >> > >> diff --git a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml b/D= ocumentation/devicetree/bindings/iommu/arm,smmu.yaml > >> index 9d27aa5111d4..1181b590db71 100644 > >> --- a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml > >> +++ b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml > >> @@ -54,8 +54,14 @@ properties: > >> - const: arm,mmu-500 > >> - description: NVIDIA SoCs that program two ARM MMU-500s identi= cally > >> items: > >> + - description: NVIDIA SoCs that require memory controller inter= action > >=20 > > This is not valid jsonschema: > >=20 > > /builds/robherring/linux-dt/Documentation/devicetree/bindings/iommu/arm= ,smmu.yaml: > > properties:compatible:oneOf:4:items: 'anyOf' conditional failed, one > > must be fixed: > > None is not of type 'object', 'boolean' > > None is not of type 'array' > > from schema $id: http://json-schema.org/draft-07/schema# > > /builds/robherring/linux-dt/Documentation/devicetree/bindings/iommu/arm= ,smmu.yaml: > > properties:compatible:oneOf:4:items: 'oneOf' conditional failed, one > > must be fixed: > > None is not of type 'object' > > None is not of type 'array' > > from schema $id: http://devicetree.org/meta-schemas/keywords.yaml# > > /builds/robherring/linux-dt/Documentation/devicetree/bindings/iommu/arm= ,smmu.yaml: > > properties:compatible:oneOf:4:items: 'oneOf' conditional failed, one > > must be fixed: > > None is not of type 'object' > > None is not of type 'array' > > from schema $id: http://devicetree.org/meta-schemas/string-array.yaml# > > /builds/robherring/linux-dt/Documentation/devicetree/bindings/iommu/arm= ,smmu.yaml: > > properties:compatible:oneOf:5:items: 'oneOf' conditional failed, one > > must be fixed: > > [{'enum': [{'const': 'nvidia,tegra194-smmu'}, {'const': > > 'nvidia,tegra186-smmu'}]}, {'const': 'nvidia,smmu-500'}] is not of > > type 'object' > > {'const': 'nvidia,tegra194-smmu'} is not of type 'string' > > {'const': 'nvidia,tegra186-smmu'} is not of type 'string' > > from schema $id: http://devicetree.org/meta-schemas/string-array.yaml# > >=20 > >=20 > > This was not reviewed nor tested since the DT list was not Cc'ed. >=20 > Ugh, I see now weird empty item on a list... and not only DT list was > skipped - Thierry did not Cc you either. This seemed like a too trivial addition to waste Rob's time on, so I didn't add him (or the DT list for that matter) on Cc. The ARM SMMU maintainers had reviewed this, which seemed like it was enough for what the DT bindings change was doing. In any case, I clearly should've checked the DT binding check output more carefully. It's rather messy for Tegra because there's quite a few that we haven't converted yet. I'll have to resume my effort to convert the remaining ones and fixup the device trees so that we can actually run the DT binding and DTB validation checks more usefully. > My bad, I did not check that patch thoroughly before applying. >=20 > Thierry, please Cc folks mentioned by get_maintainer.pl. Either sent a > fix or a revert, if fix needs more time. I've sent out a follow-up fix that removes the two bogus lines. It looks like that was the result of a bad conflict resolution on my part. > Additionally, why the patch changes reg to "minItems: 1" for > nvidia,tegra194-smmu? This is because originally the Tegra194 SMMU nodes were supposed to only represent a "dual" instance. However, on Tegra194 there are three SMMU instances in total, with the third instance (dedicated for isochronous traffic) being completely separate and having only a single range of registers. That third instance was previously supposed to be covered by the normal "arm,mmu-500" compatible string, but given that we really need that interoperation between SMMU and memory controller for SID override programming, we need the Tegra-specific compatible for the ISO instance of the SMMU as well. And since that uses only one set of registers, minItems had to become 1. Thierry --Ug2yoxoaj18CzXNu Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmDQnikACgkQ3SOs138+ s6F2uBAAhnU+wroFvGjGTsdCo19Lye7ZwlgYVldxZuzdoI44tNFapF9qTlWT/yE+ MVCOVn2Z85TkKmMWqZh2qFrbBaX4m0tU2QkoIbs5W7Poc6CECTUUsKRSHFWTojgh 1bak/TQdCSFrpwte1XOZ414EFvXRNIEmB2oD8I714MBAlpzSYLFew+1DkLTtBjqa 2Aa80pzR3OEmGhs4h643KHDdDT3RCFLu/h/Xh2h6FCv900D42bLybO0dUyatGbcX XilHecs9gsLSysXAyVyDOZ0EDBVPeeQi1CKo6coC5nXg355cEvNWtYjyW9Bi/J7b m+a3TnU9ryd+fZJFiNTzeu2ElYb8JDotBPf9CeDNeSEL7IHy9o8uOsfM4LJQuCfv 1SCDHiMdSEd7rxk3us3G/yHPaTBSLHIouud7cNy0WCD5JPL/fNgCBSLvOOXFr2LZ kKx3v++QwiLSn+lJrbb5QKyDLIWhUUrV8L2ssf2WdQGGNNKkMzjXgb99NaHHGpZU 8+q90lfktYxoWX6mehBu1luIJ2CPpvlEdX2Nb6zkHcsCwmzSiKDcTLzeBQLSquH+ 5z/FCo/510vTm2rD/9YbjGWbOZ+k8/bs+jTV2rGk/gAxeOuXEbScCyAG7UrFHAvt F6WCjfa4448VFtk0ww2Gm6DMYyrc5VKyn66oCd/xWl/iOQonB4Q= =3Q5A -----END PGP SIGNATURE----- --Ug2yoxoaj18CzXNu-- --===============3315820317836612192== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============3315820317836612192==--