From: Matthew Wilcox <willy@infradead.org> To: Christoph Hellwig <hch@lst.de> Cc: viro@zeniv.linux.org.uk, Vivek Goyal <vgoyal@redhat.com>, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, virtio-fs@redhat.com Subject: Re: [PATCH 1/2] init: split get_fs_names Date: Mon, 21 Jun 2021 16:09:16 +0100 [thread overview] Message-ID: <YNCrnCvtlOuZO9jV@casper.infradead.org> (raw) In-Reply-To: <20210621062657.3641879-2-hch@lst.de> On Mon, Jun 21, 2021 at 08:26:56AM +0200, Christoph Hellwig wrote: > -static void __init get_fs_names(char *page) > +static void __init split_fs_names(char *page, char *names) If you're going to respin it anyway, can you rename 'page' to 'buf' or something? Kind of confusing to have a char * called 'page'. > { > + strcpy(page, root_fs_names); > + while (*page++) { > + if (page[-1] == ',') > + page[-1] = '\0'; > + } > + *page = '\0'; > +} is it really worth doing a strcpy() followed by a custom strtok()? would this work better? char c; do { c = *root_fs_names++; *buf++ = c; if (c == ',') buf[-1] = '\0'; } while (c); > +static void __init get_all_fs_names(char *page) > +{ > + int len = get_filesystem_list(page); it occurs to me that get_filesystem_list() fails silently. if you build every linux filesystem in, and want your root on zonefs (assuming they're alphabetical), we'll fail to find it without a message indicating that we overflowed the buffer.
WARNING: multiple messages have this Message-ID (diff)
From: Matthew Wilcox <willy@infradead.org> To: Christoph Hellwig <hch@lst.de> Cc: linux-fsdevel@vger.kernel.org, virtio-fs@redhat.com, viro@zeniv.linux.org.uk, Vivek Goyal <vgoyal@redhat.com>, linux-kernel@vger.kernel.org Subject: Re: [Virtio-fs] [PATCH 1/2] init: split get_fs_names Date: Mon, 21 Jun 2021 16:09:16 +0100 [thread overview] Message-ID: <YNCrnCvtlOuZO9jV@casper.infradead.org> (raw) In-Reply-To: <20210621062657.3641879-2-hch@lst.de> On Mon, Jun 21, 2021 at 08:26:56AM +0200, Christoph Hellwig wrote: > -static void __init get_fs_names(char *page) > +static void __init split_fs_names(char *page, char *names) If you're going to respin it anyway, can you rename 'page' to 'buf' or something? Kind of confusing to have a char * called 'page'. > { > + strcpy(page, root_fs_names); > + while (*page++) { > + if (page[-1] == ',') > + page[-1] = '\0'; > + } > + *page = '\0'; > +} is it really worth doing a strcpy() followed by a custom strtok()? would this work better? char c; do { c = *root_fs_names++; *buf++ = c; if (c == ',') buf[-1] = '\0'; } while (c); > +static void __init get_all_fs_names(char *page) > +{ > + int len = get_filesystem_list(page); it occurs to me that get_filesystem_list() fails silently. if you build every linux filesystem in, and want your root on zonefs (assuming they're alphabetical), we'll fail to find it without a message indicating that we overflowed the buffer.
next prev parent reply other threads:[~2021-06-21 15:10 UTC|newest] Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-06-21 6:26 support booting of arbitrary non-blockdevice file systems v2 Christoph Hellwig 2021-06-21 6:26 ` [Virtio-fs] " Christoph Hellwig 2021-06-21 6:26 ` [PATCH 1/2] init: split get_fs_names Christoph Hellwig 2021-06-21 6:26 ` [Virtio-fs] " Christoph Hellwig 2021-06-21 14:46 ` Al Viro 2021-06-21 14:46 ` [Virtio-fs] " Al Viro 2021-06-21 14:51 ` Al Viro 2021-06-21 14:51 ` [Virtio-fs] " Al Viro 2021-06-21 14:53 ` Christoph Hellwig 2021-06-21 14:53 ` [Virtio-fs] " Christoph Hellwig 2021-06-21 14:59 ` Al Viro 2021-06-21 14:59 ` [Virtio-fs] " Al Viro 2021-06-21 15:09 ` Matthew Wilcox [this message] 2021-06-21 15:09 ` Matthew Wilcox 2021-06-21 15:22 ` Christoph Hellwig 2021-06-21 15:22 ` [Virtio-fs] " Christoph Hellwig 2021-06-21 6:26 ` [PATCH 2/2] init: allow mounting arbitrary non-blockdevice filesystems as root Christoph Hellwig 2021-06-21 6:26 ` [Virtio-fs] " Christoph Hellwig 2021-06-21 13:31 ` [Virtio-fs] support booting of arbitrary non-blockdevice file systems v2 Stefan Hajnoczi 2021-06-21 13:31 ` Stefan Hajnoczi 2021-06-21 14:35 ` Vivek Goyal 2021-06-21 14:35 ` [Virtio-fs] " Vivek Goyal 2021-06-22 8:12 ` [PATCH 3/2] fs: simplify get_filesystem_list / get_all_fs_names Christoph Hellwig 2021-06-22 8:12 ` [Virtio-fs] " Christoph Hellwig 2021-06-22 8:36 ` Stefan Hajnoczi 2021-06-22 8:36 ` Stefan Hajnoczi 2021-06-29 20:50 ` Vivek Goyal 2021-06-29 20:50 ` Vivek Goyal 2021-06-30 5:36 ` Christoph Hellwig 2021-06-30 5:36 ` Christoph Hellwig 2021-06-30 17:33 ` Vivek Goyal 2021-06-30 17:33 ` Vivek Goyal 2021-07-07 21:04 ` Vivek Goyal 2021-07-07 21:04 ` Vivek Goyal 2021-07-07 21:06 ` Vivek Goyal 2021-07-07 21:06 ` Vivek Goyal 2021-07-08 12:59 ` Vivek Goyal 2021-07-08 12:59 ` Vivek Goyal 2021-07-12 18:21 ` Vivek Goyal 2021-07-12 18:21 ` Vivek Goyal 2021-07-13 5:40 ` Christoph Hellwig 2021-07-13 5:40 ` Christoph Hellwig -- strict thread matches above, loose matches on Subject: below -- 2021-06-17 15:36 support booting of arbitrary non-blockdevice file systems Christoph Hellwig 2021-06-17 15:36 ` [PATCH 1/2] init: split get_fs_names Christoph Hellwig
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YNCrnCvtlOuZO9jV@casper.infradead.org \ --to=willy@infradead.org \ --cc=hch@lst.de \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=vgoyal@redhat.com \ --cc=viro@zeniv.linux.org.uk \ --cc=virtio-fs@redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.