From: Greg KH <greg@kroah.com>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: linux-can@vger.kernel.org, kernel@pengutronix.de,
Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>,
linux-stable <stable@vger.kernel.org>,
syzbot <syzbot+355f8edb2ff45d5f95fa@syzkaller.appspotmail.com>,
syzbot <syzbot+0f1827363a305f74996f@syzkaller.appspotmail.com>,
Kirill Tkhai <ktkhai@virtuozzo.com>,
Oliver Hartkopp <socketcan@hartkopp.net>
Subject: Re: [PATCH] can: bcm/raw/isotp: use per module netdevice notifier
Date: Mon, 21 Jun 2021 17:25:33 +0200 [thread overview]
Message-ID: <YNCvbZp5LDwUvyjZ@kroah.com> (raw)
In-Reply-To: <20210621112820.5gemmaw56bipx45j@pengutronix.de>
On Mon, Jun 21, 2021 at 01:28:20PM +0200, Marc Kleine-Budde wrote:
> On 21.06.2021 13:24:51, Marc Kleine-Budde wrote:
> > From: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
> >
> > commit 8d0caedb759683041d9db82069937525999ada53 upstream
> >
> > syzbot is reporting hung task at register_netdevice_notifier() [1] and
> > unregister_netdevice_notifier() [2], for cleanup_net() might perform
> > time consuming operations while CAN driver's raw/bcm/isotp modules are
> > calling {register,unregister}_netdevice_notifier() on each socket.
> >
> > Change raw/bcm/isotp modules to call register_netdevice_notifier() from
> > module's __init function and call unregister_netdevice_notifier() from
> > module's __exit function, as with gw/j1939 modules are doing.
> >
> > Link: https://syzkaller.appspot.com/bug?id=391b9498827788b3cc6830226d4ff5be87107c30 [1]
> > Link: https://syzkaller.appspot.com/bug?id=1724d278c83ca6e6df100a2e320c10d991cf2bce [2]
> > Link: https://lore.kernel.org/r/54a5f451-05ed-f977-8534-79e7aa2bcc8f@i-love.sakura.ne.jp
> > Cc: linux-stable <stable@vger.kernel.org>
> > Reported-by: syzbot <syzbot+355f8edb2ff45d5f95fa@syzkaller.appspotmail.com>
> > Reported-by: syzbot <syzbot+0f1827363a305f74996f@syzkaller.appspotmail.com>
> > Reviewed-by: Kirill Tkhai <ktkhai@virtuozzo.com>
> > Tested-by: syzbot <syzbot+355f8edb2ff45d5f95fa@syzkaller.appspotmail.com>
> > Tested-by: Oliver Hartkopp <socketcan@hartkopp.net>
> > Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
> > [mkl: ported to v4.19.195]
> > Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
> > ---
> > Hello Greg,
> >
> > this is a backport of
> >
> > | 8d0caedb7596 can: bcm/raw/isotp: use per module netdevice notifier
> >
> > to v4.19.195. Please apply.
>
> This also applies to v4.14.237.
>
> I'm working on a v4.9 version.
All now applied, thanks!
greg k-h
next prev parent reply other threads:[~2021-06-21 15:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-21 10:38 FAILED: patch "[PATCH] can: bcm/raw/isotp: use per module netdevice notifier" failed to apply to 4.19-stable tree gregkh
2021-06-21 11:24 ` [PATCH] can: bcm/raw/isotp: use per module netdevice notifier Marc Kleine-Budde
2021-06-21 11:28 ` Marc Kleine-Budde
2021-06-21 15:25 ` Greg KH [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-06-21 10:38 FAILED: patch "[PATCH] can: bcm/raw/isotp: use per module netdevice notifier" failed to apply to 4.9-stable tree gregkh
2021-06-21 11:58 ` [PATCH] can: bcm/raw/isotp: use per module netdevice notifier Marc Kleine-Budde
2021-06-21 12:01 ` Marc Kleine-Budde
2021-06-02 15:17 Tetsuo Handa
2021-06-03 6:09 ` Oliver Hartkopp
2021-06-03 11:02 ` Tetsuo Handa
2021-06-04 0:22 ` Tetsuo Handa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YNCvbZp5LDwUvyjZ@kroah.com \
--to=greg@kroah.com \
--cc=kernel@pengutronix.de \
--cc=ktkhai@virtuozzo.com \
--cc=linux-can@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=socketcan@hartkopp.net \
--cc=stable@vger.kernel.org \
--cc=syzbot+0f1827363a305f74996f@syzkaller.appspotmail.com \
--cc=syzbot+355f8edb2ff45d5f95fa@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.