From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94FB3C4743C for ; Mon, 21 Jun 2021 19:00:42 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3A612610C7 for ; Mon, 21 Jun 2021 19:00:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3A612610C7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8EC8E6E3EB; Mon, 21 Jun 2021 19:00:41 +0000 (UTC) Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id 930D46E3D6 for ; Mon, 21 Jun 2021 19:00:40 +0000 (UTC) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 8ACCF5D6B; Mon, 21 Jun 2021 21:00:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1624302038; bh=xMbLrsqFQgLO000qHWcpbhX1PSnZ/Gn8gGSn4kGajJ4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=UpCijo+cfC3dV8NbQC814d+KV57WlGiN1pIY5cx0igC9I2KcwTwcqvcMmd/WuRIIO E+OWjQthn5FMfr7uqGa0/Pm1PEYZZVzoHEVJRsjV29NnnCLPwc39xpx8XfOZWEMAvB 98dwWEeS2vGPa69CSggVsz8AGF8RiIVlsJqnJJbc= Date: Mon, 21 Jun 2021 22:00:11 +0300 From: Laurent Pinchart To: Sam Ravnborg Subject: Re: [PATCH 0/5] ti-sn65dsi83: Finalize transition to atomic operations Message-ID: References: <20210621125518.13715-1-laurent.pinchart@ideasonboard.com> <20210621184953.GC918146@ravnborg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210621184953.GC918146@ravnborg.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Marek Vasut , Loic Poulain , Dave Stevenson , Robert Foss , Douglas Anderson , dri-devel@lists.freedesktop.org, Frieder Schrempf , Philippe Schenker , Jagan Teki , Valentin Raevsky , Stephen Boyd , Adam Ford , Maxime Ripard Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Sam, On Mon, Jun 21, 2021 at 08:49:53PM +0200, Sam Ravnborg wrote: > On Mon, Jun 21, 2021 at 03:55:13PM +0300, Laurent Pinchart wrote: > > Hello, > > > > This patch series is based on top of "[PATCH] drm/bridge: ti-sn65dsi83: > > Replace connector format patching with atomic_get_input_bus_fmts". It > > completes the transition to atomic operations in the ti-sn65dsi83 > > driver. The main reason for this change is patch 4/5 that fixes a few > > issues in the driver (see the patch's commit message for details), but > > overall it also brings the driver to the most recent API which is nice > > in itself. > > > > Laurent Pinchart (5): > > drm: bridge: ti-sn65dsi83: Move LVDS format selection to .mode_set() > > drm: bridge: ti-sn65dsi83: Pass mode explicitly to helper functions > > drm: bridge: ti-sn65dsi83: Switch to atomic operations > > drm: bridge: ti-sn65dsi83: Retrieve output format from bridge state > > drm: bridge: ti-sn65dsi83: Retrieve the display mode from the state > > > > drivers/gpu/drm/bridge/ti-sn65dsi83.c | 166 +++++++++++++------------- > > 1 file changed, 82 insertions(+), 84 deletions(-) > > I have browsed the series and it all looked good. > Acked-by: Sam Ravnborg > > on them all. > > It is news to me that the atomic ops are the way to go - but then I have > been off-line for a while so no suprise or maybe I just missed it > before. They're not mandatory as such, but they give us access to the atomic state, which is sometimes required. Overall I think it would be nice to move to the atomic operations and drop the legacy ones, to avoid maintaining two sets of operations. It will take time :-) > It would be good if the comments in drm_bridge.h could point out what is > deprecated, so we know what to avoid in new and updated bridge drivers. > But this is all un-related to this series. It's a good point. Would you like to submit a patch, or should I do so ? -- Regards, Laurent Pinchart