From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14AA7C4743C for ; Tue, 22 Jun 2021 00:44:49 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C22D1610EA for ; Tue, 22 Jun 2021 00:44:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C22D1610EA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1lvUWx-0004ri-FK; Tue, 22 Jun 2021 00:44:43 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lvUWv-0004rX-S3 for linux-f2fs-devel@lists.sourceforge.net; Tue, 22 Jun 2021 00:44:41 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=4e8XLjWobcJqQzXV5OAgSzPbZdKPOl4gG9+yWjIl68U=; b=JbRb1t1CzrCIwDTTLCLFs6fFdY polNG0WQFTMBgkGJ1HARxAJ2eLZT+rPX+m+ANijWHnxe0aGyFoOa42zA9AePcO6WLa8IGm5SSkjAe taclfFmij7NX5TvlpMbeya7rWuo2+40o1ri0hCWrua7d0KNbr922mNuoUWqTX0cQxFLY=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=4e8XLjWobcJqQzXV5OAgSzPbZdKPOl4gG9+yWjIl68U=; b=RAR6SJ5YjBumdoOuvrMZZunk3x 3OZuF0zruxRFRzR+1eUEM1iuT09Gs+dOgdAtTCZUtLdEpqqqf6wJ3/TBS5dJr54E+py3I/cgTNwkh fsX4XoAYn1+477h902bEG8s538pD+wKWolqmY6HtlQ/DoKwfg0vlh/1UdUagalUQz71s=; Received: from mail.kernel.org ([198.145.29.99]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.3) id 1lvUWm-0003IM-Rt for linux-f2fs-devel@lists.sourceforge.net; Tue, 22 Jun 2021 00:44:44 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id C3B4961245; Tue, 22 Jun 2021 00:44:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1624322662; bh=2RP2X+m65Nr99q59bea69jsh5nbUda5kJywZCm6lzQc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=EYNJ6YrG3mCCq1CLiQVhf9Q1z4f//GZsvDDtM+OxJP+7pH+cal1ChVuUDyrdETxPo kE3mvm42Z+BEFv6gbqoBPzZqsS8I1UpTMcWEsEVa9YL7yfbbnWXdDorxTdWNMi3LZk z3vKcrx7G1N/lIw82XEvA1AYE1V9ihTkr4y3dXmf8q6oMTxgfy4dTxQVbQ06MyA41W 2h4lhC+nvCxVg8ywU0Jgf50N5kYcevqL7ahbZ1+t7UxUMwB7dR/kngwvTj64NpMXLB ElBt7K1J9lOot67dPLBs+drAHaAiGgP/B80NC68PfVQri31dtRhcapHGv6CVASHL9n qshvkGilC2zdw== Date: Mon, 21 Jun 2021 17:44:21 -0700 From: Jaegeuk Kim To: Aravind Ramesh Message-ID: References: <20210616192558.1655258-1-aravind.ramesh@wdc.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Headers-End: 1lvUWm-0003IM-Rt Subject: Re: [f2fs-dev] [PATCH] f2fs-tools: fix metadata region overlap with zoned block device zones X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "linux-f2fs-devel@lists.sourceforge.net" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net Hi, On 06/21, Aravind Ramesh wrote: > Hello Kim, > > Could you please pull this ? > I will send a v2 if any review comments are there, please let me know. I queued this in -dev which will go into -master later. https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs-tools.git/commit/?h=dev&id=b750268dafec5a59716b9aec606dc18a9cbdae70 Thanks, > > Thanks, > Aravind > > > -----Original Message----- > > From: Aravind Ramesh > > Sent: Thursday, June 17, 2021 12:56 AM > > To: linux-f2fs-devel@lists.sourceforge.net > > Cc: jaegeuk@kernel.org; Aravind Ramesh > > Subject: [f2fs-dev] [PATCH] f2fs-tools: fix metadata region overlap with zoned block > > device zones > > > > For a volume using a zoned block device without conventional zones (e.g. a NVMe > > ZNS drive), a regular block device must be used to store metadata so that in-place > > metadata writes can be executed. The zoned block device cannot contain any > > metadata blocks requiring in-place update (e.g. bitmap blocks). When formatting a > > volume that contains host managed zoned block devices, make sure that the > > conventional device used to store metadata is large enough to avoid write errors. > > > > Signed-off-by: Aravind Ramesh > > --- > > mkfs/f2fs_format.c | 15 +++++++++++++++ > > 1 file changed, 15 insertions(+) > > > > diff --git a/mkfs/f2fs_format.c b/mkfs/f2fs_format.c index 3565bd3..2132852 > > 100644 > > --- a/mkfs/f2fs_format.c > > +++ b/mkfs/f2fs_format.c > > @@ -440,6 +440,21 @@ static int f2fs_prepare_super_block(void) > > main_blkzone); > > return -1; > > } > > + /* > > + * Check if conventional device has enough space > > + * to accommodate all metadata, zoned device should > > + * not overlap to metadata area. > > + */ > > + for (i = 1; i < c.ndevs; i++) { > > + if (c.devices[i].zoned_model == F2FS_ZONED_HM && > > + c.devices[i].start_blkaddr < get_sb(main_blkaddr)) > > { > > + MSG(0, "\tError: Conventional device %s is too > > small," > > + " (%"PRIu64" MiB needed).\n", > > c.devices[0].path, > > + (get_sb(main_blkaddr) - > > + c.devices[i].start_blkaddr) >> 8); > > + return -1; > > + } > > + } > > } > > > > total_zones = get_sb(segment_count) / (c.segs_per_zone) - > > -- > > 2.25.1 _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel