From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5DBBC2B9F4 for ; Tue, 22 Jun 2021 04:46:55 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7B81A61153 for ; Tue, 22 Jun 2021 04:46:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7B81A61153 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 6D87B80EC6; Tue, 22 Jun 2021 06:46:52 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="ONbxB4Pe"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 4AE3080C67; Tue, 22 Jun 2021 06:46:50 +0200 (CEST) Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id AF97680C67 for ; Tue, 22 Jun 2021 06:46:46 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=ilias.apalodimas@linaro.org Received: by mail-wr1-x430.google.com with SMTP id b3so11726599wrm.6 for ; Mon, 21 Jun 2021 21:46:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=h3zd6MACoeNYxxrVlKJrWbqNNRy87E0MvLVQsWzI4hY=; b=ONbxB4PeaOzPmzDYlCPZOLsDm1xfor/nWsqoNoC63/PIQNNn6fK2hoWcUDN0AFhWUj 3j/f+dlFV4JLWTQDBjo58NIGX9CPskUtPCuRgLMfjfZtfenZIKnrXS6rJotbW88NmPvg 0adr/IUTuB/nPVKtZB1pFbKmdmjWAoUTaO9wfB9zGtt5a53D0HznhFdw2kHqFcJ/Mhzy fSdzWHW+5nrTuXLGzVFEDC2gtVWfV28Gt/FHhOxuy8RJBNsqORTH3jDvc6AwWrUwA3vp HQ4PWg0kKxXYrW2xt2JPFga1bQap0XJxwesH06iksvSES/jS06RnEDs9kYlRXFsbTWzD WNPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=h3zd6MACoeNYxxrVlKJrWbqNNRy87E0MvLVQsWzI4hY=; b=SPW6vmCWyfhQvYy2EbOZUIVCSek3zsz0e2GsFE2xSq0VborOdbJQzN4MA/JUvcfvxE 0QsaJ1S0rGhMT+a6ivJ4oL2/FjW/mB6ofPQ0lAHwbffP0I/k5dQM/mC94qJPk3mmB9Ju fYlcZteaIte0LGg8CAqIG+fd+egoH+zIUCaNTV04UryyUwgKWvhfyZ//E5UqeE3K0YNp hX8akgy/9rY5nPS8JjkNn8zVIg8kbE1OtxOeJE7jB1EPQGML2fpEHTZ/ggy8+kx+WYnv iU87A6y/RX5g5pGaTFjLJP6dsbS3JmjZtvVtsi1HvE17kJGHU/AgxW86kxhf+znIsvf0 jRnw== X-Gm-Message-State: AOAM532KljW19jMgXRIwj2lOX5alm4k6CwN8o+a7pk096JBK4k9MyQLo Jg62x8s5syiKapZQWHzEPLw+rRnLHDmwIQ== X-Google-Smtp-Source: ABdhPJydSfDI2J4IyJ5xVTPBXqeZfUV7sPYzyB7SvaSfcxiAtA5CwkVWRGiPAq5NhBO4FY61hkd9ow== X-Received: by 2002:a05:6000:184a:: with SMTP id c10mr2178850wri.232.1624337206358; Mon, 21 Jun 2021 21:46:46 -0700 (PDT) Received: from enceladus (athedsl-419796.home.otenet.gr. [79.131.191.210]) by smtp.gmail.com with ESMTPSA id m5sm1095548wmg.32.2021.06.21.21.46.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Jun 2021 21:46:45 -0700 (PDT) Date: Tue, 22 Jun 2021 07:46:43 +0300 From: Ilias Apalodimas To: Heinrich Schuchardt Cc: masami.hiramatsu@linaro.org, takahiro.akashi@linaro.org, Michal Simek , Alexander Graf , u-boot@lists.denx.de Subject: Re: [PATCH 1/3 v2] efi: Fix to use null handle to create new handle for efi_fmp_raw Message-ID: References: <20210618105115.257938-1-ilias.apalodimas@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean [...] > >v1 is at https://lists.denx.de/pipermail/u-boot/2021-June/452097.html > >changes since v1: > >- split patches > >- pick up Masami's patch fixing the efi_root issue > >- Don't use 'choice' on Kconfig sicne we need both of the FMPs > >installed for sandbox testing > > instead just make them mutually exclusive with 'depends on' > > I can't see ''depends on" in this patch. V1 was a single patch, so I included all the changes in the first patch. I'll split them in v3 Thanks /Ilias > > Best regards > > Heinrich > > > >- Only install the FMPs if CONFIG_EFI_HAVE_CAPSULE_SUPPORT is selected > > lib/efi_loader/efi_capsule.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > >diff --git a/lib/efi_loader/efi_capsule.c > >b/lib/efi_loader/efi_capsule.c > >index 9ead0d2c7816..71d3d1e523ce 100644 > >--- a/lib/efi_loader/efi_capsule.c > >+++ b/lib/efi_loader/efi_capsule.c > >@@ -939,7 +939,7 @@ efi_status_t __weak > >arch_efi_load_capsule_drivers(void) > > if (IS_ENABLED(CONFIG_EFI_CAPSULE_FIRMWARE_RAW)) { > > handle = NULL; > > ret = EFI_CALL(efi_install_multiple_protocol_interfaces( > >- &efi_root, > >+ &handle, > > &efi_guid_firmware_management_protocol, > > &efi_fmp_raw, NULL)); > > } >