From: Aman Jain <ahjain2706@gmail.com> To: alexander.deucher@amd.com, christian.koenig@amd.com, airlied@linux.ie, daniel@ffwll.ch, amd-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH] This patch replaces all the instances of dev_info with drm_info Date: Tue, 22 Jun 2021 12:45:30 +0530 [thread overview] Message-ID: <YNGOEugOA232znQD@reb0rn> (raw) When a driver has multiple instances it is necessary to differentiate between them in the logs. This was done with dev_info/warn/err since DRM_INFO/WARN/ERROR don't do this. We now have drm_info/warn/err for printing the relevant debug messages. Hence, this patch uses drm_* macros to achieve drm-formatted logging Signed-off-by: Aman Jain <ahjain2706@gmail.com> --- drivers/gpu/drm/radeon/radeon_drv.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_drv.c b/drivers/gpu/drm/radeon/radeon_drv.c index efeb115ae70e..639c447d9a1f 100644 --- a/drivers/gpu/drm/radeon/radeon_drv.c +++ b/drivers/gpu/drm/radeon/radeon_drv.c @@ -49,6 +49,7 @@ #include <drm/drm_probe_helper.h> #include <drm/drm_vblank.h> #include <drm/radeon_drm.h> +#include <drm/drm_print.h> #include "radeon_drv.h" #include "radeon.h" @@ -308,7 +309,7 @@ static int radeon_pci_probe(struct pci_dev *pdev, case CHIP_VERDE: case CHIP_OLAND: case CHIP_HAINAN: - dev_info(&pdev->dev, + drm_info(&pdev->dev, "SI support disabled by module param\n"); return -ENODEV; } @@ -320,7 +321,7 @@ static int radeon_pci_probe(struct pci_dev *pdev, case CHIP_HAWAII: case CHIP_KABINI: case CHIP_MULLINS: - dev_info(&pdev->dev, + drm_info(&pdev->dev, "CIK support disabled by module param\n"); return -ENODEV; } -- 2.30.2
WARNING: multiple messages have this Message-ID (diff)
From: Aman Jain <ahjain2706@gmail.com> To: alexander.deucher@amd.com, christian.koenig@amd.com, airlied@linux.ie, daniel@ffwll.ch, amd-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH] This patch replaces all the instances of dev_info with drm_info Date: Tue, 22 Jun 2021 12:45:30 +0530 [thread overview] Message-ID: <YNGOEugOA232znQD@reb0rn> (raw) When a driver has multiple instances it is necessary to differentiate between them in the logs. This was done with dev_info/warn/err since DRM_INFO/WARN/ERROR don't do this. We now have drm_info/warn/err for printing the relevant debug messages. Hence, this patch uses drm_* macros to achieve drm-formatted logging Signed-off-by: Aman Jain <ahjain2706@gmail.com> --- drivers/gpu/drm/radeon/radeon_drv.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_drv.c b/drivers/gpu/drm/radeon/radeon_drv.c index efeb115ae70e..639c447d9a1f 100644 --- a/drivers/gpu/drm/radeon/radeon_drv.c +++ b/drivers/gpu/drm/radeon/radeon_drv.c @@ -49,6 +49,7 @@ #include <drm/drm_probe_helper.h> #include <drm/drm_vblank.h> #include <drm/radeon_drm.h> +#include <drm/drm_print.h> #include "radeon_drv.h" #include "radeon.h" @@ -308,7 +309,7 @@ static int radeon_pci_probe(struct pci_dev *pdev, case CHIP_VERDE: case CHIP_OLAND: case CHIP_HAINAN: - dev_info(&pdev->dev, + drm_info(&pdev->dev, "SI support disabled by module param\n"); return -ENODEV; } @@ -320,7 +321,7 @@ static int radeon_pci_probe(struct pci_dev *pdev, case CHIP_HAWAII: case CHIP_KABINI: case CHIP_MULLINS: - dev_info(&pdev->dev, + drm_info(&pdev->dev, "CIK support disabled by module param\n"); return -ENODEV; } -- 2.30.2 _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next reply other threads:[~2021-06-22 7:15 UTC|newest] Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-06-22 7:15 Aman Jain [this message] 2021-06-22 7:15 ` [PATCH] This patch replaces all the instances of dev_info with drm_info Aman Jain 2021-06-22 18:34 ` kernel test robot 2021-06-22 18:34 ` kernel test robot 2021-06-22 18:34 ` kernel test robot
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YNGOEugOA232znQD@reb0rn \ --to=ahjain2706@gmail.com \ --cc=airlied@linux.ie \ --cc=alexander.deucher@amd.com \ --cc=amd-gfx@lists.freedesktop.org \ --cc=christian.koenig@amd.com \ --cc=daniel@ffwll.ch \ --cc=linux-kernel@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.