From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40D7DC2B9F4 for ; Tue, 22 Jun 2021 13:52:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2B8666128C for ; Tue, 22 Jun 2021 13:52:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231339AbhFVNyY (ORCPT ); Tue, 22 Jun 2021 09:54:24 -0400 Received: from smtp-out2.suse.de ([195.135.220.29]:60564 "EHLO smtp-out2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229786AbhFVNyW (ORCPT ); Tue, 22 Jun 2021 09:54:22 -0400 Received: from imap.suse.de (imap-alt.suse-dmz.suse.de [192.168.254.47]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 93C001FD69; Tue, 22 Jun 2021 13:52:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1624369925; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tyljBHQhfbYGn3IWWrnnSPuwRSN3DRvmx9sRgokz/IE=; b=L9ykUiFUP+Rce7f7tXbToWOgiX0Huac/vD83SRl1CdaG1YBiy8CKnb/074w8ty3LYzy7Td EhMYZT+GxdU9AICvWOJrttMg1KwMwCrgC7gg2WdC7VbNc0QBfsb+YoyMC9QAlFfLIhLMbx cboRwwNHTrjb4ZtUhxhwALXW0S8S1/c= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1624369925; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tyljBHQhfbYGn3IWWrnnSPuwRSN3DRvmx9sRgokz/IE=; b=OpRvooTXy2O6C33U+9RY2ZLL6ao7HWjnFq+uD6WFHDtDWhGW73PZPnNqIRTl+vVjsFzSy+ S1wSEna5oynuFGCg== Received: from imap3-int (imap-alt.suse-dmz.suse.de [192.168.254.47]) by imap.suse.de (Postfix) with ESMTP id 7D9B7118DD; Tue, 22 Jun 2021 13:52:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1624369925; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tyljBHQhfbYGn3IWWrnnSPuwRSN3DRvmx9sRgokz/IE=; b=L9ykUiFUP+Rce7f7tXbToWOgiX0Huac/vD83SRl1CdaG1YBiy8CKnb/074w8ty3LYzy7Td EhMYZT+GxdU9AICvWOJrttMg1KwMwCrgC7gg2WdC7VbNc0QBfsb+YoyMC9QAlFfLIhLMbx cboRwwNHTrjb4ZtUhxhwALXW0S8S1/c= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1624369925; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tyljBHQhfbYGn3IWWrnnSPuwRSN3DRvmx9sRgokz/IE=; b=OpRvooTXy2O6C33U+9RY2ZLL6ao7HWjnFq+uD6WFHDtDWhGW73PZPnNqIRTl+vVjsFzSy+ S1wSEna5oynuFGCg== Received: from director2.suse.de ([192.168.254.72]) by imap3-int with ESMTPSA id FjoWHgXr0WD7RQAALh3uQQ (envelope-from ); Tue, 22 Jun 2021 13:52:05 +0000 Date: Tue, 22 Jun 2021 15:51:53 +0200 From: Borislav Petkov To: Thomas Gleixner Cc: LKML , Andy Lutomirski , Dave Hansen , Fenghua Yu , Tony Luck , Yu-cheng Yu , Sebastian Andrzej Siewior , Peter Zijlstra , Kan Liang Subject: Re: [patch V3 40/66] x86/fpu: Rename and sanitize fpu__save/copy() Message-ID: References: <20210618141823.161158090@linutronix.de> <20210618143448.953929649@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210618143448.953929649@linutronix.de> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 18, 2021 at 04:19:03PM +0200, Thomas Gleixner wrote: > Both functions are misnomed. "Both function names are a misnomer." or simply "Both function are not named optimally." > -int fpu__copy(struct task_struct *dst, struct task_struct *src) > +/* Clone current's FPU state on fork */ > +int fpu_clone(struct task_struct *dst) > { > + struct fpu *src_fpu = ¤t->thread.fpu; > struct fpu *dst_fpu = &dst->thread.fpu; > - struct fpu *src_fpu = &src->thread.fpu; > > + /* The new task's FPU state cannot be valid in the hardware. */ > dst_fpu->last_cpu = -1; > > if (!static_cpu_has(X86_FEATURE_FPU)) cpu_feature_enabled while at it. Regardless, looks nice. Reviewed-by: Borislav Petkov -- Regards/Gruss, Boris. SUSE Software Solutions Germany GmbH, GF: Felix Imendörffer, HRB 36809, AG Nürnberg