From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Justin He <Justin.He@arm.com>
Cc: Petr Mladek <pmladek@suse.com>,
Steven Rostedt <rostedt@goodmis.org>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Jonathan Corbet <corbet@lwn.net>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Linus Torvalds <torvalds@linux-foundation.org>,
"Peter Zijlstra (Intel)" <peterz@infradead.org>,
Eric Biggers <ebiggers@google.com>,
"Ahmed S. Darwish" <a.darwish@linutronix.de>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
Matthew Wilcox <willy@infradead.org>,
Christoph Hellwig <hch@infradead.org>, nd <nd@arm.com>
Subject: Re: [PATCH v5 1/4] fs: introduce helper d_path_unsafe()
Date: Wed, 23 Jun 2021 12:07:11 +0300 [thread overview]
Message-ID: <YNL5v1I9xOfpLPke@smile.fi.intel.com> (raw)
In-Reply-To: <AM6PR08MB43761598697E6DC08A5E71ADF7089@AM6PR08MB4376.eurprd08.prod.outlook.com>
On Wed, Jun 23, 2021 at 02:02:45AM +0000, Justin He wrote:
> > From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > Sent: Tuesday, June 22, 2021 10:37 PM
> > On Tue, Jun 22, 2021 at 10:06:31PM +0800, Jia He wrote:
...
> > > * prepend_name - prepend a pathname in front of current buffer pointer
> > > - * @buffer: buffer pointer
> > > - * @buflen: allocated length of the buffer
> > > + * @p: prepend buffer which contains buffer pointer and allocated length
> >
> > > * @name: name string and length qstr structure
> >
> > Indentation issue btw, can be fixed in the same patch.
>
> Okay
> >
> > > *
> > > * With RCU path tracing, it may race with d_move(). Use READ_ONCE() to
> >
> > Shouldn't this be a separate change with corresponding Fixes tag?
>
> Sorry, I don't quite understand here.
> What do you want to fix?
Kernel doc. The Fixes tag should correspond to the changes that missed the
update of kernel doc.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-06-23 9:07 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-22 14:06 [PATCH v5 0/4] make '%pD' print the full path of file Jia He
2021-06-22 14:06 ` [PATCH v5 1/4] fs: introduce helper d_path_unsafe() Jia He
2021-06-22 14:36 ` Andy Shevchenko
2021-06-23 2:02 ` Justin He
2021-06-23 9:07 ` Andy Shevchenko [this message]
2021-06-24 2:35 ` Justin He
2021-06-24 9:26 ` Petr Mladek
2021-06-24 10:48 ` Andy Shevchenko
2021-06-22 14:06 ` [PATCH v5 2/4] lib/vsprintf.c: make '%pD' print the full path of file Jia He
2021-06-22 14:39 ` Andy Shevchenko
2021-06-23 3:14 ` Justin He
2021-06-24 8:46 ` Petr Mladek
2021-06-24 9:01 ` Justin He
2021-06-22 14:06 ` [PATCH v5 3/4] lib/test_printf.c: split write-beyond-buffer check in two Jia He
2021-06-22 14:06 ` [PATCH v5 4/4] lib/test_printf.c: add test cases for '%pD' Jia He
2021-06-22 14:41 ` Andy Shevchenko
2021-06-22 20:51 ` Rasmus Villemoes
2021-06-23 3:27 ` Justin He
2021-06-22 14:43 ` [PATCH v5 0/4] make '%pD' print the full path of file Andy Shevchenko
2021-06-23 4:13 ` Justin He
2021-06-23 9:12 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YNL5v1I9xOfpLPke@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=Justin.He@arm.com \
--cc=a.darwish@linutronix.de \
--cc=corbet@lwn.net \
--cc=ebiggers@google.com \
--cc=hch@infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=nd@arm.com \
--cc=peterz@infradead.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.