From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D742C48BC2 for ; Wed, 23 Jun 2021 09:17:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1308B601FF for ; Wed, 23 Jun 2021 09:17:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230101AbhFWJTe (ORCPT ); Wed, 23 Jun 2021 05:19:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45080 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229970AbhFWJTc (ORCPT ); Wed, 23 Jun 2021 05:19:32 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B1F73C061574; Wed, 23 Jun 2021 02:17:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=CL8XQmsLz8MJp1hdhyIHxSeG4lqcBDV8J2aWoqxO7kM=; b=oUU0MJd19YgEIwWB21YP+sbRKv fka7CIUJ+qIA/GRKsOA263HiOQMZ+2OA7l0jC/g0UtqzrdzG5geGoIo2tK+QTwwdnU5QlfD/NqDSv v8JcUU0g8tAmj/FOQO47v6ihpxybQnJaokSBJPuPL4oHhLAgHXrl5VkLL+/MiuapGu0wfyTGqUz+u vBFbaYYGXTbHL2MFJwKTZpKXX0s/rKiuWRZnkag893AMHaCW5ZDm4FkZ5Wh4+GXaG/L4nWiD1Y26s IyBM5Uq6OIzSKl1bJrIxnEGxBv+VVhJspYO9UL9Hb0/zC0BsTIKY2YM3YIkQjgtbSEx/niNM9ppAW k+lrBWPA==; Received: from [2001:4bb8:188:3e21:6594:49:139:2b3f] (helo=localhost) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1lvyzE-00FFcA-82; Wed, 23 Jun 2021 09:16:12 +0000 Date: Wed, 23 Jun 2021 11:15:55 +0200 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 24/46] mm/writeback: Add __folio_end_writeback() Message-ID: References: <20210622121551.3398730-1-willy@infradead.org> <20210622121551.3398730-25-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210622121551.3398730-25-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 22, 2021 at 01:15:29PM +0100, Matthew Wilcox (Oracle) wrote: > test_clear_page_writeback() is actually an mm-internal function, although > it's named as if it's a pagecache function. Move it to mm/internal.h, > rename it to __folio_end_writeback() and change the return type to bool. > > The conversion from page to folio is mostly about accounting the number > of pages being written back, although it does eliminate a couple of > calls to compound_head(). While this looks good, I think the whole abstraction is wrong. I think test_clear_page_writeback should just be merged into it's only caller. But if that is somehow not on the table this change looks ok: Reviewed-by: Christoph Hellwig