All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Jisheng Zhang <jszhang3@mail.ustc.edu.cn>
Cc: Alexandre Ghiti <alex@ghiti.fr>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Jisheng Zhang <jszhang@kernel.org>,
	Christoph Hellwig <hch@infradead.org>,
	Zong Li <zong.li@sifive.com>, Anup Patel <anup@brainfault.org>,
	linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 1/2] riscv: Introduce set_kernel_memory helper
Date: Wed, 23 Jun 2021 08:11:53 +0100	[thread overview]
Message-ID: <YNLeuR9j5DE1zcLY@infradead.org> (raw)
In-Reply-To: <20210622225304.53d94c0b@xhacker>

On Tue, Jun 22, 2021 at 10:53:04PM +0800, Jisheng Zhang wrote:
> >  
> > +__always_inline int set_kernel_memory(char *startp, char *endp,
> 
> If __always_inline, can it be moved to set_memory.h?

Yes, __always_inline pretty much only makes sense as
"static __always_inline" anyway.

WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Jisheng Zhang <jszhang3@mail.ustc.edu.cn>
Cc: Alexandre Ghiti <alex@ghiti.fr>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Jisheng Zhang <jszhang@kernel.org>,
	Christoph Hellwig <hch@infradead.org>,
	Zong Li <zong.li@sifive.com>, Anup Patel <anup@brainfault.org>,
	linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 1/2] riscv: Introduce set_kernel_memory helper
Date: Wed, 23 Jun 2021 08:11:53 +0100	[thread overview]
Message-ID: <YNLeuR9j5DE1zcLY@infradead.org> (raw)
In-Reply-To: <20210622225304.53d94c0b@xhacker>

On Tue, Jun 22, 2021 at 10:53:04PM +0800, Jisheng Zhang wrote:
> >  
> > +__always_inline int set_kernel_memory(char *startp, char *endp,
> 
> If __always_inline, can it be moved to set_memory.h?

Yes, __always_inline pretty much only makes sense as
"static __always_inline" anyway.

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

  reply	other threads:[~2021-06-23  7:13 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-22  8:21 [PATCH v7 0/2] Map the kernel with correct permissions the first time Alexandre Ghiti
2021-06-22  8:21 ` Alexandre Ghiti
2021-06-22  8:21 ` [PATCH v7 1/2] riscv: Introduce set_kernel_memory helper Alexandre Ghiti
2021-06-22  8:21   ` Alexandre Ghiti
2021-06-22 14:53   ` Jisheng Zhang
2021-06-22 14:53     ` Jisheng Zhang
2021-06-23  7:11     ` Christoph Hellwig [this message]
2021-06-23  7:11       ` Christoph Hellwig
2021-06-22  8:21 ` [PATCH v7 2/2] riscv: Map the kernel with correct permissions the first time Alexandre Ghiti
2021-06-22  8:21   ` Alexandre Ghiti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YNLeuR9j5DE1zcLY@infradead.org \
    --to=hch@infradead.org \
    --cc=alex@ghiti.fr \
    --cc=anup@brainfault.org \
    --cc=aou@eecs.berkeley.edu \
    --cc=jszhang3@mail.ustc.edu.cn \
    --cc=jszhang@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    --cc=zong.li@sifive.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.