From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9919CC48BE5 for ; Wed, 23 Jun 2021 08:07:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 808F960FD9 for ; Wed, 23 Jun 2021 08:07:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230052AbhFWIKG (ORCPT ); Wed, 23 Jun 2021 04:10:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57486 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229920AbhFWIKF (ORCPT ); Wed, 23 Jun 2021 04:10:05 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 61780C061574; Wed, 23 Jun 2021 01:07:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=s0d8JTUB1/iJ0/Hk5yG5Evr+fy0RTYmyaYwNwEt6dR0=; b=kDaL3XwXuN5IM/j/oV/Xk0NhIg DeWLWiIlQg605bdIVW3YfMVIiicDR4Nbia+LCL0KbRCfNvLxmErN/1tNg8Y1IcF64PHxWKT1WmSQQ sDdVf7z39up166bMwVIrs94pSXxNOn/p3ZhbWPE9Xuq916hTtQF7nsMyM6com7JlJDgwDwLHlyPy/ JcBYrW6ZKUm1xhY3tgCyfom8oXN0y/3mw1N2+FAN0J0Z3s+46YYQinnsDZno3IPv4H/Mw/tGVWLGt IuVMJPv8JQ6ZDpaUfVziSBaM51gXjdO5fpOjPwpp0quHDLa7PgTI8vgz3vak5uCB8v/2w3EsL2NCk Bja8PmRg==; Received: from [2001:4bb8:188:3e21:6594:49:139:2b3f] (helo=localhost) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1lvxua-00FBuJ-94; Wed, 23 Jun 2021 08:07:11 +0000 Date: Wed, 23 Jun 2021 10:07:03 +0200 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 09/46] mm/swap: Add folio_mark_accessed() Message-ID: References: <20210622121551.3398730-1-willy@infradead.org> <20210622121551.3398730-10-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210622121551.3398730-10-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 22, 2021 at 01:15:14PM +0100, Matthew Wilcox (Oracle) wrote: > Convert mark_page_accessed() to folio_mark_accessed(). It already > operated on the entire compound page, but now we can avoid calling > compound_head quite so many times. Shrinks the function from 424 bytes > to 295 bytes (shrinking by 129 bytes). The compatibility wrapper is 30 > bytes, plus the 8 bytes for the exported symbol means the kernel shrinks > by 91 bytes. Looks good, Reviewed-by: Christoph Hellwig