From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60244C49EA4 for ; Wed, 23 Jun 2021 11:40:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4AD4F6102A for ; Wed, 23 Jun 2021 11:40:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230402AbhFWLmn (ORCPT ); Wed, 23 Jun 2021 07:42:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49200 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230071AbhFWLml (ORCPT ); Wed, 23 Jun 2021 07:42:41 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9BFA3C061574; Wed, 23 Jun 2021 04:40:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=jGK9U4DdDhTnapEAkzMQa9BXuVanyBr75qSjp9gCCic=; b=fzHUSdynvSPD/EuKdmu1g+AnhF VxoW00t3XURKSmmS8da4p+dDSBE6jFkDpvbAiFmM1nQkxRa4wpQ31UuM/bFMBP1CJ6+7ypqS2DZWO Gq+yM0QMhQKfJkWktpiL1KfH0riBAgnTONY6KxOIPP5YniYEoasY2jf9FkmBM5pRRO8HIAUcB9XPo qLi0ryv1b0yuiSrXAWLPzBaMFzRTQIHD5iONYp3Zj536v06iQHVMnDPJ4HS75eAHu5O8jP9y5zI3Q xbYaF4ezJIdZVoILgUoSAWSEXNDnlI76b9vGfnjSs09vw1DqSJIP67fiJtNr7Dlhel//7VsWCeszj 4p9/DCGQ==; Received: from [2001:4bb8:188:3e21:6594:49:139:2b3f] (helo=localhost) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1lw1EI-00FN9b-Ae; Wed, 23 Jun 2021 11:39:46 +0000 Date: Wed, 23 Jun 2021 13:39:37 +0200 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 45/46] mm/filemap: Add filemap_get_folio Message-ID: References: <20210622121551.3398730-1-willy@infradead.org> <20210622121551.3398730-46-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210622121551.3398730-46-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > /** > - * pagecache_get_page - Find and get a reference to a page. > + * __filemap_get_folio - Find and get a reference to a folio. Maybe filemap_get_folio_flags is a better name? Otherwise looks good: Reviewed-by: Christoph Hellwig