All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: "Guilherme G. Piccoli" <gpiccoli@canonical.com>
Cc: stable@vger.kernel.org, viro@zeniv.linux.org.uk
Subject: Re: [4.14.y][PATCH 2/2] unfuck sysfs_mount()
Date: Wed, 23 Jun 2021 16:57:51 +0200	[thread overview]
Message-ID: <YNNL7z4IvnFfDOTT@kroah.com> (raw)
In-Reply-To: <20210622210622.9925-2-gpiccoli@canonical.com>

On Tue, Jun 22, 2021 at 06:06:22PM -0300, Guilherme G. Piccoli wrote:
> From: Al Viro <viro@zeniv.linux.org.uk>
> 
> commit 7b745a4e4051e1bbce40e0b1c2cf636c70583aa4 upstream.
> 
> new_sb is left uninitialized in case of early failures in kernfs_mount_ns(),
> and while IS_ERR(root) is true in all such cases, using IS_ERR(root) || !new_sb
> is not a solution - IS_ERR(root) is true in some cases when new_sb is true.
> 
> Make sure new_sb is initialized (and matches the reality) in all cases and
> fix the condition for dropping kobj reference - we want it done precisely
> in those situations where the reference has not been transferred into a new
> super_block instance.
> 
> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
> Signed-off-by: Guilherme G. Piccoli <gpiccoli@canonical.com>
> ---
> 
> I'd like to protest this patch title heheh
> But I think it's better to keep consistency with upstream. It's the same
> case as patch 1 of the series, no clear reason for its absence in stable.
> Build-tested on x86-64 with defconfig.

Both now queued up, thanks.

greg k-h

  reply	other threads:[~2021-06-23 14:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-22 21:06 [4.14.y][PATCH 1/2] kernfs: deal with kernfs_fill_super() failures Guilherme G. Piccoli
2021-06-22 21:06 ` [4.14.y][PATCH 2/2] unfuck sysfs_mount() Guilherme G. Piccoli
2021-06-23 14:57   ` Greg KH [this message]
2021-06-23 15:11     ` Guilherme Piccoli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YNNL7z4IvnFfDOTT@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=gpiccoli@canonical.com \
    --cc=stable@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.