* [PATCH 1/9] i2c: stm32: Simplify with dev_err_probe()
@ 2020-09-02 15:06 ` Krzysztof Kozlowski
0 siblings, 0 replies; 78+ messages in thread
From: Krzysztof Kozlowski @ 2020-09-02 15:06 UTC (permalink / raw)
To: Nicolas Saenz Julienne, Florian Fainelli, Ray Jui, Scott Branden,
bcm-kernel-feedback-list, Michal Simek, Sekhar Nori,
Bartosz Golaszewski, Oleksij Rempel, Pengutronix Kernel Team,
Shawn Guo, Sascha Hauer, Fabio Estevam, NXP Linux Team,
Heiko Stuebner, Pierre-Yves MORDRET, Maxime Coquelin,
Alexandre Torgue, Peter Rosin, Wolfram Sang, linux-i2c,
linux-rpi-kernel, linux-arm-kernel, linux-kernel, linux-rockchip,
linux-stm32
Cc: Krzysztof Kozlowski
Common pattern of handling deferred probe can be simplified with
dev_err_probe(). Less code and the error value gets printed.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
drivers/i2c/busses/i2c-stm32.c | 11 ++++-------
drivers/i2c/busses/i2c-stm32f4.c | 6 ++----
drivers/i2c/busses/i2c-stm32f7.c | 24 +++++++++---------------
3 files changed, 15 insertions(+), 26 deletions(-)
diff --git a/drivers/i2c/busses/i2c-stm32.c b/drivers/i2c/busses/i2c-stm32.c
index 3f69a3bb6119..198f848b7be9 100644
--- a/drivers/i2c/busses/i2c-stm32.c
+++ b/drivers/i2c/busses/i2c-stm32.c
@@ -25,9 +25,8 @@ struct stm32_i2c_dma *stm32_i2c_dma_request(struct device *dev,
/* Request and configure I2C TX dma channel */
dma->chan_tx = dma_request_chan(dev, "tx");
if (IS_ERR(dma->chan_tx)) {
- ret = PTR_ERR(dma->chan_tx);
- if (ret != -EPROBE_DEFER)
- dev_err(dev, "can't request DMA tx channel\n");
+ ret = dev_err_probe(dev, PTR_ERR(dma->chan_tx),
+ "can't request DMA tx channel\n");
goto fail_al;
}
@@ -45,10 +44,8 @@ struct stm32_i2c_dma *stm32_i2c_dma_request(struct device *dev,
/* Request and configure I2C RX dma channel */
dma->chan_rx = dma_request_chan(dev, "rx");
if (IS_ERR(dma->chan_rx)) {
- ret = PTR_ERR(dma->chan_rx);
- if (ret != -EPROBE_DEFER)
- dev_err(dev, "can't request DMA rx channel\n");
-
+ ret = dev_err_probe(dev, PTR_ERR(dma->chan_rx),
+ "can't request DMA rx channel\n");
goto fail_tx;
}
diff --git a/drivers/i2c/busses/i2c-stm32f4.c b/drivers/i2c/busses/i2c-stm32f4.c
index 48e269284369..937c2c8fd349 100644
--- a/drivers/i2c/busses/i2c-stm32f4.c
+++ b/drivers/i2c/busses/i2c-stm32f4.c
@@ -797,10 +797,8 @@ static int stm32f4_i2c_probe(struct platform_device *pdev)
rst = devm_reset_control_get_exclusive(&pdev->dev, NULL);
if (IS_ERR(rst)) {
- ret = PTR_ERR(rst);
- if (ret != -EPROBE_DEFER)
- dev_err(&pdev->dev, "Error: Missing reset ctrl\n");
-
+ ret = dev_err_probe(&pdev->dev, PTR_ERR(rst),
+ "Error: Missing reset ctrl\n");
goto clk_free;
}
reset_control_assert(rst);
diff --git a/drivers/i2c/busses/i2c-stm32f7.c b/drivers/i2c/busses/i2c-stm32f7.c
index bff3479fe122..a8f1758e4c5b 100644
--- a/drivers/i2c/busses/i2c-stm32f7.c
+++ b/drivers/i2c/busses/i2c-stm32f7.c
@@ -1968,11 +1968,9 @@ static int stm32f7_i2c_probe(struct platform_device *pdev)
"wakeup-source");
i2c_dev->clk = devm_clk_get(&pdev->dev, NULL);
- if (IS_ERR(i2c_dev->clk)) {
- if (PTR_ERR(i2c_dev->clk) != -EPROBE_DEFER)
- dev_err(&pdev->dev, "Failed to get controller clock\n");
- return PTR_ERR(i2c_dev->clk);
- }
+ if (IS_ERR(i2c_dev->clk))
+ return dev_err_probe(&pdev->dev, PTR_ERR(i2c_dev->clk),
+ "Failed to get controller clock\n");
ret = clk_prepare_enable(i2c_dev->clk);
if (ret) {
@@ -1982,10 +1980,8 @@ static int stm32f7_i2c_probe(struct platform_device *pdev)
rst = devm_reset_control_get(&pdev->dev, NULL);
if (IS_ERR(rst)) {
- ret = PTR_ERR(rst);
- if (ret != -EPROBE_DEFER)
- dev_err(&pdev->dev, "Error: Missing reset ctrl\n");
-
+ ret = dev_err_probe(&pdev->dev, PTR_ERR(rst),
+ "Error: Missing reset ctrl\n");
goto clk_free;
}
reset_control_assert(rst);
@@ -2052,13 +2048,11 @@ static int stm32f7_i2c_probe(struct platform_device *pdev)
i2c_dev->dma = stm32_i2c_dma_request(i2c_dev->dev, phy_addr,
STM32F7_I2C_TXDR,
STM32F7_I2C_RXDR);
- if (PTR_ERR(i2c_dev->dma) == -ENODEV)
+ if (PTR_ERR(i2c_dev->dma) == -ENODEV) {
i2c_dev->dma = NULL;
- else if (IS_ERR(i2c_dev->dma)) {
- ret = PTR_ERR(i2c_dev->dma);
- if (ret != -EPROBE_DEFER)
- dev_err(&pdev->dev,
- "Failed to request dma error %i\n", ret);
+ } else if (IS_ERR(i2c_dev->dma)) {
+ ret = dev_err_probe(&pdev->dev, PTR_ERR(i2c_dev->dma),
+ "Failed to request dma error\n");
goto fmp_clear;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 78+ messages in thread
* [PATCH 1/9] i2c: stm32: Simplify with dev_err_probe()
@ 2020-09-02 15:06 ` Krzysztof Kozlowski
0 siblings, 0 replies; 78+ messages in thread
From: Krzysztof Kozlowski @ 2020-09-02 15:06 UTC (permalink / raw)
To: Nicolas Saenz Julienne, Florian Fainelli, Ray Jui, Scott Branden,
bcm-kernel-feedback-list, Michal Simek, Sekhar Nori,
Bartosz Golaszewski, Oleksij Rempel, Pengutronix Kernel Team,
Shawn Guo, Sascha Hauer, Fabio Estevam, NXP Linux Team,
Heiko Stuebner, Pierre-Yves MORDRET, Maxime Coquelin,
Alexandre Torgue, Peter Rosin, Wolfram Sang, linux-i2c,
linux-rpi-kernel, linux-arm-kernel, linux-kernel, linux-rockchip,
linux-stm32
Cc: Krzysztof Kozlowski
Common pattern of handling deferred probe can be simplified with
dev_err_probe(). Less code and the error value gets printed.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
drivers/i2c/busses/i2c-stm32.c | 11 ++++-------
drivers/i2c/busses/i2c-stm32f4.c | 6 ++----
drivers/i2c/busses/i2c-stm32f7.c | 24 +++++++++---------------
3 files changed, 15 insertions(+), 26 deletions(-)
diff --git a/drivers/i2c/busses/i2c-stm32.c b/drivers/i2c/busses/i2c-stm32.c
index 3f69a3bb6119..198f848b7be9 100644
--- a/drivers/i2c/busses/i2c-stm32.c
+++ b/drivers/i2c/busses/i2c-stm32.c
@@ -25,9 +25,8 @@ struct stm32_i2c_dma *stm32_i2c_dma_request(struct device *dev,
/* Request and configure I2C TX dma channel */
dma->chan_tx = dma_request_chan(dev, "tx");
if (IS_ERR(dma->chan_tx)) {
- ret = PTR_ERR(dma->chan_tx);
- if (ret != -EPROBE_DEFER)
- dev_err(dev, "can't request DMA tx channel\n");
+ ret = dev_err_probe(dev, PTR_ERR(dma->chan_tx),
+ "can't request DMA tx channel\n");
goto fail_al;
}
@@ -45,10 +44,8 @@ struct stm32_i2c_dma *stm32_i2c_dma_request(struct device *dev,
/* Request and configure I2C RX dma channel */
dma->chan_rx = dma_request_chan(dev, "rx");
if (IS_ERR(dma->chan_rx)) {
- ret = PTR_ERR(dma->chan_rx);
- if (ret != -EPROBE_DEFER)
- dev_err(dev, "can't request DMA rx channel\n");
-
+ ret = dev_err_probe(dev, PTR_ERR(dma->chan_rx),
+ "can't request DMA rx channel\n");
goto fail_tx;
}
diff --git a/drivers/i2c/busses/i2c-stm32f4.c b/drivers/i2c/busses/i2c-stm32f4.c
index 48e269284369..937c2c8fd349 100644
--- a/drivers/i2c/busses/i2c-stm32f4.c
+++ b/drivers/i2c/busses/i2c-stm32f4.c
@@ -797,10 +797,8 @@ static int stm32f4_i2c_probe(struct platform_device *pdev)
rst = devm_reset_control_get_exclusive(&pdev->dev, NULL);
if (IS_ERR(rst)) {
- ret = PTR_ERR(rst);
- if (ret != -EPROBE_DEFER)
- dev_err(&pdev->dev, "Error: Missing reset ctrl\n");
-
+ ret = dev_err_probe(&pdev->dev, PTR_ERR(rst),
+ "Error: Missing reset ctrl\n");
goto clk_free;
}
reset_control_assert(rst);
diff --git a/drivers/i2c/busses/i2c-stm32f7.c b/drivers/i2c/busses/i2c-stm32f7.c
index bff3479fe122..a8f1758e4c5b 100644
--- a/drivers/i2c/busses/i2c-stm32f7.c
+++ b/drivers/i2c/busses/i2c-stm32f7.c
@@ -1968,11 +1968,9 @@ static int stm32f7_i2c_probe(struct platform_device *pdev)
"wakeup-source");
i2c_dev->clk = devm_clk_get(&pdev->dev, NULL);
- if (IS_ERR(i2c_dev->clk)) {
- if (PTR_ERR(i2c_dev->clk) != -EPROBE_DEFER)
- dev_err(&pdev->dev, "Failed to get controller clock\n");
- return PTR_ERR(i2c_dev->clk);
- }
+ if (IS_ERR(i2c_dev->clk))
+ return dev_err_probe(&pdev->dev, PTR_ERR(i2c_dev->clk),
+ "Failed to get controller clock\n");
ret = clk_prepare_enable(i2c_dev->clk);
if (ret) {
@@ -1982,10 +1980,8 @@ static int stm32f7_i2c_probe(struct platform_device *pdev)
rst = devm_reset_control_get(&pdev->dev, NULL);
if (IS_ERR(rst)) {
- ret = PTR_ERR(rst);
- if (ret != -EPROBE_DEFER)
- dev_err(&pdev->dev, "Error: Missing reset ctrl\n");
-
+ ret = dev_err_probe(&pdev->dev, PTR_ERR(rst),
+ "Error: Missing reset ctrl\n");
goto clk_free;
}
reset_control_assert(rst);
@@ -2052,13 +2048,11 @@ static int stm32f7_i2c_probe(struct platform_device *pdev)
i2c_dev->dma = stm32_i2c_dma_request(i2c_dev->dev, phy_addr,
STM32F7_I2C_TXDR,
STM32F7_I2C_RXDR);
- if (PTR_ERR(i2c_dev->dma) == -ENODEV)
+ if (PTR_ERR(i2c_dev->dma) == -ENODEV) {
i2c_dev->dma = NULL;
- else if (IS_ERR(i2c_dev->dma)) {
- ret = PTR_ERR(i2c_dev->dma);
- if (ret != -EPROBE_DEFER)
- dev_err(&pdev->dev,
- "Failed to request dma error %i\n", ret);
+ } else if (IS_ERR(i2c_dev->dma)) {
+ ret = dev_err_probe(&pdev->dev, PTR_ERR(i2c_dev->dma),
+ "Failed to request dma error\n");
goto fmp_clear;
}
--
2.17.1
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply related [flat|nested] 78+ messages in thread
* [PATCH 1/9] i2c: stm32: Simplify with dev_err_probe()
@ 2020-09-02 15:06 ` Krzysztof Kozlowski
0 siblings, 0 replies; 78+ messages in thread
From: Krzysztof Kozlowski @ 2020-09-02 15:06 UTC (permalink / raw)
To: Nicolas Saenz Julienne, Florian Fainelli, Ray Jui, Scott Branden,
bcm-kernel-feedback-list, Michal Simek, Sekhar Nori,
Bartosz Golaszewski, Oleksij Rempel, Pengutronix Kernel Team,
Shawn Guo, Sascha Hauer, Fabio Estevam, NXP Linux Team,
Heiko Stuebner, Pierre-Yves MORDRET, Maxime Coquelin,
Alexandre Torgue, Peter Rosin, Wolfram Sang, linux-i2c,
linux-rpi-kernel, linux-arm-kernel, linux-kernel, linux-rockchip,
linux-stm32
Cc: Krzysztof Kozlowski
Common pattern of handling deferred probe can be simplified with
dev_err_probe(). Less code and the error value gets printed.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
drivers/i2c/busses/i2c-stm32.c | 11 ++++-------
drivers/i2c/busses/i2c-stm32f4.c | 6 ++----
drivers/i2c/busses/i2c-stm32f7.c | 24 +++++++++---------------
3 files changed, 15 insertions(+), 26 deletions(-)
diff --git a/drivers/i2c/busses/i2c-stm32.c b/drivers/i2c/busses/i2c-stm32.c
index 3f69a3bb6119..198f848b7be9 100644
--- a/drivers/i2c/busses/i2c-stm32.c
+++ b/drivers/i2c/busses/i2c-stm32.c
@@ -25,9 +25,8 @@ struct stm32_i2c_dma *stm32_i2c_dma_request(struct device *dev,
/* Request and configure I2C TX dma channel */
dma->chan_tx = dma_request_chan(dev, "tx");
if (IS_ERR(dma->chan_tx)) {
- ret = PTR_ERR(dma->chan_tx);
- if (ret != -EPROBE_DEFER)
- dev_err(dev, "can't request DMA tx channel\n");
+ ret = dev_err_probe(dev, PTR_ERR(dma->chan_tx),
+ "can't request DMA tx channel\n");
goto fail_al;
}
@@ -45,10 +44,8 @@ struct stm32_i2c_dma *stm32_i2c_dma_request(struct device *dev,
/* Request and configure I2C RX dma channel */
dma->chan_rx = dma_request_chan(dev, "rx");
if (IS_ERR(dma->chan_rx)) {
- ret = PTR_ERR(dma->chan_rx);
- if (ret != -EPROBE_DEFER)
- dev_err(dev, "can't request DMA rx channel\n");
-
+ ret = dev_err_probe(dev, PTR_ERR(dma->chan_rx),
+ "can't request DMA rx channel\n");
goto fail_tx;
}
diff --git a/drivers/i2c/busses/i2c-stm32f4.c b/drivers/i2c/busses/i2c-stm32f4.c
index 48e269284369..937c2c8fd349 100644
--- a/drivers/i2c/busses/i2c-stm32f4.c
+++ b/drivers/i2c/busses/i2c-stm32f4.c
@@ -797,10 +797,8 @@ static int stm32f4_i2c_probe(struct platform_device *pdev)
rst = devm_reset_control_get_exclusive(&pdev->dev, NULL);
if (IS_ERR(rst)) {
- ret = PTR_ERR(rst);
- if (ret != -EPROBE_DEFER)
- dev_err(&pdev->dev, "Error: Missing reset ctrl\n");
-
+ ret = dev_err_probe(&pdev->dev, PTR_ERR(rst),
+ "Error: Missing reset ctrl\n");
goto clk_free;
}
reset_control_assert(rst);
diff --git a/drivers/i2c/busses/i2c-stm32f7.c b/drivers/i2c/busses/i2c-stm32f7.c
index bff3479fe122..a8f1758e4c5b 100644
--- a/drivers/i2c/busses/i2c-stm32f7.c
+++ b/drivers/i2c/busses/i2c-stm32f7.c
@@ -1968,11 +1968,9 @@ static int stm32f7_i2c_probe(struct platform_device *pdev)
"wakeup-source");
i2c_dev->clk = devm_clk_get(&pdev->dev, NULL);
- if (IS_ERR(i2c_dev->clk)) {
- if (PTR_ERR(i2c_dev->clk) != -EPROBE_DEFER)
- dev_err(&pdev->dev, "Failed to get controller clock\n");
- return PTR_ERR(i2c_dev->clk);
- }
+ if (IS_ERR(i2c_dev->clk))
+ return dev_err_probe(&pdev->dev, PTR_ERR(i2c_dev->clk),
+ "Failed to get controller clock\n");
ret = clk_prepare_enable(i2c_dev->clk);
if (ret) {
@@ -1982,10 +1980,8 @@ static int stm32f7_i2c_probe(struct platform_device *pdev)
rst = devm_reset_control_get(&pdev->dev, NULL);
if (IS_ERR(rst)) {
- ret = PTR_ERR(rst);
- if (ret != -EPROBE_DEFER)
- dev_err(&pdev->dev, "Error: Missing reset ctrl\n");
-
+ ret = dev_err_probe(&pdev->dev, PTR_ERR(rst),
+ "Error: Missing reset ctrl\n");
goto clk_free;
}
reset_control_assert(rst);
@@ -2052,13 +2048,11 @@ static int stm32f7_i2c_probe(struct platform_device *pdev)
i2c_dev->dma = stm32_i2c_dma_request(i2c_dev->dev, phy_addr,
STM32F7_I2C_TXDR,
STM32F7_I2C_RXDR);
- if (PTR_ERR(i2c_dev->dma) == -ENODEV)
+ if (PTR_ERR(i2c_dev->dma) == -ENODEV) {
i2c_dev->dma = NULL;
- else if (IS_ERR(i2c_dev->dma)) {
- ret = PTR_ERR(i2c_dev->dma);
- if (ret != -EPROBE_DEFER)
- dev_err(&pdev->dev,
- "Failed to request dma error %i\n", ret);
+ } else if (IS_ERR(i2c_dev->dma)) {
+ ret = dev_err_probe(&pdev->dev, PTR_ERR(i2c_dev->dma),
+ "Failed to request dma error\n");
goto fmp_clear;
}
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 78+ messages in thread
* [PATCH 2/9] i2c: xiic: Simplify with dev_err_probe()
2020-09-02 15:06 ` Krzysztof Kozlowski
(?)
@ 2020-09-02 15:06 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 78+ messages in thread
From: Krzysztof Kozlowski @ 2020-09-02 15:06 UTC (permalink / raw)
To: Nicolas Saenz Julienne, Florian Fainelli, Ray Jui, Scott Branden,
bcm-kernel-feedback-list, Michal Simek, Sekhar Nori,
Bartosz Golaszewski, Oleksij Rempel, Pengutronix Kernel Team,
Shawn Guo, Sascha Hauer, Fabio Estevam, NXP Linux Team,
Heiko Stuebner, Pierre-Yves MORDRET, Maxime Coquelin,
Alexandre Torgue, Peter Rosin, Wolfram Sang, linux-i2c,
linux-rpi-kernel, linux-arm-kernel, linux-kernel, linux-rockchip,
linux-stm32
Cc: Krzysztof Kozlowski
Common pattern of handling deferred probe can be simplified with
dev_err_probe(). Less code and the error value gets printed.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
drivers/i2c/busses/i2c-xiic.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/i2c/busses/i2c-xiic.c b/drivers/i2c/busses/i2c-xiic.c
index 90c1c362394d..a97438f35c5d 100644
--- a/drivers/i2c/busses/i2c-xiic.c
+++ b/drivers/i2c/busses/i2c-xiic.c
@@ -787,11 +787,10 @@ static int xiic_i2c_probe(struct platform_device *pdev)
init_waitqueue_head(&i2c->wait);
i2c->clk = devm_clk_get(&pdev->dev, NULL);
- if (IS_ERR(i2c->clk)) {
- if (PTR_ERR(i2c->clk) != -EPROBE_DEFER)
- dev_err(&pdev->dev, "input clock not found.\n");
- return PTR_ERR(i2c->clk);
- }
+ if (IS_ERR(i2c->clk))
+ return dev_err_probe(&pdev->dev, PTR_ERR(i2c->clk),
+ "input clock not found.\n");
+
ret = clk_prepare_enable(i2c->clk);
if (ret) {
dev_err(&pdev->dev, "Unable to enable clock.\n");
--
2.17.1
^ permalink raw reply related [flat|nested] 78+ messages in thread
* [PATCH 2/9] i2c: xiic: Simplify with dev_err_probe()
@ 2020-09-02 15:06 ` Krzysztof Kozlowski
0 siblings, 0 replies; 78+ messages in thread
From: Krzysztof Kozlowski @ 2020-09-02 15:06 UTC (permalink / raw)
To: Nicolas Saenz Julienne, Florian Fainelli, Ray Jui, Scott Branden,
bcm-kernel-feedback-list, Michal Simek, Sekhar Nori,
Bartosz Golaszewski, Oleksij Rempel, Pengutronix Kernel Team,
Shawn Guo, Sascha Hauer, Fabio Estevam, NXP Linux Team,
Heiko Stuebner, Pierre-Yves MORDRET, Maxime Coquelin,
Alexandre Torgue, Peter Rosin, Wolfram Sang, linux-i2c,
linux-rpi-kernel, linux-arm-kernel, linux-kernel, linux-rockchip,
linux-stm32
Cc: Krzysztof Kozlowski
Common pattern of handling deferred probe can be simplified with
dev_err_probe(). Less code and the error value gets printed.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
drivers/i2c/busses/i2c-xiic.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/i2c/busses/i2c-xiic.c b/drivers/i2c/busses/i2c-xiic.c
index 90c1c362394d..a97438f35c5d 100644
--- a/drivers/i2c/busses/i2c-xiic.c
+++ b/drivers/i2c/busses/i2c-xiic.c
@@ -787,11 +787,10 @@ static int xiic_i2c_probe(struct platform_device *pdev)
init_waitqueue_head(&i2c->wait);
i2c->clk = devm_clk_get(&pdev->dev, NULL);
- if (IS_ERR(i2c->clk)) {
- if (PTR_ERR(i2c->clk) != -EPROBE_DEFER)
- dev_err(&pdev->dev, "input clock not found.\n");
- return PTR_ERR(i2c->clk);
- }
+ if (IS_ERR(i2c->clk))
+ return dev_err_probe(&pdev->dev, PTR_ERR(i2c->clk),
+ "input clock not found.\n");
+
ret = clk_prepare_enable(i2c->clk);
if (ret) {
dev_err(&pdev->dev, "Unable to enable clock.\n");
--
2.17.1
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply related [flat|nested] 78+ messages in thread
* [PATCH 2/9] i2c: xiic: Simplify with dev_err_probe()
@ 2020-09-02 15:06 ` Krzysztof Kozlowski
0 siblings, 0 replies; 78+ messages in thread
From: Krzysztof Kozlowski @ 2020-09-02 15:06 UTC (permalink / raw)
To: Nicolas Saenz Julienne, Florian Fainelli, Ray Jui, Scott Branden,
bcm-kernel-feedback-list, Michal Simek, Sekhar Nori,
Bartosz Golaszewski, Oleksij Rempel, Pengutronix Kernel Team,
Shawn Guo, Sascha Hauer, Fabio Estevam, NXP Linux Team,
Heiko Stuebner, Pierre-Yves MORDRET, Maxime Coquelin,
Alexandre Torgue, Peter Rosin, Wolfram Sang, linux-i2c,
linux-rpi-kernel, linux-arm-kernel, linux-kernel, linux-rockchip,
linux-stm32
Cc: Krzysztof Kozlowski
Common pattern of handling deferred probe can be simplified with
dev_err_probe(). Less code and the error value gets printed.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
drivers/i2c/busses/i2c-xiic.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/i2c/busses/i2c-xiic.c b/drivers/i2c/busses/i2c-xiic.c
index 90c1c362394d..a97438f35c5d 100644
--- a/drivers/i2c/busses/i2c-xiic.c
+++ b/drivers/i2c/busses/i2c-xiic.c
@@ -787,11 +787,10 @@ static int xiic_i2c_probe(struct platform_device *pdev)
init_waitqueue_head(&i2c->wait);
i2c->clk = devm_clk_get(&pdev->dev, NULL);
- if (IS_ERR(i2c->clk)) {
- if (PTR_ERR(i2c->clk) != -EPROBE_DEFER)
- dev_err(&pdev->dev, "input clock not found.\n");
- return PTR_ERR(i2c->clk);
- }
+ if (IS_ERR(i2c->clk))
+ return dev_err_probe(&pdev->dev, PTR_ERR(i2c->clk),
+ "input clock not found.\n");
+
ret = clk_prepare_enable(i2c->clk);
if (ret) {
dev_err(&pdev->dev, "Unable to enable clock.\n");
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 78+ messages in thread
* [PATCH 3/9] i2c: bcm2835: Simplify with dev_err_probe()
2020-09-02 15:06 ` Krzysztof Kozlowski
(?)
@ 2020-09-02 15:06 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 78+ messages in thread
From: Krzysztof Kozlowski @ 2020-09-02 15:06 UTC (permalink / raw)
To: Nicolas Saenz Julienne, Florian Fainelli, Ray Jui, Scott Branden,
bcm-kernel-feedback-list, Michal Simek, Sekhar Nori,
Bartosz Golaszewski, Oleksij Rempel, Pengutronix Kernel Team,
Shawn Guo, Sascha Hauer, Fabio Estevam, NXP Linux Team,
Heiko Stuebner, Pierre-Yves MORDRET, Maxime Coquelin,
Alexandre Torgue, Peter Rosin, Wolfram Sang, linux-i2c,
linux-rpi-kernel, linux-arm-kernel, linux-kernel, linux-rockchip,
linux-stm32
Cc: Krzysztof Kozlowski
Common pattern of handling deferred probe can be simplified with
dev_err_probe(). Less code and the error value gets printed.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
drivers/i2c/busses/i2c-bcm2835.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/i2c/busses/i2c-bcm2835.c b/drivers/i2c/busses/i2c-bcm2835.c
index 5dc519516292..37443edbf754 100644
--- a/drivers/i2c/busses/i2c-bcm2835.c
+++ b/drivers/i2c/busses/i2c-bcm2835.c
@@ -421,11 +421,9 @@ static int bcm2835_i2c_probe(struct platform_device *pdev)
return PTR_ERR(i2c_dev->regs);
mclk = devm_clk_get(&pdev->dev, NULL);
- if (IS_ERR(mclk)) {
- if (PTR_ERR(mclk) != -EPROBE_DEFER)
- dev_err(&pdev->dev, "Could not get clock\n");
- return PTR_ERR(mclk);
- }
+ if (IS_ERR(mclk))
+ return dev_err_probe(&pdev->dev, PTR_ERR(mclk),
+ "Could not get clock\n");
i2c_dev->bus_clk = bcm2835_i2c_register_div(&pdev->dev, mclk, i2c_dev);
--
2.17.1
^ permalink raw reply related [flat|nested] 78+ messages in thread
* [PATCH 3/9] i2c: bcm2835: Simplify with dev_err_probe()
@ 2020-09-02 15:06 ` Krzysztof Kozlowski
0 siblings, 0 replies; 78+ messages in thread
From: Krzysztof Kozlowski @ 2020-09-02 15:06 UTC (permalink / raw)
To: Nicolas Saenz Julienne, Florian Fainelli, Ray Jui, Scott Branden,
bcm-kernel-feedback-list, Michal Simek, Sekhar Nori,
Bartosz Golaszewski, Oleksij Rempel, Pengutronix Kernel Team,
Shawn Guo, Sascha Hauer, Fabio Estevam, NXP Linux Team,
Heiko Stuebner, Pierre-Yves MORDRET, Maxime Coquelin,
Alexandre Torgue, Peter Rosin, Wolfram Sang, linux-i2c,
linux-rpi-kernel, linux-arm-kernel, linux-kernel, linux-rockchip,
linux-stm32
Cc: Krzysztof Kozlowski
Common pattern of handling deferred probe can be simplified with
dev_err_probe(). Less code and the error value gets printed.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
drivers/i2c/busses/i2c-bcm2835.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/i2c/busses/i2c-bcm2835.c b/drivers/i2c/busses/i2c-bcm2835.c
index 5dc519516292..37443edbf754 100644
--- a/drivers/i2c/busses/i2c-bcm2835.c
+++ b/drivers/i2c/busses/i2c-bcm2835.c
@@ -421,11 +421,9 @@ static int bcm2835_i2c_probe(struct platform_device *pdev)
return PTR_ERR(i2c_dev->regs);
mclk = devm_clk_get(&pdev->dev, NULL);
- if (IS_ERR(mclk)) {
- if (PTR_ERR(mclk) != -EPROBE_DEFER)
- dev_err(&pdev->dev, "Could not get clock\n");
- return PTR_ERR(mclk);
- }
+ if (IS_ERR(mclk))
+ return dev_err_probe(&pdev->dev, PTR_ERR(mclk),
+ "Could not get clock\n");
i2c_dev->bus_clk = bcm2835_i2c_register_div(&pdev->dev, mclk, i2c_dev);
--
2.17.1
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply related [flat|nested] 78+ messages in thread
* [PATCH 3/9] i2c: bcm2835: Simplify with dev_err_probe()
@ 2020-09-02 15:06 ` Krzysztof Kozlowski
0 siblings, 0 replies; 78+ messages in thread
From: Krzysztof Kozlowski @ 2020-09-02 15:06 UTC (permalink / raw)
To: Nicolas Saenz Julienne, Florian Fainelli, Ray Jui, Scott Branden,
bcm-kernel-feedback-list, Michal Simek, Sekhar Nori,
Bartosz Golaszewski, Oleksij Rempel, Pengutronix Kernel Team,
Shawn Guo, Sascha Hauer, Fabio Estevam, NXP Linux Team,
Heiko Stuebner, Pierre-Yves MORDRET, Maxime Coquelin,
Alexandre Torgue, Peter Rosin, Wolfram Sang, linux-i2c,
linux-rpi-kernel, linux-arm-kernel, linux-kernel, linux-rockchip,
linux-stm32
Cc: Krzysztof Kozlowski
Common pattern of handling deferred probe can be simplified with
dev_err_probe(). Less code and the error value gets printed.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
drivers/i2c/busses/i2c-bcm2835.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/i2c/busses/i2c-bcm2835.c b/drivers/i2c/busses/i2c-bcm2835.c
index 5dc519516292..37443edbf754 100644
--- a/drivers/i2c/busses/i2c-bcm2835.c
+++ b/drivers/i2c/busses/i2c-bcm2835.c
@@ -421,11 +421,9 @@ static int bcm2835_i2c_probe(struct platform_device *pdev)
return PTR_ERR(i2c_dev->regs);
mclk = devm_clk_get(&pdev->dev, NULL);
- if (IS_ERR(mclk)) {
- if (PTR_ERR(mclk) != -EPROBE_DEFER)
- dev_err(&pdev->dev, "Could not get clock\n");
- return PTR_ERR(mclk);
- }
+ if (IS_ERR(mclk))
+ return dev_err_probe(&pdev->dev, PTR_ERR(mclk),
+ "Could not get clock\n");
i2c_dev->bus_clk = bcm2835_i2c_register_div(&pdev->dev, mclk, i2c_dev);
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 78+ messages in thread
* [PATCH 4/9] i2c: cadence: Simplify with dev_err_probe()
2020-09-02 15:06 ` Krzysztof Kozlowski
(?)
@ 2020-09-02 15:06 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 78+ messages in thread
From: Krzysztof Kozlowski @ 2020-09-02 15:06 UTC (permalink / raw)
To: Nicolas Saenz Julienne, Florian Fainelli, Ray Jui, Scott Branden,
bcm-kernel-feedback-list, Michal Simek, Sekhar Nori,
Bartosz Golaszewski, Oleksij Rempel, Pengutronix Kernel Team,
Shawn Guo, Sascha Hauer, Fabio Estevam, NXP Linux Team,
Heiko Stuebner, Pierre-Yves MORDRET, Maxime Coquelin,
Alexandre Torgue, Peter Rosin, Wolfram Sang, linux-i2c,
linux-rpi-kernel, linux-arm-kernel, linux-kernel, linux-rockchip,
linux-stm32
Cc: Krzysztof Kozlowski
Common pattern of handling deferred probe can be simplified with
dev_err_probe(). Less code and the error value gets printed.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
drivers/i2c/busses/i2c-cadence.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/i2c/busses/i2c-cadence.c b/drivers/i2c/busses/i2c-cadence.c
index e4b7f2a951ad..eefde554c50c 100644
--- a/drivers/i2c/busses/i2c-cadence.c
+++ b/drivers/i2c/busses/i2c-cadence.c
@@ -1214,11 +1214,10 @@ static int cdns_i2c_probe(struct platform_device *pdev)
"Cadence I2C at %08lx", (unsigned long)r_mem->start);
id->clk = devm_clk_get(&pdev->dev, NULL);
- if (IS_ERR(id->clk)) {
- if (PTR_ERR(id->clk) != -EPROBE_DEFER)
- dev_err(&pdev->dev, "input clock not found.\n");
- return PTR_ERR(id->clk);
- }
+ if (IS_ERR(id->clk))
+ return dev_err_probe(&pdev->dev, PTR_ERR(id->clk),
+ "input clock not found.\n");
+
ret = clk_prepare_enable(id->clk);
if (ret)
dev_err(&pdev->dev, "Unable to enable clock.\n");
--
2.17.1
^ permalink raw reply related [flat|nested] 78+ messages in thread
* [PATCH 4/9] i2c: cadence: Simplify with dev_err_probe()
@ 2020-09-02 15:06 ` Krzysztof Kozlowski
0 siblings, 0 replies; 78+ messages in thread
From: Krzysztof Kozlowski @ 2020-09-02 15:06 UTC (permalink / raw)
To: Nicolas Saenz Julienne, Florian Fainelli, Ray Jui, Scott Branden,
bcm-kernel-feedback-list, Michal Simek, Sekhar Nori,
Bartosz Golaszewski, Oleksij Rempel, Pengutronix Kernel Team,
Shawn Guo, Sascha Hauer, Fabio Estevam, NXP Linux Team,
Heiko Stuebner, Pierre-Yves MORDRET, Maxime Coquelin,
Alexandre Torgue, Peter Rosin, Wolfram Sang, linux-i2c,
linux-rpi-kernel, linux-arm-kernel, linux-kernel, linux-rockchip,
linux-stm32
Cc: Krzysztof Kozlowski
Common pattern of handling deferred probe can be simplified with
dev_err_probe(). Less code and the error value gets printed.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
drivers/i2c/busses/i2c-cadence.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/i2c/busses/i2c-cadence.c b/drivers/i2c/busses/i2c-cadence.c
index e4b7f2a951ad..eefde554c50c 100644
--- a/drivers/i2c/busses/i2c-cadence.c
+++ b/drivers/i2c/busses/i2c-cadence.c
@@ -1214,11 +1214,10 @@ static int cdns_i2c_probe(struct platform_device *pdev)
"Cadence I2C at %08lx", (unsigned long)r_mem->start);
id->clk = devm_clk_get(&pdev->dev, NULL);
- if (IS_ERR(id->clk)) {
- if (PTR_ERR(id->clk) != -EPROBE_DEFER)
- dev_err(&pdev->dev, "input clock not found.\n");
- return PTR_ERR(id->clk);
- }
+ if (IS_ERR(id->clk))
+ return dev_err_probe(&pdev->dev, PTR_ERR(id->clk),
+ "input clock not found.\n");
+
ret = clk_prepare_enable(id->clk);
if (ret)
dev_err(&pdev->dev, "Unable to enable clock.\n");
--
2.17.1
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply related [flat|nested] 78+ messages in thread
* [PATCH 4/9] i2c: cadence: Simplify with dev_err_probe()
@ 2020-09-02 15:06 ` Krzysztof Kozlowski
0 siblings, 0 replies; 78+ messages in thread
From: Krzysztof Kozlowski @ 2020-09-02 15:06 UTC (permalink / raw)
To: Nicolas Saenz Julienne, Florian Fainelli, Ray Jui, Scott Branden,
bcm-kernel-feedback-list, Michal Simek, Sekhar Nori,
Bartosz Golaszewski, Oleksij Rempel, Pengutronix Kernel Team,
Shawn Guo, Sascha Hauer, Fabio Estevam, NXP Linux Team,
Heiko Stuebner, Pierre-Yves MORDRET, Maxime Coquelin,
Alexandre Torgue, Peter Rosin, Wolfram Sang, linux-i2c,
linux-rpi-kernel, linux-arm-kernel, linux-kernel, linux-rockchip,
linux-stm32
Cc: Krzysztof Kozlowski
Common pattern of handling deferred probe can be simplified with
dev_err_probe(). Less code and the error value gets printed.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
drivers/i2c/busses/i2c-cadence.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/i2c/busses/i2c-cadence.c b/drivers/i2c/busses/i2c-cadence.c
index e4b7f2a951ad..eefde554c50c 100644
--- a/drivers/i2c/busses/i2c-cadence.c
+++ b/drivers/i2c/busses/i2c-cadence.c
@@ -1214,11 +1214,10 @@ static int cdns_i2c_probe(struct platform_device *pdev)
"Cadence I2C at %08lx", (unsigned long)r_mem->start);
id->clk = devm_clk_get(&pdev->dev, NULL);
- if (IS_ERR(id->clk)) {
- if (PTR_ERR(id->clk) != -EPROBE_DEFER)
- dev_err(&pdev->dev, "input clock not found.\n");
- return PTR_ERR(id->clk);
- }
+ if (IS_ERR(id->clk))
+ return dev_err_probe(&pdev->dev, PTR_ERR(id->clk),
+ "input clock not found.\n");
+
ret = clk_prepare_enable(id->clk);
if (ret)
dev_err(&pdev->dev, "Unable to enable clock.\n");
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 78+ messages in thread
* [PATCH 5/9] i2c: davinci: Simplify with dev_err_probe()
2020-09-02 15:06 ` Krzysztof Kozlowski
(?)
@ 2020-09-02 15:06 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 78+ messages in thread
From: Krzysztof Kozlowski @ 2020-09-02 15:06 UTC (permalink / raw)
To: Nicolas Saenz Julienne, Florian Fainelli, Ray Jui, Scott Branden,
bcm-kernel-feedback-list, Michal Simek, Sekhar Nori,
Bartosz Golaszewski, Oleksij Rempel, Pengutronix Kernel Team,
Shawn Guo, Sascha Hauer, Fabio Estevam, NXP Linux Team,
Heiko Stuebner, Pierre-Yves MORDRET, Maxime Coquelin,
Alexandre Torgue, Peter Rosin, Wolfram Sang, linux-i2c,
linux-rpi-kernel, linux-arm-kernel, linux-kernel, linux-rockchip,
linux-stm32
Cc: Krzysztof Kozlowski
Common pattern of handling deferred probe can be simplified with
dev_err_probe(). Less code and the error value gets printed.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
drivers/i2c/busses/i2c-davinci.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/i2c/busses/i2c-davinci.c b/drivers/i2c/busses/i2c-davinci.c
index 232a7679b69b..e9d07323c604 100644
--- a/drivers/i2c/busses/i2c-davinci.c
+++ b/drivers/i2c/busses/i2c-davinci.c
@@ -768,10 +768,7 @@ static int davinci_i2c_probe(struct platform_device *pdev)
if (irq <= 0) {
if (!irq)
irq = -ENXIO;
- if (irq != -EPROBE_DEFER)
- dev_err(&pdev->dev,
- "can't get irq resource ret=%d\n", irq);
- return irq;
+ return dev_err_probe(&pdev->dev, irq, "can't get irq resource\n");
}
dev = devm_kzalloc(&pdev->dev, sizeof(struct davinci_i2c_dev),
--
2.17.1
^ permalink raw reply related [flat|nested] 78+ messages in thread
* [PATCH 5/9] i2c: davinci: Simplify with dev_err_probe()
@ 2020-09-02 15:06 ` Krzysztof Kozlowski
0 siblings, 0 replies; 78+ messages in thread
From: Krzysztof Kozlowski @ 2020-09-02 15:06 UTC (permalink / raw)
To: Nicolas Saenz Julienne, Florian Fainelli, Ray Jui, Scott Branden,
bcm-kernel-feedback-list, Michal Simek, Sekhar Nori,
Bartosz Golaszewski, Oleksij Rempel, Pengutronix Kernel Team,
Shawn Guo, Sascha Hauer, Fabio Estevam, NXP Linux Team,
Heiko Stuebner, Pierre-Yves MORDRET, Maxime Coquelin,
Alexandre Torgue, Peter Rosin, Wolfram Sang, linux-i2c,
linux-rpi-kernel, linux-arm-kernel, linux-kernel, linux-rockchip,
linux-stm32
Cc: Krzysztof Kozlowski
Common pattern of handling deferred probe can be simplified with
dev_err_probe(). Less code and the error value gets printed.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
drivers/i2c/busses/i2c-davinci.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/i2c/busses/i2c-davinci.c b/drivers/i2c/busses/i2c-davinci.c
index 232a7679b69b..e9d07323c604 100644
--- a/drivers/i2c/busses/i2c-davinci.c
+++ b/drivers/i2c/busses/i2c-davinci.c
@@ -768,10 +768,7 @@ static int davinci_i2c_probe(struct platform_device *pdev)
if (irq <= 0) {
if (!irq)
irq = -ENXIO;
- if (irq != -EPROBE_DEFER)
- dev_err(&pdev->dev,
- "can't get irq resource ret=%d\n", irq);
- return irq;
+ return dev_err_probe(&pdev->dev, irq, "can't get irq resource\n");
}
dev = devm_kzalloc(&pdev->dev, sizeof(struct davinci_i2c_dev),
--
2.17.1
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply related [flat|nested] 78+ messages in thread
* [PATCH 5/9] i2c: davinci: Simplify with dev_err_probe()
@ 2020-09-02 15:06 ` Krzysztof Kozlowski
0 siblings, 0 replies; 78+ messages in thread
From: Krzysztof Kozlowski @ 2020-09-02 15:06 UTC (permalink / raw)
To: Nicolas Saenz Julienne, Florian Fainelli, Ray Jui, Scott Branden,
bcm-kernel-feedback-list, Michal Simek, Sekhar Nori,
Bartosz Golaszewski, Oleksij Rempel, Pengutronix Kernel Team,
Shawn Guo, Sascha Hauer, Fabio Estevam, NXP Linux Team,
Heiko Stuebner, Pierre-Yves MORDRET, Maxime Coquelin,
Alexandre Torgue, Peter Rosin, Wolfram Sang, linux-i2c,
linux-rpi-kernel, linux-arm-kernel, linux-kernel, linux-rockchip,
linux-stm32
Cc: Krzysztof Kozlowski
Common pattern of handling deferred probe can be simplified with
dev_err_probe(). Less code and the error value gets printed.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
drivers/i2c/busses/i2c-davinci.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/i2c/busses/i2c-davinci.c b/drivers/i2c/busses/i2c-davinci.c
index 232a7679b69b..e9d07323c604 100644
--- a/drivers/i2c/busses/i2c-davinci.c
+++ b/drivers/i2c/busses/i2c-davinci.c
@@ -768,10 +768,7 @@ static int davinci_i2c_probe(struct platform_device *pdev)
if (irq <= 0) {
if (!irq)
irq = -ENXIO;
- if (irq != -EPROBE_DEFER)
- dev_err(&pdev->dev,
- "can't get irq resource ret=%d\n", irq);
- return irq;
+ return dev_err_probe(&pdev->dev, irq, "can't get irq resource\n");
}
dev = devm_kzalloc(&pdev->dev, sizeof(struct davinci_i2c_dev),
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 78+ messages in thread
* [PATCH 6/9] i2c: imx: Simplify with dev_err_probe()
2020-09-02 15:06 ` Krzysztof Kozlowski
(?)
@ 2020-09-02 15:06 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 78+ messages in thread
From: Krzysztof Kozlowski @ 2020-09-02 15:06 UTC (permalink / raw)
To: Nicolas Saenz Julienne, Florian Fainelli, Ray Jui, Scott Branden,
bcm-kernel-feedback-list, Michal Simek, Sekhar Nori,
Bartosz Golaszewski, Oleksij Rempel, Pengutronix Kernel Team,
Shawn Guo, Sascha Hauer, Fabio Estevam, NXP Linux Team,
Heiko Stuebner, Pierre-Yves MORDRET, Maxime Coquelin,
Alexandre Torgue, Peter Rosin, Wolfram Sang, linux-i2c,
linux-rpi-kernel, linux-arm-kernel, linux-kernel, linux-rockchip,
linux-stm32
Cc: Krzysztof Kozlowski
Common pattern of handling deferred probe can be simplified with
dev_err_probe(). Less code and the error value gets printed.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
drivers/i2c/busses/i2c-imx.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c
index 0ab5381aa012..63f4367c312b 100644
--- a/drivers/i2c/busses/i2c-imx.c
+++ b/drivers/i2c/busses/i2c-imx.c
@@ -1159,11 +1159,9 @@ static int i2c_imx_probe(struct platform_device *pdev)
/* Get I2C clock */
i2c_imx->clk = devm_clk_get(&pdev->dev, NULL);
- if (IS_ERR(i2c_imx->clk)) {
- if (PTR_ERR(i2c_imx->clk) != -EPROBE_DEFER)
- dev_err(&pdev->dev, "can't get I2C clock\n");
- return PTR_ERR(i2c_imx->clk);
- }
+ if (IS_ERR(i2c_imx->clk))
+ return dev_err_probe(&pdev->dev, PTR_ERR(i2c_imx->clk),
+ "can't get I2C clock\n");
ret = clk_prepare_enable(i2c_imx->clk);
if (ret) {
--
2.17.1
^ permalink raw reply related [flat|nested] 78+ messages in thread
* [PATCH 6/9] i2c: imx: Simplify with dev_err_probe()
@ 2020-09-02 15:06 ` Krzysztof Kozlowski
0 siblings, 0 replies; 78+ messages in thread
From: Krzysztof Kozlowski @ 2020-09-02 15:06 UTC (permalink / raw)
To: Nicolas Saenz Julienne, Florian Fainelli, Ray Jui, Scott Branden,
bcm-kernel-feedback-list, Michal Simek, Sekhar Nori,
Bartosz Golaszewski, Oleksij Rempel, Pengutronix Kernel Team,
Shawn Guo, Sascha Hauer, Fabio Estevam, NXP Linux Team,
Heiko Stuebner, Pierre-Yves MORDRET, Maxime Coquelin,
Alexandre Torgue, Peter Rosin, Wolfram Sang, linux-i2c,
linux-rpi-kernel, linux-arm-kernel, linux-kernel, linux-rockchip,
linux-stm32
Cc: Krzysztof Kozlowski
Common pattern of handling deferred probe can be simplified with
dev_err_probe(). Less code and the error value gets printed.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
drivers/i2c/busses/i2c-imx.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c
index 0ab5381aa012..63f4367c312b 100644
--- a/drivers/i2c/busses/i2c-imx.c
+++ b/drivers/i2c/busses/i2c-imx.c
@@ -1159,11 +1159,9 @@ static int i2c_imx_probe(struct platform_device *pdev)
/* Get I2C clock */
i2c_imx->clk = devm_clk_get(&pdev->dev, NULL);
- if (IS_ERR(i2c_imx->clk)) {
- if (PTR_ERR(i2c_imx->clk) != -EPROBE_DEFER)
- dev_err(&pdev->dev, "can't get I2C clock\n");
- return PTR_ERR(i2c_imx->clk);
- }
+ if (IS_ERR(i2c_imx->clk))
+ return dev_err_probe(&pdev->dev, PTR_ERR(i2c_imx->clk),
+ "can't get I2C clock\n");
ret = clk_prepare_enable(i2c_imx->clk);
if (ret) {
--
2.17.1
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply related [flat|nested] 78+ messages in thread
* [PATCH 6/9] i2c: imx: Simplify with dev_err_probe()
@ 2020-09-02 15:06 ` Krzysztof Kozlowski
0 siblings, 0 replies; 78+ messages in thread
From: Krzysztof Kozlowski @ 2020-09-02 15:06 UTC (permalink / raw)
To: Nicolas Saenz Julienne, Florian Fainelli, Ray Jui, Scott Branden,
bcm-kernel-feedback-list, Michal Simek, Sekhar Nori,
Bartosz Golaszewski, Oleksij Rempel, Pengutronix Kernel Team,
Shawn Guo, Sascha Hauer, Fabio Estevam, NXP Linux Team,
Heiko Stuebner, Pierre-Yves MORDRET, Maxime Coquelin,
Alexandre Torgue, Peter Rosin, Wolfram Sang, linux-i2c,
linux-rpi-kernel, linux-arm-kernel, linux-kernel, linux-rockchip,
linux-stm32
Cc: Krzysztof Kozlowski
Common pattern of handling deferred probe can be simplified with
dev_err_probe(). Less code and the error value gets printed.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
drivers/i2c/busses/i2c-imx.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c
index 0ab5381aa012..63f4367c312b 100644
--- a/drivers/i2c/busses/i2c-imx.c
+++ b/drivers/i2c/busses/i2c-imx.c
@@ -1159,11 +1159,9 @@ static int i2c_imx_probe(struct platform_device *pdev)
/* Get I2C clock */
i2c_imx->clk = devm_clk_get(&pdev->dev, NULL);
- if (IS_ERR(i2c_imx->clk)) {
- if (PTR_ERR(i2c_imx->clk) != -EPROBE_DEFER)
- dev_err(&pdev->dev, "can't get I2C clock\n");
- return PTR_ERR(i2c_imx->clk);
- }
+ if (IS_ERR(i2c_imx->clk))
+ return dev_err_probe(&pdev->dev, PTR_ERR(i2c_imx->clk),
+ "can't get I2C clock\n");
ret = clk_prepare_enable(i2c_imx->clk);
if (ret) {
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 78+ messages in thread
* [PATCH 7/9] i2c: rk3x: Simplify with dev_err_probe()
2020-09-02 15:06 ` Krzysztof Kozlowski
(?)
@ 2020-09-02 15:06 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 78+ messages in thread
From: Krzysztof Kozlowski @ 2020-09-02 15:06 UTC (permalink / raw)
To: Nicolas Saenz Julienne, Florian Fainelli, Ray Jui, Scott Branden,
bcm-kernel-feedback-list, Michal Simek, Sekhar Nori,
Bartosz Golaszewski, Oleksij Rempel, Pengutronix Kernel Team,
Shawn Guo, Sascha Hauer, Fabio Estevam, NXP Linux Team,
Heiko Stuebner, Pierre-Yves MORDRET, Maxime Coquelin,
Alexandre Torgue, Peter Rosin, Wolfram Sang, linux-i2c,
linux-rpi-kernel, linux-arm-kernel, linux-kernel, linux-rockchip,
linux-stm32
Cc: Krzysztof Kozlowski
Common pattern of handling deferred probe can be simplified with
dev_err_probe(). Less code and the error value gets printed.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
drivers/i2c/busses/i2c-rk3x.c | 19 +++++++------------
1 file changed, 7 insertions(+), 12 deletions(-)
diff --git a/drivers/i2c/busses/i2c-rk3x.c b/drivers/i2c/busses/i2c-rk3x.c
index 8e3cc85d1921..819ab4ee517e 100644
--- a/drivers/i2c/busses/i2c-rk3x.c
+++ b/drivers/i2c/busses/i2c-rk3x.c
@@ -1312,18 +1312,13 @@ static int rk3x_i2c_probe(struct platform_device *pdev)
i2c->pclk = devm_clk_get(&pdev->dev, "pclk");
}
- if (IS_ERR(i2c->clk)) {
- ret = PTR_ERR(i2c->clk);
- if (ret != -EPROBE_DEFER)
- dev_err(&pdev->dev, "Can't get bus clk: %d\n", ret);
- return ret;
- }
- if (IS_ERR(i2c->pclk)) {
- ret = PTR_ERR(i2c->pclk);
- if (ret != -EPROBE_DEFER)
- dev_err(&pdev->dev, "Can't get periph clk: %d\n", ret);
- return ret;
- }
+ if (IS_ERR(i2c->clk))
+ return dev_err_probe(&pdev->dev, PTR_ERR(i2c->clk),
+ "Can't get bus clk\n");
+
+ if (IS_ERR(i2c->pclk))
+ return dev_err_probe(&pdev->dev, PTR_ERR(i2c->pclk),
+ "Can't get periph clk\n");
ret = clk_prepare(i2c->clk);
if (ret < 0) {
--
2.17.1
^ permalink raw reply related [flat|nested] 78+ messages in thread
* [PATCH 7/9] i2c: rk3x: Simplify with dev_err_probe()
@ 2020-09-02 15:06 ` Krzysztof Kozlowski
0 siblings, 0 replies; 78+ messages in thread
From: Krzysztof Kozlowski @ 2020-09-02 15:06 UTC (permalink / raw)
To: Nicolas Saenz Julienne, Florian Fainelli, Ray Jui, Scott Branden,
bcm-kernel-feedback-list, Michal Simek, Sekhar Nori,
Bartosz Golaszewski, Oleksij Rempel, Pengutronix Kernel Team,
Shawn Guo, Sascha Hauer, Fabio Estevam, NXP Linux Team,
Heiko Stuebner, Pierre-Yves MORDRET, Maxime Coquelin,
Alexandre Torgue, Peter Rosin, Wolfram Sang, linux-i2c,
linux-rpi-kernel, linux-arm-kernel, linux-kernel, linux-rockchip,
linux-stm32
Cc: Krzysztof Kozlowski
Common pattern of handling deferred probe can be simplified with
dev_err_probe(). Less code and the error value gets printed.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
drivers/i2c/busses/i2c-rk3x.c | 19 +++++++------------
1 file changed, 7 insertions(+), 12 deletions(-)
diff --git a/drivers/i2c/busses/i2c-rk3x.c b/drivers/i2c/busses/i2c-rk3x.c
index 8e3cc85d1921..819ab4ee517e 100644
--- a/drivers/i2c/busses/i2c-rk3x.c
+++ b/drivers/i2c/busses/i2c-rk3x.c
@@ -1312,18 +1312,13 @@ static int rk3x_i2c_probe(struct platform_device *pdev)
i2c->pclk = devm_clk_get(&pdev->dev, "pclk");
}
- if (IS_ERR(i2c->clk)) {
- ret = PTR_ERR(i2c->clk);
- if (ret != -EPROBE_DEFER)
- dev_err(&pdev->dev, "Can't get bus clk: %d\n", ret);
- return ret;
- }
- if (IS_ERR(i2c->pclk)) {
- ret = PTR_ERR(i2c->pclk);
- if (ret != -EPROBE_DEFER)
- dev_err(&pdev->dev, "Can't get periph clk: %d\n", ret);
- return ret;
- }
+ if (IS_ERR(i2c->clk))
+ return dev_err_probe(&pdev->dev, PTR_ERR(i2c->clk),
+ "Can't get bus clk\n");
+
+ if (IS_ERR(i2c->pclk))
+ return dev_err_probe(&pdev->dev, PTR_ERR(i2c->pclk),
+ "Can't get periph clk\n");
ret = clk_prepare(i2c->clk);
if (ret < 0) {
--
2.17.1
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply related [flat|nested] 78+ messages in thread
* [PATCH 7/9] i2c: rk3x: Simplify with dev_err_probe()
@ 2020-09-02 15:06 ` Krzysztof Kozlowski
0 siblings, 0 replies; 78+ messages in thread
From: Krzysztof Kozlowski @ 2020-09-02 15:06 UTC (permalink / raw)
To: Nicolas Saenz Julienne, Florian Fainelli, Ray Jui, Scott Branden,
bcm-kernel-feedback-list, Michal Simek, Sekhar Nori,
Bartosz Golaszewski, Oleksij Rempel, Pengutronix Kernel Team,
Shawn Guo, Sascha Hauer, Fabio Estevam, NXP Linux Team,
Heiko Stuebner, Pierre-Yves MORDRET, Maxime Coquelin,
Alexandre Torgue, Peter Rosin, Wolfram Sang, linux-i2c,
linux-rpi-kernel, linux-arm-kernel, linux-kernel, linux-rockchip,
linux-stm32
Cc: Krzysztof Kozlowski
Common pattern of handling deferred probe can be simplified with
dev_err_probe(). Less code and the error value gets printed.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
drivers/i2c/busses/i2c-rk3x.c | 19 +++++++------------
1 file changed, 7 insertions(+), 12 deletions(-)
diff --git a/drivers/i2c/busses/i2c-rk3x.c b/drivers/i2c/busses/i2c-rk3x.c
index 8e3cc85d1921..819ab4ee517e 100644
--- a/drivers/i2c/busses/i2c-rk3x.c
+++ b/drivers/i2c/busses/i2c-rk3x.c
@@ -1312,18 +1312,13 @@ static int rk3x_i2c_probe(struct platform_device *pdev)
i2c->pclk = devm_clk_get(&pdev->dev, "pclk");
}
- if (IS_ERR(i2c->clk)) {
- ret = PTR_ERR(i2c->clk);
- if (ret != -EPROBE_DEFER)
- dev_err(&pdev->dev, "Can't get bus clk: %d\n", ret);
- return ret;
- }
- if (IS_ERR(i2c->pclk)) {
- ret = PTR_ERR(i2c->pclk);
- if (ret != -EPROBE_DEFER)
- dev_err(&pdev->dev, "Can't get periph clk: %d\n", ret);
- return ret;
- }
+ if (IS_ERR(i2c->clk))
+ return dev_err_probe(&pdev->dev, PTR_ERR(i2c->clk),
+ "Can't get bus clk\n");
+
+ if (IS_ERR(i2c->pclk))
+ return dev_err_probe(&pdev->dev, PTR_ERR(i2c->pclk),
+ "Can't get periph clk\n");
ret = clk_prepare(i2c->clk);
if (ret < 0) {
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 78+ messages in thread
* [PATCH 8/9] i2c: mux: gpmux: Simplify with dev_err_probe()
2020-09-02 15:06 ` Krzysztof Kozlowski
(?)
@ 2020-09-02 15:06 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 78+ messages in thread
From: Krzysztof Kozlowski @ 2020-09-02 15:06 UTC (permalink / raw)
To: Nicolas Saenz Julienne, Florian Fainelli, Ray Jui, Scott Branden,
bcm-kernel-feedback-list, Michal Simek, Sekhar Nori,
Bartosz Golaszewski, Oleksij Rempel, Pengutronix Kernel Team,
Shawn Guo, Sascha Hauer, Fabio Estevam, NXP Linux Team,
Heiko Stuebner, Pierre-Yves MORDRET, Maxime Coquelin,
Alexandre Torgue, Peter Rosin, Wolfram Sang, linux-i2c,
linux-rpi-kernel, linux-arm-kernel, linux-kernel, linux-rockchip,
linux-stm32
Cc: Krzysztof Kozlowski
Common pattern of handling deferred probe can be simplified with
dev_err_probe(). Less code and the error value gets printed.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
drivers/i2c/muxes/i2c-mux-gpmux.c | 16 ++++++----------
1 file changed, 6 insertions(+), 10 deletions(-)
diff --git a/drivers/i2c/muxes/i2c-mux-gpmux.c b/drivers/i2c/muxes/i2c-mux-gpmux.c
index f830535cff12..d3acd8d66c32 100644
--- a/drivers/i2c/muxes/i2c-mux-gpmux.c
+++ b/drivers/i2c/muxes/i2c-mux-gpmux.c
@@ -85,18 +85,14 @@ static int i2c_mux_probe(struct platform_device *pdev)
return -ENOMEM;
mux->control = devm_mux_control_get(dev, NULL);
- if (IS_ERR(mux->control)) {
- if (PTR_ERR(mux->control) != -EPROBE_DEFER)
- dev_err(dev, "failed to get control-mux\n");
- return PTR_ERR(mux->control);
- }
+ if (IS_ERR(mux->control))
+ return dev_err_probe(dev, PTR_ERR(mux->control),
+ "failed to get control-mux\n");
parent = mux_parent_adapter(dev);
- if (IS_ERR(parent)) {
- if (PTR_ERR(parent) != -EPROBE_DEFER)
- dev_err(dev, "failed to get i2c-parent adapter\n");
- return PTR_ERR(parent);
- }
+ if (IS_ERR(parent))
+ return dev_err_probe(dev, PTR_ERR(parent),
+ "failed to get i2c-parent adapter\n");
children = of_get_child_count(np);
--
2.17.1
^ permalink raw reply related [flat|nested] 78+ messages in thread
* [PATCH 8/9] i2c: mux: gpmux: Simplify with dev_err_probe()
@ 2020-09-02 15:06 ` Krzysztof Kozlowski
0 siblings, 0 replies; 78+ messages in thread
From: Krzysztof Kozlowski @ 2020-09-02 15:06 UTC (permalink / raw)
To: Nicolas Saenz Julienne, Florian Fainelli, Ray Jui, Scott Branden,
bcm-kernel-feedback-list, Michal Simek, Sekhar Nori,
Bartosz Golaszewski, Oleksij Rempel, Pengutronix Kernel Team,
Shawn Guo, Sascha Hauer, Fabio Estevam, NXP Linux Team,
Heiko Stuebner, Pierre-Yves MORDRET, Maxime Coquelin,
Alexandre Torgue, Peter Rosin, Wolfram Sang, linux-i2c,
linux-rpi-kernel, linux-arm-kernel, linux-kernel, linux-rockchip,
linux-stm32
Cc: Krzysztof Kozlowski
Common pattern of handling deferred probe can be simplified with
dev_err_probe(). Less code and the error value gets printed.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
drivers/i2c/muxes/i2c-mux-gpmux.c | 16 ++++++----------
1 file changed, 6 insertions(+), 10 deletions(-)
diff --git a/drivers/i2c/muxes/i2c-mux-gpmux.c b/drivers/i2c/muxes/i2c-mux-gpmux.c
index f830535cff12..d3acd8d66c32 100644
--- a/drivers/i2c/muxes/i2c-mux-gpmux.c
+++ b/drivers/i2c/muxes/i2c-mux-gpmux.c
@@ -85,18 +85,14 @@ static int i2c_mux_probe(struct platform_device *pdev)
return -ENOMEM;
mux->control = devm_mux_control_get(dev, NULL);
- if (IS_ERR(mux->control)) {
- if (PTR_ERR(mux->control) != -EPROBE_DEFER)
- dev_err(dev, "failed to get control-mux\n");
- return PTR_ERR(mux->control);
- }
+ if (IS_ERR(mux->control))
+ return dev_err_probe(dev, PTR_ERR(mux->control),
+ "failed to get control-mux\n");
parent = mux_parent_adapter(dev);
- if (IS_ERR(parent)) {
- if (PTR_ERR(parent) != -EPROBE_DEFER)
- dev_err(dev, "failed to get i2c-parent adapter\n");
- return PTR_ERR(parent);
- }
+ if (IS_ERR(parent))
+ return dev_err_probe(dev, PTR_ERR(parent),
+ "failed to get i2c-parent adapter\n");
children = of_get_child_count(np);
--
2.17.1
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply related [flat|nested] 78+ messages in thread
* [PATCH 8/9] i2c: mux: gpmux: Simplify with dev_err_probe()
@ 2020-09-02 15:06 ` Krzysztof Kozlowski
0 siblings, 0 replies; 78+ messages in thread
From: Krzysztof Kozlowski @ 2020-09-02 15:06 UTC (permalink / raw)
To: Nicolas Saenz Julienne, Florian Fainelli, Ray Jui, Scott Branden,
bcm-kernel-feedback-list, Michal Simek, Sekhar Nori,
Bartosz Golaszewski, Oleksij Rempel, Pengutronix Kernel Team,
Shawn Guo, Sascha Hauer, Fabio Estevam, NXP Linux Team,
Heiko Stuebner, Pierre-Yves MORDRET, Maxime Coquelin,
Alexandre Torgue, Peter Rosin, Wolfram Sang, linux-i2c,
linux-rpi-kernel, linux-arm-kernel, linux-kernel, linux-rockchip,
linux-stm32
Cc: Krzysztof Kozlowski
Common pattern of handling deferred probe can be simplified with
dev_err_probe(). Less code and the error value gets printed.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
drivers/i2c/muxes/i2c-mux-gpmux.c | 16 ++++++----------
1 file changed, 6 insertions(+), 10 deletions(-)
diff --git a/drivers/i2c/muxes/i2c-mux-gpmux.c b/drivers/i2c/muxes/i2c-mux-gpmux.c
index f830535cff12..d3acd8d66c32 100644
--- a/drivers/i2c/muxes/i2c-mux-gpmux.c
+++ b/drivers/i2c/muxes/i2c-mux-gpmux.c
@@ -85,18 +85,14 @@ static int i2c_mux_probe(struct platform_device *pdev)
return -ENOMEM;
mux->control = devm_mux_control_get(dev, NULL);
- if (IS_ERR(mux->control)) {
- if (PTR_ERR(mux->control) != -EPROBE_DEFER)
- dev_err(dev, "failed to get control-mux\n");
- return PTR_ERR(mux->control);
- }
+ if (IS_ERR(mux->control))
+ return dev_err_probe(dev, PTR_ERR(mux->control),
+ "failed to get control-mux\n");
parent = mux_parent_adapter(dev);
- if (IS_ERR(parent)) {
- if (PTR_ERR(parent) != -EPROBE_DEFER)
- dev_err(dev, "failed to get i2c-parent adapter\n");
- return PTR_ERR(parent);
- }
+ if (IS_ERR(parent))
+ return dev_err_probe(dev, PTR_ERR(parent),
+ "failed to get i2c-parent adapter\n");
children = of_get_child_count(np);
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 78+ messages in thread
* [PATCH 9/9] i2c: mux: reg: Simplify with dev_err_probe()
2020-09-02 15:06 ` Krzysztof Kozlowski
(?)
@ 2020-09-02 15:06 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 78+ messages in thread
From: Krzysztof Kozlowski @ 2020-09-02 15:06 UTC (permalink / raw)
To: Nicolas Saenz Julienne, Florian Fainelli, Ray Jui, Scott Branden,
bcm-kernel-feedback-list, Michal Simek, Sekhar Nori,
Bartosz Golaszewski, Oleksij Rempel, Pengutronix Kernel Team,
Shawn Guo, Sascha Hauer, Fabio Estevam, NXP Linux Team,
Heiko Stuebner, Pierre-Yves MORDRET, Maxime Coquelin,
Alexandre Torgue, Peter Rosin, Wolfram Sang, linux-i2c,
linux-rpi-kernel, linux-arm-kernel, linux-kernel, linux-rockchip,
linux-stm32
Cc: Krzysztof Kozlowski
Common pattern of handling deferred probe can be simplified with
dev_err_probe(). Less code and the error value gets printed.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
drivers/i2c/muxes/i2c-mux-reg.c | 10 +++-------
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/drivers/i2c/muxes/i2c-mux-reg.c b/drivers/i2c/muxes/i2c-mux-reg.c
index b59a62f8d7a6..0e0679f65cf7 100644
--- a/drivers/i2c/muxes/i2c-mux-reg.c
+++ b/drivers/i2c/muxes/i2c-mux-reg.c
@@ -171,13 +171,9 @@ static int i2c_mux_reg_probe(struct platform_device *pdev)
sizeof(mux->data));
} else {
ret = i2c_mux_reg_probe_dt(mux, pdev);
- if (ret == -EPROBE_DEFER)
- return ret;
-
- if (ret < 0) {
- dev_err(&pdev->dev, "Error parsing device tree");
- return ret;
- }
+ if (ret < 0)
+ return dev_err_probe(&pdev->dev, ret,
+ "Error parsing device tree");
}
parent = i2c_get_adapter(mux->data.parent);
--
2.17.1
^ permalink raw reply related [flat|nested] 78+ messages in thread
* [PATCH 9/9] i2c: mux: reg: Simplify with dev_err_probe()
@ 2020-09-02 15:06 ` Krzysztof Kozlowski
0 siblings, 0 replies; 78+ messages in thread
From: Krzysztof Kozlowski @ 2020-09-02 15:06 UTC (permalink / raw)
To: Nicolas Saenz Julienne, Florian Fainelli, Ray Jui, Scott Branden,
bcm-kernel-feedback-list, Michal Simek, Sekhar Nori,
Bartosz Golaszewski, Oleksij Rempel, Pengutronix Kernel Team,
Shawn Guo, Sascha Hauer, Fabio Estevam, NXP Linux Team,
Heiko Stuebner, Pierre-Yves MORDRET, Maxime Coquelin,
Alexandre Torgue, Peter Rosin, Wolfram Sang, linux-i2c,
linux-rpi-kernel, linux-arm-kernel, linux-kernel, linux-rockchip,
linux-stm32
Cc: Krzysztof Kozlowski
Common pattern of handling deferred probe can be simplified with
dev_err_probe(). Less code and the error value gets printed.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
drivers/i2c/muxes/i2c-mux-reg.c | 10 +++-------
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/drivers/i2c/muxes/i2c-mux-reg.c b/drivers/i2c/muxes/i2c-mux-reg.c
index b59a62f8d7a6..0e0679f65cf7 100644
--- a/drivers/i2c/muxes/i2c-mux-reg.c
+++ b/drivers/i2c/muxes/i2c-mux-reg.c
@@ -171,13 +171,9 @@ static int i2c_mux_reg_probe(struct platform_device *pdev)
sizeof(mux->data));
} else {
ret = i2c_mux_reg_probe_dt(mux, pdev);
- if (ret == -EPROBE_DEFER)
- return ret;
-
- if (ret < 0) {
- dev_err(&pdev->dev, "Error parsing device tree");
- return ret;
- }
+ if (ret < 0)
+ return dev_err_probe(&pdev->dev, ret,
+ "Error parsing device tree");
}
parent = i2c_get_adapter(mux->data.parent);
--
2.17.1
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply related [flat|nested] 78+ messages in thread
* [PATCH 9/9] i2c: mux: reg: Simplify with dev_err_probe()
@ 2020-09-02 15:06 ` Krzysztof Kozlowski
0 siblings, 0 replies; 78+ messages in thread
From: Krzysztof Kozlowski @ 2020-09-02 15:06 UTC (permalink / raw)
To: Nicolas Saenz Julienne, Florian Fainelli, Ray Jui, Scott Branden,
bcm-kernel-feedback-list, Michal Simek, Sekhar Nori,
Bartosz Golaszewski, Oleksij Rempel, Pengutronix Kernel Team,
Shawn Guo, Sascha Hauer, Fabio Estevam, NXP Linux Team,
Heiko Stuebner, Pierre-Yves MORDRET, Maxime Coquelin,
Alexandre Torgue, Peter Rosin, Wolfram Sang, linux-i2c,
linux-rpi-kernel, linux-arm-kernel, linux-kernel, linux-rockchip,
linux-stm32
Cc: Krzysztof Kozlowski
Common pattern of handling deferred probe can be simplified with
dev_err_probe(). Less code and the error value gets printed.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
drivers/i2c/muxes/i2c-mux-reg.c | 10 +++-------
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/drivers/i2c/muxes/i2c-mux-reg.c b/drivers/i2c/muxes/i2c-mux-reg.c
index b59a62f8d7a6..0e0679f65cf7 100644
--- a/drivers/i2c/muxes/i2c-mux-reg.c
+++ b/drivers/i2c/muxes/i2c-mux-reg.c
@@ -171,13 +171,9 @@ static int i2c_mux_reg_probe(struct platform_device *pdev)
sizeof(mux->data));
} else {
ret = i2c_mux_reg_probe_dt(mux, pdev);
- if (ret == -EPROBE_DEFER)
- return ret;
-
- if (ret < 0) {
- dev_err(&pdev->dev, "Error parsing device tree");
- return ret;
- }
+ if (ret < 0)
+ return dev_err_probe(&pdev->dev, ret,
+ "Error parsing device tree");
}
parent = i2c_get_adapter(mux->data.parent);
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 78+ messages in thread
* Re: [PATCH 3/9] i2c: bcm2835: Simplify with dev_err_probe()
2020-09-02 15:06 ` Krzysztof Kozlowski
(?)
@ 2020-09-02 15:24 ` Florian Fainelli
-1 siblings, 0 replies; 78+ messages in thread
From: Florian Fainelli @ 2020-09-02 15:24 UTC (permalink / raw)
To: Krzysztof Kozlowski, Nicolas Saenz Julienne, Florian Fainelli,
Ray Jui, Scott Branden, bcm-kernel-feedback-list, Michal Simek,
Sekhar Nori, Bartosz Golaszewski, Oleksij Rempel,
Pengutronix Kernel Team, Shawn Guo, Sascha Hauer, Fabio Estevam,
NXP Linux Team, Heiko Stuebner, Pierre-Yves MORDRET,
Maxime Coquelin, Alexandre Torgue, Peter Rosin, Wolfram Sang,
linux-i2c, linux-rpi-kernel, linux-arm-kernel, linux-kernel,
linux-rockchip, linux-stm32
On 9/2/2020 8:06 AM, Krzysztof Kozlowski wrote:
> Common pattern of handling deferred probe can be simplified with
> dev_err_probe(). Less code and the error value gets printed.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
^ permalink raw reply [flat|nested] 78+ messages in thread
* Re: [PATCH 3/9] i2c: bcm2835: Simplify with dev_err_probe()
@ 2020-09-02 15:24 ` Florian Fainelli
0 siblings, 0 replies; 78+ messages in thread
From: Florian Fainelli @ 2020-09-02 15:24 UTC (permalink / raw)
To: Krzysztof Kozlowski, Nicolas Saenz Julienne, Florian Fainelli,
Ray Jui, Scott Branden, bcm-kernel-feedback-list, Michal Simek,
Sekhar Nori, Bartosz Golaszewski, Oleksij Rempel,
Pengutronix Kernel Team, Shawn Guo, Sascha Hauer, Fabio Estevam,
NXP Linux Team, Heiko Stuebner, Pierre-Yves MORDRET,
Maxime Coquelin, Alexandre Torgue, Peter Rosin, Wolfram Sang,
linux-i2c, linux-rpi-kernel, linux-arm-kernel, linux-kernel,
linux-rockchip, linux-stm32
On 9/2/2020 8:06 AM, Krzysztof Kozlowski wrote:
> Common pattern of handling deferred probe can be simplified with
> dev_err_probe(). Less code and the error value gets printed.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 78+ messages in thread
* Re: [PATCH 3/9] i2c: bcm2835: Simplify with dev_err_probe()
@ 2020-09-02 15:24 ` Florian Fainelli
0 siblings, 0 replies; 78+ messages in thread
From: Florian Fainelli @ 2020-09-02 15:24 UTC (permalink / raw)
To: Krzysztof Kozlowski, Nicolas Saenz Julienne, Florian Fainelli,
Ray Jui, Scott Branden, bcm-kernel-feedback-list, Michal Simek,
Sekhar Nori, Bartosz Golaszewski, Oleksij Rempel,
Pengutronix Kernel Team, Shawn Guo, Sascha Hauer, Fabio Estevam,
NXP Linux Team, Heiko Stuebner, Pierre-Yves MORDRET,
Maxime Coquelin, Alexandre Torgue, Peter Rosin, Wolfram Sang,
linux-i2c, linux-rpi-kernel, linux-arm-kernel, linux-kernel,
linux-rockchip, linux-stm32
On 9/2/2020 8:06 AM, Krzysztof Kozlowski wrote:
> Common pattern of handling deferred probe can be simplified with
> dev_err_probe(). Less code and the error value gets printed.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 78+ messages in thread
* Re: [PATCH 6/9] i2c: imx: Simplify with dev_err_probe()
2020-09-02 15:06 ` Krzysztof Kozlowski
(?)
@ 2020-09-02 17:58 ` Uwe Kleine-König
-1 siblings, 0 replies; 78+ messages in thread
From: Uwe Kleine-König @ 2020-09-02 17:58 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Nicolas Saenz Julienne, Florian Fainelli, Ray Jui, Scott Branden,
bcm-kernel-feedback-list, Michal Simek, Sekhar Nori,
Bartosz Golaszewski, Oleksij Rempel, Pengutronix Kernel Team,
Shawn Guo, Sascha Hauer, Fabio Estevam, NXP Linux Team,
Heiko Stuebner, Pierre-Yves MORDRET, Maxime Coquelin,
Alexandre Torgue, Peter Rosin, Wolfram Sang, linux-i2c,
linux-rpi-kernel, linux-arm-kernel, linux-kernel, linux-rockchip,
linux-stm32
[-- Attachment #1: Type: text/plain, Size: 500 bytes --]
On Wed, Sep 02, 2020 at 05:06:40PM +0200, Krzysztof Kozlowski wrote:
> Common pattern of handling deferred probe can be simplified with
> dev_err_probe(). Less code and the error value gets printed.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Thanks
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 78+ messages in thread
* Re: [PATCH 6/9] i2c: imx: Simplify with dev_err_probe()
@ 2020-09-02 17:58 ` Uwe Kleine-König
0 siblings, 0 replies; 78+ messages in thread
From: Uwe Kleine-König @ 2020-09-02 17:58 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Heiko Stuebner, Sekhar Nori, Pierre-Yves MORDRET, linux-i2c,
Fabio Estevam, linux-stm32, Alexandre Torgue, Florian Fainelli,
linux-rockchip, Michal Simek, Bartosz Golaszewski,
bcm-kernel-feedback-list, NXP Linux Team,
Pengutronix Kernel Team, Ray Jui, Sascha Hauer, linux-rpi-kernel,
linux-arm-kernel, Scott Branden, linux-kernel, Oleksij Rempel,
Wolfram Sang, Maxime Coquelin, Shawn Guo, Peter Rosin,
Nicolas Saenz Julienne
[-- Attachment #1.1: Type: text/plain, Size: 500 bytes --]
On Wed, Sep 02, 2020 at 05:06:40PM +0200, Krzysztof Kozlowski wrote:
> Common pattern of handling deferred probe can be simplified with
> dev_err_probe(). Less code and the error value gets printed.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Thanks
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 170 bytes --]
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 78+ messages in thread
* Re: [PATCH 6/9] i2c: imx: Simplify with dev_err_probe()
@ 2020-09-02 17:58 ` Uwe Kleine-König
0 siblings, 0 replies; 78+ messages in thread
From: Uwe Kleine-König @ 2020-09-02 17:58 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Heiko Stuebner, Sekhar Nori, Pierre-Yves MORDRET, linux-i2c,
Fabio Estevam, linux-stm32, Alexandre Torgue, Florian Fainelli,
linux-rockchip, Michal Simek, Bartosz Golaszewski,
bcm-kernel-feedback-list, NXP Linux Team,
Pengutronix Kernel Team, Ray Jui, Sascha Hauer, linux-rpi-kernel,
linux-arm-kernel, Scott Branden, linux-kernel, Oleksij Rempel,
Wolfram Sang, Maxime Coquelin, Shawn Guo, Peter Rosin,
Nicolas Saenz Julienne
[-- Attachment #1.1: Type: text/plain, Size: 500 bytes --]
On Wed, Sep 02, 2020 at 05:06:40PM +0200, Krzysztof Kozlowski wrote:
> Common pattern of handling deferred probe can be simplified with
> dev_err_probe(). Less code and the error value gets printed.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Thanks
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 78+ messages in thread
* Re: [PATCH 8/9] i2c: mux: gpmux: Simplify with dev_err_probe()
2020-09-02 15:06 ` Krzysztof Kozlowski
(?)
@ 2020-09-02 18:33 ` Peter Rosin
-1 siblings, 0 replies; 78+ messages in thread
From: Peter Rosin @ 2020-09-02 18:33 UTC (permalink / raw)
To: Krzysztof Kozlowski, Nicolas Saenz Julienne, Florian Fainelli,
Ray Jui, Scott Branden, bcm-kernel-feedback-list, Michal Simek,
Sekhar Nori, Bartosz Golaszewski, Oleksij Rempel,
Pengutronix Kernel Team, Shawn Guo, Sascha Hauer, Fabio Estevam,
NXP Linux Team, Heiko Stuebner, Pierre-Yves MORDRET,
Maxime Coquelin, Alexandre Torgue, Wolfram Sang, linux-i2c,
linux-rpi-kernel, linux-arm-kernel, linux-kernel, linux-rockchip,
linux-stm32
On 2020-09-02 17:06, Krzysztof Kozlowski wrote:
> Common pattern of handling deferred probe can be simplified with
> dev_err_probe(). Less code and the error value gets printed.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Acked-by: Peter Rosin <peda@axentia.se>
Cheers,
Peter
^ permalink raw reply [flat|nested] 78+ messages in thread
* Re: [PATCH 8/9] i2c: mux: gpmux: Simplify with dev_err_probe()
@ 2020-09-02 18:33 ` Peter Rosin
0 siblings, 0 replies; 78+ messages in thread
From: Peter Rosin @ 2020-09-02 18:33 UTC (permalink / raw)
To: Krzysztof Kozlowski, Nicolas Saenz Julienne, Florian Fainelli,
Ray Jui, Scott Branden, bcm-kernel-feedback-list, Michal Simek,
Sekhar Nori, Bartosz Golaszewski, Oleksij Rempel,
Pengutronix Kernel Team, Shawn Guo, Sascha Hauer, Fabio Estevam,
NXP Linux Team, Heiko Stuebner, Pierre-Yves MORDRET,
Maxime Coquelin, Alexandre Torgue, Wolfram Sang, linux-i2c,
linux-rpi-kernel, linux-arm-kernel, linux-kernel, linux-rockchip,
linux-stm32
On 2020-09-02 17:06, Krzysztof Kozlowski wrote:
> Common pattern of handling deferred probe can be simplified with
> dev_err_probe(). Less code and the error value gets printed.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Acked-by: Peter Rosin <peda@axentia.se>
Cheers,
Peter
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 78+ messages in thread
* Re: [PATCH 8/9] i2c: mux: gpmux: Simplify with dev_err_probe()
@ 2020-09-02 18:33 ` Peter Rosin
0 siblings, 0 replies; 78+ messages in thread
From: Peter Rosin @ 2020-09-02 18:33 UTC (permalink / raw)
To: Krzysztof Kozlowski, Nicolas Saenz Julienne, Florian Fainelli,
Ray Jui, Scott Branden, bcm-kernel-feedback-list, Michal Simek,
Sekhar Nori, Bartosz Golaszewski, Oleksij Rempel,
Pengutronix Kernel Team, Shawn Guo, Sascha Hauer, Fabio Estevam,
NXP Linux Team, Heiko Stuebner, Pierre-Yves MORDRET,
Maxime Coquelin, Alexandre Torgue, Wolfram Sang, linux-i2c,
linux-rpi-kernel, linux-arm-kernel, linux-kernel, linux-rockchip,
linux-stm32
On 2020-09-02 17:06, Krzysztof Kozlowski wrote:
> Common pattern of handling deferred probe can be simplified with
> dev_err_probe(). Less code and the error value gets printed.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Acked-by: Peter Rosin <peda@axentia.se>
Cheers,
Peter
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 78+ messages in thread
* Re: [PATCH 9/9] i2c: mux: reg: Simplify with dev_err_probe()
2020-09-02 15:06 ` Krzysztof Kozlowski
(?)
@ 2020-09-02 18:33 ` Peter Rosin
-1 siblings, 0 replies; 78+ messages in thread
From: Peter Rosin @ 2020-09-02 18:33 UTC (permalink / raw)
To: Krzysztof Kozlowski, Nicolas Saenz Julienne, Florian Fainelli,
Ray Jui, Scott Branden, bcm-kernel-feedback-list, Michal Simek,
Sekhar Nori, Bartosz Golaszewski, Oleksij Rempel,
Pengutronix Kernel Team, Shawn Guo, Sascha Hauer, Fabio Estevam,
NXP Linux Team, Heiko Stuebner, Pierre-Yves MORDRET,
Maxime Coquelin, Alexandre Torgue, Wolfram Sang, linux-i2c,
linux-rpi-kernel, linux-arm-kernel, linux-kernel, linux-rockchip,
linux-stm32
On 2020-09-02 17:06, Krzysztof Kozlowski wrote:
> Common pattern of handling deferred probe can be simplified with
> dev_err_probe(). Less code and the error value gets printed.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Acked-by: Peter Rosin <peda@axentia.se>
Cheers,
Peter
^ permalink raw reply [flat|nested] 78+ messages in thread
* Re: [PATCH 9/9] i2c: mux: reg: Simplify with dev_err_probe()
@ 2020-09-02 18:33 ` Peter Rosin
0 siblings, 0 replies; 78+ messages in thread
From: Peter Rosin @ 2020-09-02 18:33 UTC (permalink / raw)
To: Krzysztof Kozlowski, Nicolas Saenz Julienne, Florian Fainelli,
Ray Jui, Scott Branden, bcm-kernel-feedback-list, Michal Simek,
Sekhar Nori, Bartosz Golaszewski, Oleksij Rempel,
Pengutronix Kernel Team, Shawn Guo, Sascha Hauer, Fabio Estevam,
NXP Linux Team, Heiko Stuebner, Pierre-Yves MORDRET,
Maxime Coquelin, Alexandre Torgue, Wolfram Sang, linux-i2c,
linux-rpi-kernel, linux-arm-kernel, linux-kernel, linux-rockchip,
linux-stm32
On 2020-09-02 17:06, Krzysztof Kozlowski wrote:
> Common pattern of handling deferred probe can be simplified with
> dev_err_probe(). Less code and the error value gets printed.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Acked-by: Peter Rosin <peda@axentia.se>
Cheers,
Peter
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 78+ messages in thread
* Re: [PATCH 9/9] i2c: mux: reg: Simplify with dev_err_probe()
@ 2020-09-02 18:33 ` Peter Rosin
0 siblings, 0 replies; 78+ messages in thread
From: Peter Rosin @ 2020-09-02 18:33 UTC (permalink / raw)
To: Krzysztof Kozlowski, Nicolas Saenz Julienne, Florian Fainelli,
Ray Jui, Scott Branden, bcm-kernel-feedback-list, Michal Simek,
Sekhar Nori, Bartosz Golaszewski, Oleksij Rempel,
Pengutronix Kernel Team, Shawn Guo, Sascha Hauer, Fabio Estevam,
NXP Linux Team, Heiko Stuebner, Pierre-Yves MORDRET,
Maxime Coquelin, Alexandre Torgue, Wolfram Sang, linux-i2c,
linux-rpi-kernel, linux-arm-kernel, linux-kernel, linux-rockchip,
linux-stm32
On 2020-09-02 17:06, Krzysztof Kozlowski wrote:
> Common pattern of handling deferred probe can be simplified with
> dev_err_probe(). Less code and the error value gets printed.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Acked-by: Peter Rosin <peda@axentia.se>
Cheers,
Peter
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 78+ messages in thread
* Re: [PATCH 6/9] i2c: imx: Simplify with dev_err_probe()
2020-09-02 15:06 ` Krzysztof Kozlowski
(?)
@ 2020-09-03 5:36 ` Oleksij Rempel
-1 siblings, 0 replies; 78+ messages in thread
From: Oleksij Rempel @ 2020-09-03 5:36 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Nicolas Saenz Julienne, Florian Fainelli, Ray Jui, Scott Branden,
bcm-kernel-feedback-list, Michal Simek, Sekhar Nori,
Bartosz Golaszewski, Oleksij Rempel, Pengutronix Kernel Team,
Shawn Guo, Sascha Hauer, Fabio Estevam, NXP Linux Team,
Heiko Stuebner, Pierre-Yves MORDRET, Maxime Coquelin,
Alexandre Torgue, Peter Rosin, Wolfram Sang, linux-i2c,
linux-rpi-kernel, linux-arm-kernel, linux-kernel, linux-rockchip,
linux-stm32
On Wed, Sep 02, 2020 at 05:06:40PM +0200, Krzysztof Kozlowski wrote:
> Common pattern of handling deferred probe can be simplified with
> dev_err_probe(). Less code and the error value gets printed.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Acked-by: Oleksij Rempel <o.rempel@pengutronix.de>
> ---
> drivers/i2c/busses/i2c-imx.c | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c
> index 0ab5381aa012..63f4367c312b 100644
> --- a/drivers/i2c/busses/i2c-imx.c
> +++ b/drivers/i2c/busses/i2c-imx.c
> @@ -1159,11 +1159,9 @@ static int i2c_imx_probe(struct platform_device *pdev)
>
> /* Get I2C clock */
> i2c_imx->clk = devm_clk_get(&pdev->dev, NULL);
> - if (IS_ERR(i2c_imx->clk)) {
> - if (PTR_ERR(i2c_imx->clk) != -EPROBE_DEFER)
> - dev_err(&pdev->dev, "can't get I2C clock\n");
> - return PTR_ERR(i2c_imx->clk);
> - }
> + if (IS_ERR(i2c_imx->clk))
> + return dev_err_probe(&pdev->dev, PTR_ERR(i2c_imx->clk),
> + "can't get I2C clock\n");
>
> ret = clk_prepare_enable(i2c_imx->clk);
> if (ret) {
> --
> 2.17.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 78+ messages in thread
* Re: [PATCH 6/9] i2c: imx: Simplify with dev_err_probe()
@ 2020-09-03 5:36 ` Oleksij Rempel
0 siblings, 0 replies; 78+ messages in thread
From: Oleksij Rempel @ 2020-09-03 5:36 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Heiko Stuebner, Sekhar Nori, Pierre-Yves MORDRET, linux-i2c,
Fabio Estevam, linux-stm32, Alexandre Torgue, Florian Fainelli,
linux-rockchip, Michal Simek, Bartosz Golaszewski,
bcm-kernel-feedback-list, NXP Linux Team,
Pengutronix Kernel Team, Ray Jui, Sascha Hauer, linux-rpi-kernel,
linux-arm-kernel, Scott Branden, linux-kernel, Oleksij Rempel,
Wolfram Sang, Maxime Coquelin, Shawn Guo, Peter Rosin,
Nicolas Saenz Julienne
On Wed, Sep 02, 2020 at 05:06:40PM +0200, Krzysztof Kozlowski wrote:
> Common pattern of handling deferred probe can be simplified with
> dev_err_probe(). Less code and the error value gets printed.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Acked-by: Oleksij Rempel <o.rempel@pengutronix.de>
> ---
> drivers/i2c/busses/i2c-imx.c | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c
> index 0ab5381aa012..63f4367c312b 100644
> --- a/drivers/i2c/busses/i2c-imx.c
> +++ b/drivers/i2c/busses/i2c-imx.c
> @@ -1159,11 +1159,9 @@ static int i2c_imx_probe(struct platform_device *pdev)
>
> /* Get I2C clock */
> i2c_imx->clk = devm_clk_get(&pdev->dev, NULL);
> - if (IS_ERR(i2c_imx->clk)) {
> - if (PTR_ERR(i2c_imx->clk) != -EPROBE_DEFER)
> - dev_err(&pdev->dev, "can't get I2C clock\n");
> - return PTR_ERR(i2c_imx->clk);
> - }
> + if (IS_ERR(i2c_imx->clk))
> + return dev_err_probe(&pdev->dev, PTR_ERR(i2c_imx->clk),
> + "can't get I2C clock\n");
>
> ret = clk_prepare_enable(i2c_imx->clk);
> if (ret) {
> --
> 2.17.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 78+ messages in thread
* Re: [PATCH 6/9] i2c: imx: Simplify with dev_err_probe()
@ 2020-09-03 5:36 ` Oleksij Rempel
0 siblings, 0 replies; 78+ messages in thread
From: Oleksij Rempel @ 2020-09-03 5:36 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Heiko Stuebner, Sekhar Nori, Pierre-Yves MORDRET, linux-i2c,
Fabio Estevam, linux-stm32, Alexandre Torgue, Florian Fainelli,
linux-rockchip, Michal Simek, Bartosz Golaszewski,
bcm-kernel-feedback-list, NXP Linux Team,
Pengutronix Kernel Team, Ray Jui, Sascha Hauer, linux-rpi-kernel,
linux-arm-kernel, Scott Branden, linux-kernel, Oleksij Rempel,
Wolfram Sang, Maxime Coquelin, Shawn Guo, Peter Rosin,
Nicolas Saenz Julienne
On Wed, Sep 02, 2020 at 05:06:40PM +0200, Krzysztof Kozlowski wrote:
> Common pattern of handling deferred probe can be simplified with
> dev_err_probe(). Less code and the error value gets printed.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Acked-by: Oleksij Rempel <o.rempel@pengutronix.de>
> ---
> drivers/i2c/busses/i2c-imx.c | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c
> index 0ab5381aa012..63f4367c312b 100644
> --- a/drivers/i2c/busses/i2c-imx.c
> +++ b/drivers/i2c/busses/i2c-imx.c
> @@ -1159,11 +1159,9 @@ static int i2c_imx_probe(struct platform_device *pdev)
>
> /* Get I2C clock */
> i2c_imx->clk = devm_clk_get(&pdev->dev, NULL);
> - if (IS_ERR(i2c_imx->clk)) {
> - if (PTR_ERR(i2c_imx->clk) != -EPROBE_DEFER)
> - dev_err(&pdev->dev, "can't get I2C clock\n");
> - return PTR_ERR(i2c_imx->clk);
> - }
> + if (IS_ERR(i2c_imx->clk))
> + return dev_err_probe(&pdev->dev, PTR_ERR(i2c_imx->clk),
> + "can't get I2C clock\n");
>
> ret = clk_prepare_enable(i2c_imx->clk);
> if (ret) {
> --
> 2.17.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 78+ messages in thread
* Re: [PATCH 8/9] i2c: mux: gpmux: Simplify with dev_err_probe()
2020-09-02 15:06 ` Krzysztof Kozlowski
(?)
@ 2020-09-10 6:24 ` Wolfram Sang
-1 siblings, 0 replies; 78+ messages in thread
From: Wolfram Sang @ 2020-09-10 6:24 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Nicolas Saenz Julienne, Florian Fainelli, Ray Jui, Scott Branden,
bcm-kernel-feedback-list, Michal Simek, Sekhar Nori,
Bartosz Golaszewski, Oleksij Rempel, Pengutronix Kernel Team,
Shawn Guo, Sascha Hauer, Fabio Estevam, NXP Linux Team,
Heiko Stuebner, Pierre-Yves MORDRET, Maxime Coquelin,
Alexandre Torgue, Peter Rosin, linux-i2c, linux-rpi-kernel,
linux-arm-kernel, linux-kernel, linux-rockchip, linux-stm32
[-- Attachment #1: Type: text/plain, Size: 297 bytes --]
On Wed, Sep 02, 2020 at 05:06:42PM +0200, Krzysztof Kozlowski wrote:
> Common pattern of handling deferred probe can be simplified with
> dev_err_probe(). Less code and the error value gets printed.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Applied to for-next, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 78+ messages in thread
* Re: [PATCH 8/9] i2c: mux: gpmux: Simplify with dev_err_probe()
@ 2020-09-10 6:24 ` Wolfram Sang
0 siblings, 0 replies; 78+ messages in thread
From: Wolfram Sang @ 2020-09-10 6:24 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Heiko Stuebner, Sekhar Nori, Pierre-Yves MORDRET, linux-i2c,
Fabio Estevam, linux-stm32, Alexandre Torgue, Florian Fainelli,
linux-rockchip, Michal Simek, Bartosz Golaszewski,
bcm-kernel-feedback-list, NXP Linux Team,
Pengutronix Kernel Team, Ray Jui, Sascha Hauer, linux-rpi-kernel,
linux-arm-kernel, Scott Branden, linux-kernel, Oleksij Rempel,
Maxime Coquelin, Shawn Guo, Peter Rosin, Nicolas Saenz Julienne
[-- Attachment #1.1: Type: text/plain, Size: 297 bytes --]
On Wed, Sep 02, 2020 at 05:06:42PM +0200, Krzysztof Kozlowski wrote:
> Common pattern of handling deferred probe can be simplified with
> dev_err_probe(). Less code and the error value gets printed.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Applied to for-next, thanks!
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 170 bytes --]
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 78+ messages in thread
* Re: [PATCH 8/9] i2c: mux: gpmux: Simplify with dev_err_probe()
@ 2020-09-10 6:24 ` Wolfram Sang
0 siblings, 0 replies; 78+ messages in thread
From: Wolfram Sang @ 2020-09-10 6:24 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Heiko Stuebner, Sekhar Nori, Pierre-Yves MORDRET, linux-i2c,
Fabio Estevam, linux-stm32, Alexandre Torgue, Florian Fainelli,
linux-rockchip, Michal Simek, Bartosz Golaszewski,
bcm-kernel-feedback-list, NXP Linux Team,
Pengutronix Kernel Team, Ray Jui, Sascha Hauer, linux-rpi-kernel,
linux-arm-kernel, Scott Branden, linux-kernel, Oleksij Rempel,
Maxime Coquelin, Shawn Guo, Peter Rosin, Nicolas Saenz Julienne
[-- Attachment #1.1: Type: text/plain, Size: 297 bytes --]
On Wed, Sep 02, 2020 at 05:06:42PM +0200, Krzysztof Kozlowski wrote:
> Common pattern of handling deferred probe can be simplified with
> dev_err_probe(). Less code and the error value gets printed.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Applied to for-next, thanks!
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 78+ messages in thread
* Re: [PATCH 9/9] i2c: mux: reg: Simplify with dev_err_probe()
2020-09-02 15:06 ` Krzysztof Kozlowski
(?)
@ 2020-09-10 6:24 ` Wolfram Sang
-1 siblings, 0 replies; 78+ messages in thread
From: Wolfram Sang @ 2020-09-10 6:24 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Nicolas Saenz Julienne, Florian Fainelli, Ray Jui, Scott Branden,
bcm-kernel-feedback-list, Michal Simek, Sekhar Nori,
Bartosz Golaszewski, Oleksij Rempel, Pengutronix Kernel Team,
Shawn Guo, Sascha Hauer, Fabio Estevam, NXP Linux Team,
Heiko Stuebner, Pierre-Yves MORDRET, Maxime Coquelin,
Alexandre Torgue, Peter Rosin, linux-i2c, linux-rpi-kernel,
linux-arm-kernel, linux-kernel, linux-rockchip, linux-stm32
[-- Attachment #1: Type: text/plain, Size: 297 bytes --]
On Wed, Sep 02, 2020 at 05:06:43PM +0200, Krzysztof Kozlowski wrote:
> Common pattern of handling deferred probe can be simplified with
> dev_err_probe(). Less code and the error value gets printed.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Applied to for-next, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 78+ messages in thread
* Re: [PATCH 9/9] i2c: mux: reg: Simplify with dev_err_probe()
@ 2020-09-10 6:24 ` Wolfram Sang
0 siblings, 0 replies; 78+ messages in thread
From: Wolfram Sang @ 2020-09-10 6:24 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Heiko Stuebner, Sekhar Nori, Pierre-Yves MORDRET, linux-i2c,
Fabio Estevam, linux-stm32, Alexandre Torgue, Florian Fainelli,
linux-rockchip, Michal Simek, Bartosz Golaszewski,
bcm-kernel-feedback-list, NXP Linux Team,
Pengutronix Kernel Team, Ray Jui, Sascha Hauer, linux-rpi-kernel,
linux-arm-kernel, Scott Branden, linux-kernel, Oleksij Rempel,
Maxime Coquelin, Shawn Guo, Peter Rosin, Nicolas Saenz Julienne
[-- Attachment #1.1: Type: text/plain, Size: 297 bytes --]
On Wed, Sep 02, 2020 at 05:06:43PM +0200, Krzysztof Kozlowski wrote:
> Common pattern of handling deferred probe can be simplified with
> dev_err_probe(). Less code and the error value gets printed.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Applied to for-next, thanks!
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 170 bytes --]
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 78+ messages in thread
* Re: [PATCH 9/9] i2c: mux: reg: Simplify with dev_err_probe()
@ 2020-09-10 6:24 ` Wolfram Sang
0 siblings, 0 replies; 78+ messages in thread
From: Wolfram Sang @ 2020-09-10 6:24 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Heiko Stuebner, Sekhar Nori, Pierre-Yves MORDRET, linux-i2c,
Fabio Estevam, linux-stm32, Alexandre Torgue, Florian Fainelli,
linux-rockchip, Michal Simek, Bartosz Golaszewski,
bcm-kernel-feedback-list, NXP Linux Team,
Pengutronix Kernel Team, Ray Jui, Sascha Hauer, linux-rpi-kernel,
linux-arm-kernel, Scott Branden, linux-kernel, Oleksij Rempel,
Maxime Coquelin, Shawn Guo, Peter Rosin, Nicolas Saenz Julienne
[-- Attachment #1.1: Type: text/plain, Size: 297 bytes --]
On Wed, Sep 02, 2020 at 05:06:43PM +0200, Krzysztof Kozlowski wrote:
> Common pattern of handling deferred probe can be simplified with
> dev_err_probe(). Less code and the error value gets printed.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Applied to for-next, thanks!
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 78+ messages in thread
* Re: [PATCH 3/9] i2c: bcm2835: Simplify with dev_err_probe()
2020-09-02 15:06 ` Krzysztof Kozlowski
(?)
@ 2020-09-10 6:25 ` Wolfram Sang
-1 siblings, 0 replies; 78+ messages in thread
From: Wolfram Sang @ 2020-09-10 6:25 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Nicolas Saenz Julienne, Florian Fainelli, Ray Jui, Scott Branden,
bcm-kernel-feedback-list, Michal Simek, Sekhar Nori,
Bartosz Golaszewski, Oleksij Rempel, Pengutronix Kernel Team,
Shawn Guo, Sascha Hauer, Fabio Estevam, NXP Linux Team,
Heiko Stuebner, Pierre-Yves MORDRET, Maxime Coquelin,
Alexandre Torgue, Peter Rosin, linux-i2c, linux-rpi-kernel,
linux-arm-kernel, linux-kernel, linux-rockchip, linux-stm32
[-- Attachment #1: Type: text/plain, Size: 297 bytes --]
On Wed, Sep 02, 2020 at 05:06:37PM +0200, Krzysztof Kozlowski wrote:
> Common pattern of handling deferred probe can be simplified with
> dev_err_probe(). Less code and the error value gets printed.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Applied to for-next, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 78+ messages in thread
* Re: [PATCH 3/9] i2c: bcm2835: Simplify with dev_err_probe()
@ 2020-09-10 6:25 ` Wolfram Sang
0 siblings, 0 replies; 78+ messages in thread
From: Wolfram Sang @ 2020-09-10 6:25 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Heiko Stuebner, Sekhar Nori, Pierre-Yves MORDRET, linux-i2c,
Fabio Estevam, linux-stm32, Alexandre Torgue, Florian Fainelli,
linux-rockchip, Michal Simek, Bartosz Golaszewski,
bcm-kernel-feedback-list, NXP Linux Team,
Pengutronix Kernel Team, Ray Jui, Sascha Hauer, linux-rpi-kernel,
linux-arm-kernel, Scott Branden, linux-kernel, Oleksij Rempel,
Maxime Coquelin, Shawn Guo, Peter Rosin, Nicolas Saenz Julienne
[-- Attachment #1.1: Type: text/plain, Size: 297 bytes --]
On Wed, Sep 02, 2020 at 05:06:37PM +0200, Krzysztof Kozlowski wrote:
> Common pattern of handling deferred probe can be simplified with
> dev_err_probe(). Less code and the error value gets printed.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Applied to for-next, thanks!
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 170 bytes --]
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 78+ messages in thread
* Re: [PATCH 3/9] i2c: bcm2835: Simplify with dev_err_probe()
@ 2020-09-10 6:25 ` Wolfram Sang
0 siblings, 0 replies; 78+ messages in thread
From: Wolfram Sang @ 2020-09-10 6:25 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Heiko Stuebner, Sekhar Nori, Pierre-Yves MORDRET, linux-i2c,
Fabio Estevam, linux-stm32, Alexandre Torgue, Florian Fainelli,
linux-rockchip, Michal Simek, Bartosz Golaszewski,
bcm-kernel-feedback-list, NXP Linux Team,
Pengutronix Kernel Team, Ray Jui, Sascha Hauer, linux-rpi-kernel,
linux-arm-kernel, Scott Branden, linux-kernel, Oleksij Rempel,
Maxime Coquelin, Shawn Guo, Peter Rosin, Nicolas Saenz Julienne
[-- Attachment #1.1: Type: text/plain, Size: 297 bytes --]
On Wed, Sep 02, 2020 at 05:06:37PM +0200, Krzysztof Kozlowski wrote:
> Common pattern of handling deferred probe can be simplified with
> dev_err_probe(). Less code and the error value gets printed.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Applied to for-next, thanks!
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 78+ messages in thread
* Re: [PATCH 6/9] i2c: imx: Simplify with dev_err_probe()
2020-09-02 15:06 ` Krzysztof Kozlowski
(?)
@ 2020-09-10 6:27 ` Wolfram Sang
-1 siblings, 0 replies; 78+ messages in thread
From: Wolfram Sang @ 2020-09-10 6:27 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Nicolas Saenz Julienne, Florian Fainelli, Ray Jui, Scott Branden,
bcm-kernel-feedback-list, Michal Simek, Sekhar Nori,
Bartosz Golaszewski, Oleksij Rempel, Pengutronix Kernel Team,
Shawn Guo, Sascha Hauer, Fabio Estevam, NXP Linux Team,
Heiko Stuebner, Pierre-Yves MORDRET, Maxime Coquelin,
Alexandre Torgue, Peter Rosin, linux-i2c, linux-rpi-kernel,
linux-arm-kernel, linux-kernel, linux-rockchip, linux-stm32
[-- Attachment #1: Type: text/plain, Size: 419 bytes --]
On Wed, Sep 02, 2020 at 05:06:40PM +0200, Krzysztof Kozlowski wrote:
> Common pattern of handling deferred probe can be simplified with
> dev_err_probe(). Less code and the error value gets printed.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Thanks, but this patch was a bit earlier:
http://patchwork.ozlabs.org/project/linux-i2c/patch/1597203954-1803-1-git-send-email-Anson.Huang@nxp.com/
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 78+ messages in thread
* Re: [PATCH 6/9] i2c: imx: Simplify with dev_err_probe()
@ 2020-09-10 6:27 ` Wolfram Sang
0 siblings, 0 replies; 78+ messages in thread
From: Wolfram Sang @ 2020-09-10 6:27 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Heiko Stuebner, Sekhar Nori, Pierre-Yves MORDRET, linux-i2c,
Fabio Estevam, linux-stm32, Alexandre Torgue, Florian Fainelli,
linux-rockchip, Michal Simek, Bartosz Golaszewski,
bcm-kernel-feedback-list, NXP Linux Team,
Pengutronix Kernel Team, Ray Jui, Sascha Hauer, linux-rpi-kernel,
linux-arm-kernel, Scott Branden, linux-kernel, Oleksij Rempel,
Maxime Coquelin, Shawn Guo, Peter Rosin, Nicolas Saenz Julienne
[-- Attachment #1.1: Type: text/plain, Size: 419 bytes --]
On Wed, Sep 02, 2020 at 05:06:40PM +0200, Krzysztof Kozlowski wrote:
> Common pattern of handling deferred probe can be simplified with
> dev_err_probe(). Less code and the error value gets printed.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Thanks, but this patch was a bit earlier:
http://patchwork.ozlabs.org/project/linux-i2c/patch/1597203954-1803-1-git-send-email-Anson.Huang@nxp.com/
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 170 bytes --]
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 78+ messages in thread
* Re: [PATCH 6/9] i2c: imx: Simplify with dev_err_probe()
@ 2020-09-10 6:27 ` Wolfram Sang
0 siblings, 0 replies; 78+ messages in thread
From: Wolfram Sang @ 2020-09-10 6:27 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Heiko Stuebner, Sekhar Nori, Pierre-Yves MORDRET, linux-i2c,
Fabio Estevam, linux-stm32, Alexandre Torgue, Florian Fainelli,
linux-rockchip, Michal Simek, Bartosz Golaszewski,
bcm-kernel-feedback-list, NXP Linux Team,
Pengutronix Kernel Team, Ray Jui, Sascha Hauer, linux-rpi-kernel,
linux-arm-kernel, Scott Branden, linux-kernel, Oleksij Rempel,
Maxime Coquelin, Shawn Guo, Peter Rosin, Nicolas Saenz Julienne
[-- Attachment #1.1: Type: text/plain, Size: 419 bytes --]
On Wed, Sep 02, 2020 at 05:06:40PM +0200, Krzysztof Kozlowski wrote:
> Common pattern of handling deferred probe can be simplified with
> dev_err_probe(). Less code and the error value gets printed.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Thanks, but this patch was a bit earlier:
http://patchwork.ozlabs.org/project/linux-i2c/patch/1597203954-1803-1-git-send-email-Anson.Huang@nxp.com/
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 78+ messages in thread
* Re: [PATCH 1/9] i2c: stm32: Simplify with dev_err_probe()
2020-09-02 15:06 ` Krzysztof Kozlowski
(?)
@ 2020-09-10 9:36 ` Alain Volmat
-1 siblings, 0 replies; 78+ messages in thread
From: Alain Volmat @ 2020-09-10 9:36 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Nicolas Saenz Julienne, Florian Fainelli, Ray Jui, Scott Branden,
bcm-kernel-feedback-list, Michal Simek, Sekhar Nori,
Bartosz Golaszewski, Oleksij Rempel, Pengutronix Kernel Team,
Shawn Guo, Sascha Hauer, Fabio Estevam, NXP Linux Team,
Heiko Stuebner, Pierre-Yves MORDRET, Maxime Coquelin,
Alexandre Torgue, Peter Rosin, Wolfram Sang, linux-i2c,
linux-rpi-kernel, linux-arm-kernel, linux-kernel, linux-rockchip,
linux-stm32
Hi,
On Wed, Sep 02, 2020 at 05:06:35PM +0200, Krzysztof Kozlowski wrote:
> Common pattern of handling deferred probe can be simplified with
> dev_err_probe(). Less code and the error value gets printed.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Reviewed-by: Alain Volmat <alain.volmat@st.com>
> ---
> drivers/i2c/busses/i2c-stm32.c | 11 ++++-------
> drivers/i2c/busses/i2c-stm32f4.c | 6 ++----
> drivers/i2c/busses/i2c-stm32f7.c | 24 +++++++++---------------
> 3 files changed, 15 insertions(+), 26 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-stm32.c b/drivers/i2c/busses/i2c-stm32.c
> index 3f69a3bb6119..198f848b7be9 100644
> --- a/drivers/i2c/busses/i2c-stm32.c
> +++ b/drivers/i2c/busses/i2c-stm32.c
> @@ -25,9 +25,8 @@ struct stm32_i2c_dma *stm32_i2c_dma_request(struct device *dev,
> /* Request and configure I2C TX dma channel */
> dma->chan_tx = dma_request_chan(dev, "tx");
> if (IS_ERR(dma->chan_tx)) {
> - ret = PTR_ERR(dma->chan_tx);
> - if (ret != -EPROBE_DEFER)
> - dev_err(dev, "can't request DMA tx channel\n");
> + ret = dev_err_probe(dev, PTR_ERR(dma->chan_tx),
> + "can't request DMA tx channel\n");
> goto fail_al;
> }
>
> @@ -45,10 +44,8 @@ struct stm32_i2c_dma *stm32_i2c_dma_request(struct device *dev,
> /* Request and configure I2C RX dma channel */
> dma->chan_rx = dma_request_chan(dev, "rx");
> if (IS_ERR(dma->chan_rx)) {
> - ret = PTR_ERR(dma->chan_rx);
> - if (ret != -EPROBE_DEFER)
> - dev_err(dev, "can't request DMA rx channel\n");
> -
> + ret = dev_err_probe(dev, PTR_ERR(dma->chan_rx),
> + "can't request DMA rx channel\n");
> goto fail_tx;
> }
>
> diff --git a/drivers/i2c/busses/i2c-stm32f4.c b/drivers/i2c/busses/i2c-stm32f4.c
> index 48e269284369..937c2c8fd349 100644
> --- a/drivers/i2c/busses/i2c-stm32f4.c
> +++ b/drivers/i2c/busses/i2c-stm32f4.c
> @@ -797,10 +797,8 @@ static int stm32f4_i2c_probe(struct platform_device *pdev)
>
> rst = devm_reset_control_get_exclusive(&pdev->dev, NULL);
> if (IS_ERR(rst)) {
> - ret = PTR_ERR(rst);
> - if (ret != -EPROBE_DEFER)
> - dev_err(&pdev->dev, "Error: Missing reset ctrl\n");
> -
> + ret = dev_err_probe(&pdev->dev, PTR_ERR(rst),
> + "Error: Missing reset ctrl\n");
> goto clk_free;
> }
> reset_control_assert(rst);
> diff --git a/drivers/i2c/busses/i2c-stm32f7.c b/drivers/i2c/busses/i2c-stm32f7.c
> index bff3479fe122..a8f1758e4c5b 100644
> --- a/drivers/i2c/busses/i2c-stm32f7.c
> +++ b/drivers/i2c/busses/i2c-stm32f7.c
> @@ -1968,11 +1968,9 @@ static int stm32f7_i2c_probe(struct platform_device *pdev)
> "wakeup-source");
>
> i2c_dev->clk = devm_clk_get(&pdev->dev, NULL);
> - if (IS_ERR(i2c_dev->clk)) {
> - if (PTR_ERR(i2c_dev->clk) != -EPROBE_DEFER)
> - dev_err(&pdev->dev, "Failed to get controller clock\n");
> - return PTR_ERR(i2c_dev->clk);
> - }
> + if (IS_ERR(i2c_dev->clk))
> + return dev_err_probe(&pdev->dev, PTR_ERR(i2c_dev->clk),
> + "Failed to get controller clock\n");
>
> ret = clk_prepare_enable(i2c_dev->clk);
> if (ret) {
> @@ -1982,10 +1980,8 @@ static int stm32f7_i2c_probe(struct platform_device *pdev)
>
> rst = devm_reset_control_get(&pdev->dev, NULL);
> if (IS_ERR(rst)) {
> - ret = PTR_ERR(rst);
> - if (ret != -EPROBE_DEFER)
> - dev_err(&pdev->dev, "Error: Missing reset ctrl\n");
> -
> + ret = dev_err_probe(&pdev->dev, PTR_ERR(rst),
> + "Error: Missing reset ctrl\n");
> goto clk_free;
> }
> reset_control_assert(rst);
> @@ -2052,13 +2048,11 @@ static int stm32f7_i2c_probe(struct platform_device *pdev)
> i2c_dev->dma = stm32_i2c_dma_request(i2c_dev->dev, phy_addr,
> STM32F7_I2C_TXDR,
> STM32F7_I2C_RXDR);
> - if (PTR_ERR(i2c_dev->dma) == -ENODEV)
> + if (PTR_ERR(i2c_dev->dma) == -ENODEV) {
> i2c_dev->dma = NULL;
> - else if (IS_ERR(i2c_dev->dma)) {
> - ret = PTR_ERR(i2c_dev->dma);
> - if (ret != -EPROBE_DEFER)
> - dev_err(&pdev->dev,
> - "Failed to request dma error %i\n", ret);
> + } else if (IS_ERR(i2c_dev->dma)) {
> + ret = dev_err_probe(&pdev->dev, PTR_ERR(i2c_dev->dma),
> + "Failed to request dma error\n");
> goto fmp_clear;
> }
>
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 78+ messages in thread
* Re: [PATCH 1/9] i2c: stm32: Simplify with dev_err_probe()
@ 2020-09-10 9:36 ` Alain Volmat
0 siblings, 0 replies; 78+ messages in thread
From: Alain Volmat @ 2020-09-10 9:36 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Heiko Stuebner, Sekhar Nori, Pierre-Yves MORDRET, linux-i2c,
Fabio Estevam, linux-stm32, Alexandre Torgue, Florian Fainelli,
linux-rockchip, Michal Simek, Bartosz Golaszewski,
bcm-kernel-feedback-list, NXP Linux Team,
Pengutronix Kernel Team, Ray Jui, Sascha Hauer, linux-rpi-kernel,
linux-arm-kernel, Scott Branden, linux-kernel, Oleksij Rempel,
Wolfram Sang, Maxime Coquelin, Shawn Guo, Peter Rosin,
Nicolas Saenz Julienne
Hi,
On Wed, Sep 02, 2020 at 05:06:35PM +0200, Krzysztof Kozlowski wrote:
> Common pattern of handling deferred probe can be simplified with
> dev_err_probe(). Less code and the error value gets printed.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Reviewed-by: Alain Volmat <alain.volmat@st.com>
> ---
> drivers/i2c/busses/i2c-stm32.c | 11 ++++-------
> drivers/i2c/busses/i2c-stm32f4.c | 6 ++----
> drivers/i2c/busses/i2c-stm32f7.c | 24 +++++++++---------------
> 3 files changed, 15 insertions(+), 26 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-stm32.c b/drivers/i2c/busses/i2c-stm32.c
> index 3f69a3bb6119..198f848b7be9 100644
> --- a/drivers/i2c/busses/i2c-stm32.c
> +++ b/drivers/i2c/busses/i2c-stm32.c
> @@ -25,9 +25,8 @@ struct stm32_i2c_dma *stm32_i2c_dma_request(struct device *dev,
> /* Request and configure I2C TX dma channel */
> dma->chan_tx = dma_request_chan(dev, "tx");
> if (IS_ERR(dma->chan_tx)) {
> - ret = PTR_ERR(dma->chan_tx);
> - if (ret != -EPROBE_DEFER)
> - dev_err(dev, "can't request DMA tx channel\n");
> + ret = dev_err_probe(dev, PTR_ERR(dma->chan_tx),
> + "can't request DMA tx channel\n");
> goto fail_al;
> }
>
> @@ -45,10 +44,8 @@ struct stm32_i2c_dma *stm32_i2c_dma_request(struct device *dev,
> /* Request and configure I2C RX dma channel */
> dma->chan_rx = dma_request_chan(dev, "rx");
> if (IS_ERR(dma->chan_rx)) {
> - ret = PTR_ERR(dma->chan_rx);
> - if (ret != -EPROBE_DEFER)
> - dev_err(dev, "can't request DMA rx channel\n");
> -
> + ret = dev_err_probe(dev, PTR_ERR(dma->chan_rx),
> + "can't request DMA rx channel\n");
> goto fail_tx;
> }
>
> diff --git a/drivers/i2c/busses/i2c-stm32f4.c b/drivers/i2c/busses/i2c-stm32f4.c
> index 48e269284369..937c2c8fd349 100644
> --- a/drivers/i2c/busses/i2c-stm32f4.c
> +++ b/drivers/i2c/busses/i2c-stm32f4.c
> @@ -797,10 +797,8 @@ static int stm32f4_i2c_probe(struct platform_device *pdev)
>
> rst = devm_reset_control_get_exclusive(&pdev->dev, NULL);
> if (IS_ERR(rst)) {
> - ret = PTR_ERR(rst);
> - if (ret != -EPROBE_DEFER)
> - dev_err(&pdev->dev, "Error: Missing reset ctrl\n");
> -
> + ret = dev_err_probe(&pdev->dev, PTR_ERR(rst),
> + "Error: Missing reset ctrl\n");
> goto clk_free;
> }
> reset_control_assert(rst);
> diff --git a/drivers/i2c/busses/i2c-stm32f7.c b/drivers/i2c/busses/i2c-stm32f7.c
> index bff3479fe122..a8f1758e4c5b 100644
> --- a/drivers/i2c/busses/i2c-stm32f7.c
> +++ b/drivers/i2c/busses/i2c-stm32f7.c
> @@ -1968,11 +1968,9 @@ static int stm32f7_i2c_probe(struct platform_device *pdev)
> "wakeup-source");
>
> i2c_dev->clk = devm_clk_get(&pdev->dev, NULL);
> - if (IS_ERR(i2c_dev->clk)) {
> - if (PTR_ERR(i2c_dev->clk) != -EPROBE_DEFER)
> - dev_err(&pdev->dev, "Failed to get controller clock\n");
> - return PTR_ERR(i2c_dev->clk);
> - }
> + if (IS_ERR(i2c_dev->clk))
> + return dev_err_probe(&pdev->dev, PTR_ERR(i2c_dev->clk),
> + "Failed to get controller clock\n");
>
> ret = clk_prepare_enable(i2c_dev->clk);
> if (ret) {
> @@ -1982,10 +1980,8 @@ static int stm32f7_i2c_probe(struct platform_device *pdev)
>
> rst = devm_reset_control_get(&pdev->dev, NULL);
> if (IS_ERR(rst)) {
> - ret = PTR_ERR(rst);
> - if (ret != -EPROBE_DEFER)
> - dev_err(&pdev->dev, "Error: Missing reset ctrl\n");
> -
> + ret = dev_err_probe(&pdev->dev, PTR_ERR(rst),
> + "Error: Missing reset ctrl\n");
> goto clk_free;
> }
> reset_control_assert(rst);
> @@ -2052,13 +2048,11 @@ static int stm32f7_i2c_probe(struct platform_device *pdev)
> i2c_dev->dma = stm32_i2c_dma_request(i2c_dev->dev, phy_addr,
> STM32F7_I2C_TXDR,
> STM32F7_I2C_RXDR);
> - if (PTR_ERR(i2c_dev->dma) == -ENODEV)
> + if (PTR_ERR(i2c_dev->dma) == -ENODEV) {
> i2c_dev->dma = NULL;
> - else if (IS_ERR(i2c_dev->dma)) {
> - ret = PTR_ERR(i2c_dev->dma);
> - if (ret != -EPROBE_DEFER)
> - dev_err(&pdev->dev,
> - "Failed to request dma error %i\n", ret);
> + } else if (IS_ERR(i2c_dev->dma)) {
> + ret = dev_err_probe(&pdev->dev, PTR_ERR(i2c_dev->dma),
> + "Failed to request dma error\n");
> goto fmp_clear;
> }
>
> --
> 2.17.1
>
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 78+ messages in thread
* Re: [PATCH 1/9] i2c: stm32: Simplify with dev_err_probe()
@ 2020-09-10 9:36 ` Alain Volmat
0 siblings, 0 replies; 78+ messages in thread
From: Alain Volmat @ 2020-09-10 9:36 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Heiko Stuebner, Sekhar Nori, Pierre-Yves MORDRET, linux-i2c,
Fabio Estevam, linux-stm32, Alexandre Torgue, Florian Fainelli,
linux-rockchip, Michal Simek, Bartosz Golaszewski,
bcm-kernel-feedback-list, NXP Linux Team,
Pengutronix Kernel Team, Ray Jui, Sascha Hauer, linux-rpi-kernel,
linux-arm-kernel, Scott Branden, linux-kernel, Oleksij Rempel,
Wolfram Sang, Maxime Coquelin, Shawn Guo, Peter Rosin,
Nicolas Saenz Julienne
Hi,
On Wed, Sep 02, 2020 at 05:06:35PM +0200, Krzysztof Kozlowski wrote:
> Common pattern of handling deferred probe can be simplified with
> dev_err_probe(). Less code and the error value gets printed.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Reviewed-by: Alain Volmat <alain.volmat@st.com>
> ---
> drivers/i2c/busses/i2c-stm32.c | 11 ++++-------
> drivers/i2c/busses/i2c-stm32f4.c | 6 ++----
> drivers/i2c/busses/i2c-stm32f7.c | 24 +++++++++---------------
> 3 files changed, 15 insertions(+), 26 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-stm32.c b/drivers/i2c/busses/i2c-stm32.c
> index 3f69a3bb6119..198f848b7be9 100644
> --- a/drivers/i2c/busses/i2c-stm32.c
> +++ b/drivers/i2c/busses/i2c-stm32.c
> @@ -25,9 +25,8 @@ struct stm32_i2c_dma *stm32_i2c_dma_request(struct device *dev,
> /* Request and configure I2C TX dma channel */
> dma->chan_tx = dma_request_chan(dev, "tx");
> if (IS_ERR(dma->chan_tx)) {
> - ret = PTR_ERR(dma->chan_tx);
> - if (ret != -EPROBE_DEFER)
> - dev_err(dev, "can't request DMA tx channel\n");
> + ret = dev_err_probe(dev, PTR_ERR(dma->chan_tx),
> + "can't request DMA tx channel\n");
> goto fail_al;
> }
>
> @@ -45,10 +44,8 @@ struct stm32_i2c_dma *stm32_i2c_dma_request(struct device *dev,
> /* Request and configure I2C RX dma channel */
> dma->chan_rx = dma_request_chan(dev, "rx");
> if (IS_ERR(dma->chan_rx)) {
> - ret = PTR_ERR(dma->chan_rx);
> - if (ret != -EPROBE_DEFER)
> - dev_err(dev, "can't request DMA rx channel\n");
> -
> + ret = dev_err_probe(dev, PTR_ERR(dma->chan_rx),
> + "can't request DMA rx channel\n");
> goto fail_tx;
> }
>
> diff --git a/drivers/i2c/busses/i2c-stm32f4.c b/drivers/i2c/busses/i2c-stm32f4.c
> index 48e269284369..937c2c8fd349 100644
> --- a/drivers/i2c/busses/i2c-stm32f4.c
> +++ b/drivers/i2c/busses/i2c-stm32f4.c
> @@ -797,10 +797,8 @@ static int stm32f4_i2c_probe(struct platform_device *pdev)
>
> rst = devm_reset_control_get_exclusive(&pdev->dev, NULL);
> if (IS_ERR(rst)) {
> - ret = PTR_ERR(rst);
> - if (ret != -EPROBE_DEFER)
> - dev_err(&pdev->dev, "Error: Missing reset ctrl\n");
> -
> + ret = dev_err_probe(&pdev->dev, PTR_ERR(rst),
> + "Error: Missing reset ctrl\n");
> goto clk_free;
> }
> reset_control_assert(rst);
> diff --git a/drivers/i2c/busses/i2c-stm32f7.c b/drivers/i2c/busses/i2c-stm32f7.c
> index bff3479fe122..a8f1758e4c5b 100644
> --- a/drivers/i2c/busses/i2c-stm32f7.c
> +++ b/drivers/i2c/busses/i2c-stm32f7.c
> @@ -1968,11 +1968,9 @@ static int stm32f7_i2c_probe(struct platform_device *pdev)
> "wakeup-source");
>
> i2c_dev->clk = devm_clk_get(&pdev->dev, NULL);
> - if (IS_ERR(i2c_dev->clk)) {
> - if (PTR_ERR(i2c_dev->clk) != -EPROBE_DEFER)
> - dev_err(&pdev->dev, "Failed to get controller clock\n");
> - return PTR_ERR(i2c_dev->clk);
> - }
> + if (IS_ERR(i2c_dev->clk))
> + return dev_err_probe(&pdev->dev, PTR_ERR(i2c_dev->clk),
> + "Failed to get controller clock\n");
>
> ret = clk_prepare_enable(i2c_dev->clk);
> if (ret) {
> @@ -1982,10 +1980,8 @@ static int stm32f7_i2c_probe(struct platform_device *pdev)
>
> rst = devm_reset_control_get(&pdev->dev, NULL);
> if (IS_ERR(rst)) {
> - ret = PTR_ERR(rst);
> - if (ret != -EPROBE_DEFER)
> - dev_err(&pdev->dev, "Error: Missing reset ctrl\n");
> -
> + ret = dev_err_probe(&pdev->dev, PTR_ERR(rst),
> + "Error: Missing reset ctrl\n");
> goto clk_free;
> }
> reset_control_assert(rst);
> @@ -2052,13 +2048,11 @@ static int stm32f7_i2c_probe(struct platform_device *pdev)
> i2c_dev->dma = stm32_i2c_dma_request(i2c_dev->dev, phy_addr,
> STM32F7_I2C_TXDR,
> STM32F7_I2C_RXDR);
> - if (PTR_ERR(i2c_dev->dma) == -ENODEV)
> + if (PTR_ERR(i2c_dev->dma) == -ENODEV) {
> i2c_dev->dma = NULL;
> - else if (IS_ERR(i2c_dev->dma)) {
> - ret = PTR_ERR(i2c_dev->dma);
> - if (ret != -EPROBE_DEFER)
> - dev_err(&pdev->dev,
> - "Failed to request dma error %i\n", ret);
> + } else if (IS_ERR(i2c_dev->dma)) {
> + ret = dev_err_probe(&pdev->dev, PTR_ERR(i2c_dev->dma),
> + "Failed to request dma error\n");
> goto fmp_clear;
> }
>
> --
> 2.17.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 78+ messages in thread
* Re: [PATCH 7/9] i2c: rk3x: Simplify with dev_err_probe()
2020-09-02 15:06 ` Krzysztof Kozlowski
(?)
@ 2020-09-22 14:25 ` Heiko Stübner
-1 siblings, 0 replies; 78+ messages in thread
From: Heiko Stübner @ 2020-09-22 14:25 UTC (permalink / raw)
To: Nicolas Saenz Julienne, Florian Fainelli, Ray Jui, Scott Branden,
bcm-kernel-feedback-list, Michal Simek, Sekhar Nori,
Pengutronix Kernel Team, Shawn Guo, Sascha Hauer, Fabio Estevam,
NXP Linux Team, Wolfram Sang, linux-i2c, linux-rpi-kernel,
linux-arm-kernel, linux-kernel, linux-rockchip,
Krzysztof Kozlowski
Am Mittwoch, 2. September 2020, 17:06:41 CEST schrieb Krzysztof Kozlowski:
> Common pattern of handling deferred probe can be simplified with
> dev_err_probe(). Less code and the error value gets printed.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
^ permalink raw reply [flat|nested] 78+ messages in thread
* Re: [PATCH 7/9] i2c: rk3x: Simplify with dev_err_probe()
@ 2020-09-22 14:25 ` Heiko Stübner
0 siblings, 0 replies; 78+ messages in thread
From: Heiko Stübner @ 2020-09-22 14:25 UTC (permalink / raw)
To: Nicolas Saenz Julienne, Florian Fainelli, Ray Jui, Scott Branden,
bcm-kernel-feedback-list, Michal Simek, Sekhar Nori,
Pengutronix Kernel Team, Shawn Guo, Sascha Hauer, Fabio Estevam,
NXP Linux Team, Wolfram Sang, linux-i2c, linux-rpi-kernel,
linux-arm-kernel, linux-kernel, linux-rockchip,
Krzysztof Kozlowski
Am Mittwoch, 2. September 2020, 17:06:41 CEST schrieb Krzysztof Kozlowski:
> Common pattern of handling deferred probe can be simplified with
> dev_err_probe(). Less code and the error value gets printed.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 78+ messages in thread
* Re: [PATCH 7/9] i2c: rk3x: Simplify with dev_err_probe()
@ 2020-09-22 14:25 ` Heiko Stübner
0 siblings, 0 replies; 78+ messages in thread
From: Heiko Stübner @ 2020-09-22 14:25 UTC (permalink / raw)
To: Nicolas Saenz Julienne, Florian Fainelli, Ray Jui, Scott Branden,
bcm-kernel-feedback-list, Michal Simek, Sekhar Nori,
Pengutronix Kernel Team, Shawn Guo, Sascha Hauer, Fabio Estevam,
NXP Linux Team, Wolfram Sang, linux-i2c, linux-rpi-kernel,
linux-arm-kernel, linux-kernel, linux-rockchip,
Krzysztof Kozlowski
Am Mittwoch, 2. September 2020, 17:06:41 CEST schrieb Krzysztof Kozlowski:
> Common pattern of handling deferred probe can be simplified with
> dev_err_probe(). Less code and the error value gets printed.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 78+ messages in thread
* Re: [PATCH 7/9] i2c: rk3x: Simplify with dev_err_probe()
2020-09-02 15:06 ` Krzysztof Kozlowski
(?)
@ 2020-09-27 18:01 ` Wolfram Sang
-1 siblings, 0 replies; 78+ messages in thread
From: Wolfram Sang @ 2020-09-27 18:01 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Nicolas Saenz Julienne, Florian Fainelli, Ray Jui, Scott Branden,
bcm-kernel-feedback-list, Michal Simek, Sekhar Nori,
Bartosz Golaszewski, Oleksij Rempel, Pengutronix Kernel Team,
Shawn Guo, Sascha Hauer, Fabio Estevam, NXP Linux Team,
Heiko Stuebner, Pierre-Yves MORDRET, Maxime Coquelin,
Alexandre Torgue, Peter Rosin, linux-i2c, linux-rpi-kernel,
linux-arm-kernel, linux-kernel, linux-rockchip, linux-stm32
[-- Attachment #1: Type: text/plain, Size: 297 bytes --]
On Wed, Sep 02, 2020 at 05:06:41PM +0200, Krzysztof Kozlowski wrote:
> Common pattern of handling deferred probe can be simplified with
> dev_err_probe(). Less code and the error value gets printed.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Applied to for-next, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 78+ messages in thread
* Re: [PATCH 7/9] i2c: rk3x: Simplify with dev_err_probe()
@ 2020-09-27 18:01 ` Wolfram Sang
0 siblings, 0 replies; 78+ messages in thread
From: Wolfram Sang @ 2020-09-27 18:01 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Heiko Stuebner, Sekhar Nori, Pierre-Yves MORDRET, linux-i2c,
Fabio Estevam, linux-stm32, Alexandre Torgue, Florian Fainelli,
linux-rockchip, Michal Simek, Bartosz Golaszewski,
bcm-kernel-feedback-list, NXP Linux Team,
Pengutronix Kernel Team, Ray Jui, Sascha Hauer, linux-rpi-kernel,
linux-arm-kernel, Scott Branden, linux-kernel, Oleksij Rempel,
Maxime Coquelin, Shawn Guo, Peter Rosin, Nicolas Saenz Julienne
[-- Attachment #1.1: Type: text/plain, Size: 297 bytes --]
On Wed, Sep 02, 2020 at 05:06:41PM +0200, Krzysztof Kozlowski wrote:
> Common pattern of handling deferred probe can be simplified with
> dev_err_probe(). Less code and the error value gets printed.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Applied to for-next, thanks!
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 170 bytes --]
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 78+ messages in thread
* Re: [PATCH 7/9] i2c: rk3x: Simplify with dev_err_probe()
@ 2020-09-27 18:01 ` Wolfram Sang
0 siblings, 0 replies; 78+ messages in thread
From: Wolfram Sang @ 2020-09-27 18:01 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Heiko Stuebner, Sekhar Nori, Pierre-Yves MORDRET, linux-i2c,
Fabio Estevam, linux-stm32, Alexandre Torgue, Florian Fainelli,
linux-rockchip, Michal Simek, Bartosz Golaszewski,
bcm-kernel-feedback-list, NXP Linux Team,
Pengutronix Kernel Team, Ray Jui, Sascha Hauer, linux-rpi-kernel,
linux-arm-kernel, Scott Branden, linux-kernel, Oleksij Rempel,
Maxime Coquelin, Shawn Guo, Peter Rosin, Nicolas Saenz Julienne
[-- Attachment #1.1: Type: text/plain, Size: 297 bytes --]
On Wed, Sep 02, 2020 at 05:06:41PM +0200, Krzysztof Kozlowski wrote:
> Common pattern of handling deferred probe can be simplified with
> dev_err_probe(). Less code and the error value gets printed.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Applied to for-next, thanks!
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 78+ messages in thread
* Re: [PATCH 2/9] i2c: xiic: Simplify with dev_err_probe()
2020-09-02 15:06 ` Krzysztof Kozlowski
(?)
@ 2021-06-23 8:57 ` Michal Simek
-1 siblings, 0 replies; 78+ messages in thread
From: Michal Simek @ 2021-06-23 8:57 UTC (permalink / raw)
To: Krzysztof Kozlowski, Wolfram Sang
Cc: Nicolas Saenz Julienne, Florian Fainelli, Ray Jui, Scott Branden,
bcm-kernel-feedback-list, Sekhar Nori, Bartosz Golaszewski,
Oleksij Rempel, Pengutronix Kernel Team, Shawn Guo, Sascha Hauer,
Fabio Estevam, NXP Linux Team, Heiko Stuebner,
Pierre-Yves MORDRET, Maxime Coquelin, Alexandre Torgue,
Peter Rosin, Wolfram Sang, linux-i2c, linux-rpi-kernel,
linux-arm, LKML, linux-rockchip, linux-stm32
st 2. 9. 2020 v 17:10 odesílatel Krzysztof Kozlowski <krzk@kernel.org> napsal:
>
> Common pattern of handling deferred probe can be simplified with
> dev_err_probe(). Less code and the error value gets printed.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
> drivers/i2c/busses/i2c-xiic.c | 9 ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-xiic.c b/drivers/i2c/busses/i2c-xiic.c
> index 90c1c362394d..a97438f35c5d 100644
> --- a/drivers/i2c/busses/i2c-xiic.c
> +++ b/drivers/i2c/busses/i2c-xiic.c
> @@ -787,11 +787,10 @@ static int xiic_i2c_probe(struct platform_device *pdev)
> init_waitqueue_head(&i2c->wait);
>
> i2c->clk = devm_clk_get(&pdev->dev, NULL);
> - if (IS_ERR(i2c->clk)) {
> - if (PTR_ERR(i2c->clk) != -EPROBE_DEFER)
> - dev_err(&pdev->dev, "input clock not found.\n");
> - return PTR_ERR(i2c->clk);
> - }
> + if (IS_ERR(i2c->clk))
> + return dev_err_probe(&pdev->dev, PTR_ERR(i2c->clk),
> + "input clock not found.\n");
> +
> ret = clk_prepare_enable(i2c->clk);
> if (ret) {
> dev_err(&pdev->dev, "Unable to enable clock.\n");
> --
> 2.17.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
I see that this didn't go through.
Acked-by: Michal Simek <michal.simek@xilinx.com>
Wolfram: Can you please apply?
Thanks,
Michal
--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Xilinx Microblaze
Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs
U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP/Versal SoCs
^ permalink raw reply [flat|nested] 78+ messages in thread
* Re: [PATCH 2/9] i2c: xiic: Simplify with dev_err_probe()
@ 2021-06-23 8:57 ` Michal Simek
0 siblings, 0 replies; 78+ messages in thread
From: Michal Simek @ 2021-06-23 8:57 UTC (permalink / raw)
To: Krzysztof Kozlowski, Wolfram Sang
Cc: Nicolas Saenz Julienne, Florian Fainelli, Ray Jui, Scott Branden,
bcm-kernel-feedback-list, Sekhar Nori, Bartosz Golaszewski,
Oleksij Rempel, Pengutronix Kernel Team, Shawn Guo, Sascha Hauer,
Fabio Estevam, NXP Linux Team, Heiko Stuebner,
Pierre-Yves MORDRET, Maxime Coquelin, Alexandre Torgue,
Peter Rosin, Wolfram Sang, linux-i2c, linux-rpi-kernel,
linux-arm, LKML, linux-rockchip, linux-stm32
st 2. 9. 2020 v 17:10 odesílatel Krzysztof Kozlowski <krzk@kernel.org> napsal:
>
> Common pattern of handling deferred probe can be simplified with
> dev_err_probe(). Less code and the error value gets printed.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
> drivers/i2c/busses/i2c-xiic.c | 9 ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-xiic.c b/drivers/i2c/busses/i2c-xiic.c
> index 90c1c362394d..a97438f35c5d 100644
> --- a/drivers/i2c/busses/i2c-xiic.c
> +++ b/drivers/i2c/busses/i2c-xiic.c
> @@ -787,11 +787,10 @@ static int xiic_i2c_probe(struct platform_device *pdev)
> init_waitqueue_head(&i2c->wait);
>
> i2c->clk = devm_clk_get(&pdev->dev, NULL);
> - if (IS_ERR(i2c->clk)) {
> - if (PTR_ERR(i2c->clk) != -EPROBE_DEFER)
> - dev_err(&pdev->dev, "input clock not found.\n");
> - return PTR_ERR(i2c->clk);
> - }
> + if (IS_ERR(i2c->clk))
> + return dev_err_probe(&pdev->dev, PTR_ERR(i2c->clk),
> + "input clock not found.\n");
> +
> ret = clk_prepare_enable(i2c->clk);
> if (ret) {
> dev_err(&pdev->dev, "Unable to enable clock.\n");
> --
> 2.17.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
I see that this didn't go through.
Acked-by: Michal Simek <michal.simek@xilinx.com>
Wolfram: Can you please apply?
Thanks,
Michal
--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Xilinx Microblaze
Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs
U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP/Versal SoCs
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 78+ messages in thread
* Re: [PATCH 2/9] i2c: xiic: Simplify with dev_err_probe()
@ 2021-06-23 8:57 ` Michal Simek
0 siblings, 0 replies; 78+ messages in thread
From: Michal Simek @ 2021-06-23 8:57 UTC (permalink / raw)
To: Krzysztof Kozlowski, Wolfram Sang
Cc: Nicolas Saenz Julienne, Florian Fainelli, Ray Jui, Scott Branden,
bcm-kernel-feedback-list, Sekhar Nori, Bartosz Golaszewski,
Oleksij Rempel, Pengutronix Kernel Team, Shawn Guo, Sascha Hauer,
Fabio Estevam, NXP Linux Team, Heiko Stuebner,
Pierre-Yves MORDRET, Maxime Coquelin, Alexandre Torgue,
Peter Rosin, Wolfram Sang, linux-i2c, linux-rpi-kernel,
linux-arm, LKML, linux-rockchip, linux-stm32
st 2. 9. 2020 v 17:10 odesílatel Krzysztof Kozlowski <krzk@kernel.org> napsal:
>
> Common pattern of handling deferred probe can be simplified with
> dev_err_probe(). Less code and the error value gets printed.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
> drivers/i2c/busses/i2c-xiic.c | 9 ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-xiic.c b/drivers/i2c/busses/i2c-xiic.c
> index 90c1c362394d..a97438f35c5d 100644
> --- a/drivers/i2c/busses/i2c-xiic.c
> +++ b/drivers/i2c/busses/i2c-xiic.c
> @@ -787,11 +787,10 @@ static int xiic_i2c_probe(struct platform_device *pdev)
> init_waitqueue_head(&i2c->wait);
>
> i2c->clk = devm_clk_get(&pdev->dev, NULL);
> - if (IS_ERR(i2c->clk)) {
> - if (PTR_ERR(i2c->clk) != -EPROBE_DEFER)
> - dev_err(&pdev->dev, "input clock not found.\n");
> - return PTR_ERR(i2c->clk);
> - }
> + if (IS_ERR(i2c->clk))
> + return dev_err_probe(&pdev->dev, PTR_ERR(i2c->clk),
> + "input clock not found.\n");
> +
> ret = clk_prepare_enable(i2c->clk);
> if (ret) {
> dev_err(&pdev->dev, "Unable to enable clock.\n");
> --
> 2.17.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
I see that this didn't go through.
Acked-by: Michal Simek <michal.simek@xilinx.com>
Wolfram: Can you please apply?
Thanks,
Michal
--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Xilinx Microblaze
Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs
U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP/Versal SoCs
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 78+ messages in thread
* Re: [PATCH 4/9] i2c: cadence: Simplify with dev_err_probe()
2020-09-02 15:06 ` Krzysztof Kozlowski
(?)
@ 2021-06-23 8:59 ` Michal Simek
-1 siblings, 0 replies; 78+ messages in thread
From: Michal Simek @ 2021-06-23 8:59 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Nicolas Saenz Julienne, Florian Fainelli, Ray Jui, Scott Branden,
bcm-kernel-feedback-list, Sekhar Nori, Bartosz Golaszewski,
Oleksij Rempel, Pengutronix Kernel Team, Shawn Guo, Sascha Hauer,
Fabio Estevam, NXP Linux Team, Heiko Stuebner,
Pierre-Yves MORDRET, Maxime Coquelin, Alexandre Torgue,
Peter Rosin, Wolfram Sang, linux-i2c, linux-rpi-kernel,
linux-arm, LKML, linux-rockchip, linux-stm32
st 2. 9. 2020 v 17:10 odesílatel Krzysztof Kozlowski <krzk@kernel.org> napsal:
>
> Common pattern of handling deferred probe can be simplified with
> dev_err_probe(). Less code and the error value gets printed.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
> drivers/i2c/busses/i2c-cadence.c | 9 ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-cadence.c b/drivers/i2c/busses/i2c-cadence.c
> index e4b7f2a951ad..eefde554c50c 100644
> --- a/drivers/i2c/busses/i2c-cadence.c
> +++ b/drivers/i2c/busses/i2c-cadence.c
> @@ -1214,11 +1214,10 @@ static int cdns_i2c_probe(struct platform_device *pdev)
> "Cadence I2C at %08lx", (unsigned long)r_mem->start);
>
> id->clk = devm_clk_get(&pdev->dev, NULL);
> - if (IS_ERR(id->clk)) {
> - if (PTR_ERR(id->clk) != -EPROBE_DEFER)
> - dev_err(&pdev->dev, "input clock not found.\n");
> - return PTR_ERR(id->clk);
> - }
> + if (IS_ERR(id->clk))
> + return dev_err_probe(&pdev->dev, PTR_ERR(id->clk),
> + "input clock not found.\n");
> +
> ret = clk_prepare_enable(id->clk);
> if (ret)
> dev_err(&pdev->dev, "Unable to enable clock.\n");
> --
> 2.17.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Also this one is pending but still possible to apply without any conflict.
Acked-by: Michal Simek <michal.simek@xilinx.com>
Thanks,
Michal
--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Xilinx Microblaze
Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs
U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP/Versal SoCs
^ permalink raw reply [flat|nested] 78+ messages in thread
* Re: [PATCH 4/9] i2c: cadence: Simplify with dev_err_probe()
@ 2021-06-23 8:59 ` Michal Simek
0 siblings, 0 replies; 78+ messages in thread
From: Michal Simek @ 2021-06-23 8:59 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Nicolas Saenz Julienne, Florian Fainelli, Ray Jui, Scott Branden,
bcm-kernel-feedback-list, Sekhar Nori, Bartosz Golaszewski,
Oleksij Rempel, Pengutronix Kernel Team, Shawn Guo, Sascha Hauer,
Fabio Estevam, NXP Linux Team, Heiko Stuebner,
Pierre-Yves MORDRET, Maxime Coquelin, Alexandre Torgue,
Peter Rosin, Wolfram Sang, linux-i2c, linux-rpi-kernel,
linux-arm, LKML, linux-rockchip, linux-stm32
st 2. 9. 2020 v 17:10 odesílatel Krzysztof Kozlowski <krzk@kernel.org> napsal:
>
> Common pattern of handling deferred probe can be simplified with
> dev_err_probe(). Less code and the error value gets printed.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
> drivers/i2c/busses/i2c-cadence.c | 9 ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-cadence.c b/drivers/i2c/busses/i2c-cadence.c
> index e4b7f2a951ad..eefde554c50c 100644
> --- a/drivers/i2c/busses/i2c-cadence.c
> +++ b/drivers/i2c/busses/i2c-cadence.c
> @@ -1214,11 +1214,10 @@ static int cdns_i2c_probe(struct platform_device *pdev)
> "Cadence I2C at %08lx", (unsigned long)r_mem->start);
>
> id->clk = devm_clk_get(&pdev->dev, NULL);
> - if (IS_ERR(id->clk)) {
> - if (PTR_ERR(id->clk) != -EPROBE_DEFER)
> - dev_err(&pdev->dev, "input clock not found.\n");
> - return PTR_ERR(id->clk);
> - }
> + if (IS_ERR(id->clk))
> + return dev_err_probe(&pdev->dev, PTR_ERR(id->clk),
> + "input clock not found.\n");
> +
> ret = clk_prepare_enable(id->clk);
> if (ret)
> dev_err(&pdev->dev, "Unable to enable clock.\n");
> --
> 2.17.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Also this one is pending but still possible to apply without any conflict.
Acked-by: Michal Simek <michal.simek@xilinx.com>
Thanks,
Michal
--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Xilinx Microblaze
Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs
U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP/Versal SoCs
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 78+ messages in thread
* Re: [PATCH 4/9] i2c: cadence: Simplify with dev_err_probe()
@ 2021-06-23 8:59 ` Michal Simek
0 siblings, 0 replies; 78+ messages in thread
From: Michal Simek @ 2021-06-23 8:59 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Nicolas Saenz Julienne, Florian Fainelli, Ray Jui, Scott Branden,
bcm-kernel-feedback-list, Sekhar Nori, Bartosz Golaszewski,
Oleksij Rempel, Pengutronix Kernel Team, Shawn Guo, Sascha Hauer,
Fabio Estevam, NXP Linux Team, Heiko Stuebner,
Pierre-Yves MORDRET, Maxime Coquelin, Alexandre Torgue,
Peter Rosin, Wolfram Sang, linux-i2c, linux-rpi-kernel,
linux-arm, LKML, linux-rockchip, linux-stm32
st 2. 9. 2020 v 17:10 odesílatel Krzysztof Kozlowski <krzk@kernel.org> napsal:
>
> Common pattern of handling deferred probe can be simplified with
> dev_err_probe(). Less code and the error value gets printed.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
> drivers/i2c/busses/i2c-cadence.c | 9 ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-cadence.c b/drivers/i2c/busses/i2c-cadence.c
> index e4b7f2a951ad..eefde554c50c 100644
> --- a/drivers/i2c/busses/i2c-cadence.c
> +++ b/drivers/i2c/busses/i2c-cadence.c
> @@ -1214,11 +1214,10 @@ static int cdns_i2c_probe(struct platform_device *pdev)
> "Cadence I2C at %08lx", (unsigned long)r_mem->start);
>
> id->clk = devm_clk_get(&pdev->dev, NULL);
> - if (IS_ERR(id->clk)) {
> - if (PTR_ERR(id->clk) != -EPROBE_DEFER)
> - dev_err(&pdev->dev, "input clock not found.\n");
> - return PTR_ERR(id->clk);
> - }
> + if (IS_ERR(id->clk))
> + return dev_err_probe(&pdev->dev, PTR_ERR(id->clk),
> + "input clock not found.\n");
> +
> ret = clk_prepare_enable(id->clk);
> if (ret)
> dev_err(&pdev->dev, "Unable to enable clock.\n");
> --
> 2.17.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Also this one is pending but still possible to apply without any conflict.
Acked-by: Michal Simek <michal.simek@xilinx.com>
Thanks,
Michal
--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Xilinx Microblaze
Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs
U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP/Versal SoCs
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 78+ messages in thread
* Re: [PATCH 4/9] i2c: cadence: Simplify with dev_err_probe()
2020-09-02 15:06 ` Krzysztof Kozlowski
(?)
@ 2021-06-23 16:26 ` Wolfram Sang
-1 siblings, 0 replies; 78+ messages in thread
From: Wolfram Sang @ 2021-06-23 16:26 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Nicolas Saenz Julienne, Florian Fainelli, Ray Jui, Scott Branden,
bcm-kernel-feedback-list, Michal Simek, Sekhar Nori,
Bartosz Golaszewski, Oleksij Rempel, Pengutronix Kernel Team,
Shawn Guo, Sascha Hauer, Fabio Estevam, NXP Linux Team,
Heiko Stuebner, Pierre-Yves MORDRET, Maxime Coquelin,
Alexandre Torgue, Peter Rosin, linux-i2c, linux-rpi-kernel,
linux-arm-kernel, linux-kernel, linux-rockchip, linux-stm32
[-- Attachment #1: Type: text/plain, Size: 297 bytes --]
On Wed, Sep 02, 2020 at 05:06:38PM +0200, Krzysztof Kozlowski wrote:
> Common pattern of handling deferred probe can be simplified with
> dev_err_probe(). Less code and the error value gets printed.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Applied to for-next, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 78+ messages in thread
* Re: [PATCH 4/9] i2c: cadence: Simplify with dev_err_probe()
@ 2021-06-23 16:26 ` Wolfram Sang
0 siblings, 0 replies; 78+ messages in thread
From: Wolfram Sang @ 2021-06-23 16:26 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Nicolas Saenz Julienne, Florian Fainelli, Ray Jui, Scott Branden,
bcm-kernel-feedback-list, Michal Simek, Sekhar Nori,
Bartosz Golaszewski, Oleksij Rempel, Pengutronix Kernel Team,
Shawn Guo, Sascha Hauer, Fabio Estevam, NXP Linux Team,
Heiko Stuebner, Pierre-Yves MORDRET, Maxime Coquelin,
Alexandre Torgue, Peter Rosin, linux-i2c, linux-rpi-kernel,
linux-arm-kernel, linux-kernel, linux-rockchip, linux-stm32
[-- Attachment #1.1: Type: text/plain, Size: 297 bytes --]
On Wed, Sep 02, 2020 at 05:06:38PM +0200, Krzysztof Kozlowski wrote:
> Common pattern of handling deferred probe can be simplified with
> dev_err_probe(). Less code and the error value gets printed.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Applied to for-next, thanks!
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 170 bytes --]
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 78+ messages in thread
* Re: [PATCH 4/9] i2c: cadence: Simplify with dev_err_probe()
@ 2021-06-23 16:26 ` Wolfram Sang
0 siblings, 0 replies; 78+ messages in thread
From: Wolfram Sang @ 2021-06-23 16:26 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Nicolas Saenz Julienne, Florian Fainelli, Ray Jui, Scott Branden,
bcm-kernel-feedback-list, Michal Simek, Sekhar Nori,
Bartosz Golaszewski, Oleksij Rempel, Pengutronix Kernel Team,
Shawn Guo, Sascha Hauer, Fabio Estevam, NXP Linux Team,
Heiko Stuebner, Pierre-Yves MORDRET, Maxime Coquelin,
Alexandre Torgue, Peter Rosin, linux-i2c, linux-rpi-kernel,
linux-arm-kernel, linux-kernel, linux-rockchip, linux-stm32
[-- Attachment #1.1: Type: text/plain, Size: 297 bytes --]
On Wed, Sep 02, 2020 at 05:06:38PM +0200, Krzysztof Kozlowski wrote:
> Common pattern of handling deferred probe can be simplified with
> dev_err_probe(). Less code and the error value gets printed.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Applied to for-next, thanks!
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 78+ messages in thread
* Re: [PATCH 5/9] i2c: davinci: Simplify with dev_err_probe()
2020-09-02 15:06 ` Krzysztof Kozlowski
(?)
@ 2021-06-23 16:26 ` Wolfram Sang
-1 siblings, 0 replies; 78+ messages in thread
From: Wolfram Sang @ 2021-06-23 16:26 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Nicolas Saenz Julienne, Florian Fainelli, Ray Jui, Scott Branden,
bcm-kernel-feedback-list, Michal Simek, Sekhar Nori,
Bartosz Golaszewski, Oleksij Rempel, Pengutronix Kernel Team,
Shawn Guo, Sascha Hauer, Fabio Estevam, NXP Linux Team,
Heiko Stuebner, Pierre-Yves MORDRET, Maxime Coquelin,
Alexandre Torgue, Peter Rosin, linux-i2c, linux-rpi-kernel,
linux-arm-kernel, linux-kernel, linux-rockchip, linux-stm32
[-- Attachment #1: Type: text/plain, Size: 297 bytes --]
On Wed, Sep 02, 2020 at 05:06:39PM +0200, Krzysztof Kozlowski wrote:
> Common pattern of handling deferred probe can be simplified with
> dev_err_probe(). Less code and the error value gets printed.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Applied to for-next, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 78+ messages in thread
* Re: [PATCH 5/9] i2c: davinci: Simplify with dev_err_probe()
@ 2021-06-23 16:26 ` Wolfram Sang
0 siblings, 0 replies; 78+ messages in thread
From: Wolfram Sang @ 2021-06-23 16:26 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Nicolas Saenz Julienne, Florian Fainelli, Ray Jui, Scott Branden,
bcm-kernel-feedback-list, Michal Simek, Sekhar Nori,
Bartosz Golaszewski, Oleksij Rempel, Pengutronix Kernel Team,
Shawn Guo, Sascha Hauer, Fabio Estevam, NXP Linux Team,
Heiko Stuebner, Pierre-Yves MORDRET, Maxime Coquelin,
Alexandre Torgue, Peter Rosin, linux-i2c, linux-rpi-kernel,
linux-arm-kernel, linux-kernel, linux-rockchip, linux-stm32
[-- Attachment #1.1: Type: text/plain, Size: 297 bytes --]
On Wed, Sep 02, 2020 at 05:06:39PM +0200, Krzysztof Kozlowski wrote:
> Common pattern of handling deferred probe can be simplified with
> dev_err_probe(). Less code and the error value gets printed.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Applied to for-next, thanks!
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 170 bytes --]
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 78+ messages in thread
* Re: [PATCH 5/9] i2c: davinci: Simplify with dev_err_probe()
@ 2021-06-23 16:26 ` Wolfram Sang
0 siblings, 0 replies; 78+ messages in thread
From: Wolfram Sang @ 2021-06-23 16:26 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Nicolas Saenz Julienne, Florian Fainelli, Ray Jui, Scott Branden,
bcm-kernel-feedback-list, Michal Simek, Sekhar Nori,
Bartosz Golaszewski, Oleksij Rempel, Pengutronix Kernel Team,
Shawn Guo, Sascha Hauer, Fabio Estevam, NXP Linux Team,
Heiko Stuebner, Pierre-Yves MORDRET, Maxime Coquelin,
Alexandre Torgue, Peter Rosin, linux-i2c, linux-rpi-kernel,
linux-arm-kernel, linux-kernel, linux-rockchip, linux-stm32
[-- Attachment #1.1: Type: text/plain, Size: 297 bytes --]
On Wed, Sep 02, 2020 at 05:06:39PM +0200, Krzysztof Kozlowski wrote:
> Common pattern of handling deferred probe can be simplified with
> dev_err_probe(). Less code and the error value gets printed.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Applied to for-next, thanks!
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 78+ messages in thread
* Re: [PATCH 2/9] i2c: xiic: Simplify with dev_err_probe()
2020-09-02 15:06 ` Krzysztof Kozlowski
(?)
@ 2021-06-23 16:26 ` Wolfram Sang
-1 siblings, 0 replies; 78+ messages in thread
From: Wolfram Sang @ 2021-06-23 16:26 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Nicolas Saenz Julienne, Florian Fainelli, Ray Jui, Scott Branden,
bcm-kernel-feedback-list, Michal Simek, Sekhar Nori,
Bartosz Golaszewski, Oleksij Rempel, Pengutronix Kernel Team,
Shawn Guo, Sascha Hauer, Fabio Estevam, NXP Linux Team,
Heiko Stuebner, Pierre-Yves MORDRET, Maxime Coquelin,
Alexandre Torgue, Peter Rosin, linux-i2c, linux-rpi-kernel,
linux-arm-kernel, linux-kernel, linux-rockchip, linux-stm32
[-- Attachment #1: Type: text/plain, Size: 297 bytes --]
On Wed, Sep 02, 2020 at 05:06:36PM +0200, Krzysztof Kozlowski wrote:
> Common pattern of handling deferred probe can be simplified with
> dev_err_probe(). Less code and the error value gets printed.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Applied to for-next, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 78+ messages in thread
* Re: [PATCH 2/9] i2c: xiic: Simplify with dev_err_probe()
@ 2021-06-23 16:26 ` Wolfram Sang
0 siblings, 0 replies; 78+ messages in thread
From: Wolfram Sang @ 2021-06-23 16:26 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Nicolas Saenz Julienne, Florian Fainelli, Ray Jui, Scott Branden,
bcm-kernel-feedback-list, Michal Simek, Sekhar Nori,
Bartosz Golaszewski, Oleksij Rempel, Pengutronix Kernel Team,
Shawn Guo, Sascha Hauer, Fabio Estevam, NXP Linux Team,
Heiko Stuebner, Pierre-Yves MORDRET, Maxime Coquelin,
Alexandre Torgue, Peter Rosin, linux-i2c, linux-rpi-kernel,
linux-arm-kernel, linux-kernel, linux-rockchip, linux-stm32
[-- Attachment #1.1: Type: text/plain, Size: 297 bytes --]
On Wed, Sep 02, 2020 at 05:06:36PM +0200, Krzysztof Kozlowski wrote:
> Common pattern of handling deferred probe can be simplified with
> dev_err_probe(). Less code and the error value gets printed.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Applied to for-next, thanks!
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 170 bytes --]
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 78+ messages in thread
* Re: [PATCH 2/9] i2c: xiic: Simplify with dev_err_probe()
@ 2021-06-23 16:26 ` Wolfram Sang
0 siblings, 0 replies; 78+ messages in thread
From: Wolfram Sang @ 2021-06-23 16:26 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Nicolas Saenz Julienne, Florian Fainelli, Ray Jui, Scott Branden,
bcm-kernel-feedback-list, Michal Simek, Sekhar Nori,
Bartosz Golaszewski, Oleksij Rempel, Pengutronix Kernel Team,
Shawn Guo, Sascha Hauer, Fabio Estevam, NXP Linux Team,
Heiko Stuebner, Pierre-Yves MORDRET, Maxime Coquelin,
Alexandre Torgue, Peter Rosin, linux-i2c, linux-rpi-kernel,
linux-arm-kernel, linux-kernel, linux-rockchip, linux-stm32
[-- Attachment #1.1: Type: text/plain, Size: 297 bytes --]
On Wed, Sep 02, 2020 at 05:06:36PM +0200, Krzysztof Kozlowski wrote:
> Common pattern of handling deferred probe can be simplified with
> dev_err_probe(). Less code and the error value gets printed.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Applied to for-next, thanks!
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 78+ messages in thread
end of thread, other threads:[~2021-06-23 16:28 UTC | newest]
Thread overview: 78+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-02 15:06 [PATCH 1/9] i2c: stm32: Simplify with dev_err_probe() Krzysztof Kozlowski
2020-09-02 15:06 ` Krzysztof Kozlowski
2020-09-02 15:06 ` Krzysztof Kozlowski
2020-09-02 15:06 ` [PATCH 2/9] i2c: xiic: " Krzysztof Kozlowski
2020-09-02 15:06 ` Krzysztof Kozlowski
2020-09-02 15:06 ` Krzysztof Kozlowski
2021-06-23 8:57 ` Michal Simek
2021-06-23 8:57 ` Michal Simek
2021-06-23 8:57 ` Michal Simek
2021-06-23 16:26 ` Wolfram Sang
2021-06-23 16:26 ` Wolfram Sang
2021-06-23 16:26 ` Wolfram Sang
2020-09-02 15:06 ` [PATCH 3/9] i2c: bcm2835: " Krzysztof Kozlowski
2020-09-02 15:06 ` Krzysztof Kozlowski
2020-09-02 15:06 ` Krzysztof Kozlowski
2020-09-02 15:24 ` Florian Fainelli
2020-09-02 15:24 ` Florian Fainelli
2020-09-02 15:24 ` Florian Fainelli
2020-09-10 6:25 ` Wolfram Sang
2020-09-10 6:25 ` Wolfram Sang
2020-09-10 6:25 ` Wolfram Sang
2020-09-02 15:06 ` [PATCH 4/9] i2c: cadence: " Krzysztof Kozlowski
2020-09-02 15:06 ` Krzysztof Kozlowski
2020-09-02 15:06 ` Krzysztof Kozlowski
2021-06-23 8:59 ` Michal Simek
2021-06-23 8:59 ` Michal Simek
2021-06-23 8:59 ` Michal Simek
2021-06-23 16:26 ` Wolfram Sang
2021-06-23 16:26 ` Wolfram Sang
2021-06-23 16:26 ` Wolfram Sang
2020-09-02 15:06 ` [PATCH 5/9] i2c: davinci: " Krzysztof Kozlowski
2020-09-02 15:06 ` Krzysztof Kozlowski
2020-09-02 15:06 ` Krzysztof Kozlowski
2021-06-23 16:26 ` Wolfram Sang
2021-06-23 16:26 ` Wolfram Sang
2021-06-23 16:26 ` Wolfram Sang
2020-09-02 15:06 ` [PATCH 6/9] i2c: imx: " Krzysztof Kozlowski
2020-09-02 15:06 ` Krzysztof Kozlowski
2020-09-02 15:06 ` Krzysztof Kozlowski
2020-09-02 17:58 ` Uwe Kleine-König
2020-09-02 17:58 ` Uwe Kleine-König
2020-09-02 17:58 ` Uwe Kleine-König
2020-09-03 5:36 ` Oleksij Rempel
2020-09-03 5:36 ` Oleksij Rempel
2020-09-03 5:36 ` Oleksij Rempel
2020-09-10 6:27 ` Wolfram Sang
2020-09-10 6:27 ` Wolfram Sang
2020-09-10 6:27 ` Wolfram Sang
2020-09-02 15:06 ` [PATCH 7/9] i2c: rk3x: " Krzysztof Kozlowski
2020-09-02 15:06 ` Krzysztof Kozlowski
2020-09-02 15:06 ` Krzysztof Kozlowski
2020-09-22 14:25 ` Heiko Stübner
2020-09-22 14:25 ` Heiko Stübner
2020-09-22 14:25 ` Heiko Stübner
2020-09-27 18:01 ` Wolfram Sang
2020-09-27 18:01 ` Wolfram Sang
2020-09-27 18:01 ` Wolfram Sang
2020-09-02 15:06 ` [PATCH 8/9] i2c: mux: gpmux: " Krzysztof Kozlowski
2020-09-02 15:06 ` Krzysztof Kozlowski
2020-09-02 15:06 ` Krzysztof Kozlowski
2020-09-02 18:33 ` Peter Rosin
2020-09-02 18:33 ` Peter Rosin
2020-09-02 18:33 ` Peter Rosin
2020-09-10 6:24 ` Wolfram Sang
2020-09-10 6:24 ` Wolfram Sang
2020-09-10 6:24 ` Wolfram Sang
2020-09-02 15:06 ` [PATCH 9/9] i2c: mux: reg: " Krzysztof Kozlowski
2020-09-02 15:06 ` Krzysztof Kozlowski
2020-09-02 15:06 ` Krzysztof Kozlowski
2020-09-02 18:33 ` Peter Rosin
2020-09-02 18:33 ` Peter Rosin
2020-09-02 18:33 ` Peter Rosin
2020-09-10 6:24 ` Wolfram Sang
2020-09-10 6:24 ` Wolfram Sang
2020-09-10 6:24 ` Wolfram Sang
2020-09-10 9:36 ` [PATCH 1/9] i2c: stm32: " Alain Volmat
2020-09-10 9:36 ` Alain Volmat
2020-09-10 9:36 ` Alain Volmat
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.