From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD0B3C48BC2 for ; Wed, 23 Jun 2021 17:25:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A5D15611AC for ; Wed, 23 Jun 2021 17:25:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229900AbhFWR1e (ORCPT ); Wed, 23 Jun 2021 13:27:34 -0400 Received: from mail.kernel.org ([198.145.29.99]:57496 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229523AbhFWR1c (ORCPT ); Wed, 23 Jun 2021 13:27:32 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 9F90460FEA; Wed, 23 Jun 2021 17:25:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1624469114; bh=bskff73XWWxpgTzfK/jxsxgtC9fuGF5fnf7xrQldBiQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OCpB9iw5B9xMuFtds+/77jyu3PUVIeGnJOh7aSkDfU+i9UFz1z++SvqO0NMGZPQSR OozYnLZViLOVukzCYAa1vdB2QayAFjbBSjJsv4kORIzf+UJ8e2ihfvZQTRbqxw6mxP bSSNEYQ6uVLgacK5Tz4kieKkqjnjWjStQE5LzC9c= Date: Wed, 23 Jun 2021 19:25:11 +0200 From: Greg KH To: Rocco Yue Cc: "David S . Miller" , Jakub Kicinski , Jonathan Corbet , Hideaki YOSHIFUJI , David Ahern , Matthias Brugger , Felix Fietkau , John Crispin , Sean Wang , Mark Lee , netdev@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, bpf@vger.kernel.org, wsd_upstream@mediatek.com, chao.song@mediatek.com, zhuoliang.zhang@mediatek.com, kuohong.wang@mediatek.com Subject: Re: [PATCH 4/4] drivers: net: mediatek: initial implementation of ccmni Message-ID: References: <20210623113452.5671-1-rocco.yue@mediatek.com> <20210623113452.5671-4-rocco.yue@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210623113452.5671-4-rocco.yue@mediatek.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 23, 2021 at 07:34:52PM +0800, Rocco Yue wrote: > +EXPORT_SYMBOL(ccmni_rx_push); Why are you exporting symbols that are not used by anyone in this patch series? That doesn't feel right. Who needs this? > +EXPORT_SYMBOL(ccmni_hif_hook); Same with this, who calls this? > +++ b/drivers/net/ethernet/mediatek/ccmni/ccmni.h Why do you have a .h file for a single .c file? that shouldn't be needed. thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E40BC4743C for ; Wed, 23 Jun 2021 17:25:39 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 585A9611AD for ; Wed, 23 Jun 2021 17:25:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 585A9611AD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ySaZ+HNvK9Xmg5mL14wVnroaCvNDw2pYvzkNPtvyddI=; b=PsxKtVUM1cwCSq kpIvSrSjOvEyWYWiHiuzOetw0rXsIq5irAD81D/QigmKDsG0b/vx3iiC2SZGoBZxCi+loxFvnwwVC B25VPonq+mfSpKjzOy0521VjBYmpzXt9Jbm+eGXQSYyKjKSkK7II/7/cBvAkXllpTZBV9whaVO61f YQuccSohszCKAYwzNLJfCP0tPu0aTgJd+jFdfCQumhNI/sjd1O1/6Gkeq63QrComXwSDipQH51BQb OR+NzeDHg1OG0VNANrQBzGtEKoJymX1wHy7QXkEc6wnpsdYxdNeWKe9mfR6JmfC0tcOqS3QuHkOyY qIl5uSnPGtqLys4L98SA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lw6cy-00BOAF-Rp; Wed, 23 Jun 2021 17:25:28 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lw6ck-00BO7G-KB; Wed, 23 Jun 2021 17:25:15 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 9F90460FEA; Wed, 23 Jun 2021 17:25:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1624469114; bh=bskff73XWWxpgTzfK/jxsxgtC9fuGF5fnf7xrQldBiQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OCpB9iw5B9xMuFtds+/77jyu3PUVIeGnJOh7aSkDfU+i9UFz1z++SvqO0NMGZPQSR OozYnLZViLOVukzCYAa1vdB2QayAFjbBSjJsv4kORIzf+UJ8e2ihfvZQTRbqxw6mxP bSSNEYQ6uVLgacK5Tz4kieKkqjnjWjStQE5LzC9c= Date: Wed, 23 Jun 2021 19:25:11 +0200 From: Greg KH To: Rocco Yue Cc: "David S . Miller" , Jakub Kicinski , Jonathan Corbet , Hideaki YOSHIFUJI , David Ahern , Matthias Brugger , Felix Fietkau , John Crispin , Sean Wang , Mark Lee , netdev@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, bpf@vger.kernel.org, wsd_upstream@mediatek.com, chao.song@mediatek.com, zhuoliang.zhang@mediatek.com, kuohong.wang@mediatek.com Subject: Re: [PATCH 4/4] drivers: net: mediatek: initial implementation of ccmni Message-ID: References: <20210623113452.5671-1-rocco.yue@mediatek.com> <20210623113452.5671-4-rocco.yue@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210623113452.5671-4-rocco.yue@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210623_102514_746559_A6EF2540 X-CRM114-Status: UNSURE ( 8.33 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Wed, Jun 23, 2021 at 07:34:52PM +0800, Rocco Yue wrote: > +EXPORT_SYMBOL(ccmni_rx_push); Why are you exporting symbols that are not used by anyone in this patch series? That doesn't feel right. Who needs this? > +EXPORT_SYMBOL(ccmni_hif_hook); Same with this, who calls this? > +++ b/drivers/net/ethernet/mediatek/ccmni/ccmni.h Why do you have a .h file for a single .c file? that shouldn't be needed. thanks, greg k-h _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3280CC4743C for ; Wed, 23 Jun 2021 17:26:54 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EBCF060FEA for ; Wed, 23 Jun 2021 17:26:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EBCF060FEA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=EcLV4cPGaymnfcvf3+6XPflz41o7KJFsx0fUcAX7IVI=; b=DuV0URdPxyzirE QEdDMIIqSmCG3Wwds5E5RPtD5kgEDwBHfmTI8u8JOUk6etcUCvMy0A9p5XflqhdE3OAHg4eKFSd9p 2U2AQbE9QeXwOoJmQiPRdh/KATNGhRdSddt489w4YZ6C9N0B7FYOxtt1NeX6B+Wb+Ab7tbiLnM5EA im1Kdq4SScFrWqrpmU9f0GcC/h8Ar17U8t+vZTq85PXTtZhngs84H/SYXOldzqN8VFmAOnY1mPDJ3 DjtxIxR1dIr3lPM+4KtglYhmVKg1+dHOhAaVTwF58MNzwv75WJFDuSoOWN0BX2Acsnus2JCSkSTJq lQWNOqmoNlOospEsv/QA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lw6cp-00BO8P-5l; Wed, 23 Jun 2021 17:25:19 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lw6ck-00BO7G-KB; Wed, 23 Jun 2021 17:25:15 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 9F90460FEA; Wed, 23 Jun 2021 17:25:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1624469114; bh=bskff73XWWxpgTzfK/jxsxgtC9fuGF5fnf7xrQldBiQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OCpB9iw5B9xMuFtds+/77jyu3PUVIeGnJOh7aSkDfU+i9UFz1z++SvqO0NMGZPQSR OozYnLZViLOVukzCYAa1vdB2QayAFjbBSjJsv4kORIzf+UJ8e2ihfvZQTRbqxw6mxP bSSNEYQ6uVLgacK5Tz4kieKkqjnjWjStQE5LzC9c= Date: Wed, 23 Jun 2021 19:25:11 +0200 From: Greg KH To: Rocco Yue Cc: "David S . Miller" , Jakub Kicinski , Jonathan Corbet , Hideaki YOSHIFUJI , David Ahern , Matthias Brugger , Felix Fietkau , John Crispin , Sean Wang , Mark Lee , netdev@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, bpf@vger.kernel.org, wsd_upstream@mediatek.com, chao.song@mediatek.com, zhuoliang.zhang@mediatek.com, kuohong.wang@mediatek.com Subject: Re: [PATCH 4/4] drivers: net: mediatek: initial implementation of ccmni Message-ID: References: <20210623113452.5671-1-rocco.yue@mediatek.com> <20210623113452.5671-4-rocco.yue@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210623113452.5671-4-rocco.yue@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210623_102514_746559_A6EF2540 X-CRM114-Status: UNSURE ( 8.33 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jun 23, 2021 at 07:34:52PM +0800, Rocco Yue wrote: > +EXPORT_SYMBOL(ccmni_rx_push); Why are you exporting symbols that are not used by anyone in this patch series? That doesn't feel right. Who needs this? > +EXPORT_SYMBOL(ccmni_hif_hook); Same with this, who calls this? > +++ b/drivers/net/ethernet/mediatek/ccmni/ccmni.h Why do you have a .h file for a single .c file? that shouldn't be needed. thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel