From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7338EC48BC2 for ; Wed, 23 Jun 2021 20:37:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 45C8461185 for ; Wed, 23 Jun 2021 20:37:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229889AbhFWUjk (ORCPT ); Wed, 23 Jun 2021 16:39:40 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:52450 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229660AbhFWUji (ORCPT ); Wed, 23 Jun 2021 16:39:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=1XtEzc6VnSjwLXbMFdcKxrNUxmRgQuaNqMZ4b5TzFxo=; b=ONgnW4sIZKv4soPmAFcM4MNh6S eBjrrNk0sM4dgCFBqgTez62PZAPefRuFqBJkswL0oQWBk81pdg+HOh8K4ry4inZlNo/YIwK3nICg0 gzTPcfsAmx4ExJT1NjxRcguwbqTSNSpxI2XNEckRW1kCaLLnH+Sjh0PN6/tqRGL+fVmM=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1lw9cc-00AtE6-9o; Wed, 23 Jun 2021 22:37:18 +0200 Date: Wed, 23 Jun 2021 22:37:18 +0200 From: Andrew Lunn To: Marcin Wojtas Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, davem@davemloft.net, kuba@kernel.org, linux@armlinux.org.uk, jaz@semihalf.com, gjb@semihalf.com, upstream@semihalf.com, Samer.El-Haj-Mahmoud@arm.com, jon@solid-run.com, tn@semihalf.com, rjw@rjwysocki.net, lenb@kernel.org Subject: Re: [net-next: PATCH v3 5/6] net: mvpp2: enable using phylink with ACPI Message-ID: References: <20210621173028.3541424-1-mw@semihalf.com> <20210621173028.3541424-6-mw@semihalf.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210621173028.3541424-6-mw@semihalf.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > +static bool mvpp2_use_acpi_compat_mode(struct fwnode_handle *port_fwnode) > +{ > + if (!is_acpi_node(port_fwnode)) > + return false; > + > + return (!fwnode_property_present(port_fwnode, "phy-handle") && > + !fwnode_property_present(port_fwnode, "managed") && > + !fwnode_get_named_child_node(port_fwnode, "fixed-link")); I'm not too sure about this last one. You only use fixed-link when connecting to an Ethernet switch. I doubt anybody will try ACPI and a switch. It has been agreed, ACPI is for simple hardware, and you need to use DT for advanced hardware configurations. What is your use case for fixed-link? Andrew