From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-23.2 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F31FC48BC2 for ; Thu, 24 Jun 2021 01:01:14 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8C09961361 for ; Thu, 24 Jun 2021 01:01:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8C09961361 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 4FA8A6B0071; Wed, 23 Jun 2021 21:01:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4AA798D0002; Wed, 23 Jun 2021 21:01:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2FF428D0001; Wed, 23 Jun 2021 21:01:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0157.hostedemail.com [216.40.44.157]) by kanga.kvack.org (Postfix) with ESMTP id EEA006B0071 for ; Wed, 23 Jun 2021 21:01:11 -0400 (EDT) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 32A3D1A4B5 for ; Thu, 24 Jun 2021 01:01:12 +0000 (UTC) X-FDA: 78286813584.05.B4C37C9 Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) by imf15.hostedemail.com (Postfix) with ESMTP id E36E2A000276 for ; Thu, 24 Jun 2021 01:01:11 +0000 (UTC) Received: by mail-pj1-f48.google.com with SMTP id pf4-20020a17090b1d84b029016f6699c3f2so4867471pjb.0 for ; Wed, 23 Jun 2021 18:01:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=zAct/C7cwTnaxm62CcM05AOERh/5KXSK9F1pZ6RZAok=; b=KsCBL0fmkWUTJNYLgqM64NlDw8J5vbb6TN2Ccb2SGpENpU7wsIz/8auAPekBg05UqH 2Y+QgZLS3p21OU05NlaRFwPOStqh+YvtjnBEvIuaVkvjimsDzPpYxjqBv9/J3jSYvxjo WUFWVZUM+Cm+ilaxRx2GOAfrBokTVtz8hcRw7snsuQ4ES9rH8NkVJ1R5AKEXkKxt5dwZ IuLr602kaaT1SAFx71W+0RBXw8m5b54RNj4q7Z/amFmn0SroIh3ukNCC9K1CnQGu9Bb0 0wEhwe9TsLt4obieNjDB9IDKNoh2HjYPEyAnBF9rhV41YDz5nsNgF60J0mCf5G0+75Dh ycNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=zAct/C7cwTnaxm62CcM05AOERh/5KXSK9F1pZ6RZAok=; b=YtV9QiA1/qthXSh7M4NxyjQzddnuIOC/qRyOigqRQWZK9516W1ctk0ZyDDM4PMQAhu qZSSTY3/0po6p7cwvzqgnuChuFhzktnXF5P1cvT6gue4BbeF5mmSr5wpMxeHo0y90VSG 0TCQimYjI3DKKdwiqY7OzjOAqQYApnDVeaqVYAkCUPa94ZMvR2w2OZDAsE7nWd7uF6vU wkJQmn23oYce28EwXqIP/CTOa65Tg2Txuw7oQ29DK8AJGqbj8jIAuTlAfzEPZZqEAnXs eJAxYltqJ5LSKEJUG3Of83IifcDMEGrFuRl1pWMdPZu8lfpk+q66t+qC9HVjCe3tF2pk C2kQ== X-Gm-Message-State: AOAM530CJ6jqq2HjjsES4X2ONvAMJsImUcD8nw8HDb4Ej61RAu6SIATH uAf6yGHTZELmZF5rHayQaHQ1ow== X-Google-Smtp-Source: ABdhPJySvzn98niKQApxqYqeiz4a0ZWKkImSd5YIdlfRuQKoAozakX+i2UkadIiICNEvz9WjyQCjrQ== X-Received: by 2002:a17:90b:3697:: with SMTP id mj23mr12299268pjb.118.1624496470729; Wed, 23 Jun 2021 18:01:10 -0700 (PDT) Received: from google.com (150.12.83.34.bc.googleusercontent.com. [34.83.12.150]) by smtp.gmail.com with ESMTPSA id b65sm906775pfa.32.2021.06.23.18.01.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Jun 2021 18:01:10 -0700 (PDT) Date: Wed, 23 Jun 2021 18:01:06 -0700 From: Ricardo Koller To: Marc Zyngier Cc: kernel test robot , Paolo Bonzini , Vitaly Kuznetsov , kbuild-all@lists.01.org, Linux Memory Management List Subject: Re: [linux-next:master 12154/12271] tools/testing/selftests/kvm/x86_64/hyperv_features.c:618: undefined reference to `vm_handle_exception' Message-ID: References: <202106230606.sNbagz4E-lkp@intel.com> <87r1gtau4g.wl-maz@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87r1gtau4g.wl-maz@kernel.org> X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: E36E2A000276 Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=google.com header.s=20161025 header.b=KsCBL0fm; spf=pass (imf15.hostedemail.com: domain of ricarkol@google.com designates 209.85.216.48 as permitted sender) smtp.mailfrom=ricarkol@google.com; dmarc=pass (policy=reject) header.from=google.com X-Stat-Signature: 6o6hz57xc1snn99hggm3mb5ojoyai3n1 X-HE-Tag: 1624496471-307518 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jun 23, 2021 at 08:59:59AM +0100, Marc Zyngier wrote: > + Paolo, Vitaly, Ricardo, > > On Tue, 22 Jun 2021 23:54:17 +0100, > kernel test robot wrote: > > > > Hi Stephen, > > > > First bad commit (maybe != root cause): > > > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > > head: 4238b1710eadd18dd16de0288a2bc5bb84614b4e > > commit: 954e285eafdd4ac36b114a7f6abce3f792591ea8 [12154/12271] Merge remote-tracking branch 'kvm-arm/next' > > config: x86_64-rhel-8.3-kselftests (attached as .config) > > compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 > > reproduce (this is a W=1 build): > > # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=954e285eafdd4ac36b114a7f6abce3f792591ea8 > > git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git > > git fetch --no-tags linux-next master > > git checkout 954e285eafdd4ac36b114a7f6abce3f792591ea8 > > # save the attached .config to linux build tree > > make W=1 ARCH=x86_64 > > > > If you fix the issue, kindly add following tag as appropriate > > Reported-by: kernel test robot > > > > All error/warnings (new ones prefixed by >>): > > > > x86_64/hyperv_features.c: In function 'main': > > >> x86_64/hyperv_features.c:618:2: warning: implicit declaration of function 'vm_handle_exception' [-Wimplicit-function-declaration] > > 618 | vm_handle_exception(vm, GP_VECTOR, guest_gp_handler); > > | ^~~~~~~~~~~~~~~~~~~ > > /usr/bin/ld: /tmp/ccIBsVo3.o: in function `main': > > >> tools/testing/selftests/kvm/x86_64/hyperv_features.c:618: undefined reference to `vm_handle_exception' > > collect2: error: ld returned 1 exit status > > -- > > x86_64/hyperv_features.c: In function 'main': > > >> x86_64/hyperv_features.c:618:2: warning: implicit declaration of function 'vm_handle_exception' [-Wimplicit-function-declaration] > > 618 | vm_handle_exception(vm, GP_VECTOR, guest_gp_handler); > > | ^~~~~~~~~~~~~~~~~~~ > > /usr/bin/ld: /tmp/cc7zqGvp.o: in function `main': > > >> tools/testing/selftests/kvm/x86_64/hyperv_features.c:618: undefined reference to `vm_handle_exception' > > collect2: error: ld returned 1 exit status > > > > This stems from the following commit: > > commit b78f4a596692f6805e796a4c13f2d921b8a95166 > Author: Ricardo Koller > Date: Thu Jun 10 18:10:15 2021 -0700 > > KVM: selftests: Rename vm_handle_exception > > Rename the vm_handle_exception function to a name that indicates more > clearly that it installs something: vm_install_exception_handler. > > Reported-by: kernel test robot > Suggested-by: Marc Zyngier > Suggested-by: Andrew Jones > Signed-off-by: Ricardo Koller > Reviewed-by: Andrew Jones > Signed-off-by: Marc Zyngier > Link: https://lore.kernel.org/r/20210611011020.3420067-2-ricarkol@google.com Yes, that's my change (again). Thanks you both for handling it. Thanks, Ricardo > > If there is a stable branch with this patch on it, I can take it in > the kvmarm tree and fix it up myself. Otherwise, Paolo could take the > stable branch at [1] (or even that particular commit which is right on > top of v5.13-rc4) and do a similar fixup. Just let me know. > > Thanks, > > M. > > [1] https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git/log/?h=kvm-arm64/selftest/debug > > -- > Without deviation from the norm, progress is not possible. From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============6151263581616225809==" MIME-Version: 1.0 From: Ricardo Koller To: kbuild-all@lists.01.org Subject: Re: [linux-next:master 12154/12271] tools/testing/selftests/kvm/x86_64/hyperv_features.c:618: undefined reference to `vm_handle_exception' Date: Wed, 23 Jun 2021 18:01:06 -0700 Message-ID: In-Reply-To: <87r1gtau4g.wl-maz@kernel.org> List-Id: --===============6151263581616225809== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On Wed, Jun 23, 2021 at 08:59:59AM +0100, Marc Zyngier wrote: > + Paolo, Vitaly, Ricardo, > = > On Tue, 22 Jun 2021 23:54:17 +0100, > kernel test robot wrote: > > = > > Hi Stephen, > > = > > First bad commit (maybe !=3D root cause): > > = > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next= .git master > > head: 4238b1710eadd18dd16de0288a2bc5bb84614b4e > > commit: 954e285eafdd4ac36b114a7f6abce3f792591ea8 [12154/12271] Merge re= mote-tracking branch 'kvm-arm/next' > > config: x86_64-rhel-8.3-kselftests (attached as .config) > > compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 > > reproduce (this is a W=3D1 build): > > # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-ne= xt.git/commit/?id=3D954e285eafdd4ac36b114a7f6abce3f792591ea8 > > git remote add linux-next https://git.kernel.org/pub/scm/linux/= kernel/git/next/linux-next.git > > git fetch --no-tags linux-next master > > git checkout 954e285eafdd4ac36b114a7f6abce3f792591ea8 > > # save the attached .config to linux build tree > > make W=3D1 ARCH=3Dx86_64 = > > = > > If you fix the issue, kindly add following tag as appropriate > > Reported-by: kernel test robot > > = > > All error/warnings (new ones prefixed by >>): > > = > > x86_64/hyperv_features.c: In function 'main': > > >> x86_64/hyperv_features.c:618:2: warning: implicit declaration of fun= ction 'vm_handle_exception' [-Wimplicit-function-declaration] > > 618 | vm_handle_exception(vm, GP_VECTOR, guest_gp_handler); > > | ^~~~~~~~~~~~~~~~~~~ > > /usr/bin/ld: /tmp/ccIBsVo3.o: in function `main': > > >> tools/testing/selftests/kvm/x86_64/hyperv_features.c:618: undefined = reference to `vm_handle_exception' > > collect2: error: ld returned 1 exit status > > -- > > x86_64/hyperv_features.c: In function 'main': > > >> x86_64/hyperv_features.c:618:2: warning: implicit declaration of fun= ction 'vm_handle_exception' [-Wimplicit-function-declaration] > > 618 | vm_handle_exception(vm, GP_VECTOR, guest_gp_handler); > > | ^~~~~~~~~~~~~~~~~~~ > > /usr/bin/ld: /tmp/cc7zqGvp.o: in function `main': > > >> tools/testing/selftests/kvm/x86_64/hyperv_features.c:618: undefined = reference to `vm_handle_exception' > > collect2: error: ld returned 1 exit status > > > = > This stems from the following commit: > = > commit b78f4a596692f6805e796a4c13f2d921b8a95166 > Author: Ricardo Koller > Date: Thu Jun 10 18:10:15 2021 -0700 > = > KVM: selftests: Rename vm_handle_exception > = > Rename the vm_handle_exception function to a name that indicates more > clearly that it installs something: vm_install_exception_handler. > = > Reported-by: kernel test robot > Suggested-by: Marc Zyngier > Suggested-by: Andrew Jones > Signed-off-by: Ricardo Koller > Reviewed-by: Andrew Jones > Signed-off-by: Marc Zyngier > Link: https://lore.kernel.org/r/20210611011020.3420067-2-ricarkol(a)g= oogle.com Yes, that's my change (again). Thanks you both for handling it. Thanks, Ricardo > = > If there is a stable branch with this patch on it, I can take it in > the kvmarm tree and fix it up myself. Otherwise, Paolo could take the > stable branch at [1] (or even that particular commit which is right on > top of v5.13-rc4) and do a similar fixup. Just let me know. > = > Thanks, > = > M. > = > [1] https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git= /log/?h=3Dkvm-arm64/selftest/debug > = > -- = > Without deviation from the norm, progress is not possible. --===============6151263581616225809==--