From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2B14470 for ; Thu, 24 Jun 2021 07:27:48 +0000 (UTC) Received: from zn.tnic (p200300ec2f0c1e0051d60f689d4f0453.dip0.t-ipconnect.de [IPv6:2003:ec:2f0c:1e00:51d6:f68:9d4f:453]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 2CEBD1EC0253; Thu, 24 Jun 2021 09:27:47 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1624519667; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=Tk8bS/1GVIXPT0HJ7nIwptwsGI5hts/jHchSoFxDYwk=; b=LI0h9MmccHlICbtRqQhCC3gRJh4OKEODp3Chzd+32gPVF3K9RZOvUCpqfOF7Ds7k0dTR42 Pu2uxB3uG0wcizcYUsLG3RGmRR66qZaNYd+x9mNYFTvgAEy+OiP+lpgWjJjEGUkO7KQz33 qu3nAYVYpp+HzJ3neF4aZ/ZyH67DiO8= Date: Thu, 24 Jun 2021 09:27:41 +0200 From: Borislav Petkov To: Michael Roth Cc: "Kuppuswamy, Sathyanarayanan" , Dave Hansen , Brijesh Singh , x86@kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-efi@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-crypto@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Joerg Roedel , Tom Lendacky , "H. Peter Anvin" , Ard Biesheuvel , Paolo Bonzini , Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Andy Lutomirski , Sergio Lopez , Peter Gonda , Peter Zijlstra , Srinivas Pandruvada , David Rientjes , tony.luck@intel.com, npmccallum@redhat.com Subject: Re: [PATCH Part1 RFC v3 20/22] x86/boot: Add Confidential Computing address to setup_header Message-ID: References: <20210602140416.23573-1-brijesh.singh@amd.com> <20210602140416.23573-21-brijesh.singh@amd.com> <15568c80-c9a9-5602-d940-264af87bed98@amd.com> <162442264313.98837.16983159316116149849@amd.com> <20210624031911.eznpkbgjt4e445xj@amd.com> Precedence: bulk X-Mailing-List: linux-coco@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210624031911.eznpkbgjt4e445xj@amd.com> On Wed, Jun 23, 2021 at 10:19:11PM -0500, Michael Roth wrote: > One downside to this is we still need something in the boot protocol, > either via setup_data, or setup_header directly. Huh, now I'm confused. You gave the acpi_rsdp_addr example and I thought that should be enough, that's why I suggested boot_params. Maybe you should point me to the code which does what you need so that I can get a better idea... > Having it in setup_header avoids the need to also have to add a field > to boot_params for the boot/compressed->uncompressed passing, but > maybe that's not a good enough justification. Perhaps if the TDX folks > have similar needs though. Yes, reportedly they do so I guess the solution should be vendor-agnostic. Let's see what they need first. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2463BC49EA7 for ; Thu, 24 Jun 2021 07:27:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F0ABA613ED for ; Thu, 24 Jun 2021 07:27:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231437AbhFXHaJ (ORCPT ); Thu, 24 Jun 2021 03:30:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32898 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231434AbhFXHaI (ORCPT ); Thu, 24 Jun 2021 03:30:08 -0400 Received: from mail.skyhub.de (mail.skyhub.de [IPv6:2a01:4f8:190:11c2::b:1457]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B3558C061574; Thu, 24 Jun 2021 00:27:49 -0700 (PDT) Received: from zn.tnic (p200300ec2f0c1e0051d60f689d4f0453.dip0.t-ipconnect.de [IPv6:2003:ec:2f0c:1e00:51d6:f68:9d4f:453]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 2CEBD1EC0253; Thu, 24 Jun 2021 09:27:47 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1624519667; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=Tk8bS/1GVIXPT0HJ7nIwptwsGI5hts/jHchSoFxDYwk=; b=LI0h9MmccHlICbtRqQhCC3gRJh4OKEODp3Chzd+32gPVF3K9RZOvUCpqfOF7Ds7k0dTR42 Pu2uxB3uG0wcizcYUsLG3RGmRR66qZaNYd+x9mNYFTvgAEy+OiP+lpgWjJjEGUkO7KQz33 qu3nAYVYpp+HzJ3neF4aZ/ZyH67DiO8= Date: Thu, 24 Jun 2021 09:27:41 +0200 From: Borislav Petkov To: Michael Roth Cc: "Kuppuswamy, Sathyanarayanan" , Dave Hansen , Brijesh Singh , x86@kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-efi@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-crypto@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Joerg Roedel , Tom Lendacky , "H. Peter Anvin" , Ard Biesheuvel , Paolo Bonzini , Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Andy Lutomirski , Sergio Lopez , Peter Gonda , Peter Zijlstra , Srinivas Pandruvada , David Rientjes , tony.luck@intel.com, npmccallum@redhat.com Subject: Re: [PATCH Part1 RFC v3 20/22] x86/boot: Add Confidential Computing address to setup_header Message-ID: References: <20210602140416.23573-1-brijesh.singh@amd.com> <20210602140416.23573-21-brijesh.singh@amd.com> <15568c80-c9a9-5602-d940-264af87bed98@amd.com> <162442264313.98837.16983159316116149849@amd.com> <20210624031911.eznpkbgjt4e445xj@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210624031911.eznpkbgjt4e445xj@amd.com> Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Wed, Jun 23, 2021 at 10:19:11PM -0500, Michael Roth wrote: > One downside to this is we still need something in the boot protocol, > either via setup_data, or setup_header directly. Huh, now I'm confused. You gave the acpi_rsdp_addr example and I thought that should be enough, that's why I suggested boot_params. Maybe you should point me to the code which does what you need so that I can get a better idea... > Having it in setup_header avoids the need to also have to add a field > to boot_params for the boot/compressed->uncompressed passing, but > maybe that's not a good enough justification. Perhaps if the TDX folks > have similar needs though. Yes, reportedly they do so I guess the solution should be vendor-agnostic. Let's see what they need first. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette