From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66C8CC49EA6 for ; Thu, 24 Jun 2021 16:40:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 42E2F613CC for ; Thu, 24 Jun 2021 16:40:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232075AbhFXQmd (ORCPT ); Thu, 24 Jun 2021 12:42:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46180 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232005AbhFXQmb (ORCPT ); Thu, 24 Jun 2021 12:42:31 -0400 Received: from zeniv-ca.linux.org.uk (zeniv-ca.linux.org.uk [IPv6:2607:5300:60:148a::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DBE62C061574 for ; Thu, 24 Jun 2021 09:40:11 -0700 (PDT) Received: from viro by zeniv-ca.linux.org.uk with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1lwSOK-00BrRG-Mi; Thu, 24 Jun 2021 16:39:48 +0000 Date: Thu, 24 Jun 2021 16:39:48 +0000 From: Al Viro To: Robin Murphy Cc: Matthew Wilcox , Christoph Hellwig , Chen Huang , Mark Rutland , Andrew Morton , Stephen Rothwell , Randy Dunlap , Catalin Marinas , Will Deacon , Linux ARM , linux-mm , open list Subject: Re: [BUG] arm64: an infinite loop in generic_perform_write() Message-ID: References: <20210623132223.GA96264@C02TD0UTHF1T.local> <1c635945-fb25-8871-7b34-f475f75b2caf@huawei.com> <27fbb8c1-2a65-738f-6bec-13f450395ab7@arm.com> <7896a3c7-2e14-d0f4-dbb9-286b6f7181b5@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7896a3c7-2e14-d0f4-dbb9-286b6f7181b5@arm.com> Sender: Al Viro Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 24, 2021 at 05:38:35PM +0100, Robin Murphy wrote: > On 2021-06-24 17:27, Al Viro wrote: > > On Thu, Jun 24, 2021 at 02:22:27PM +0100, Robin Murphy wrote: > > > > > FWIW I think the only way to make the kernel behaviour any more robust here > > > would be to make the whole uaccess API more expressive, such that rather > > > than simply saying "I only got this far" it could actually differentiate > > > between stopping due to a fault which may be recoverable and worth retrying, > > > and one which definitely isn't. > > > > ... and propagate that "more expressive" information through what, 3 or 4 > > levels in the call chain? > > > > From include/linux/uaccess.h: > > > > * If raw_copy_{to,from}_user(to, from, size) returns N, size - N bytes starting > > * at to must become equal to the bytes fetched from the corresponding area > > * starting at from. All data past to + size - N must be left unmodified. > > * > > * If copying succeeds, the return value must be 0. If some data cannot be > > * fetched, it is permitted to copy less than had been fetched; the only > > * hard requirement is that not storing anything at all (i.e. returning size) > > * should happen only when nothing could be copied. In other words, you don't > > * have to squeeze as much as possible - it is allowed, but not necessary. > > > > arm64 instances violate the aforementioned hard requirement. Please, fix > > it there; it's not hard. All you need is an exception handler in .Ltiny15 > > that would fall back to (short) byte-by-byte copy if the faulting address > > happened to be unaligned. Or just do one-byte copy, not that it had been > > considerably cheaper than a loop. Will be cheaper than propagating that extra > > information up the call chain, let alone paying for extra ->write_begin() > > and ->write_end() for single byte in generic_perform_write(). > > And what do we do if we then continue to fault with an external abort > because whatever it is that warranted being mapped as Device-type memory in > the first place doesn't support byte accesses? If it does not support byte access, it would've failed on fault-in. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0BDB0C49EA7 for ; Thu, 24 Jun 2021 16:41:39 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CB04F613C2 for ; Thu, 24 Jun 2021 16:41:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CB04F613C2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=zeniv.linux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Yd82+Fq4aReJJIRjkStGRHz5jYPXlKorNh/ZGYXt14s=; b=aBALam2o9Y04m8 6+bnkk9ZSp9x0LLy3OeifSG4SCiQPe2kw9Lh+Y6pOp2e4rC36aSa4Z+8/uqgmsO2v1xBHlXdMI+xd j2x2OJ0KvTnaRwuEPzUlBf7dfFck+QQd0RUUNJDUJgWRZfXThCWx0tQ8SuyvW/+QcYmAfnc+11vV9 CfeykUAUCsReaoUVMBdGTpFX6plft4847x658FE5AM7zhQEM5eiKRYm0Sh3LLAbnsfrFhqu54tOtO Z3GeVRpQ6LeEJiiYZ64YW+rhYpbGSbNgDzALObrep4wppECVakgbtDLjM2Danj0mbkf9tVXRUrj5b irDk6kwSsg95v2ll8kbw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lwSOk-00FW2e-Om; Thu, 24 Jun 2021 16:40:14 +0000 Received: from zeniv-ca.linux.org.uk ([2607:5300:60:148a::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lwSOf-00FW0X-Tk for linux-arm-kernel@lists.infradead.org; Thu, 24 Jun 2021 16:40:12 +0000 Received: from viro by zeniv-ca.linux.org.uk with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1lwSOK-00BrRG-Mi; Thu, 24 Jun 2021 16:39:48 +0000 Date: Thu, 24 Jun 2021 16:39:48 +0000 From: Al Viro To: Robin Murphy Cc: Matthew Wilcox , Christoph Hellwig , Chen Huang , Mark Rutland , Andrew Morton , Stephen Rothwell , Randy Dunlap , Catalin Marinas , Will Deacon , Linux ARM , linux-mm , open list Subject: Re: [BUG] arm64: an infinite loop in generic_perform_write() Message-ID: References: <20210623132223.GA96264@C02TD0UTHF1T.local> <1c635945-fb25-8871-7b34-f475f75b2caf@huawei.com> <27fbb8c1-2a65-738f-6bec-13f450395ab7@arm.com> <7896a3c7-2e14-d0f4-dbb9-286b6f7181b5@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <7896a3c7-2e14-d0f4-dbb9-286b6f7181b5@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210624_094009_995652_9D4A141E X-CRM114-Status: GOOD ( 26.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jun 24, 2021 at 05:38:35PM +0100, Robin Murphy wrote: > On 2021-06-24 17:27, Al Viro wrote: > > On Thu, Jun 24, 2021 at 02:22:27PM +0100, Robin Murphy wrote: > > > > > FWIW I think the only way to make the kernel behaviour any more robust here > > > would be to make the whole uaccess API more expressive, such that rather > > > than simply saying "I only got this far" it could actually differentiate > > > between stopping due to a fault which may be recoverable and worth retrying, > > > and one which definitely isn't. > > > > ... and propagate that "more expressive" information through what, 3 or 4 > > levels in the call chain? > > > > From include/linux/uaccess.h: > > > > * If raw_copy_{to,from}_user(to, from, size) returns N, size - N bytes starting > > * at to must become equal to the bytes fetched from the corresponding area > > * starting at from. All data past to + size - N must be left unmodified. > > * > > * If copying succeeds, the return value must be 0. If some data cannot be > > * fetched, it is permitted to copy less than had been fetched; the only > > * hard requirement is that not storing anything at all (i.e. returning size) > > * should happen only when nothing could be copied. In other words, you don't > > * have to squeeze as much as possible - it is allowed, but not necessary. > > > > arm64 instances violate the aforementioned hard requirement. Please, fix > > it there; it's not hard. All you need is an exception handler in .Ltiny15 > > that would fall back to (short) byte-by-byte copy if the faulting address > > happened to be unaligned. Or just do one-byte copy, not that it had been > > considerably cheaper than a loop. Will be cheaper than propagating that extra > > information up the call chain, let alone paying for extra ->write_begin() > > and ->write_end() for single byte in generic_perform_write(). > > And what do we do if we then continue to fault with an external abort > because whatever it is that warranted being mapped as Device-type memory in > the first place doesn't support byte accesses? If it does not support byte access, it would've failed on fault-in. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel