From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3A861177 for ; Thu, 24 Jun 2021 16:49:07 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 63551613EE; Thu, 24 Jun 2021 16:49:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1624553346; bh=MeqLZfUB8tx3ZzyZcTQy1E/T0mhq/q0VqTm0Q8WZCNY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=S/EszYzIkqMhReBJSrnSYZCczK+E9eWU7RMshVz5JFn2GPzr2Jz86oyEQbFMC/eJy jYPQ9dOJ7G7q72pqNAlCLQOiZsF/3+Lj7385Y6s1+2iTeOFyV600ntL11bQPofiPw9 q/XqAdDjItAu957n+hOD14NQIOqy+6jEi+ZFZsfc= Date: Thu, 24 Jun 2021 18:49:04 +0200 From: Greg Kroah-Hartman To: Mauro Carvalho Chehab Cc: linuxarm@huawei.com, mauro.chehab@huawei.com, Lee Jones , linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev Subject: Re: [PATCH v7 3/8] staging: hi6421-spmi-pmic: do some additional cleanups Message-ID: References: <08b3d0eb4256c4fad25652f2aeb701b81d11ece2.1624542940.git.mchehab+huawei@kernel.org> <20210624174322.0fe582f0@coco.lan> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210624174322.0fe582f0@coco.lan> On Thu, Jun 24, 2021 at 05:43:22PM +0200, Mauro Carvalho Chehab wrote: > Em Thu, 24 Jun 2021 16:26:41 +0200 > Greg Kroah-Hartman escreveu: > > > On Thu, Jun 24, 2021 at 04:01:32PM +0200, Mauro Carvalho Chehab wrote: > > > Before moving this driver out of staging, do a couple of > > > cleanups, in order to make the driver clearer. > > > > > > No functional changes. > > > > > > Signed-off-by: Mauro Carvalho Chehab > > > --- > > > drivers/staging/hikey9xx/hi6421-spmi-pmic.c | 122 ++++++++++-------- > > > .../hikey9xx/hisilicon,hi6421-spmi-pmic.yaml | 7 +- > > > 2 files changed, 71 insertions(+), 58 deletions(-) > > > > > > diff --git a/drivers/staging/hikey9xx/hi6421-spmi-pmic.c b/drivers/staging/hikey9xx/hi6421-spmi-pmic.c > > > index 626140cb96f2..252b731e272d 100644 > > > --- a/drivers/staging/hikey9xx/hi6421-spmi-pmic.c > > > +++ b/drivers/staging/hikey9xx/hi6421-spmi-pmic.c > > > @@ -2,9 +2,9 @@ > > > /* > > > * Device driver for regulators in HISI PMIC IC > > > * > > > - * Copyright (c) 2013 Linaro Ltd. > > > - * Copyright (c) 2011 Hisilicon. > > > - * Copyright (c) 2020-2021 Huawei Technologies Co., Ltd > > > + * Copyright (c) 2013- Linaro Ltd. > > > + * Copyright (c) 2011- Hisilicon. > > > > What does the "-" mean here? That does not mean from 2013-present. > > I'm pretty sure I found some copyright notes using this convention > somewhere to mean "2013-present". That is not a valid copyright date assignment listing. There is no way to say something like this as it does not make any sense. The years need to be listed individually or as a range. thanks, greg k-h