From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F93CC49EA6 for ; Thu, 24 Jun 2021 13:40:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6B4D361375 for ; Thu, 24 Jun 2021 13:40:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231666AbhFXNnB (ORCPT ); Thu, 24 Jun 2021 09:43:01 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:53750 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229995AbhFXNnA (ORCPT ); Thu, 24 Jun 2021 09:43:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=kJoNj9EV1XTA3nOzVNZZ5d15uvZW2jJVc5PSAJpiypM=; b=niF93v22kDwoh3YOc+RIXkezY3 Yfa1uVichJuoJb6DQzSf+5cCFhhk/qibdhVqv6VqWLUiozFRA40y3NLKPFyTFrmgmO7YDUZmM9mzn iE1sg6CaSuLwuIjEb+uQTwX04CAa4DVit6fNjGEx3NSdHdhnqtB5YRGNwO7HX9hT4sOg=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1lwPac-00AycZ-7y; Thu, 24 Jun 2021 15:40:18 +0200 Date: Thu, 24 Jun 2021 15:40:18 +0200 From: Andrew Lunn To: "Voon, Weifeng" Cc: "Ling, Pei Lee" , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S . Miller" , Jakub Kicinski , Maxime Coquelin , Russell King , "Ong, Boon Leong" , Wong Vee Khee , "Wong, Vee Khee" , "Tan, Tee Min" , "Sit, Michael Wei Hong" , "netdev@vger.kernel.org" , "linux-stm32@st-md-mailman.stormreply.com" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH net-next V1 3/4] net: stmmac: Reconfigure the PHY WOL settings in stmmac_resume() Message-ID: References: <20210621094536.387442-1-pei.lee.ling@intel.com> <20210621094536.387442-4-pei.lee.ling@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > No, the interrupt will not be discarded. If the PHY is in interrupt mode, the > interrupt handler will triggers and ISR will clear the WOL status bit. > The condition here is when the PHY is in polling mode, the PHY driver does not > have any other mechanism to clear the WOL interrupt status bit. > Hence, we need to go through the PHY set_wol() again. I would say you have a broken setup. If you are explicitly using the interrupt as a wakeup source, you need to be servicing the interrupt. You cannot use polled mode. Andrew From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01C7CC49EA5 for ; Thu, 24 Jun 2021 13:42:23 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CA62661375 for ; Thu, 24 Jun 2021 13:42:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CA62661375 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lunn.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8rZ6UcxwxP/69mLcPBFGKMqUuVjQ1d+S9mmqHx+6jzw=; b=nb+Tb7KluZjKao tSrPdsEcx4yblT8WjqrmNbgIPWy7oPNkmUPfXXlGqWx/gMDhYnWU40xsdNP2OFd5cCKGPpIciW0bi gD8xC1ahsXEm2cF738dE9jtFMJN/mM2e6NGoIvSqUifFqFfKAxKUl6afGb/QLt8TOR/QjeZBud22E DwEbrcskpz3YVLyuZhs1ugoMsuH0ySnJug5KZ3lBNSnEMiqVgiaEFVd5MvhFVwurYd7ugPvyfEPxL vxNv2ExdzhKZkp+1TnAu9Z11xgqFBIXHfP4WRTi5DLeu/ZoqGbisvewrR4qv6TOOlgpVAjwvmSD00 5RUbnTawZreOcno5XsyA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lwPb4-00EslR-H9; Thu, 24 Jun 2021 13:40:46 +0000 Received: from vps0.lunn.ch ([185.16.172.187]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lwPb0-00Esir-Bj for linux-arm-kernel@lists.infradead.org; Thu, 24 Jun 2021 13:40:43 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=kJoNj9EV1XTA3nOzVNZZ5d15uvZW2jJVc5PSAJpiypM=; b=niF93v22kDwoh3YOc+RIXkezY3 Yfa1uVichJuoJb6DQzSf+5cCFhhk/qibdhVqv6VqWLUiozFRA40y3NLKPFyTFrmgmO7YDUZmM9mzn iE1sg6CaSuLwuIjEb+uQTwX04CAa4DVit6fNjGEx3NSdHdhnqtB5YRGNwO7HX9hT4sOg=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1lwPac-00AycZ-7y; Thu, 24 Jun 2021 15:40:18 +0200 Date: Thu, 24 Jun 2021 15:40:18 +0200 From: Andrew Lunn To: "Voon, Weifeng" Cc: "Ling, Pei Lee" , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S . Miller" , Jakub Kicinski , Maxime Coquelin , Russell King , "Ong, Boon Leong" , Wong Vee Khee , "Wong, Vee Khee" , "Tan, Tee Min" , "Sit, Michael Wei Hong" , "netdev@vger.kernel.org" , "linux-stm32@st-md-mailman.stormreply.com" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH net-next V1 3/4] net: stmmac: Reconfigure the PHY WOL settings in stmmac_resume() Message-ID: References: <20210621094536.387442-1-pei.lee.ling@intel.com> <20210621094536.387442-4-pei.lee.ling@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210624_064042_462918_31C9D5E5 X-CRM114-Status: UNSURE ( 8.71 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > No, the interrupt will not be discarded. If the PHY is in interrupt mode, the > interrupt handler will triggers and ISR will clear the WOL status bit. > The condition here is when the PHY is in polling mode, the PHY driver does not > have any other mechanism to clear the WOL interrupt status bit. > Hence, we need to go through the PHY set_wol() again. I would say you have a broken setup. If you are explicitly using the interrupt as a wakeup source, you need to be servicing the interrupt. You cannot use polled mode. Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel