From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D560FC49EA7 for ; Thu, 24 Jun 2021 13:41:52 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A12BF61057 for ; Thu, 24 Jun 2021 13:41:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A12BF61057 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9D3B66EB95; Thu, 24 Jun 2021 13:41:50 +0000 (UTC) Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7B0D76EB94 for ; Thu, 24 Jun 2021 13:41:49 +0000 (UTC) Received: by mail-wr1-x434.google.com with SMTP id u11so6691562wrw.11 for ; Thu, 24 Jun 2021 06:41:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=FjNCqJKC4Y1RLns/XS8aAMxmVEkgXAOsPLe38vXYZw4=; b=StsOy8gcKSE6fgXgqNzcG4KKUFLz3Ej1CvQbaQbeBlcW77X5GmHwSCJ1cCCKmF3iUo xEIJavlnTHil2FXV+8lThyvYh+Yj4lwB3fWD16B2+UCnQ/TH3yYv7vpLwJp8h/YNn+VE ffZsBHLoxvfIyne6aOHuOPN1p97SpCRfrJoi8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=FjNCqJKC4Y1RLns/XS8aAMxmVEkgXAOsPLe38vXYZw4=; b=AA/s55eR42kUDBvOlMQ2A4tuq/uG2eMCfvv0Kv6k4mnZtvfEHYDOpj3N++u0C1Q9Yb P00deVQfKo+8xe+/n+dEPxn2kgWLQVdh3SGdIaUdHUUSVtpiATwVrBdkzyTPJnjOkF9+ AGRXncBBWldfQU3vGoP8Uhg6jO2tTgsE0FrUb4EPw6eNYJ9ta66WRnQ736qUI6q1bT34 GC0q5qIzaHWasz8ciDSzu7mu3WtXbd8gacMIdfIoFYC4aGqGX6WFzkQs6RCAkpyIlZuL OZ2Z+3b+tV/qVjjB7Jk5YbJ2x93SH9Lkx1kg99qBHklDOAghZTlp1lH384oYoNxLTKIP aegw== X-Gm-Message-State: AOAM532X/G1RlGrtjwm06NtLEnE4AXX1EUhOwKn/Ljj7DnVlRcie5P+b YWFdyb98T7khEf1ELxBHqDnsMw== X-Google-Smtp-Source: ABdhPJzoh7guSpX+otzlPPnAeqEiddDQTsa2xWiA7Trp2QX6r0I8ZUPaW4riiTz9RCfRbaqeMTVx8Q== X-Received: by 2002:a5d:5146:: with SMTP id u6mr4620731wrt.341.1624542108185; Thu, 24 Jun 2021 06:41:48 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id b7sm3317927wrw.20.2021.06.24.06.41.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Jun 2021 06:41:47 -0700 (PDT) Date: Thu, 24 Jun 2021 15:41:45 +0200 From: Daniel Vetter To: Christian =?iso-8859-1?Q?K=F6nig?= Subject: Re: [PATCH 14/15] drm/gem: Tiny kernel clarification for drm_gem_fence_array_add Message-ID: References: <20210622165511.3169559-1-daniel.vetter@ffwll.ch> <20210622165511.3169559-15-daniel.vetter@ffwll.ch> <4ed8f1d3-eb9c-74d6-d93f-ee28971af7f6@amd.com> <4fba7964-3306-4e2a-f87e-906ebedbe7fe@amd.com> <3800d89a-3591-daf5-6a9a-292f95c58619@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <3800d89a-3591-daf5-6a9a-292f95c58619@amd.com> X-Operating-System: Linux phenom 5.10.0-7-amd64 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Zimmermann , David Airlie , Daniel Vetter , Intel Graphics Development , DRI Development , Daniel Vetter Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, Jun 24, 2021 at 03:35:19PM +0200, Christian König wrote: > Am 24.06.21 um 15:32 schrieb Daniel Vetter: > > On Thu, Jun 24, 2021 at 02:48:54PM +0200, Christian König wrote: > > > > > > Am 24.06.21 um 14:41 schrieb Daniel Vetter: > > > > On Wed, Jun 23, 2021 at 10:42:50AM +0200, Christian König wrote: > > > > > Am 22.06.21 um 18:55 schrieb Daniel Vetter: > > > > > > Spotted while trying to convert panfrost to these. > > > > > > > > > > > > Signed-off-by: Daniel Vetter > > > > > > Cc: "Christian König" > > > > > > Cc: Lucas Stach > > > > > > Cc: Maarten Lankhorst > > > > > > Cc: Maxime Ripard > > > > > > Cc: Thomas Zimmermann > > > > > > Cc: David Airlie > > > > > > Cc: Daniel Vetter > > > > > > --- > > > > > > drivers/gpu/drm/drm_gem.c | 3 +++ > > > > > > 1 file changed, 3 insertions(+) > > > > > > > > > > > > diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/drm/drm_gem.c > > > > > > index ba2e64ed8b47..68deb1de8235 100644 > > > > > > --- a/drivers/gpu/drm/drm_gem.c > > > > > > +++ b/drivers/gpu/drm/drm_gem.c > > > > > > @@ -1302,6 +1302,9 @@ EXPORT_SYMBOL(drm_gem_unlock_reservations); > > > > > > * @fence_array: array of dma_fence * for the job to block on. > > > > > > * @fence: the dma_fence to add to the list of dependencies. > > > > > > * > > > > > > + * This functions consumes the reference for @fence both on success and error > > > > > > + * cases. > > > > > > + * > > > > > Oh, the later is a bit ugly I think. But good to know. > > > > > > > > > > Reviewed-by: Christian König > > > > Merged to drm-misc-next, thanks for taking a look. Can you perhaps take a > > > > look at the drm/armada patch too, then I think I have reviews/acks for all > > > > of them? > > > What are you talking about? I only see drm/armada patches for the irq stuff > > > Thomas is working on. > > There was one in this series, but Maxime was quicker. I'm going to apply > > all the remaining ones now. After that I'll send out a patch set to add > > some dependency tracking to drm_sched_job so that there's not so much > > copypasta going on there. I stumbled over that when reviewing how we > > handle dependencies. > > Do you mean a common container for dma_fence objects a drm_sched_job depends > on? Yup. Well the real usefulness is the interfaces, so that you can just grep for those when trying to figure out htf a driver handles its implicit dependencies. And amdgpu is unfortunately going to be a bit in the cold because it's special (but should be able to benefit too, just more than 1-2 patches to convert it over). Anyway I'm going to type the cover letter rsn. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4917CC49EA5 for ; Thu, 24 Jun 2021 13:41:51 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0F6C2613DC for ; Thu, 24 Jun 2021 13:41:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0F6C2613DC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9C2FF6EB94; Thu, 24 Jun 2021 13:41:50 +0000 (UTC) Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) by gabe.freedesktop.org (Postfix) with ESMTPS id 651EB6EB93 for ; Thu, 24 Jun 2021 13:41:49 +0000 (UTC) Received: by mail-wr1-x433.google.com with SMTP id g7so2099309wri.7 for ; Thu, 24 Jun 2021 06:41:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=FjNCqJKC4Y1RLns/XS8aAMxmVEkgXAOsPLe38vXYZw4=; b=StsOy8gcKSE6fgXgqNzcG4KKUFLz3Ej1CvQbaQbeBlcW77X5GmHwSCJ1cCCKmF3iUo xEIJavlnTHil2FXV+8lThyvYh+Yj4lwB3fWD16B2+UCnQ/TH3yYv7vpLwJp8h/YNn+VE ffZsBHLoxvfIyne6aOHuOPN1p97SpCRfrJoi8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=FjNCqJKC4Y1RLns/XS8aAMxmVEkgXAOsPLe38vXYZw4=; b=DUH2gtH47kFXGkYtuKxfpj300mbhBYbOOisXt/yeV6NZLrYmArWZqtSscA9vEfQoFn agjerl31cqx0eN80UufgqFjlEzVWe1Ydz9FF4+XE7eQjxxoXkbhuZWIZO5dbhGi+8Fso d0X3uJlWoohRXDUtQitEjrhJsqAhAAbPMrvxfs7ZjzgOmDCWLIyAeyiVwoEY7Qe9O/T6 W15fXkGz+2U+StnWbPL6/VTrLxtv0Y+fwEqGwuuCYQJGwo+1LTtgF/H16OUMtE4pjjRf QPt+O5H/iZ2sLGTHIIGq5kH3NzoXMuVlcaKJ2/eeXdTEMTVK0PoDMwTyhbyPlSk0vIfP KJCQ== X-Gm-Message-State: AOAM532Z0gT+rRSDjei7wPBpplc6gsWLGgpE4esISF/0HGWRQoNxC5+F B14xTQK+wpJXYkt8VhOeppvIbg== X-Google-Smtp-Source: ABdhPJzoh7guSpX+otzlPPnAeqEiddDQTsa2xWiA7Trp2QX6r0I8ZUPaW4riiTz9RCfRbaqeMTVx8Q== X-Received: by 2002:a5d:5146:: with SMTP id u6mr4620731wrt.341.1624542108185; Thu, 24 Jun 2021 06:41:48 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id b7sm3317927wrw.20.2021.06.24.06.41.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Jun 2021 06:41:47 -0700 (PDT) Date: Thu, 24 Jun 2021 15:41:45 +0200 From: Daniel Vetter To: Christian =?iso-8859-1?Q?K=F6nig?= Message-ID: References: <20210622165511.3169559-1-daniel.vetter@ffwll.ch> <20210622165511.3169559-15-daniel.vetter@ffwll.ch> <4ed8f1d3-eb9c-74d6-d93f-ee28971af7f6@amd.com> <4fba7964-3306-4e2a-f87e-906ebedbe7fe@amd.com> <3800d89a-3591-daf5-6a9a-292f95c58619@amd.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <3800d89a-3591-daf5-6a9a-292f95c58619@amd.com> X-Operating-System: Linux phenom 5.10.0-7-amd64 Subject: Re: [Intel-gfx] [PATCH 14/15] drm/gem: Tiny kernel clarification for drm_gem_fence_array_add X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Zimmermann , David Airlie , Daniel Vetter , Intel Graphics Development , DRI Development , Maxime Ripard , Daniel Vetter , Lucas Stach Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Thu, Jun 24, 2021 at 03:35:19PM +0200, Christian K=F6nig wrote: > Am 24.06.21 um 15:32 schrieb Daniel Vetter: > > On Thu, Jun 24, 2021 at 02:48:54PM +0200, Christian K=F6nig wrote: > > > = > > > Am 24.06.21 um 14:41 schrieb Daniel Vetter: > > > > On Wed, Jun 23, 2021 at 10:42:50AM +0200, Christian K=F6nig wrote: > > > > > Am 22.06.21 um 18:55 schrieb Daniel Vetter: > > > > > > Spotted while trying to convert panfrost to these. > > > > > > = > > > > > > Signed-off-by: Daniel Vetter > > > > > > Cc: "Christian K=F6nig" > > > > > > Cc: Lucas Stach > > > > > > Cc: Maarten Lankhorst > > > > > > Cc: Maxime Ripard > > > > > > Cc: Thomas Zimmermann > > > > > > Cc: David Airlie > > > > > > Cc: Daniel Vetter > > > > > > --- > > > > > > drivers/gpu/drm/drm_gem.c | 3 +++ > > > > > > 1 file changed, 3 insertions(+) > > > > > > = > > > > > > diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/drm/drm_ge= m.c > > > > > > index ba2e64ed8b47..68deb1de8235 100644 > > > > > > --- a/drivers/gpu/drm/drm_gem.c > > > > > > +++ b/drivers/gpu/drm/drm_gem.c > > > > > > @@ -1302,6 +1302,9 @@ EXPORT_SYMBOL(drm_gem_unlock_reservations= ); > > > > > > * @fence_array: array of dma_fence * for the job to block = on. > > > > > > * @fence: the dma_fence to add to the list of dependencies. > > > > > > * > > > > > > + * This functions consumes the reference for @fence both on su= ccess and error > > > > > > + * cases. > > > > > > + * > > > > > Oh, the later is a bit ugly I think. But good to know. > > > > > = > > > > > Reviewed-by: Christian K=F6nig > > > > Merged to drm-misc-next, thanks for taking a look. Can you perhaps = take a > > > > look at the drm/armada patch too, then I think I have reviews/acks = for all > > > > of them? > > > What are you talking about? I only see drm/armada patches for the irq= stuff > > > Thomas is working on. > > There was one in this series, but Maxime was quicker. I'm going to apply > > all the remaining ones now. After that I'll send out a patch set to add > > some dependency tracking to drm_sched_job so that there's not so much > > copypasta going on there. I stumbled over that when reviewing how we > > handle dependencies. > = > Do you mean a common container for dma_fence objects a drm_sched_job depe= nds > on? Yup. Well the real usefulness is the interfaces, so that you can just grep for those when trying to figure out htf a driver handles its implicit dependencies. And amdgpu is unfortunately going to be a bit in the cold because it's special (but should be able to benefit too, just more than 1-2 patches to convert it over). Anyway I'm going to type the cover letter rsn. -Daniel -- = Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx