From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1780F2FB7 for ; Thu, 24 Jun 2021 14:27:05 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 3C734613F2; Thu, 24 Jun 2021 14:27:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1624544824; bh=sHYaaUtH+g2NFrMoMeOWhr8EhC8hzra0BKRr1vJcO5A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=n34NMTbNqxRrUD8yZop7QeXfVaKUy4EJ0wSwHxa727c9XABF89NmZZczrAllTXT0E EfGMkhKeNCavGuu4PPwJhI88Ff7blMB9Fm3eSySlusqwbX6avQat/VG7Xn35va6e0m 6S0yROl+yWMitSE11kGRRX7Yv/Fh16A0s53eIO0I= Date: Thu, 24 Jun 2021 16:27:02 +0200 From: Greg Kroah-Hartman To: Mauro Carvalho Chehab Cc: linuxarm@huawei.com, mauro.chehab@huawei.com, Lee Jones , linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev Subject: Re: [PATCH v7 3/8] staging: hi6421-spmi-pmic: do some additional cleanups Message-ID: References: <08b3d0eb4256c4fad25652f2aeb701b81d11ece2.1624542940.git.mchehab+huawei@kernel.org> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <08b3d0eb4256c4fad25652f2aeb701b81d11ece2.1624542940.git.mchehab+huawei@kernel.org> On Thu, Jun 24, 2021 at 04:01:32PM +0200, Mauro Carvalho Chehab wrote: > Before moving this driver out of staging, do a couple of > cleanups, in order to make the driver clearer. Please break this up into "one logical change per patch" thanks, greg k-h