From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48AFFC49EA6 for ; Thu, 24 Jun 2021 15:19:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 25ADF61405 for ; Thu, 24 Jun 2021 15:19:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230267AbhFXPWD (ORCPT ); Thu, 24 Jun 2021 11:22:03 -0400 Received: from mail.kernel.org ([198.145.29.99]:46220 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230087AbhFXPWC (ORCPT ); Thu, 24 Jun 2021 11:22:02 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 7444261374; Thu, 24 Jun 2021 15:19:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1624547983; bh=KV10zHBSqlCkuKc2RJJQDADhYV4Qrdmr5zoSUOufvyY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SWsageM1fKXEYBFcT6G+t4lIrigXJtbHW7dNMFYZTCnjAD8+z9FqYUNHYR5TqZEvQ D0E/hElsjg1sUo3YhmxFP3ahKoJ4xUH8Vh+3loTSImVkpHEPl6wrCP85B8/2qcKrtw YMwxGyNanIRc6+1nUbZTJrk45G4JEUWvUyvc0Q5y/00NK04u7GQOlvXsnSb18dBw+6 8w+JoUCvzrAvhcUDn8fYmKwIkA8n4hKthWL40drJUF3U3ygZyjKfDN6uwZqc/dUbY1 uZ/R296o+k7J/ZjSy9NFYa/8fCYZuezNa3AT+flNP7igk7dSYSrKuk9fXyeH5xudy5 i/yVTPyntF7pg== Date: Thu, 24 Jun 2021 17:19:40 +0200 From: Wolfram Sang To: Yoshihiro Shimoda Cc: Geert Uytterhoeven , Laurent Pinchart , Magnus Damm , Rob Herring , Linux-Renesas , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" Subject: Re: [PATCH 04/14] mmc: renesas_sdhi: Add support for R-Car H3e-2G and M3e-2G Message-ID: Mail-Followup-To: Wolfram Sang , Yoshihiro Shimoda , Geert Uytterhoeven , Laurent Pinchart , Magnus Damm , Rob Herring , Linux-Renesas , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" References: <22b4c393bf5074b53791d2797d8fe74deb8ea9a7.1623315732.git.geert+renesas@glider.be> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Mk2WMQJ6OjkrKA/s" Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org --Mk2WMQJ6OjkrKA/s Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable > > I don't fully understand how the refactoring should look like? Is it > > moving 'struct renesas_sdhi_quirks' to renesas_sdhi_internal_dmac.c and > > merge it there with renesas_sdhi_of_data? Is it really better to copy > > this struct per SoC? Most of the data is the same. >=20 > I also have the same concern. But, I guess we can refactor > the renesas_sdhi_of_data like below to avoid increasing data size: >=20 > struct renesas_sdhi_of_data_with_quirks { > const struct renesas_sdhi_of_data *of_data; > const struct renesas_sdhi_quirks *quirks; > }; >=20 > And then, we can keep of_rcar_gen3_compatible and > we can add each SoC's renesas_sdhi_of_data_with_quirks > and set it to the .data. That sounds like a reasonable approach to me. This would also allow us to merge the quirks from sdhi_core with the quirks from sdhi_internal_dmac. --Mk2WMQJ6OjkrKA/s Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmDUoogACgkQFA3kzBSg KbZzQw/9GYBMM268CNgZPNIylRBi83cLVXIzwCzVFdoN7NFsKLR+PfRtj7sI0sm8 krvF9iV4AiQSOqOkQq44fMg8TX4SW104chpSowL1wCOJi3RB1GeWnCrk1Ob8fpTE lU5iYr1AqWd55m9wpqA0ELBhJcvbIVUs3YCEWq2o2lWhQn/cElqfUfw+7r68j1df f4O0kyU4ZhAMaBrpnC2bnseFFchgPtdpeoAgQHsX6TEqGwIfuPY+OLt32CWVFL1x EyeT9mXOqc95Ozqs3CbufzMbUT9W7A5VW2+X1ZiV2fSE1yUhKRJP+fGY4YUibLrD iS+Oi5HcTYQj+2vOEFuGpVTAoJy8Ay8n9bPx20nZTFEWFvUWNw/AE3VGIZHF54n3 jSNqlSq0VqtczcfIULSPMvl6UxjWDadvBFkAxf2SqKHItU/z0hmCs65DyObK5e14 2HqOIvdp1ZF0ps76BLpryqh+TFQ0/ljazB6cQAlEuyTeDyTx4dOFlPOGyWspSknI sfjwe+wD25WiXCPGDyOa+ZdclOQUlXKAL/k/Fcso1pnumd2BbDyZ/QeDL+gYj/r9 ACzokBxFu1Pu2xyFtkehwYVV54hw9Yszj57iwrQ200IHC4gHoS0S0eYWoRJ/a0aL lRmkAAkOjGEVOul7ipcKb+lQAcFxb8nJ/sexCEhuN3DXA5SaKcU= =Btk4 -----END PGP SIGNATURE----- --Mk2WMQJ6OjkrKA/s--