From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD713C49EA6 for ; Thu, 24 Jun 2021 17:38:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A68C1613DC for ; Thu, 24 Jun 2021 17:38:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232425AbhFXRkp (ORCPT ); Thu, 24 Jun 2021 13:40:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59358 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229464AbhFXRko (ORCPT ); Thu, 24 Jun 2021 13:40:44 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 22EDCC061574; Thu, 24 Jun 2021 10:38:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=2CrBXZN94UanW7Z9wbxJJ19Ik2XzepvUm7qpu+EStk0=; b=jBQ0NmZKRLHKjDQc9jvD3aDUNp GR1n7RIIEIJxc7aqo9Iey0Z3VDbjtjG+RFJAjM6Rj37cXXF0S/uDHWuh67kp9PoTSTcQAAGHF0qOJ nsEBM6acW7i4XA1lZMSltDK7xft6gXjXGxQB22wfNg/M+Ql1MoBPG2Xj7QXGZXQE9WsHe1lBg2Xc4 iYlT21yUploEw+7s5BsHk76qt6G2wKLp5ppjmHOZ0wF/7MYsLjTM0GVod6ADQy9RcDb+HMo148mOq VFndPkGbwHRjm1ZgC++Nr3y/fJNxeVF7B+4nwlEoYsiairK88dsXFpw4jOmAlmKanrxufNAnLxKSX 3jbEo0kQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1lwTIR-00GpHA-RT; Thu, 24 Jun 2021 17:37:52 +0000 Date: Thu, 24 Jun 2021 18:37:47 +0100 From: Matthew Wilcox To: Christoph Hellwig Cc: akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 17/46] mm/memcg: Convert mem_cgroup_track_foreign_dirty_slowpath() to folio Message-ID: References: <20210622121551.3398730-1-willy@infradead.org> <20210622121551.3398730-18-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 23, 2021 at 10:21:26AM +0200, Christoph Hellwig wrote: > Looks good, > > Reviewed-by: Christoph Hellwig > > Although I wish we could come up with a shorter name for > mem_cgroup_track_foreign_dirty_slowpath somehow.. It is quite grotesque! How about folio_track_foreign_writeback() as a replacement name for mem_cgroup_track_foreign_dirty() and have it call __folio_track_foreign_writeback()? Although 'foreign' tends to be used in MM to mean "wrong NUMA node", so maybe that's misleading. folio_track_dirty_cgroup()? folio_mark_dirty_cgroup()? (the last to be read in context of __set_page_dirty() being renamed to __folio_mark_dirty())