From: Lee Jones <lee.jones@linaro.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Daniel Thompson <daniel.thompson@linaro.org>,
Jingoo Han <jingoohan1@gmail.com>,
linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
Thierry Reding <thierry.reding@gmail.com>,
kernel@pengutronix.de
Subject: Re: [PATCH v3 2/2] backlight: lm3630a: convert to atomic PWM API and check for errors
Date: Fri, 25 Jun 2021 09:44:43 +0100 [thread overview]
Message-ID: <YNWXe9OhS3o4iRGi@dell> (raw)
In-Reply-To: <20210624201009.5se7o27b7m6bff4g@pengutronix.de>
On Thu, 24 Jun 2021, Uwe Kleine-König wrote:
> Hi Lee,
>
> On Tue, Jun 22, 2021 at 02:12:57PM +0100, Lee Jones wrote:
> > On Mon, 21 Jun 2021, Uwe Kleine-König wrote:
> >
> > > The practical upside here is that this only needs a single API call to
> > > program the hardware which (depending on the underlaying hardware) can
> > > be more effective and prevents glitches.
> > >
> > > Up to now the return value of the pwm functions was ignored. Fix this
> > > and propagate the error to the caller.
> > >
> > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> > > ---
> > > drivers/video/backlight/lm3630a_bl.c | 42 +++++++++++++---------------
> > > 1 file changed, 19 insertions(+), 23 deletions(-)
> >
> > Fixed the subject line and applied, thanks.
>
> It's not obvious to me what needed fixing here, and I don't find where
> you the patches, neither in next nor in
> https://git.kernel.org/pub/scm/linux/kernel/git/lee/backlight.git; so I
> cannot check what you actually changed.
>
> I assume you did s/lm3630a/lm3630a_bl/ ? I didn't because it felt
> tautological.
No, but perhaps I should have. Format goes:
<backlight>: <driver_file_name>: <Subject starting with uppercase>
Where <driver_file_name> has the file extension removed.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2021-06-25 8:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-21 12:21 [PATCH v3 0/2] backlight: lm3630a: convert to atomic PWM API Uwe Kleine-König
2021-06-21 12:21 ` Uwe Kleine-König
2021-06-21 12:21 ` [PATCH v3 1/2] backlight: lm3630a: fix return code of .update_status() callback Uwe Kleine-König
2021-06-21 12:21 ` Uwe Kleine-König
2021-06-21 13:06 ` Daniel Thompson
2021-06-21 13:06 ` Daniel Thompson
2021-06-22 13:11 ` Lee Jones
2021-06-22 13:11 ` Lee Jones
2021-06-21 12:21 ` [PATCH v3 2/2] backlight: lm3630a: convert to atomic PWM API and check for errors Uwe Kleine-König
2021-06-21 12:21 ` Uwe Kleine-König
2021-06-21 13:14 ` Daniel Thompson
2021-06-21 13:14 ` Daniel Thompson
2021-06-22 13:12 ` Lee Jones
2021-06-22 13:12 ` Lee Jones
2021-06-24 20:10 ` Uwe Kleine-König
2021-06-25 8:44 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YNWXe9OhS3o4iRGi@dell \
--to=lee.jones@linaro.org \
--cc=daniel.thompson@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jingoohan1@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-fbdev@vger.kernel.org \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.