From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5ACBEC49EA7 for ; Mon, 28 Jun 2021 06:53:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 37136619F1 for ; Mon, 28 Jun 2021 06:53:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232240AbhF1Gzc (ORCPT ); Mon, 28 Jun 2021 02:55:32 -0400 Received: from mail.kernel.org ([198.145.29.99]:50052 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229998AbhF1Gza (ORCPT ); Mon, 28 Jun 2021 02:55:30 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id A435D619A3; Mon, 28 Jun 2021 06:53:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1624863185; bh=G3fzbTwZoVC5otl/ywBvSBZTfbpse+RSsAZqEbAHOOg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=YRlKkDF0aaCNiuNNNfNpQNovBX7R+0xJj3sd18dP2Q9GwDNOKvZXDO3rCdQPLVxRr pB9iTTrOXq/OD2tpqHEBl+gtiNO/nlcS6SZlpc4qCNKxB5lHsaJGXz/BkY0G4gAJZL QqBIMOAkzaAtBeUaBd5d45/JWz9Ver9N1vGvrwm8= Date: Mon, 28 Jun 2021 08:53:02 +0200 From: Greg Kroah-Hartman To: Jung Daehwan Cc: Mathias Nyman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: usb: host: Reduce xhci_handshake timeout in xhci_reset Message-ID: References: <1624361096-41282-1-git-send-email-dh10.jung@samsung.com> <20210628022548.GA69289@ubuntu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210628022548.GA69289@ubuntu> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 28, 2021 at 11:25:48AM +0900, Jung Daehwan wrote: > On Tue, Jun 22, 2021 at 09:56:20PM +0200, Greg Kroah-Hartman wrote: > > On Tue, Jun 22, 2021 at 08:24:56PM +0900, Daehwan Jung wrote: > > > It seems 10 secs timeout is too long in general case. A core would wait for > > > 10 secs without doing other task and it can be happended on every device. > > > > Only if the handshake does not come back sooner, right? > > Yes, right. > > > What is causing your device to timeout here? > > Host Controller doesn't respond handshake. I don't know why and I ask HW team > to debug it. Please work to fix your hardware, that feels like the root of the problem here. If you require the timeout for xhci_reset() to happen, then how do you know that the hardware really did reset properly in the reduced amount of time you just provided? thanks, greg k-h