From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 1/1] cgroup/cgroup_regression_test: Fix umount failure
Date: Mon, 28 Jun 2021 10:49:39 +0200 [thread overview]
Message-ID: <YNmNI3omBfAnj5dN@pevik> (raw)
In-Reply-To: <caf1bb46-5212-3c3d-f180-e722ef2cf8dd@jv-coder.de>
Hi all,
[ changed Cyril's address in Cc to the working one ]
> > mkdir cgroup/0
> > sleep 100 < cgroup/0 & # add refcnt to this dir
> > rmdir cgroup/0
> > + sync
> > # remount with some subsystems removed
> > # since 2.6.28, this remount will fail
> I would like a short comment close to the syncs. When I converted
> cpuset_regression_test.sh, I would have removed the sync in there, if there
> wouldn't have been any comment.
> Most of the time syncs are not required and just added by paranoid
> developers, but if there is a real reason, I think it should be stated in a
> comment.
Agree with this. Are all these sync really needed? Or just some?
Kind regards,
Petr
> J?rg
next prev parent reply other threads:[~2021-06-28 8:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-28 3:30 [LTP] [PATCH 1/1] cgroup/cgroup_regression_test: Fix umount failure Leo Liang
2021-06-28 7:24 ` Richard Palethorpe
2021-06-28 7:36 ` Joerg Vehlow
2021-06-28 8:49 ` Petr Vorel [this message]
2021-06-28 13:08 ` Cyril Hrubis
2021-07-06 3:27 ` Leo Liang
2021-07-06 5:45 ` xuyang2018.jy
2021-07-12 7:28 ` Leo Liang
2021-06-29 7:01 ` xuyang2018.jy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YNmNI3omBfAnj5dN@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.