From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BE51C49EB7 for ; Mon, 28 Jun 2021 09:30:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 666CE61C5B for ; Mon, 28 Jun 2021 09:30:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232577AbhF1JdM (ORCPT ); Mon, 28 Jun 2021 05:33:12 -0400 Received: from mail.kernel.org ([198.145.29.99]:32900 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232426AbhF1JdL (ORCPT ); Mon, 28 Jun 2021 05:33:11 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 3D96461C5A; Mon, 28 Jun 2021 09:30:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1624872646; bh=tko4HhpTn1KfqSQcG6rk256TdCkSHRTiZNDg1gfOL1U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mdirt+wh3MtaZ7eNyZ9G3nbYCW5idUpb0uLyW3y3Pff8g1i8FeRt120hCx8rMfLOA LnRoyQZ6znqLxXb5WQ4POqk3nvJJlxgEnyIMLyf/4xRDnJ3jrCYholI79Dx7JQswRh BPPsck43uFy1epGSrPj0zjj0CnIzhGXT51/oNF84= Date: Mon, 28 Jun 2021 11:30:41 +0200 From: Greg KH To: Rocco Yue Cc: "David S . Miller" , Jakub Kicinski , Jonathan Corbet , Hideaki YOSHIFUJI , David Ahern , Matthias Brugger , Felix Fietkau , John Crispin , Sean Wang , Mark Lee , netdev@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, bpf@vger.kernel.org, wsd_upstream@mediatek.com, chao.song@mediatek.com, kuohong.wang@mediatek.com Subject: Re: [PATCH 4/4] drivers: net: mediatek: initial implementation of ccmni Message-ID: References: <20210628071829.14925-1-rocco.yue@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210628071829.14925-1-rocco.yue@mediatek.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 28, 2021 at 03:18:30PM +0800, Rocco Yue wrote: > On Thu, 2021-06-24 at 18:51 +0200, Greg KH wrote: > On Thu, Jun 24, 2021 at 11:55:02PM +0800, Rocco Yue wrote: > >> On Thu, 2021-06-24 at 14:23 +0200, Greg KH wrote: > >> On Thu, Jun 24, 2021 at 07:53:49PM +0800, Rocco Yue wrote: > >>> > >>> not have exports that no one uses. Please add the driver to this patch > >>> series when you resend it. > >>> > >> > >> I've just took a look at what the Linux staging tree is. It looks like > >> a good choice for the current ccmni driver. > >> > >> honstly, If I simply upload the relevant driver code B that calls > >> A (e.g. ccmni_rx_push), there is still a lack of code to call B. > >> This seems to be a continuty problem, unless all drivers codes are > >> uploaded (e.g. power on modem, get hardware status, complete tx/rx flow). > > > > Great, send it all! Why is it different modules, it's only for one > > chunk of hardware, no need to split it up into tiny pieces. That way > > only causes it to be more code overall. > > > >> > >> Thanks~ > >> > >> Can I resend patch set as follows: > >> (1) supplement the details of pureip for patch 1/4; > >> (2) the document of ccmni.rst still live in the Documentation/... > >> (3) modify ccmni and move it into the drivers/staging/... > > > > for drivers/staging/ the code needs to be "self contained" in that it > > does not require adding anything outside of the directory for it. > > > > If you still require this core networking change, that needs to be > > accepted first by the networking developers and maintainers. > > > > thanks, > > > > greg k-h > > > > Hi Greg, > > I am grateful for your help. > > Both ccmni change and networking changes are needed, because as far > as I know, usually a device type should have at least one device to > use it, and pureip is what the ccmni driver needs, so I uploaded the > networking change and ccmni driver together; > > Since MTK’s modem driver has a large amount of code and strong code > coupling, it takes some time to clean up them. At this stage, it may > be difficult to upstream all the codes together. Why? Just dump the whole thing in a drivers/staging/mtk/ directory structure and all should be fine. > During this period, even if ccmni is incomplete, can I put the ccmni > driver initial code in the driver/staging first ? After that, we will > gradually implement more functions of ccmni in the staging tree, and > we can also gradually sort out and clean up modem driver in the staging. I do not know, let's see the code first. But we can not add frameworks with no in-kernel users, as that does not make any sense at all. > In addition, due to the requirements of GKI 2.0, That is a Google requirement, not a kernel.org requirement. Please work with Google if you have questions/issues about that, there is NOTHING we can do about that here in the community for obvious reasons. > if ccmni device > uses RAWIP or NONE, it will hit ipv6 issue; and if ccmni uses > a device type other than PUREIP/RAWIP/NONE, there will be tethering > ebpf offload or clat ebpf offload can not work problems. > > I hope PUREIP and ccmni can be accepted by the Linux community. As I stated before you need to have an in-kernel user for us to be able to accept frameworks and functions into the tree. Otherwise Linux would quickly become unmanagable and unmaintainable. Would you want to try to maintain code with no in-tree users? What would you do if you were in our position? But for networking flags like this that go into userspace, I do not know what the maintainers of the networking stack require, so that really is up to them, not me. thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B574CC49EB7 for ; Mon, 28 Jun 2021 09:31:15 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 789D661C59 for ; Mon, 28 Jun 2021 09:31:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 789D661C59 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=OGtBQwLwf2V4UeQdGgYQZ30L+IaNKpkWzCxcKaxcdDs=; b=Crb2XXRqvgGO1q EyZnMiiswPWOH82IsTktgA1f7i+sDX1Rw1DAz3IrhRyExyL8XzIHUzzYDGl06VYh1WifUFVTxkD5D mymdC4kIQJUg7Wb2wVNZA245YXTKiYLLz4DuWLMedi4q6TlPIhqimgk7FB02iAj/OMibfskxlHCke PUpXLEG9z248zmZFEjMh2kZ+kuzXfuuq1ZIg2JaTvXqbIHKCXd8cXunMXdiR8u1q1LJs1s+sHdAMX la557LiYegi1v46eYo+5gaB3/dgYEZ7s3ZVUWeS4Lf1ZsEglf/Q9asXF5fcCYjM0akNRmY4VMjAID 84knlgRCnSSXzSb/zt0g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lxnbW-007UFg-Lm; Mon, 28 Jun 2021 09:30:58 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lxnbK-007UDR-Ba; Mon, 28 Jun 2021 09:30:47 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 3D96461C5A; Mon, 28 Jun 2021 09:30:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1624872646; bh=tko4HhpTn1KfqSQcG6rk256TdCkSHRTiZNDg1gfOL1U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mdirt+wh3MtaZ7eNyZ9G3nbYCW5idUpb0uLyW3y3Pff8g1i8FeRt120hCx8rMfLOA LnRoyQZ6znqLxXb5WQ4POqk3nvJJlxgEnyIMLyf/4xRDnJ3jrCYholI79Dx7JQswRh BPPsck43uFy1epGSrPj0zjj0CnIzhGXT51/oNF84= Date: Mon, 28 Jun 2021 11:30:41 +0200 From: Greg KH To: Rocco Yue Cc: "David S . Miller" , Jakub Kicinski , Jonathan Corbet , Hideaki YOSHIFUJI , David Ahern , Matthias Brugger , Felix Fietkau , John Crispin , Sean Wang , Mark Lee , netdev@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, bpf@vger.kernel.org, wsd_upstream@mediatek.com, chao.song@mediatek.com, kuohong.wang@mediatek.com Subject: Re: [PATCH 4/4] drivers: net: mediatek: initial implementation of ccmni Message-ID: References: <20210628071829.14925-1-rocco.yue@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210628071829.14925-1-rocco.yue@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210628_023046_478494_239232F6 X-CRM114-Status: GOOD ( 40.37 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org T24gTW9uLCBKdW4gMjgsIDIwMjEgYXQgMDM6MTg6MzBQTSArMDgwMCwgUm9jY28gWXVlIHdyb3Rl Ogo+IE9uIFRodSwgMjAyMS0wNi0yNCBhdCAxODo1MSArMDIwMCwgR3JlZyBLSCB3cm90ZToKPiBP biBUaHUsIEp1biAyNCwgMjAyMSBhdCAxMTo1NTowMlBNICswODAwLCBSb2NjbyBZdWUgd3JvdGU6 Cj4gPj4gT24gVGh1LCAyMDIxLTA2LTI0IGF0IDE0OjIzICswMjAwLCBHcmVnIEtIIHdyb3RlOgo+ ID4+IE9uIFRodSwgSnVuIDI0LCAyMDIxIGF0IDA3OjUzOjQ5UE0gKzA4MDAsIFJvY2NvIFl1ZSB3 cm90ZToKPiA+Pj4gCj4gPj4+IG5vdCBoYXZlIGV4cG9ydHMgdGhhdCBubyBvbmUgdXNlcy4gIFBs ZWFzZSBhZGQgdGhlIGRyaXZlciB0byB0aGlzIHBhdGNoCj4gPj4+IHNlcmllcyB3aGVuIHlvdSBy ZXNlbmQgaXQuCj4gPj4+IAo+ID4+IAo+ID4+IEkndmUganVzdCB0b29rIGEgbG9vayBhdCB3aGF0 IHRoZSBMaW51eCBzdGFnaW5nIHRyZWUgaXMuIEl0IGxvb2tzIGxpa2UKPiA+PiBhIGdvb2QgY2hv aWNlIGZvciB0aGUgY3VycmVudCBjY21uaSBkcml2ZXIuCj4gPj4gCj4gPj4gaG9uc3RseSwgSWYg SSBzaW1wbHkgdXBsb2FkIHRoZSByZWxldmFudCBkcml2ZXIgY29kZSBCIHRoYXQgY2FsbHMKPiA+ PiBBIChlLmcuIGNjbW5pX3J4X3B1c2gpLCB0aGVyZSBpcyBzdGlsbCBhIGxhY2sgb2YgY29kZSB0 byBjYWxsIEIuCj4gPj4gVGhpcyBzZWVtcyB0byBiZSBhIGNvbnRpbnV0eSBwcm9ibGVtLCB1bmxl c3MgYWxsIGRyaXZlcnMgY29kZXMgYXJlCj4gPj4gdXBsb2FkZWQgKGUuZy4gcG93ZXIgb24gbW9k ZW0sIGdldCBoYXJkd2FyZSBzdGF0dXMsIGNvbXBsZXRlIHR4L3J4IGZsb3cpLgo+ID4gCj4gPiBH cmVhdCwgc2VuZCBpdCBhbGwhICBXaHkgaXMgaXQgZGlmZmVyZW50IG1vZHVsZXMsIGl0J3Mgb25s eSBmb3Igb25lCj4gPiBjaHVuayBvZiBoYXJkd2FyZSwgbm8gbmVlZCB0byBzcGxpdCBpdCB1cCBp bnRvIHRpbnkgcGllY2VzLiAgVGhhdCB3YXkKPiA+IG9ubHkgY2F1c2VzIGl0IHRvIGJlIG1vcmUg Y29kZSBvdmVyYWxsLgo+ID4gCj4gPj4gCj4gPj4gVGhhbmtzfgo+ID4+IAo+ID4+IENhbiBJIHJl c2VuZCBwYXRjaCBzZXQgYXMgZm9sbG93czoKPiA+PiAoMSkgc3VwcGxlbWVudCB0aGUgZGV0YWls cyBvZiBwdXJlaXAgZm9yIHBhdGNoIDEvNDsKPiA+PiAoMikgdGhlIGRvY3VtZW50IG9mIGNjbW5p LnJzdCBzdGlsbCBsaXZlIGluIHRoZSBEb2N1bWVudGF0aW9uLy4uLgo+ID4+ICgzKSBtb2RpZnkg Y2NtbmkgYW5kIG1vdmUgaXQgaW50byB0aGUgZHJpdmVycy9zdGFnaW5nLy4uLgo+ID4gCj4gPiBm b3IgZHJpdmVycy9zdGFnaW5nLyB0aGUgY29kZSBuZWVkcyB0byBiZSAic2VsZiBjb250YWluZWQi IGluIHRoYXQgaXQKPiA+IGRvZXMgbm90IHJlcXVpcmUgYWRkaW5nIGFueXRoaW5nIG91dHNpZGUg b2YgdGhlIGRpcmVjdG9yeSBmb3IgaXQuCj4gPiAKPiA+IElmIHlvdSBzdGlsbCByZXF1aXJlIHRo aXMgY29yZSBuZXR3b3JraW5nIGNoYW5nZSwgdGhhdCBuZWVkcyB0byBiZQo+ID4gYWNjZXB0ZWQg Zmlyc3QgYnkgdGhlIG5ldHdvcmtpbmcgZGV2ZWxvcGVycyBhbmQgbWFpbnRhaW5lcnMuCj4gPiAK PiA+IHRoYW5rcywKPiA+IAo+ID4gZ3JlZyBrLWgKPiA+IAo+IAo+IEhpIEdyZWcsCj4gCj4gSSBh bSBncmF0ZWZ1bCBmb3IgeW91ciBoZWxwLgo+IAo+IEJvdGggY2NtbmkgY2hhbmdlIGFuZCBuZXR3 b3JraW5nIGNoYW5nZXMgYXJlIG5lZWRlZCwgYmVjYXVzZSBhcyBmYXIKPiBhcyBJIGtub3csIHVz dWFsbHkgYSBkZXZpY2UgdHlwZSBzaG91bGQgaGF2ZSBhdCBsZWFzdCBvbmUgZGV2aWNlIHRvCj4g dXNlIGl0LCBhbmQgcHVyZWlwIGlzIHdoYXQgdGhlIGNjbW5pIGRyaXZlciBuZWVkcywgc28gSSB1 cGxvYWRlZCB0aGUKPiBuZXR3b3JraW5nIGNoYW5nZSBhbmQgY2NtbmkgZHJpdmVyIHRvZ2V0aGVy Owo+IAo+IFNpbmNlIE1US+KAmXMgbW9kZW0gZHJpdmVyIGhhcyBhIGxhcmdlIGFtb3VudCBvZiBj b2RlIGFuZCBzdHJvbmcgY29kZQo+IGNvdXBsaW5nLCBpdCB0YWtlcyBzb21lIHRpbWUgdG8gY2xl YW4gdXAgdGhlbS4gQXQgdGhpcyBzdGFnZSwgaXQgbWF5Cj4gYmUgZGlmZmljdWx0IHRvIHVwc3Ry ZWFtIGFsbCB0aGUgY29kZXMgdG9nZXRoZXIuCgpXaHk/ICBKdXN0IGR1bXAgdGhlIHdob2xlIHRo aW5nIGluIGEgZHJpdmVycy9zdGFnaW5nL210ay8gZGlyZWN0b3J5CnN0cnVjdHVyZSBhbmQgYWxs IHNob3VsZCBiZSBmaW5lLgoKPiBEdXJpbmcgdGhpcyBwZXJpb2QsIGV2ZW4gaWYgY2NtbmkgaXMg aW5jb21wbGV0ZSwgY2FuIEkgcHV0IHRoZSBjY21uaQo+IGRyaXZlciBpbml0aWFsIGNvZGUgaW4g dGhlIGRyaXZlci9zdGFnaW5nIGZpcnN0ID8gQWZ0ZXIgdGhhdCwgd2Ugd2lsbAo+IGdyYWR1YWxs eSBpbXBsZW1lbnQgbW9yZSBmdW5jdGlvbnMgb2YgY2NtbmkgaW4gdGhlIHN0YWdpbmcgdHJlZSwg YW5kCj4gd2UgY2FuIGFsc28gZ3JhZHVhbGx5IHNvcnQgb3V0IGFuZCBjbGVhbiB1cCBtb2RlbSBk cml2ZXIgaW4gdGhlIHN0YWdpbmcuCgpJIGRvIG5vdCBrbm93LCBsZXQncyBzZWUgdGhlIGNvZGUg Zmlyc3QuICBCdXQgd2UgY2FuIG5vdCBhZGQgZnJhbWV3b3Jrcwp3aXRoIG5vIGluLWtlcm5lbCB1 c2VycywgYXMgdGhhdCBkb2VzIG5vdCBtYWtlIGFueSBzZW5zZSBhdCBhbGwuCgo+IEluIGFkZGl0 aW9uLCBkdWUgdG8gdGhlIHJlcXVpcmVtZW50cyBvZiBHS0kgMi4wLAoKVGhhdCBpcyBhIEdvb2ds ZSByZXF1aXJlbWVudCwgbm90IGEga2VybmVsLm9yZyByZXF1aXJlbWVudC4gIFBsZWFzZSB3b3Jr CndpdGggR29vZ2xlIGlmIHlvdSBoYXZlIHF1ZXN0aW9ucy9pc3N1ZXMgYWJvdXQgdGhhdCwgdGhl cmUgaXMgTk9USElORyB3ZQpjYW4gZG8gYWJvdXQgdGhhdCBoZXJlIGluIHRoZSBjb21tdW5pdHkg Zm9yIG9idmlvdXMgcmVhc29ucy4KCj4gaWYgY2NtbmkgZGV2aWNlCj4gdXNlcyBSQVdJUCBvciBO T05FLCBpdCB3aWxsIGhpdCBpcHY2IGlzc3VlOyBhbmQgaWYgY2NtbmkgdXNlcwo+IGEgZGV2aWNl IHR5cGUgb3RoZXIgdGhhbiBQVVJFSVAvUkFXSVAvTk9ORSwgdGhlcmUgd2lsbCBiZSB0ZXRoZXJp bmcKPiBlYnBmIG9mZmxvYWQgb3IgY2xhdCBlYnBmIG9mZmxvYWQgY2FuIG5vdCB3b3JrIHByb2Js ZW1zLgo+IAo+IEkgaG9wZSBQVVJFSVAgYW5kIGNjbW5pIGNhbiBiZSBhY2NlcHRlZCBieSB0aGUg TGludXggY29tbXVuaXR5LgoKQXMgSSBzdGF0ZWQgYmVmb3JlIHlvdSBuZWVkIHRvIGhhdmUgYW4g aW4ta2VybmVsIHVzZXIgZm9yIHVzIHRvIGJlIGFibGUKdG8gYWNjZXB0IGZyYW1ld29ya3MgYW5k IGZ1bmN0aW9ucyBpbnRvIHRoZSB0cmVlLiAgT3RoZXJ3aXNlIExpbnV4IHdvdWxkCnF1aWNrbHkg YmVjb21lIHVubWFuYWdhYmxlIGFuZCB1bm1haW50YWluYWJsZS4gIFdvdWxkIHlvdSB3YW50IHRv IHRyeSB0bwptYWludGFpbiBjb2RlIHdpdGggbm8gaW4tdHJlZSB1c2Vycz8gIFdoYXQgd291bGQg eW91IGRvIGlmIHlvdSB3ZXJlIGluCm91ciBwb3NpdGlvbj8KCkJ1dCBmb3IgbmV0d29ya2luZyBm bGFncyBsaWtlIHRoaXMgdGhhdCBnbyBpbnRvIHVzZXJzcGFjZSwgSSBkbyBub3Qga25vdwp3aGF0 IHRoZSBtYWludGFpbmVycyBvZiB0aGUgbmV0d29ya2luZyBzdGFjayByZXF1aXJlLCBzbyB0aGF0 IHJlYWxseSBpcwp1cCB0byB0aGVtLCBub3QgbWUuCgp0aGFua3MsCgpncmVnIGstaAoKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KTGludXgtbWVkaWF0ZWsg bWFpbGluZyBsaXN0CkxpbnV4LW1lZGlhdGVrQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xp c3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1tZWRpYXRlawo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F2FAC2B9F4 for ; Mon, 28 Jun 2021 09:33:23 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D3F7F619C5 for ; Mon, 28 Jun 2021 09:33:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D3F7F619C5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=b59H7ozVfAdQ2vPkEP0gGeZQloesCfE16loOqnLXo8s=; b=2UUEn4DjxQ+ccB qhf9gbRSLMyHi0tWnHXeVpdeyTtQHK+nKKojIAvkQBmRxjTOWvHWZQjAUyZtzr2uRVgNNnpLjriEb XmJadvMG3FDVLhiObLzMIPlDDUUjPgfmueGuMjaTF+6Rj5F1Xq3cWAGNu4fvPsoSZLAdysmjItDiO AwqhS1Cu4cKXbaBLb3kgQit+cK1U81DUJlPyPjuOK0Fw6M6wG7tTL5XEZTFJeyMMx2Omg0mYXfGTq J38HKii4+tsNJPeHnUYHSbFYqUGdcSgxSJ+cB46VhDJWF44y+6E8YhnZzF5eHeW+DaO/DIxOHA27q EIYEh5a0titVc6OrV1vA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lxnbN-007UEK-Qi; Mon, 28 Jun 2021 09:30:49 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lxnbK-007UDR-Ba; Mon, 28 Jun 2021 09:30:47 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 3D96461C5A; Mon, 28 Jun 2021 09:30:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1624872646; bh=tko4HhpTn1KfqSQcG6rk256TdCkSHRTiZNDg1gfOL1U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mdirt+wh3MtaZ7eNyZ9G3nbYCW5idUpb0uLyW3y3Pff8g1i8FeRt120hCx8rMfLOA LnRoyQZ6znqLxXb5WQ4POqk3nvJJlxgEnyIMLyf/4xRDnJ3jrCYholI79Dx7JQswRh BPPsck43uFy1epGSrPj0zjj0CnIzhGXT51/oNF84= Date: Mon, 28 Jun 2021 11:30:41 +0200 From: Greg KH To: Rocco Yue Cc: "David S . Miller" , Jakub Kicinski , Jonathan Corbet , Hideaki YOSHIFUJI , David Ahern , Matthias Brugger , Felix Fietkau , John Crispin , Sean Wang , Mark Lee , netdev@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, bpf@vger.kernel.org, wsd_upstream@mediatek.com, chao.song@mediatek.com, kuohong.wang@mediatek.com Subject: Re: [PATCH 4/4] drivers: net: mediatek: initial implementation of ccmni Message-ID: References: <20210628071829.14925-1-rocco.yue@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210628071829.14925-1-rocco.yue@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210628_023046_478494_239232F6 X-CRM114-Status: GOOD ( 40.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCBKdW4gMjgsIDIwMjEgYXQgMDM6MTg6MzBQTSArMDgwMCwgUm9jY28gWXVlIHdyb3Rl Ogo+IE9uIFRodSwgMjAyMS0wNi0yNCBhdCAxODo1MSArMDIwMCwgR3JlZyBLSCB3cm90ZToKPiBP biBUaHUsIEp1biAyNCwgMjAyMSBhdCAxMTo1NTowMlBNICswODAwLCBSb2NjbyBZdWUgd3JvdGU6 Cj4gPj4gT24gVGh1LCAyMDIxLTA2LTI0IGF0IDE0OjIzICswMjAwLCBHcmVnIEtIIHdyb3RlOgo+ ID4+IE9uIFRodSwgSnVuIDI0LCAyMDIxIGF0IDA3OjUzOjQ5UE0gKzA4MDAsIFJvY2NvIFl1ZSB3 cm90ZToKPiA+Pj4gCj4gPj4+IG5vdCBoYXZlIGV4cG9ydHMgdGhhdCBubyBvbmUgdXNlcy4gIFBs ZWFzZSBhZGQgdGhlIGRyaXZlciB0byB0aGlzIHBhdGNoCj4gPj4+IHNlcmllcyB3aGVuIHlvdSBy ZXNlbmQgaXQuCj4gPj4+IAo+ID4+IAo+ID4+IEkndmUganVzdCB0b29rIGEgbG9vayBhdCB3aGF0 IHRoZSBMaW51eCBzdGFnaW5nIHRyZWUgaXMuIEl0IGxvb2tzIGxpa2UKPiA+PiBhIGdvb2QgY2hv aWNlIGZvciB0aGUgY3VycmVudCBjY21uaSBkcml2ZXIuCj4gPj4gCj4gPj4gaG9uc3RseSwgSWYg SSBzaW1wbHkgdXBsb2FkIHRoZSByZWxldmFudCBkcml2ZXIgY29kZSBCIHRoYXQgY2FsbHMKPiA+ PiBBIChlLmcuIGNjbW5pX3J4X3B1c2gpLCB0aGVyZSBpcyBzdGlsbCBhIGxhY2sgb2YgY29kZSB0 byBjYWxsIEIuCj4gPj4gVGhpcyBzZWVtcyB0byBiZSBhIGNvbnRpbnV0eSBwcm9ibGVtLCB1bmxl c3MgYWxsIGRyaXZlcnMgY29kZXMgYXJlCj4gPj4gdXBsb2FkZWQgKGUuZy4gcG93ZXIgb24gbW9k ZW0sIGdldCBoYXJkd2FyZSBzdGF0dXMsIGNvbXBsZXRlIHR4L3J4IGZsb3cpLgo+ID4gCj4gPiBH cmVhdCwgc2VuZCBpdCBhbGwhICBXaHkgaXMgaXQgZGlmZmVyZW50IG1vZHVsZXMsIGl0J3Mgb25s eSBmb3Igb25lCj4gPiBjaHVuayBvZiBoYXJkd2FyZSwgbm8gbmVlZCB0byBzcGxpdCBpdCB1cCBp bnRvIHRpbnkgcGllY2VzLiAgVGhhdCB3YXkKPiA+IG9ubHkgY2F1c2VzIGl0IHRvIGJlIG1vcmUg Y29kZSBvdmVyYWxsLgo+ID4gCj4gPj4gCj4gPj4gVGhhbmtzfgo+ID4+IAo+ID4+IENhbiBJIHJl c2VuZCBwYXRjaCBzZXQgYXMgZm9sbG93czoKPiA+PiAoMSkgc3VwcGxlbWVudCB0aGUgZGV0YWls cyBvZiBwdXJlaXAgZm9yIHBhdGNoIDEvNDsKPiA+PiAoMikgdGhlIGRvY3VtZW50IG9mIGNjbW5p LnJzdCBzdGlsbCBsaXZlIGluIHRoZSBEb2N1bWVudGF0aW9uLy4uLgo+ID4+ICgzKSBtb2RpZnkg Y2NtbmkgYW5kIG1vdmUgaXQgaW50byB0aGUgZHJpdmVycy9zdGFnaW5nLy4uLgo+ID4gCj4gPiBm b3IgZHJpdmVycy9zdGFnaW5nLyB0aGUgY29kZSBuZWVkcyB0byBiZSAic2VsZiBjb250YWluZWQi IGluIHRoYXQgaXQKPiA+IGRvZXMgbm90IHJlcXVpcmUgYWRkaW5nIGFueXRoaW5nIG91dHNpZGUg b2YgdGhlIGRpcmVjdG9yeSBmb3IgaXQuCj4gPiAKPiA+IElmIHlvdSBzdGlsbCByZXF1aXJlIHRo aXMgY29yZSBuZXR3b3JraW5nIGNoYW5nZSwgdGhhdCBuZWVkcyB0byBiZQo+ID4gYWNjZXB0ZWQg Zmlyc3QgYnkgdGhlIG5ldHdvcmtpbmcgZGV2ZWxvcGVycyBhbmQgbWFpbnRhaW5lcnMuCj4gPiAK PiA+IHRoYW5rcywKPiA+IAo+ID4gZ3JlZyBrLWgKPiA+IAo+IAo+IEhpIEdyZWcsCj4gCj4gSSBh bSBncmF0ZWZ1bCBmb3IgeW91ciBoZWxwLgo+IAo+IEJvdGggY2NtbmkgY2hhbmdlIGFuZCBuZXR3 b3JraW5nIGNoYW5nZXMgYXJlIG5lZWRlZCwgYmVjYXVzZSBhcyBmYXIKPiBhcyBJIGtub3csIHVz dWFsbHkgYSBkZXZpY2UgdHlwZSBzaG91bGQgaGF2ZSBhdCBsZWFzdCBvbmUgZGV2aWNlIHRvCj4g dXNlIGl0LCBhbmQgcHVyZWlwIGlzIHdoYXQgdGhlIGNjbW5pIGRyaXZlciBuZWVkcywgc28gSSB1 cGxvYWRlZCB0aGUKPiBuZXR3b3JraW5nIGNoYW5nZSBhbmQgY2NtbmkgZHJpdmVyIHRvZ2V0aGVy Owo+IAo+IFNpbmNlIE1US+KAmXMgbW9kZW0gZHJpdmVyIGhhcyBhIGxhcmdlIGFtb3VudCBvZiBj b2RlIGFuZCBzdHJvbmcgY29kZQo+IGNvdXBsaW5nLCBpdCB0YWtlcyBzb21lIHRpbWUgdG8gY2xl YW4gdXAgdGhlbS4gQXQgdGhpcyBzdGFnZSwgaXQgbWF5Cj4gYmUgZGlmZmljdWx0IHRvIHVwc3Ry ZWFtIGFsbCB0aGUgY29kZXMgdG9nZXRoZXIuCgpXaHk/ICBKdXN0IGR1bXAgdGhlIHdob2xlIHRo aW5nIGluIGEgZHJpdmVycy9zdGFnaW5nL210ay8gZGlyZWN0b3J5CnN0cnVjdHVyZSBhbmQgYWxs IHNob3VsZCBiZSBmaW5lLgoKPiBEdXJpbmcgdGhpcyBwZXJpb2QsIGV2ZW4gaWYgY2NtbmkgaXMg aW5jb21wbGV0ZSwgY2FuIEkgcHV0IHRoZSBjY21uaQo+IGRyaXZlciBpbml0aWFsIGNvZGUgaW4g dGhlIGRyaXZlci9zdGFnaW5nIGZpcnN0ID8gQWZ0ZXIgdGhhdCwgd2Ugd2lsbAo+IGdyYWR1YWxs eSBpbXBsZW1lbnQgbW9yZSBmdW5jdGlvbnMgb2YgY2NtbmkgaW4gdGhlIHN0YWdpbmcgdHJlZSwg YW5kCj4gd2UgY2FuIGFsc28gZ3JhZHVhbGx5IHNvcnQgb3V0IGFuZCBjbGVhbiB1cCBtb2RlbSBk cml2ZXIgaW4gdGhlIHN0YWdpbmcuCgpJIGRvIG5vdCBrbm93LCBsZXQncyBzZWUgdGhlIGNvZGUg Zmlyc3QuICBCdXQgd2UgY2FuIG5vdCBhZGQgZnJhbWV3b3Jrcwp3aXRoIG5vIGluLWtlcm5lbCB1 c2VycywgYXMgdGhhdCBkb2VzIG5vdCBtYWtlIGFueSBzZW5zZSBhdCBhbGwuCgo+IEluIGFkZGl0 aW9uLCBkdWUgdG8gdGhlIHJlcXVpcmVtZW50cyBvZiBHS0kgMi4wLAoKVGhhdCBpcyBhIEdvb2ds ZSByZXF1aXJlbWVudCwgbm90IGEga2VybmVsLm9yZyByZXF1aXJlbWVudC4gIFBsZWFzZSB3b3Jr CndpdGggR29vZ2xlIGlmIHlvdSBoYXZlIHF1ZXN0aW9ucy9pc3N1ZXMgYWJvdXQgdGhhdCwgdGhl cmUgaXMgTk9USElORyB3ZQpjYW4gZG8gYWJvdXQgdGhhdCBoZXJlIGluIHRoZSBjb21tdW5pdHkg Zm9yIG9idmlvdXMgcmVhc29ucy4KCj4gaWYgY2NtbmkgZGV2aWNlCj4gdXNlcyBSQVdJUCBvciBO T05FLCBpdCB3aWxsIGhpdCBpcHY2IGlzc3VlOyBhbmQgaWYgY2NtbmkgdXNlcwo+IGEgZGV2aWNl IHR5cGUgb3RoZXIgdGhhbiBQVVJFSVAvUkFXSVAvTk9ORSwgdGhlcmUgd2lsbCBiZSB0ZXRoZXJp bmcKPiBlYnBmIG9mZmxvYWQgb3IgY2xhdCBlYnBmIG9mZmxvYWQgY2FuIG5vdCB3b3JrIHByb2Js ZW1zLgo+IAo+IEkgaG9wZSBQVVJFSVAgYW5kIGNjbW5pIGNhbiBiZSBhY2NlcHRlZCBieSB0aGUg TGludXggY29tbXVuaXR5LgoKQXMgSSBzdGF0ZWQgYmVmb3JlIHlvdSBuZWVkIHRvIGhhdmUgYW4g aW4ta2VybmVsIHVzZXIgZm9yIHVzIHRvIGJlIGFibGUKdG8gYWNjZXB0IGZyYW1ld29ya3MgYW5k IGZ1bmN0aW9ucyBpbnRvIHRoZSB0cmVlLiAgT3RoZXJ3aXNlIExpbnV4IHdvdWxkCnF1aWNrbHkg YmVjb21lIHVubWFuYWdhYmxlIGFuZCB1bm1haW50YWluYWJsZS4gIFdvdWxkIHlvdSB3YW50IHRv IHRyeSB0bwptYWludGFpbiBjb2RlIHdpdGggbm8gaW4tdHJlZSB1c2Vycz8gIFdoYXQgd291bGQg eW91IGRvIGlmIHlvdSB3ZXJlIGluCm91ciBwb3NpdGlvbj8KCkJ1dCBmb3IgbmV0d29ya2luZyBm bGFncyBsaWtlIHRoaXMgdGhhdCBnbyBpbnRvIHVzZXJzcGFjZSwgSSBkbyBub3Qga25vdwp3aGF0 IHRoZSBtYWludGFpbmVycyBvZiB0aGUgbmV0d29ya2luZyBzdGFjayByZXF1aXJlLCBzbyB0aGF0 IHJlYWxseSBpcwp1cCB0byB0aGVtLCBub3QgbWUuCgp0aGFua3MsCgpncmVnIGstaAoKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5l bCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6 Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=