From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Kent Gibson <warthog618@gmail.com>
Cc: Bartosz Golaszewski <brgl@bgdev.pl>,
Linus Walleij <linus.walleij@linaro.org>,
Jack Winch <sunt.un.morcov@gmail.com>,
Helmut Grohne <helmut.grohne@intenta.de>,
linux-gpio@vger.kernel.org
Subject: Re: [libgpiod][PATCH 4/4] bindings: cxx: implement C++ bindings for libgpiod v2.0
Date: Mon, 28 Jun 2021 14:30:05 +0300 [thread overview]
Message-ID: <YNmyvYDZwNeYRyTU@smile.fi.intel.com> (raw)
In-Reply-To: <20210627084757.GA21720@sol>
On Sun, Jun 27, 2021 at 04:47:57PM +0800, Kent Gibson wrote:
> On Mon, Jun 21, 2021 at 09:18:30PM +0200, Bartosz Golaszewski wrote:
> > This is the bulk of work implementing C++ bindings for the new libgpiod
> > API. The tests are not converted yet but the examples are fully
> > functional. More details in the cover letter as this patch will be
> > squashed with the one for the core C library anyway.
>
> Firstly, I don't have any problems with patches 1-3.
>
> Secondly, I'll be focussing on the API here, but I'm not up on current C++
> best practice, so take my comments, or the absence of them, with a
> suitable dose of salt.
>
> A general comment - you use retrieve/read/get/return for essentially the
> same thing in the accessor method documentation.
> Perhaps you could settle on one?
> Variety may be the spice of life, but sometimes boring is better.
It's a weak point of many documentation files that I saw :-)
Nevertheless, it's good practice to define terms in the preface pages to be
sure everybody is on the same page with meaning of them.
Kent, do I understand correctly that Go bindings use C library?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-06-28 11:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-21 19:18 [libgpiod][PATCH 0/4] libgpiod v2: C++ bindings Bartosz Golaszewski
2021-06-21 19:18 ` [libgpiod][PATCH 1/4] events: hide the *_read_fd() symbols from the API header Bartosz Golaszewski
2021-06-21 19:18 ` [libgpiod][PATCH 2/4] API: drop "peek" functions Bartosz Golaszewski
2021-06-21 19:18 ` [libgpiod][PATCH 3/4] API: add an AS_IS value for bias setting Bartosz Golaszewski
2021-06-21 19:18 ` [libgpiod][PATCH 4/4] bindings: cxx: implement C++ bindings for libgpiod v2.0 Bartosz Golaszewski
2021-06-27 8:47 ` Kent Gibson
2021-06-28 11:30 ` Andy Shevchenko [this message]
2021-06-28 11:34 ` Kent Gibson
2021-06-28 11:53 ` Andy Shevchenko
2021-06-28 14:25 ` Kent Gibson
2021-07-02 8:50 ` Bartosz Golaszewski
2021-07-02 11:38 ` Kent Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YNmyvYDZwNeYRyTU@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=brgl@bgdev.pl \
--cc=helmut.grohne@intenta.de \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=sunt.un.morcov@gmail.com \
--cc=warthog618@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.