All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Nikolay Borisov <nborisov@suse.com>
Cc: hch@infradead.org, djwong@kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v2] iomap: Break build if io_inline_bio is not last in iomap_ioend
Date: Tue, 29 Jun 2021 14:08:05 +0100	[thread overview]
Message-ID: <YNsbNctGHDW1DA3A@infradead.org> (raw)
In-Reply-To: <20210629072051.2875413-1-nborisov@suse.com>

On Tue, Jun 29, 2021 at 10:20:51AM +0300, Nikolay Borisov wrote:
> Comments are good but unfortunately they can't effectively enforce
> certain invariants, to that effect let's break the build in case
> io_inline_bio is, for whatever reason, not the last member of
> iomap_ioend.

Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>

      reply	other threads:[~2021-06-29 13:09 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-29  7:20 [PATCH v2] iomap: Break build if io_inline_bio is not last in iomap_ioend Nikolay Borisov
2021-06-29 13:08 ` Christoph Hellwig [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YNsbNctGHDW1DA3A@infradead.org \
    --to=hch@infradead.org \
    --cc=djwong@kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=nborisov@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.