All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alyssa Rosenzweig <alyssa@collabora.com>
To: Boris Brezillon <boris.brezillon@collabora.com>
Cc: Tomeu Vizoso <tomeu.vizoso@collabora.com>,
	dri-devel@lists.freedesktop.org,
	Steven Price <steven.price@arm.com>,
	Rob Herring <robh+dt@kernel.org>,
	Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>,
	Robin Murphy <robin.murphy@arm.com>
Subject: Re: [PATCH v6 05/16] drm/panfrost: Drop the pfdev argument passed to panfrost_exception_name()
Date: Wed, 30 Jun 2021 09:56:34 -0400	[thread overview]
Message-ID: <YNx4EjcvwXcL1+9e@maud> (raw)
In-Reply-To: <20210630062751.2832545-6-boris.brezillon@collabora.com>

Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>

On Wed, Jun 30, 2021 at 08:27:40AM +0200, Boris Brezillon wrote:
> Currently unused. We'll add it back if we need per-GPU definitions.
> 
> Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
> Reviewed-by: Steven Price <steven.price@arm.com>
> ---
>  drivers/gpu/drm/panfrost/panfrost_device.c | 2 +-
>  drivers/gpu/drm/panfrost/panfrost_device.h | 2 +-
>  drivers/gpu/drm/panfrost/panfrost_gpu.c    | 2 +-
>  drivers/gpu/drm/panfrost/panfrost_job.c    | 2 +-
>  drivers/gpu/drm/panfrost/panfrost_mmu.c    | 2 +-
>  5 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/gpu/drm/panfrost/panfrost_device.c b/drivers/gpu/drm/panfrost/panfrost_device.c
> index a2a09c51eed7..f7f5ca94f910 100644
> --- a/drivers/gpu/drm/panfrost/panfrost_device.c
> +++ b/drivers/gpu/drm/panfrost/panfrost_device.c
> @@ -292,7 +292,7 @@ void panfrost_device_fini(struct panfrost_device *pfdev)
>  	panfrost_clk_fini(pfdev);
>  }
>  
> -const char *panfrost_exception_name(struct panfrost_device *pfdev, u32 exception_code)
> +const char *panfrost_exception_name(u32 exception_code)
>  {
>  	switch (exception_code) {
>  		/* Non-Fault Status code */
> diff --git a/drivers/gpu/drm/panfrost/panfrost_device.h b/drivers/gpu/drm/panfrost/panfrost_device.h
> index 8b2cdb8c701d..2fe1550da7f8 100644
> --- a/drivers/gpu/drm/panfrost/panfrost_device.h
> +++ b/drivers/gpu/drm/panfrost/panfrost_device.h
> @@ -173,6 +173,6 @@ void panfrost_device_reset(struct panfrost_device *pfdev);
>  int panfrost_device_resume(struct device *dev);
>  int panfrost_device_suspend(struct device *dev);
>  
> -const char *panfrost_exception_name(struct panfrost_device *pfdev, u32 exception_code);
> +const char *panfrost_exception_name(u32 exception_code);
>  
>  #endif
> diff --git a/drivers/gpu/drm/panfrost/panfrost_gpu.c b/drivers/gpu/drm/panfrost/panfrost_gpu.c
> index 0e70e27fd8c3..26e4196b6c90 100644
> --- a/drivers/gpu/drm/panfrost/panfrost_gpu.c
> +++ b/drivers/gpu/drm/panfrost/panfrost_gpu.c
> @@ -33,7 +33,7 @@ static irqreturn_t panfrost_gpu_irq_handler(int irq, void *data)
>  		address |= gpu_read(pfdev, GPU_FAULT_ADDRESS_LO);
>  
>  		dev_warn(pfdev->dev, "GPU Fault 0x%08x (%s) at 0x%016llx\n",
> -			 fault_status & 0xFF, panfrost_exception_name(pfdev, fault_status),
> +			 fault_status & 0xFF, panfrost_exception_name(fault_status),
>  			 address);
>  
>  		if (state & GPU_IRQ_MULTIPLE_FAULT)
> diff --git a/drivers/gpu/drm/panfrost/panfrost_job.c b/drivers/gpu/drm/panfrost/panfrost_job.c
> index 3c1dbae3ebdd..ea3432ffde40 100644
> --- a/drivers/gpu/drm/panfrost/panfrost_job.c
> +++ b/drivers/gpu/drm/panfrost/panfrost_job.c
> @@ -489,7 +489,7 @@ static irqreturn_t panfrost_job_irq_handler(int irq, void *data)
>  
>  			dev_err(pfdev->dev, "js fault, js=%d, status=%s, head=0x%x, tail=0x%x",
>  				j,
> -				panfrost_exception_name(pfdev, job_read(pfdev, JS_STATUS(j))),
> +				panfrost_exception_name(job_read(pfdev, JS_STATUS(j))),
>  				job_read(pfdev, JS_HEAD_LO(j)),
>  				job_read(pfdev, JS_TAIL_LO(j)));
>  
> diff --git a/drivers/gpu/drm/panfrost/panfrost_mmu.c b/drivers/gpu/drm/panfrost/panfrost_mmu.c
> index 569509c2ba27..2a9bf30edc9d 100644
> --- a/drivers/gpu/drm/panfrost/panfrost_mmu.c
> +++ b/drivers/gpu/drm/panfrost/panfrost_mmu.c
> @@ -675,7 +675,7 @@ static irqreturn_t panfrost_mmu_irq_handler_thread(int irq, void *data)
>  				"TODO",
>  				fault_status,
>  				(fault_status & (1 << 10) ? "DECODER FAULT" : "SLAVE FAULT"),
> -				exception_type, panfrost_exception_name(pfdev, exception_type),
> +				exception_type, panfrost_exception_name(exception_type),
>  				access_type, access_type_name(pfdev, fault_status),
>  				source_id);
>  
> -- 
> 2.31.1
> 

  reply	other threads:[~2021-06-30 13:56 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-30  6:27 [PATCH v6 00/16] drm/panfrost Boris Brezillon
2021-06-30  6:27 ` [PATCH v6 01/16] drm/sched: Document what the timedout_job method should do Boris Brezillon
2021-06-30  6:27 ` [PATCH v6 02/16] drm/sched: Allow using a dedicated workqueue for the timeout/fault tdr Boris Brezillon
2021-06-30  6:27 ` [PATCH v6 03/16] drm/panfrost: Make ->run_job() return an ERR_PTR() when appropriate Boris Brezillon
2021-06-30  6:27 ` [PATCH v6 04/16] drm/panfrost: Get rid of the unused JS_STATUS_EVENT_ACTIVE definition Boris Brezillon
2021-06-30  6:27 ` [PATCH v6 05/16] drm/panfrost: Drop the pfdev argument passed to panfrost_exception_name() Boris Brezillon
2021-06-30 13:56   ` Alyssa Rosenzweig [this message]
2021-06-30  6:27 ` [PATCH v6 06/16] drm/panfrost: Do the exception -> string translation using a table Boris Brezillon
2021-06-30  6:27 ` [PATCH v6 07/16] drm/panfrost: Expose a helper to trigger a GPU reset Boris Brezillon
2021-06-30  6:27 ` [PATCH v6 08/16] drm/panfrost: Use a threaded IRQ for job interrupts Boris Brezillon
2021-06-30  6:27 ` [PATCH v6 09/16] drm/panfrost: Simplify the reset serialization logic Boris Brezillon
2021-06-30  6:27 ` [PATCH v6 10/16] drm/panfrost: Make sure job interrupts are masked before resetting Boris Brezillon
2021-06-30  6:27 ` [PATCH v6 11/16] drm/panfrost: Disable the AS on unhandled page faults Boris Brezillon
2021-06-30  6:27 ` [PATCH v6 12/16] drm/panfrost: Reset the GPU when the AS_ACTIVE bit is stuck Boris Brezillon
2021-06-30  6:27 ` [PATCH v6 13/16] drm/panfrost: Don't reset the GPU on job faults unless we really have to Boris Brezillon
2021-06-30  6:27 ` [PATCH v6 14/16] drm/panfrost: Kill in-flight jobs on FD close Boris Brezillon
2021-06-30 14:14   ` Steven Price
2021-06-30  6:27 ` [PATCH v6 15/16] drm/panfrost: Queue jobs on the hardware Boris Brezillon
2021-06-30 15:00   ` Steven Price
2021-06-30  6:27 ` [PATCH v6 16/16] drm/panfrost: Increase the AS_ACTIVE polling timeout Boris Brezillon
2021-06-30 15:01   ` Steven Price
2021-07-01  6:56 ` [PATCH v6 00/16] drm/panfrost Boris Brezillon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YNx4EjcvwXcL1+9e@maud \
    --to=alyssa@collabora.com \
    --cc=alyssa.rosenzweig@collabora.com \
    --cc=boris.brezillon@collabora.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=robh+dt@kernel.org \
    --cc=robin.murphy@arm.com \
    --cc=steven.price@arm.com \
    --cc=tomeu.vizoso@collabora.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.