From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21212C11F65 for ; Wed, 30 Jun 2021 16:27:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0372F61350 for ; Wed, 30 Jun 2021 16:27:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229529AbhF3Q35 (ORCPT ); Wed, 30 Jun 2021 12:29:57 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:34739 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S229510AbhF3Q34 (ORCPT ); Wed, 30 Jun 2021 12:29:56 -0400 Received: from cwcc.thunk.org (pool-72-74-133-215.bstnma.fios.verizon.net [72.74.133.215]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 15UGRLBZ003232 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 30 Jun 2021 12:27:22 -0400 Received: by cwcc.thunk.org (Postfix, from userid 15806) id 9F8E915C3C8E; Wed, 30 Jun 2021 12:27:21 -0400 (EDT) Date: Wed, 30 Jun 2021 12:27:21 -0400 From: "Theodore Ts'o" To: Ritesh Harjani Cc: fstests@vger.kernel.org, linux-ext4@vger.kernel.org Subject: Re: [PATCH 1/9] ext4/003: Fix this test on 64K platform for dax config Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org On Mon, Jun 14, 2021 at 11:58:05AM +0530, Ritesh Harjani wrote: > mkfs.ext4 by default uses 4K blocksize which doesn't mount when testing > with dax config and the test fails. This patch fixes it. > > Signed-off-by: Ritesh Harjani > --- > tests/ext4/003 | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/tests/ext4/003 b/tests/ext4/003 > index 00ea9150..1ddb3063 100755 > --- a/tests/ext4/003 > +++ b/tests/ext4/003 > @@ -31,7 +31,8 @@ _require_scratch_ext4_feature "bigalloc" > > rm -f $seqres.full > > -$MKFS_EXT4_PROG -F -O bigalloc -C 65536 -g 256 $SCRATCH_DEV 512m \ > +BLOCK_SIZE=$(get_page_size) > +$MKFS_EXT4_PROG -F -b $BLOCK_SIZE -O bigalloc -C 65536 -g 256 $SCRATCH_DEV 512m \ > >> $seqres.full 2>&1 > _scratch_mount Thanks for the patch! If the block size is 64k, then the cluster_size == block_size at which point ext4/003 won't be able to test for the regression its designed to test. So we probably need to scale the cluster size and file system size relative to the block size. - Ted