All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ilias Apalodimas <ilias.apalodimas@linaro.org>
To: Heinrich Schuchardt <xypron.glpk@gmx.de>
Cc: u-boot@lists.denx.de, Alexander Graf <agraf@csgraf.de>,
	AKASHI Takahiro <takahiro.akashi@linaro.org>
Subject: Re: [PATCH v2 2/2] efi_loader: clear OsIndications
Date: Wed, 30 Jun 2021 22:18:13 +0300	[thread overview]
Message-ID: <YNzDdVi5z9/uRAw0@enceladus> (raw)
In-Reply-To: <20210630153116.26756-3-xypron.glpk@gmx.de>

Hi Heinrich, 

>  	if (IS_ENABLED(CONFIG_EFI_CAPSULE_ON_DISK) &&

[...]

>  	    !IS_ENABLED(CONFIG_EFI_CAPSULE_ON_DISK_EARLY))
>  		ret = efi_launch_capsules();
> +	if (ret != EFI_SUCCESS)
> +		goto out;
> +

I think OsIndications should be cleared reagrdless of the capsuleupdate
result.  There's a detailed explanation on your v1

Cheers
Ilias
> +	ret = efi_clear_os_indications();
>  out:
>  	efi_obj_list_initialized = ret;
>  	return ret;
> --
> 2.30.2
> 

      reply	other threads:[~2021-06-30 19:18 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-30 15:31 [PATCH v2 0/2] efi_loader: indicating capsule update results Heinrich Schuchardt
2021-06-30 15:31 ` [PATCH v2 1/2] efi_loader: fix set_capsule_result() Heinrich Schuchardt
2021-07-01  0:49   ` AKASHI Takahiro
2021-07-01  1:20     ` Heinrich Schuchardt
2021-07-01  1:55       ` AKASHI Takahiro
2021-06-30 15:31 ` [PATCH v2 2/2] efi_loader: clear OsIndications Heinrich Schuchardt
2021-06-30 19:18   ` Ilias Apalodimas [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YNzDdVi5z9/uRAw0@enceladus \
    --to=ilias.apalodimas@linaro.org \
    --cc=agraf@csgraf.de \
    --cc=takahiro.akashi@linaro.org \
    --cc=u-boot@lists.denx.de \
    --cc=xypron.glpk@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.