All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heiko Carstens <hca@linux.ibm.com>
To: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: Janosch Frank <frankja@linux.vnet.ibm.com>,
	David Hildenbrand <david@redhat.com>,
	Cornelia Huck <cohuck@redhat.com>,
	Claudio Imbrenda <imbrenda@linux.ibm.com>,
	kvm@vger.kernel.org, linux-s390@vger.kernel.org
Subject: Re: [PATCH] KVM: s390: generate kvm hypercall functions
Date: Tue, 13 Jul 2021 18:15:15 +0200	[thread overview]
Message-ID: <YO28E42wIH6/aGUm@osiris> (raw)
In-Reply-To: <fe51925a-7f1c-fb98-94c9-729c5e23ff08@de.ibm.com>

On Tue, Jul 13, 2021 at 05:59:17PM +0200, Christian Borntraeger wrote:
> On 13.07.21 17:52, Heiko Carstens wrote:
> > On Tue, Jul 13, 2021 at 05:41:33PM +0200, Christian Borntraeger wrote:
> > > On 13.07.21 16:57, Heiko Carstens wrote:
> > > [..]
> > > > +#define HYPERCALL_FMT_0
> > > > +#define HYPERCALL_FMT_1 , "0" (r2)
> > > > +#define HYPERCALL_FMT_2 , "d" (r3) HYPERCALL_FMT_1
> > > > +#define HYPERCALL_FMT_3 , "d" (r4) HYPERCALL_FMT_2
> > > > +#define HYPERCALL_FMT_4 , "d" (r5) HYPERCALL_FMT_3
> > > > +#define HYPERCALL_FMT_5 , "d" (r6) HYPERCALL_FMT_4
> > > > +#define HYPERCALL_FMT_6 , "d" (r7) HYPERCALL_FMT_5
> > > 
> > > This will result in reverse order.
> > > old:
> > > "d" (__nr), "0" (__p1), "d" (__p2), "d" (__p3), "d" (__p4), "d" (__p5), "d" (__p6)
> > > new:
> > > "d"(__nr), "d"(r7), "d"(r6), "d"(r5), "d"(r4), "d"(r3), "0"(r2)
> > > 
> > > As we do not reference the variable in the asm this should not matter,
> > > I just noticed it when comparing the result of the preprocessed files.
> > > 
> > > Assuming that we do not care this looks good.
> > 
> > Yes, it does not matter. Please let me know if should change it anyway.
> 
> No, I think this is ok.
> Shall I take it via the kvm tree or do you want to take it via the s390 tree?

I think this should go via kvm tree. It probably has to wait until next merge
window anyway(?).

  reply	other threads:[~2021-07-13 16:15 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-13 14:57 [PATCH] KVM: s390: generate kvm hypercall functions Heiko Carstens
2021-07-13 15:41 ` Christian Borntraeger
2021-07-13 15:52   ` Heiko Carstens
2021-07-13 15:59     ` Christian Borntraeger
2021-07-13 16:15       ` Heiko Carstens [this message]
2021-07-13 18:06 ` Christian Borntraeger
2021-07-14  9:38 ` Claudio Imbrenda
2021-07-14  9:50   ` Heiko Carstens
2021-07-14 10:03     ` Christian Borntraeger
2021-07-14 11:21       ` Heiko Carstens

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YO28E42wIH6/aGUm@osiris \
    --to=hca@linux.ibm.com \
    --cc=borntraeger@de.ibm.com \
    --cc=cohuck@redhat.com \
    --cc=david@redhat.com \
    --cc=frankja@linux.vnet.ibm.com \
    --cc=imbrenda@linux.ibm.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.