From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1m3NkT-0007jv-Qp for mharc-grub-devel@gnu.org; Tue, 13 Jul 2021 15:07:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48134) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m3NkR-0007jl-W1 for grub-devel@gnu.org; Tue, 13 Jul 2021 15:07:16 -0400 Received: from smtp-out2.suse.de ([195.135.220.29]:37502) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m3NkQ-0008DY-Dt for grub-devel@gnu.org; Tue, 13 Jul 2021 15:07:15 -0400 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 893192021C; Tue, 13 Jul 2021 19:07:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1626203232; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=EstiwD8JtbQ61TCa0PWiFBPpjkhRP0GVMnIZtDYFzJc=; b=X31lx4D8sg0WamNdHa8raRQIKhXP7KmVAaOuZa2q/2dLZNX6r4yuf2nBN5Tp6+Vfd9/Y8j I5Sdk3LY7z21JLAIP9q3DLIF+H2b3i/f5LYKrv0yb1uXFFIaGFDbUagScYE+APSJWSPGFU 3z4khwMMOme8frfDqAVnDtdAQG82Rl0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1626203232; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=EstiwD8JtbQ61TCa0PWiFBPpjkhRP0GVMnIZtDYFzJc=; b=5CRSb65BmO3TWSbadYMxzr9o5xYSfoxjlTgzE+UydHyU0ID7rINbKB8DiFvhjzoRx51wp0 uMVsq2MUmJkn1QDg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 4E42313AFE; Tue, 13 Jul 2021 19:07:12 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id kW57EWDk7WBHagAAMHmgww (envelope-from ); Tue, 13 Jul 2021 19:07:12 +0000 Date: Tue, 13 Jul 2021 21:07:10 +0200 From: Petr Vorel To: Daniel Kiper Cc: grub-devel@gnu.org, Michael Chang , Mike Gilbert , Jeff Mahoney Subject: Re: [PATCH 1/2] osdep: Introduce major.h and use it Message-ID: Reply-To: Petr Vorel References: <20210708155558.26466-1-pvorel@suse.cz> <20210708155558.26466-2-pvorel@suse.cz> <20210713173658.fc23yio5tqfwkozi@tomti.i.net-space.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210713173658.fc23yio5tqfwkozi@tomti.i.net-space.pl> Received-SPF: pass client-ip=195.135.220.29; envelope-from=pvorel@suse.cz; helo=smtp-out2.suse.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Jul 2021 19:07:16 -0000 > On Thu, Jul 08, 2021 at 05:55:57PM +0200, Petr Vorel wrote: > > Signed-off-by: Petr Vorel > > --- > > grub-core/osdep/devmapper/getroot.c | 7 +------ > > grub-core/osdep/devmapper/hostdisk.c | 7 +------ > > grub-core/osdep/linux/getroot.c | 7 +------ > > grub-core/osdep/unix/getroot.c | 7 +------ > > include/grub/osdep/major.h | 30 ++++++++++++++++++++++++++++ > > 5 files changed, 34 insertions(+), 24 deletions(-) > > create mode 100644 include/grub/osdep/major.h > May I ask you to explain in the commit message why this patch is needed? It's just a small cleanup. If you're not against it, sure, I can mention it in the commit message. Kind regards, Petr > Daniel