From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA76EC07E9C for ; Wed, 14 Jul 2021 10:14:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A87A96101B for ; Wed, 14 Jul 2021 10:14:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238948AbhGNKRb (ORCPT ); Wed, 14 Jul 2021 06:17:31 -0400 Received: from mail.kernel.org ([198.145.29.99]:59942 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238849AbhGNKRb (ORCPT ); Wed, 14 Jul 2021 06:17:31 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 3CD566101B; Wed, 14 Jul 2021 10:14:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1626257680; bh=KMdm/q4EZ7TeQOF+6nu4RACAto6lVye1VWbBT0sDDfY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FjRMSJLAtY3gl6hc71B0o9ZOdL/Y8MMeHa2pPC1FoPWw14vZW2jeWCjbf+L5Otjhu d3gekinCJPaPkxO8rjCJYdk2dXawpWB0WCM65TuCIrKVMZDheVZY53LD4GsqsDls+P xZ4YeSUp9zpdAZkojqSmeijIiYm16+xHkP7avXCFbUPwTMdC8x3tKhlRhJh99dqELc PtK/L9i94iBvuJMvANEKdJMib4rdAlWYU+o226mymhFwADYiV4bR8EhPWKqYQdj455 CAOzD+U+p8NuV1oczbl2++X+oyC1L6ddoatbFv3Aq3kTdE8qOssGCOvIePvBg6IOsN smZsBZPl3Odvw== Date: Wed, 14 Jul 2021 15:44:36 +0530 From: Vinod Koul To: Douglas Anderson Cc: Mark Brown , akashast@codeaurora.org, swboyd@chromium.org, Andy Gross , Bjorn Andersson , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org Subject: Re: [PATCH] spi: spi-geni-qcom: Remove confusing comment about setting the watermark Message-ID: References: <20210712085010.1.Ie3bb9f9d30d6475bb75251d32635194c1c72b9ee@changeid> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210712085010.1.Ie3bb9f9d30d6475bb75251d32635194c1c72b9ee@changeid> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 12-07-21, 08:50, Douglas Anderson wrote: > The comment in setup_fifo_xfer() about setting the watermark wasn't > quite proper grammar and also stopped making sense around commit > 6d66507d9b55 ("spi: spi-geni-qcom: Don't wait to start 1st transfer if > transmitting"). After that commit we actually start the transfer > _before_ the watermark interrupt comes. > > I don't think the comment really has any value anymore. We've already > got a comment when we grab the spinlock saying that our interrupt can > come any time as a result of the things in the locked section. Let's > just remove it. Reviewed-by: Vinod Koul -- ~Vinod