From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59237C07E9A for ; Wed, 14 Jul 2021 06:58:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 32A41613B7 for ; Wed, 14 Jul 2021 06:58:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238129AbhGNHBT (ORCPT ); Wed, 14 Jul 2021 03:01:19 -0400 Received: from mail.kernel.org ([198.145.29.99]:53106 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237948AbhGNHBS (ORCPT ); Wed, 14 Jul 2021 03:01:18 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id E77B46100C; Wed, 14 Jul 2021 06:58:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1626245907; bh=7rYn8qhbP5gr0VccdQ6vD/FAZ5ES5/hm8SCvpF8lbiA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hQjAsrNvA3w7Ky/28cSk2Yj/jOBMl2nCk+QfIFAF7BuRWCacv7apzEZEczCdIdj0a rwZAGIEqrozbLJU/RJn5C08JqiRihxeGADwq6cmWCa2BIuNlIl2HU2brRFvirO4MAj 0zBxjF0KtADnfub2dbXSm23OKe5zGOBcx5J8JtaPVwlqBsAXoLJBGUpVAYezYYk1MC KKqFHhWYWIrg+A5rHIQsb5DXOwRd45wIpJ5ZNJkaYYdN+tBsf/N4wwMqf6MM/AlR2O JEYKY+O424jz1OssrtOPP2DJ4FHrRSCYy5UOg6cNNLZZS+By/JIrsGB2bWT+dgRCv5 MwskSETrDt75w== Date: Wed, 14 Jul 2021 12:28:24 +0530 From: Vinod Koul To: Dave Jiang Cc: dmaengine@vger.kernel.org Subject: Re: [PATCH] dmaengine: idxd: add missing percpu ref put on failure Message-ID: References: <162456170168.1121236.7240941044089212312.stgit@djiang5-desk3.ch.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <162456170168.1121236.7240941044089212312.stgit@djiang5-desk3.ch.intel.com> Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org On 24-06-21, 12:08, Dave Jiang wrote: > When enqcmds() fails, exit path is missing a percpu_ref_put(). This can > cause failure on shutdown path when the driver is attempting to quiesce the > wq. Add missing percpu_ref_put() call on the error exit path. Applied, thanks -- ~Vinod