From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Justin He <Justin.He@arm.com>
Cc: Petr Mladek <pmladek@suse.com>,
Steven Rostedt <rostedt@goodmis.org>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Jonathan Corbet <corbet@lwn.net>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Linus Torvalds <torvalds@linux-foundation.org>,
"Peter Zijlstra (Intel)" <peterz@infradead.org>,
Eric Biggers <ebiggers@google.com>,
"Ahmed S. Darwish" <a.darwish@linutronix.de>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
Matthew Wilcox <willy@infradead.org>,
Christoph Hellwig <hch@infradead.org>, nd <nd@arm.com>
Subject: Re: [PATCH v2 1/4] fs: introduce helper d_path_unsafe()
Date: Wed, 14 Jul 2021 12:17:06 +0300 [thread overview]
Message-ID: <YO6rkgKpca/Z0LtH@smile.fi.intel.com> (raw)
In-Reply-To: <AM6PR08MB4376DB011A86FCD8C76FE80DF7139@AM6PR08MB4376.eurprd08.prod.outlook.com>
On Wed, Jul 14, 2021 at 08:33:10AM +0000, Justin He wrote:
> > From: Justin He
> > Sent: Thursday, June 24, 2021 1:49 PM
> > > From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > > Sent: Wednesday, June 23, 2021 5:11 PM
> > > On Wed, Jun 23, 2021 at 01:50:08PM +0800, Jia He wrote:
...
> > > > + const char *dname = smp_load_acquire(&name->name); /* ^^^ */
> > >
> > > I have commented on the comment here. What does it mean for mere reader?
> > >
> >
> > Do you suggest making the comment "/* ^^^ */" more clear?
Yes.
> > It is detailed already in prepend_name_with_len()'s comments:
> > > * Load acquire is needed to make sure that we see that terminating NUL,
> > > * which is similar to prepend_name().
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-07-14 9:17 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-23 5:50 [PATCH v2 0/4] make '%pD' print the full path of file Jia He
2021-06-23 5:50 ` [PATCH v2 1/4] fs: introduce helper d_path_unsafe() Jia He
2021-06-23 9:10 ` Andy Shevchenko
2021-06-24 5:48 ` Justin He
2021-07-14 8:33 ` Justin He
2021-07-14 9:17 ` Andy Shevchenko [this message]
2021-06-28 5:13 ` Justin He
2021-06-28 9:06 ` Petr Mladek
2021-07-02 6:36 ` Justin He
2021-06-23 5:50 ` [PATCH v2 2/4] lib/vsprintf.c: make '%pD' print the full path of file Jia He
2021-06-23 9:14 ` Andy Shevchenko
2021-06-24 9:01 ` Petr Mladek
2021-06-24 10:49 ` Andy Shevchenko
2021-06-25 2:29 ` Justin He
2021-06-25 2:32 ` Justin He
2021-06-23 5:50 ` [PATCH v2 3/4] lib/test_printf.c: split write-beyond-buffer check in two Jia He
2021-06-23 9:16 ` Andy Shevchenko
2021-06-23 5:50 ` [PATCH v2 4/4] lib/test_printf.c: add test cases for '%pD' Jia He
2021-06-23 9:17 ` [PATCH v2 0/4] make '%pD' print the full path of file Andy Shevchenko
[not found] ` <AM6PR08MB43763816EBF217940F5B3E15F7139@AM6PR08MB4376.eurprd08.prod.outlook.com>
2021-07-14 14:17 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YO6rkgKpca/Z0LtH@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=Justin.He@arm.com \
--cc=a.darwish@linutronix.de \
--cc=corbet@lwn.net \
--cc=ebiggers@google.com \
--cc=hch@infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=nd@arm.com \
--cc=peterz@infradead.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.