All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@redhat.com>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: qemu-devel@nongnu.org,
	Wainer dos Santos Moschetta <wainersm@redhat.com>,
	Cleber Rosa <crosa@redhat.com>
Subject: Re: [PATCH] tests/acceptance: Add tests for the Pegasos2 machine
Date: Wed, 14 Jul 2021 15:37:27 +0100	[thread overview]
Message-ID: <YO72pzyK1eaRazgz@stefanha-x1.localdomain> (raw)
In-Reply-To: <78d672f2-9cd2-adae-502a-f72110ed7e6c@amsat.org>

[-- Attachment #1: Type: text/plain, Size: 1413 bytes --]

On Wed, Jul 14, 2021 at 11:37:54AM +0200, Philippe Mathieu-Daudé wrote:
> On 7/13/21 3:43 AM, Cleber Rosa wrote:
> > +@skipUnless(os.getenv('AVOCADO_ALLOW_UNTRUSTED_CODE'), 'untrusted code')
> > +class PPCPegasos2(Test):
> > +    """These tests require a Pegasos2 ROM.  You need to perform a one
> > +    time manual set up of the ROM, registering it with the Avocado
> > +    assets system.  Please follow the steps bellow from a QEMU build
> > +    directory, replaceing $MY_ROMS_DIR with a suitable directory.
> > +
> > +    1. make check-venv
> > +    2. curl http://web.archive.org/web/20071021223056/http://www.bplan-gmbh.de/up050404/up050404 -o $MY_ROMS_DIR/up050404
> > +    3. tail -c +85581 /tmp/up050404 | head -c 524288 > $MY_ROMS_DIR/pegasos2.rom
> 
> Sorry but I am not signing for this patch description. I don't think
> the project should link non-free software like this; which is why I
> only listed the recipe link in the commit description. Maybe we can
> simply add this link here again.
> 
> Stefan do you know what is recommended?

I think that it's okay to include instructions for manually adding
non-free software, but I'm not a lawyer.

I don't know what the origin of this up050404 file is and under what
license it is available. Could you add that information so users can
make their own decision on whether or not to manually install it?

Thanks,
Stefan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

      parent reply	other threads:[~2021-07-14 14:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-13  1:43 [PATCH] tests/acceptance: Add tests for the Pegasos2 machine Cleber Rosa
2021-07-14  9:37 ` Philippe Mathieu-Daudé
2021-07-14 10:36   ` BALATON Zoltan
2021-07-14 10:43   ` BALATON Zoltan
2021-07-14 14:37   ` Stefan Hajnoczi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YO72pzyK1eaRazgz@stefanha-x1.localdomain \
    --to=stefanha@redhat.com \
    --cc=crosa@redhat.com \
    --cc=f4bug@amsat.org \
    --cc=qemu-devel@nongnu.org \
    --cc=wainersm@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.