All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Borislav Petkov <bp@alien8.de>
Cc: Adrian Hunter <adrian.hunter@intel.com>,
	Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: [PATCH] tools headers: Remove broken definition of __LITTLE_ENDIAN
Date: Wed, 14 Jul 2021 14:38:51 -0300	[thread overview]
Message-ID: <YO8hK7lqJcIWuBzx@kernel.org> (raw)

FYI, added this to my local tree.

commit adfb906cb3ee7b941a5de71dbb72b6de1ee258db
Author: Arnaldo Carvalho de Melo <acme@redhat.com>
Date:   Wed Jul 14 14:28:02 2021 -0300

    tools headers: Remove broken definition of __LITTLE_ENDIAN
    
    The linux/kconfig.h file was copied from the kernel but the line where
    with the generated/autoconf.h include from where the CONFIG_ entries
    would come from was deleted, as tools/ build system don't create that
    file, so we ended up always defining just __LITTLE_ENDIAN as
    CONFIG_CPU_BIG_ENDIAN was nowhere to be found.
    
    This in turn ended up breaking the build in some systems where
    __LITTLE_ENDIAN was already defined, such as the androind NDK.
    
    So just ditch that block that depends on the CONFIG_CPU_BIG_ENDIAN
    define.
    
    The kconfig.h file was copied just to get IS_ENABLED() and a
    'make -C tools/all' doesn't breaks with this removal.
    
    Fixes: 93281c4a96572a34 ("x86/insn: Add an insn_decode() API")
    Cc: Borislav Petkov <bp@suse.de>
    Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

diff --git a/tools/include/linux/kconfig.h b/tools/include/linux/kconfig.h
index 1555a0c4f34514bf..13b86bd3b7461d27 100644
--- a/tools/include/linux/kconfig.h
+++ b/tools/include/linux/kconfig.h
@@ -4,12 +4,6 @@
 
 /* CONFIG_CC_VERSION_TEXT (Do not delete this comment. See help in Kconfig) */
 
-#ifdef CONFIG_CPU_BIG_ENDIAN
-#define __BIG_ENDIAN 4321
-#else
-#define __LITTLE_ENDIAN 1234
-#endif
-
 #define __ARG_PLACEHOLDER_1 0,
 #define __take_second_arg(__ignored, val, ...) val
 

                 reply	other threads:[~2021-07-14 17:38 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YO8hK7lqJcIWuBzx@kernel.org \
    --to=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=bp@alien8.de \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=namhyung@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.