From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A19A5C47E4B for ; Wed, 14 Jul 2021 20:59:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 77B50601FA for ; Wed, 14 Jul 2021 20:59:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234692AbhGNVCR (ORCPT ); Wed, 14 Jul 2021 17:02:17 -0400 Received: from mail.kernel.org ([198.145.29.99]:56946 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230382AbhGNVCO (ORCPT ); Wed, 14 Jul 2021 17:02:14 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 984FE613D2; Wed, 14 Jul 2021 20:59:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1626296362; bh=46LZepb4ibcHU0dIyCjWFYG69WtsVts8G634YB/zfu4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hmlhNAehPM0iCcte6ZJr9LRGH5D9qqDN/W/0PjfCSHsxS7KhBCr9sm5/SdafO8j/j t+cc1OOWD+rL6MS2DhMF+xDgJvFz+es+pAV0m0PSY6zZbqnrMj0frvw7LF5duiTibe Ea4woNOSjjGQlfKLfgOsr5T33NrnwmYhfqGoBT9kQ/07SOOtoi3w55nKEaaT5vunSd VvXBspWcSAKODcVfjIQV31/hpB3qeyJmgn9iC0wHqw5LmrpDRe0qxuWpGUL/qzcWFB GfD7xwVfzC6++b2wtywmmwPtqNWicVPo4A4CQEj3KMF6X4MZXBoBc+35lYLEU/coev N/LAQDuW6xYSg== Date: Wed, 14 Jul 2021 16:59:21 -0400 From: Sasha Levin To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Shawn Guo , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH AUTOSEL 5.13 024/108] ARM: dts: imx25-pinfunc: Fix gpio function name for pads GPIO_[A-F] Message-ID: References: <20210714193800.52097-1-sashal@kernel.org> <20210714193800.52097-24-sashal@kernel.org> <20210714203550.zlbvfh6rfnah6iir@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210714203550.zlbvfh6rfnah6iir@pengutronix.de> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 14, 2021 at 10:35:50PM +0200, Uwe Kleine-König wrote: >On Wed, Jul 14, 2021 at 03:36:36PM -0400, Sasha Levin wrote: >> From: Uwe Kleine-König >> >> [ Upstream commit e0cdd26af8eb9001689a4cde4f72c61c1c4b06be ] >> >> The pinfunc definitions used GPIO_A as function instead of GPIO_1_0 as >> done for all the other pins with GPIO functionality. Fix for consistency. >> >> There are no mainline users that needs adaption. >> >> Signed-off-by: Uwe Kleine-König >> Signed-off-by: Shawn Guo >> Signed-off-by: Sasha Levin > >I'm not convinced it's a good idea to take this patch for stable. >in-tree users are unaffected and the only effect this can have on >out-of-tree users is to break them. So the gain of having this is not >positive. > >Am I missing something? Hm, if those definitions don't have an in-tree users, why are they still around to begin with? -- Thanks, Sasha From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07AF4C12002 for ; Wed, 14 Jul 2021 23:40:19 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BA070610C7 for ; Wed, 14 Jul 2021 23:40:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BA070610C7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=DnT9lrsIq+W9EdU5u27cmZeUJ0wpnQrNj3BKGovpLFc=; b=XbmtxJy47y1oDzXAQtd7EWbVCv PzdpUhGezUs1YPaHtPqm+/up/Q6VM+Jlq6nr3xd3Dq1Imcv3o0hbrSAbtK+GSjOIFpDq1VwjG9utF UJi69EOL8+dHixhDClaP6xiJHzh/dW5Ot+SoVjzLrmSs4Bdl0LC+iMQm/WvsJ7ihYjeVoYVIzcFi8 eAisA7MVs7r5b7d4YLtmJGHZIoX7tUW5qhZT7EL5R8HPg04U0hXLKIZalSSxvAiv09EuZZJlBf8hA jzT3Hb4kfPi/bhvmYNBFg2JV21V/YZtGe6qn1oPItfdl4KyO7t8/ZzAGjERI7OMwl7Y3WPfH7tYpK rs4/518w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m3oRz-00GM4a-In; Wed, 14 Jul 2021 23:38:00 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m3lyV-00FDhL-3c for linux-arm-kernel@lists.infradead.org; Wed, 14 Jul 2021 20:59:24 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 984FE613D2; Wed, 14 Jul 2021 20:59:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1626296362; bh=46LZepb4ibcHU0dIyCjWFYG69WtsVts8G634YB/zfu4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hmlhNAehPM0iCcte6ZJr9LRGH5D9qqDN/W/0PjfCSHsxS7KhBCr9sm5/SdafO8j/j t+cc1OOWD+rL6MS2DhMF+xDgJvFz+es+pAV0m0PSY6zZbqnrMj0frvw7LF5duiTibe Ea4woNOSjjGQlfKLfgOsr5T33NrnwmYhfqGoBT9kQ/07SOOtoi3w55nKEaaT5vunSd VvXBspWcSAKODcVfjIQV31/hpB3qeyJmgn9iC0wHqw5LmrpDRe0qxuWpGUL/qzcWFB GfD7xwVfzC6++b2wtywmmwPtqNWicVPo4A4CQEj3KMF6X4MZXBoBc+35lYLEU/coev N/LAQDuW6xYSg== Date: Wed, 14 Jul 2021 16:59:21 -0400 From: Sasha Levin To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Shawn Guo , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH AUTOSEL 5.13 024/108] ARM: dts: imx25-pinfunc: Fix gpio function name for pads GPIO_[A-F] Message-ID: References: <20210714193800.52097-1-sashal@kernel.org> <20210714193800.52097-24-sashal@kernel.org> <20210714203550.zlbvfh6rfnah6iir@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210714203550.zlbvfh6rfnah6iir@pengutronix.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210714_135923_201477_F3649329 X-CRM114-Status: GOOD ( 11.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jul 14, 2021 at 10:35:50PM +0200, Uwe Kleine-K=F6nig wrote: >On Wed, Jul 14, 2021 at 03:36:36PM -0400, Sasha Levin wrote: >> From: Uwe Kleine-K=F6nig >> >> [ Upstream commit e0cdd26af8eb9001689a4cde4f72c61c1c4b06be ] >> >> The pinfunc definitions used GPIO_A as function instead of GPIO_1_0 as >> done for all the other pins with GPIO functionality. Fix for consistency. >> >> There are no mainline users that needs adaption. >> >> Signed-off-by: Uwe Kleine-K=F6nig >> Signed-off-by: Shawn Guo >> Signed-off-by: Sasha Levin > >I'm not convinced it's a good idea to take this patch for stable. >in-tree users are unaffected and the only effect this can have on >out-of-tree users is to break them. So the gain of having this is not >positive. > >Am I missing something? Hm, if those definitions don't have an in-tree users, why are they still around to begin with? -- = Thanks, Sasha _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel