Re: [PATCH libnetfilter_queue] src: annotation: Correctly identify item for which header is needed

[Duncan Roe <duncan_roe@optusnet.com.au>]

On Mon, Jul 05, 2021 at 10:52:46AM +0200, Pablo Neira Ayuso wrote:
> On Sun, Jul 04, 2021 at 03:47:08PM +1000, Duncan Roe wrote:
> > Signed-off-by: Duncan Roe <duncan_roe@optusnet.com.au>
> > ---
> >  examples/nf-queue.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/examples/nf-queue.c b/examples/nf-queue.c
> > index 3da2c24..7d34081 100644
> > --- a/examples/nf-queue.c
> > +++ b/examples/nf-queue.c
> > @@ -15,7 +15,7 @@
> >
> >  #include <libnetfilter_queue/libnetfilter_queue.h>
> >
> > -/* only for NFQA_CT, not needed otherwise: */
> > +/* only for CTA_MARK, not needed otherwise: */
>    #include <linux/netfilter/nfnetlink_conntrack.h>
>
> The reference to NFQA_CT is correct.

If I comment out the #include, the compiler complains about CTA_MARK. It does
not complain about NFQA_CT. Perhaps:
> -/* only for NFQA_CT, not needed otherwise: */
> +/* only for conntrack attribute CTA_MARK, not needed otherwise: */

In any case:
>
> enum nfqnl_attr_type {
[...]
>         NFQA_CT,                        /* nf_conntrack_netlink.h */
>
The header is nfnetlink_conntrack.h, not nf_conntrack_netlink.h.

I can submit a v2 to also fix nf_conntrack_netlink in the cached headers.

Cheers ... Duncan.