From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Yunsheng Lin <linyunsheng@huawei.com>,
davem@davemloft.net, kuba@kernel.org, jasowang@redhat.com,
nickhu@andestech.com, green.hu@gmail.com, deanbo422@gmail.com,
akpm@linux-foundation.org, yury.norov@gmail.com,
ojeda@kernel.org, ndesaulniers@gooogle.com, joe@perches.com,
linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next 0/2] refactor the ringtest testing for ptr_ring
Date: Mon, 5 Jul 2021 21:36:26 +0300 [thread overview]
Message-ID: <YONRKnDzCzSAXptx@smile.fi.intel.com> (raw)
In-Reply-To: <20210705142555-mutt-send-email-mst@kernel.org>
On Mon, Jul 05, 2021 at 02:26:32PM -0400, Michael S. Tsirkin wrote:
> On Mon, Jul 05, 2021 at 08:06:50PM +0800, Yunsheng Lin wrote:
> > On 2021/7/5 17:56, Andy Shevchenko wrote:
> > > On Mon, Jul 05, 2021 at 11:57:33AM +0800, Yunsheng Lin wrote:
> > >> tools/include/* have a lot of abstract layer for building
> > >> kernel code from userspace, so reuse or add the abstract
> > >> layer in tools/include/ to build the ptr_ring for ringtest
> > >> testing.
> > >
> > > ...
> > >
> > >> create mode 100644 tools/include/asm/cache.h
> > >> create mode 100644 tools/include/asm/processor.h
> > >> create mode 100644 tools/include/generated/autoconf.h
> > >> create mode 100644 tools/include/linux/align.h
> > >> create mode 100644 tools/include/linux/cache.h
> > >> create mode 100644 tools/include/linux/slab.h
> > >
> > > Maybe somebody can change this to be able to include in-tree headers directly?
> >
> > If the above works, maybe the files in tools/include/* is not
> > necessary any more, just use the in-tree headers to compile
> > the user space app?
> >
> > Or I missed something here?
>
> why would it work? kernel headers outside of uapi are not
> intended to be consumed by userspace.
The problem here, that we are almost getting two copies of the headers, and
tools are not in a good maintenance, so it's often desynchronized from the
actual Linux headers. This will become more and more diverse if we keep same
way of operation. So, I would rather NAK any new copies of the headers from
include/ to tools/include.
> > > Besides above, had you tested this with `make O=...`?
> >
> > You are right, the generated/autoconf.h is in another directory
> > with `make O=...`.
> >
> > Any nice idea to fix the above problem?
--
With Best Regards,
Andy Shevchenko
WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: yury.norov@gmail.com, nickhu@andestech.com,
netdev@vger.kernel.org, ndesaulniers@gooogle.com,
linux-kernel@vger.kernel.org, joe@perches.com,
Yunsheng Lin <linyunsheng@huawei.com>,
green.hu@gmail.com, ojeda@kernel.org, kuba@kernel.org,
akpm@linux-foundation.org, deanbo422@gmail.com,
virtualization@lists.linux-foundation.org, davem@davemloft.net
Subject: Re: [PATCH net-next 0/2] refactor the ringtest testing for ptr_ring
Date: Mon, 5 Jul 2021 21:36:26 +0300 [thread overview]
Message-ID: <YONRKnDzCzSAXptx@smile.fi.intel.com> (raw)
In-Reply-To: <20210705142555-mutt-send-email-mst@kernel.org>
On Mon, Jul 05, 2021 at 02:26:32PM -0400, Michael S. Tsirkin wrote:
> On Mon, Jul 05, 2021 at 08:06:50PM +0800, Yunsheng Lin wrote:
> > On 2021/7/5 17:56, Andy Shevchenko wrote:
> > > On Mon, Jul 05, 2021 at 11:57:33AM +0800, Yunsheng Lin wrote:
> > >> tools/include/* have a lot of abstract layer for building
> > >> kernel code from userspace, so reuse or add the abstract
> > >> layer in tools/include/ to build the ptr_ring for ringtest
> > >> testing.
> > >
> > > ...
> > >
> > >> create mode 100644 tools/include/asm/cache.h
> > >> create mode 100644 tools/include/asm/processor.h
> > >> create mode 100644 tools/include/generated/autoconf.h
> > >> create mode 100644 tools/include/linux/align.h
> > >> create mode 100644 tools/include/linux/cache.h
> > >> create mode 100644 tools/include/linux/slab.h
> > >
> > > Maybe somebody can change this to be able to include in-tree headers directly?
> >
> > If the above works, maybe the files in tools/include/* is not
> > necessary any more, just use the in-tree headers to compile
> > the user space app?
> >
> > Or I missed something here?
>
> why would it work? kernel headers outside of uapi are not
> intended to be consumed by userspace.
The problem here, that we are almost getting two copies of the headers, and
tools are not in a good maintenance, so it's often desynchronized from the
actual Linux headers. This will become more and more diverse if we keep same
way of operation. So, I would rather NAK any new copies of the headers from
include/ to tools/include.
> > > Besides above, had you tested this with `make O=...`?
> >
> > You are right, the generated/autoconf.h is in another directory
> > with `make O=...`.
> >
> > Any nice idea to fix the above problem?
--
With Best Regards,
Andy Shevchenko
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2021-07-05 18:36 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-05 3:57 [PATCH net-next 0/2] refactor the ringtest testing for ptr_ring Yunsheng Lin
2021-07-05 3:57 ` [PATCH net-next 1/2] tools: add missing infrastructure for building ptr_ring.h Yunsheng Lin
2021-07-05 18:39 ` Michael S. Tsirkin
2021-07-05 18:39 ` Michael S. Tsirkin
2021-07-06 2:04 ` Yunsheng Lin
2021-07-18 2:09 ` Michael S. Tsirkin
2021-07-18 2:09 ` Michael S. Tsirkin
2021-07-19 1:40 ` Yunsheng Lin
2021-07-19 11:58 ` Michael S. Tsirkin
2021-07-19 11:58 ` Michael S. Tsirkin
2021-07-05 3:57 ` [PATCH net-next 2/2] tools/virtio: use common infrastructure to build ptr_ring.h Yunsheng Lin
2021-07-05 9:56 ` [PATCH net-next 0/2] refactor the ringtest testing for ptr_ring Andy Shevchenko
2021-07-05 9:56 ` Andy Shevchenko
2021-07-05 12:06 ` Yunsheng Lin
2021-07-05 14:57 ` Andy Shevchenko
2021-07-05 14:57 ` Andy Shevchenko
2021-07-05 18:26 ` Michael S. Tsirkin
2021-07-05 18:26 ` Michael S. Tsirkin
2021-07-05 18:36 ` Andy Shevchenko [this message]
2021-07-05 18:36 ` Andy Shevchenko
2021-07-05 18:42 ` Michael S. Tsirkin
2021-07-05 18:42 ` Michael S. Tsirkin
2021-07-05 19:05 ` Andy Shevchenko
2021-07-05 19:05 ` Andy Shevchenko
2021-07-05 19:31 ` Michael S. Tsirkin
2021-07-05 19:31 ` Michael S. Tsirkin
2021-07-06 1:35 ` Yunsheng Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YONRKnDzCzSAXptx@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=deanbo422@gmail.com \
--cc=green.hu@gmail.com \
--cc=jasowang@redhat.com \
--cc=joe@perches.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linyunsheng@huawei.com \
--cc=mst@redhat.com \
--cc=ndesaulniers@gooogle.com \
--cc=netdev@vger.kernel.org \
--cc=nickhu@andestech.com \
--cc=ojeda@kernel.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.