From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53576C07E9B for ; Tue, 6 Jul 2021 19:20:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 39BA361C9E for ; Tue, 6 Jul 2021 19:20:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231785AbhGFTXK (ORCPT ); Tue, 6 Jul 2021 15:23:10 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:45102 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S231773AbhGFTXI (ORCPT ); Tue, 6 Jul 2021 15:23:08 -0400 Received: from cwcc.thunk.org (pool-72-74-133-215.bstnma.fios.verizon.net [72.74.133.215]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 166JKL7Z013101 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 6 Jul 2021 15:20:22 -0400 Received: by cwcc.thunk.org (Postfix, from userid 15806) id 6EFB115C3CC6; Tue, 6 Jul 2021 15:20:21 -0400 (EDT) Date: Tue, 6 Jul 2021 15:20:21 -0400 From: "Theodore Ts'o" To: Jan Gruber Cc: adilger.kernel@dilger.ca, trivial@kernel.org, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ext4: Fix comments and spaces to follow coding style Message-ID: References: <20210706183900.310975-1-j4n6ru@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210706183900.310975-1-j4n6ru@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 06, 2021 at 08:39:00PM +0200, Jan Gruber wrote: > This commit addresses two whitespace issues as well as > instances of the following coding style issue regarding > block comments, which were identified by checkpatch.pl: > > "WARNING: Block comments use a trailing */ on a separate line" > > The changes aim at making the code more pleasant to read > and to eliminate warnings > > Signed-off-by: Jan Gruber Please don't send "checkpatch.pl --file" patches for the ext4 file system; if you must, please focus on files in the drivers directory, where they are more welcome. If developers are making changes to a file, fixing some checkpatch.pl whines is fine, but white-sapace only changes just obfuscates "git blame" code archology, and so the costs far outwieghs the costs. "Fix" is also not the right verb to use. For more information please see [1]. [1] https://gist.github.com/17twenty/8154928 If you are looking for subtantive ways of contributing to the ext4 file system, feel free to look at various syzbot warnings[2] and try to figure out what is going on there. [2] https://syzkaller.appspot.com/upstream (In some cases, the syzbot complaint has already been fixed, and it's just a matter of letting syzbot knoww that it has since been fixed by a particular commit. See [3] for more details.) [3] https://github.com/google/syzkaller/blob/master/docs/syzbot.md Cheers, - Ted